)]}'
{"src/js/components/deployment/DeploymentConfirmation.js":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"62bed5f815c77b8a2895e05b50db2eb83c961d33","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u003cBlankSlate iconClass\u003d\"fa fa-cloud-upload\""},{"line_number":48,"context_line":"                    title\u003d{this.props.intl.formatMessage(messages.deploymentConfirmationHeader,"},{"line_number":49,"context_line":"                                                         { planName: currentPlan.name })}\u003e"},{"line_number":50,"context_line":"          \u003cp\u003e\u003cstrong\u003eSummary:\u003c/strong\u003e {environmentSummary}\u003c/p\u003e"},{"line_number":51,"context_line":"          \u003cValidationsWarning allValidationsSuccessful\u003d{allValidationsSuccessful}/\u003e"},{"line_number":52,"context_line":"          \u003cp\u003e"},{"line_number":53,"context_line":"            \u003cFormattedMessage {...messages.deploymentConfirmation} /\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_e59f7263","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":29},"updated":"2017-01-09 16:01:21.000000000","message":"Probably needs localisation?","commit_id":"0e4bec7a0f58707658950596bd54b6fbd7e02267"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"ee2fbbce57b259edd26727bc0916deaf84cb8744","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u003cBlankSlate iconClass\u003d\"fa fa-cloud-upload\""},{"line_number":48,"context_line":"                    title\u003d{this.props.intl.formatMessage(messages.deploymentConfirmationHeader,"},{"line_number":49,"context_line":"                                                         { planName: currentPlan.name })}\u003e"},{"line_number":50,"context_line":"          \u003cp\u003e\u003cstrong\u003eSummary:\u003c/strong\u003e {environmentSummary}\u003c/p\u003e"},{"line_number":51,"context_line":"          \u003cValidationsWarning allValidationsSuccessful\u003d{allValidationsSuccessful}/\u003e"},{"line_number":52,"context_line":"          \u003cp\u003e"},{"line_number":53,"context_line":"            \u003cFormattedMessage {...messages.deploymentConfirmation} /\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_be863011","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":29},"in_reply_to":"ba5201f7_e59f7263","updated":"2017-01-10 11:22:40.000000000","message":"Done","commit_id":"0e4bec7a0f58707658950596bd54b6fbd7e02267"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"1534d5804cceed2bffe66a69838c0e4c1392580a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u003cBlankSlate iconClass\u003d\"fa fa-cloud-upload\""},{"line_number":52,"context_line":"                    title\u003d{this.props.intl.formatMessage(messages.deploymentConfirmationHeader,"},{"line_number":53,"context_line":"                                                         { planName: currentPlan.name })}\u003e"},{"line_number":54,"context_line":"          \u003cp\u003e\u003cstrong\u003e\u003cFormattedMessage {...messages.summary}/\u003e:\u003c/strong\u003e {environmentSummary}\u003c/p\u003e"},{"line_number":55,"context_line":"          \u003cValidationsWarning allValidationsSuccessful\u003d{allValidationsSuccessful}/\u003e"},{"line_number":56,"context_line":"          \u003cp\u003e"},{"line_number":57,"context_line":"            \u003cFormattedMessage {...messages.deploymentConfirmation} /\u003e"}],"source_content_type":"text/javascript","patch_set":3,"id":"9a57fde8_605c4926","line":54,"range":{"start_line":54,"start_character":21,"end_line":54,"end_character":63},"updated":"2017-01-12 16:33:03.000000000","message":"I\u0027ve seen this come up in Horizon so I will make the comment here now, but we should include the punctuation in such strings. It\u0027s come up for \":\" before because French puts a space before, while English doesn\u0027t and so things look a bit off and/or translators end up having to figure out whether to add an extra blank space to the translation, which isn\u0027t right (and potentially causes other issues when the string ends up reused in another context, too).","commit_id":"5f7fffcc606d57d84b6df8695413b0535847304a"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"d4e236b8af19b67b794929431b916bb60ec4bf33","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u003cBlankSlate iconClass\u003d\"fa fa-cloud-upload\""},{"line_number":52,"context_line":"                    title\u003d{this.props.intl.formatMessage(messages.deploymentConfirmationHeader,"},{"line_number":53,"context_line":"                                                         { planName: currentPlan.name })}\u003e"},{"line_number":54,"context_line":"          \u003cp\u003e\u003cstrong\u003e\u003cFormattedMessage {...messages.summary}/\u003e:\u003c/strong\u003e {environmentSummary}\u003c/p\u003e"},{"line_number":55,"context_line":"          \u003cValidationsWarning allValidationsSuccessful\u003d{allValidationsSuccessful}/\u003e"},{"line_number":56,"context_line":"          \u003cp\u003e"},{"line_number":57,"context_line":"            \u003cFormattedMessage {...messages.deploymentConfirmation} /\u003e"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a3c09a3_369cf168","line":54,"range":{"start_line":54,"start_character":21,"end_line":54,"end_character":63},"in_reply_to":"7a3c09a3_32c7ec13","updated":"2017-01-16 14:23:22.000000000","message":"Done","commit_id":"5f7fffcc606d57d84b6df8695413b0535847304a"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"5f74417295a99b3e7222ac7bcf7699506ac20cf5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u003cBlankSlate iconClass\u003d\"fa fa-cloud-upload\""},{"line_number":52,"context_line":"                    title\u003d{this.props.intl.formatMessage(messages.deploymentConfirmationHeader,"},{"line_number":53,"context_line":"                                                         { planName: currentPlan.name })}\u003e"},{"line_number":54,"context_line":"          \u003cp\u003e\u003cstrong\u003e\u003cFormattedMessage {...messages.summary}/\u003e:\u003c/strong\u003e {environmentSummary}\u003c/p\u003e"},{"line_number":55,"context_line":"          \u003cValidationsWarning allValidationsSuccessful\u003d{allValidationsSuccessful}/\u003e"},{"line_number":56,"context_line":"          \u003cp\u003e"},{"line_number":57,"context_line":"            \u003cFormattedMessage {...messages.deploymentConfirmation} /\u003e"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a3c09a3_32c7ec13","line":54,"range":{"start_line":54,"start_character":21,"end_line":54,"end_character":63},"in_reply_to":"9a57fde8_605c4926","updated":"2017-01-13 13:07:11.000000000","message":"Thanks a lot for bringing this to my attention! I\u0027ll include the colon in the translation string.","commit_id":"5f7fffcc606d57d84b6df8695413b0535847304a"}],"src/js/components/deployment/DeploymentDetail.js":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"62bed5f815c77b8a2895e05b50db2eb83c961d33","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u003cLink to\u003d\"/deployment-plan\""},{"line_number":111,"context_line":"                  type\u003d\"button\""},{"line_number":112,"context_line":"                  className\u003d\"btn btn-default\"\u003e"},{"line_number":113,"context_line":"              Close"},{"line_number":114,"context_line":"            \u003c/Link\u003e"},{"line_number":115,"context_line":"          \u003c/ModalPanelFooter\u003e"},{"line_number":116,"context_line":"        \u003c/ModalPanel\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_6840b936","line":113,"range":{"start_line":113,"start_character":14,"end_line":113,"end_character":19},"updated":"2017-01-09 16:01:21.000000000","message":"Forgotten string?","commit_id":"0e4bec7a0f58707658950596bd54b6fbd7e02267"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"ee2fbbce57b259edd26727bc0916deaf84cb8744","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u003cLink to\u003d\"/deployment-plan\""},{"line_number":111,"context_line":"                  type\u003d\"button\""},{"line_number":112,"context_line":"                  className\u003d\"btn btn-default\"\u003e"},{"line_number":113,"context_line":"              Close"},{"line_number":114,"context_line":"            \u003c/Link\u003e"},{"line_number":115,"context_line":"          \u003c/ModalPanelFooter\u003e"},{"line_number":116,"context_line":"        \u003c/ModalPanel\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_fe78b82d","line":113,"range":{"start_line":113,"start_character":14,"end_line":113,"end_character":19},"in_reply_to":"ba5201f7_6840b936","updated":"2017-01-10 11:22:40.000000000","message":"Done","commit_id":"0e4bec7a0f58707658950596bd54b6fbd7e02267"}],"src/js/components/deployment/DeploymentFailure.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"9e36014f67f65ddcd916d0fa32cb04201985abc6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"const messages \u003d defineMessages({"},{"line_number":10,"context_line":"  resources: {"},{"line_number":11,"context_line":"    id: \u0027DeploymentSuccess.resources\u0027,"},{"line_number":12,"context_line":"    defaultMessage: \u0027Resources\u0027"},{"line_number":13,"context_line":"  }"},{"line_number":14,"context_line":"});"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_c4ad4cea","line":11,"updated":"2017-01-06 17:07:48.000000000","message":"This one should probably be DeploymentFailure.resources? I see that sometimes we have duplicate messages. This will potentially happen quite often, did you consider defining the messages in separate module? At first glance it seems as a good way to keep the components clean as much as possible and allow to use common messages in multiple components.\n\nOnly thing I am not entirely sure is where to put it inside codebase. Maybe js/messages/ ? What do you think?","commit_id":"0e4bec7a0f58707658950596bd54b6fbd7e02267"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"ee2fbbce57b259edd26727bc0916deaf84cb8744","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"const messages \u003d defineMessages({"},{"line_number":10,"context_line":"  resources: {"},{"line_number":11,"context_line":"    id: \u0027DeploymentSuccess.resources\u0027,"},{"line_number":12,"context_line":"    defaultMessage: \u0027Resources\u0027"},{"line_number":13,"context_line":"  }"},{"line_number":14,"context_line":"});"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_793b029d","line":11,"in_reply_to":"ba5201f7_c4ad4cea","updated":"2017-01-10 11:22:40.000000000","message":"Yes, it should be DeploymentFailure. The component is incorrectly named here, but that didn\u0027t cause an error since it is only imported as default. I corrected that as well.\n\nRegarding redundant message definition: I think once all components are i18n\u0027d it would make sense to look through the messages and pull out the duplicates. js/messages/common.js seems like a good place for that.\n\nAre you suggesting we should generally separate the component-specific messages as well? (js/messages/deployment/DeploymentFailure etc.?)","commit_id":"0e4bec7a0f58707658950596bd54b6fbd7e02267"}],"src/js/components/deployment/OvercloudInfo.js":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"62bed5f815c77b8a2895e05b50db2eb83c961d33","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      \u003cLoader loaded\u003d{stackResourcesLoaded}"},{"line_number":34,"context_line":"              content\u003d{intl.formatMessage(messages.loadingOvercloudInformation)}\u003e"},{"line_number":35,"context_line":"        \u003cul className\u003d\"list\"\u003e"},{"line_number":36,"context_line":"          \u003cli\u003eOvercloud IP address: {ip}\u003c/li\u003e"},{"line_number":37,"context_line":"          \u003cli\u003eUsername: admin\u003c/li\u003e"},{"line_number":38,"context_line":"          \u003cli\u003ePassword: {password}\u003c/li\u003e"},{"line_number":39,"context_line":"        \u003c/ul\u003e"},{"line_number":40,"context_line":"      \u003c/Loader\u003e"},{"line_number":41,"context_line":"      \u003cbr /\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_4845b515","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":39},"updated":"2017-01-09 16:01:21.000000000","message":"We probably need to localise these 3 strings as well?","commit_id":"0e4bec7a0f58707658950596bd54b6fbd7e02267"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"ee2fbbce57b259edd26727bc0916deaf84cb8744","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      \u003cLoader loaded\u003d{stackResourcesLoaded}"},{"line_number":34,"context_line":"              content\u003d{intl.formatMessage(messages.loadingOvercloudInformation)}\u003e"},{"line_number":35,"context_line":"        \u003cul className\u003d\"list\"\u003e"},{"line_number":36,"context_line":"          \u003cli\u003eOvercloud IP address: {ip}\u003c/li\u003e"},{"line_number":37,"context_line":"          \u003cli\u003eUsername: admin\u003c/li\u003e"},{"line_number":38,"context_line":"          \u003cli\u003ePassword: {password}\u003c/li\u003e"},{"line_number":39,"context_line":"        \u003c/ul\u003e"},{"line_number":40,"context_line":"      \u003c/Loader\u003e"},{"line_number":41,"context_line":"      \u003cbr /\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba5201f7_de6cd438","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":39},"in_reply_to":"ba5201f7_4845b515","updated":"2017-01-10 11:22:40.000000000","message":"Done","commit_id":"0e4bec7a0f58707658950596bd54b6fbd7e02267"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"1534d5804cceed2bffe66a69838c0e4c1392580a","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  return ("},{"line_number":43,"context_line":"    \u003cdiv\u003e"},{"line_number":44,"context_line":"      \u003ch4\u003e\u003cFormattedMessage {...messages.overcloudInformationHeader}/\u003e:\u003c/h4\u003e"},{"line_number":45,"context_line":"      \u003cLoader loaded\u003d{stackResourcesLoaded}"},{"line_number":46,"context_line":"              content\u003d{intl.formatMessage(messages.loadingOvercloudInformation)}\u003e"},{"line_number":47,"context_line":"        \u003cul className\u003d\"list\"\u003e"},{"line_number":48,"context_line":"          \u003cli\u003e\u003cFormattedMessage {...messages.overcloudIpAddress}/\u003e: {ip}\u003c/li\u003e"},{"line_number":49,"context_line":"          \u003cli\u003e\u003cFormattedMessage {...messages.username}/\u003e: admin\u003c/li\u003e"},{"line_number":50,"context_line":"          \u003cli\u003e\u003cFormattedMessage {...messages.password}/\u003e: {password}\u003c/li\u003e"},{"line_number":51,"context_line":"        \u003c/ul\u003e"},{"line_number":52,"context_line":"      \u003c/Loader\u003e"},{"line_number":53,"context_line":"      \u003cbr /\u003e"}],"source_content_type":"text/javascript","patch_set":3,"id":"9a57fde8_a048f12e","line":50,"range":{"start_line":44,"start_character":10,"end_line":50,"end_character":73},"updated":"2017-01-12 16:33:03.000000000","message":"Same thinking about the colons...","commit_id":"5f7fffcc606d57d84b6df8695413b0535847304a"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"d4e236b8af19b67b794929431b916bb60ec4bf33","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  return ("},{"line_number":43,"context_line":"    \u003cdiv\u003e"},{"line_number":44,"context_line":"      \u003ch4\u003e\u003cFormattedMessage {...messages.overcloudInformationHeader}/\u003e:\u003c/h4\u003e"},{"line_number":45,"context_line":"      \u003cLoader loaded\u003d{stackResourcesLoaded}"},{"line_number":46,"context_line":"              content\u003d{intl.formatMessage(messages.loadingOvercloudInformation)}\u003e"},{"line_number":47,"context_line":"        \u003cul className\u003d\"list\"\u003e"},{"line_number":48,"context_line":"          \u003cli\u003e\u003cFormattedMessage {...messages.overcloudIpAddress}/\u003e: {ip}\u003c/li\u003e"},{"line_number":49,"context_line":"          \u003cli\u003e\u003cFormattedMessage {...messages.username}/\u003e: admin\u003c/li\u003e"},{"line_number":50,"context_line":"          \u003cli\u003e\u003cFormattedMessage {...messages.password}/\u003e: {password}\u003c/li\u003e"},{"line_number":51,"context_line":"        \u003c/ul\u003e"},{"line_number":52,"context_line":"      \u003c/Loader\u003e"},{"line_number":53,"context_line":"      \u003cbr /\u003e"}],"source_content_type":"text/javascript","patch_set":3,"id":"7a3c09a3_562c1d02","line":50,"range":{"start_line":44,"start_character":10,"end_line":50,"end_character":73},"in_reply_to":"9a57fde8_a048f12e","updated":"2017-01-16 14:23:22.000000000","message":"Done","commit_id":"5f7fffcc606d57d84b6df8695413b0535847304a"}]}