)]}'
{"src/js/components/Login.js":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"e4838c222ff8f91d5af2ec979da0930339029ca2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"const messages \u003d defineMessages({"},{"line_number":17,"context_line":"  username: {"},{"line_number":18,"context_line":"    id: \u0027Login.username\u0027,"},{"line_number":19,"context_line":"    defaultMessage: \u0027username\u0027"},{"line_number":20,"context_line":"  },"},{"line_number":21,"context_line":"  usernameRequired: {"},{"line_number":22,"context_line":"    id: \u0027Login.usernameRequired\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_1ebf5ad1","line":19,"range":{"start_line":19,"start_character":21,"end_line":19,"end_character":29},"updated":"2017-01-12 17:19:35.000000000","message":"Should be \"Username\"?","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"eb785de20f7c56528fb78daf821eeedd479b24e9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"const messages \u003d defineMessages({"},{"line_number":17,"context_line":"  username: {"},{"line_number":18,"context_line":"    id: \u0027Login.username\u0027,"},{"line_number":19,"context_line":"    defaultMessage: \u0027username\u0027"},{"line_number":20,"context_line":"  },"},{"line_number":21,"context_line":"  usernameRequired: {"},{"line_number":22,"context_line":"    id: \u0027Login.usernameRequired\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_d9e24c9f","line":19,"range":{"start_line":19,"start_character":21,"end_line":19,"end_character":29},"in_reply_to":"9a57fde8_1ebf5ad1","updated":"2017-01-12 17:36:18.000000000","message":"OOps. yes, you\u0027re right.","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"e4838c222ff8f91d5af2ec979da0930339029ca2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  },"},{"line_number":21,"context_line":"  usernameRequired: {"},{"line_number":22,"context_line":"    id: \u0027Login.usernameRequired\u0027,"},{"line_number":23,"context_line":"    defaultMessage: \u0027usernameRequired\u0027"},{"line_number":24,"context_line":"  },"},{"line_number":25,"context_line":"  password: {"},{"line_number":26,"context_line":"    id: \u0027Login.password\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_bec80e76","line":23,"range":{"start_line":23,"start_character":21,"end_line":23,"end_character":37},"updated":"2017-01-12 17:19:35.000000000","message":"I think this should be \"Username is required.\"","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"eb785de20f7c56528fb78daf821eeedd479b24e9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  },"},{"line_number":21,"context_line":"  usernameRequired: {"},{"line_number":22,"context_line":"    id: \u0027Login.usernameRequired\u0027,"},{"line_number":23,"context_line":"    defaultMessage: \u0027usernameRequired\u0027"},{"line_number":24,"context_line":"  },"},{"line_number":25,"context_line":"  password: {"},{"line_number":26,"context_line":"    id: \u0027Login.password\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_998604b8","line":23,"range":{"start_line":23,"start_character":21,"end_line":23,"end_character":37},"in_reply_to":"9a57fde8_bec80e76","updated":"2017-01-12 17:36:18.000000000","message":"Done","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"e4838c222ff8f91d5af2ec979da0930339029ca2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  },"},{"line_number":25,"context_line":"  password: {"},{"line_number":26,"context_line":"    id: \u0027Login.password\u0027,"},{"line_number":27,"context_line":"    defaultMessage: \u0027password\u0027"},{"line_number":28,"context_line":"  },"},{"line_number":29,"context_line":"  passwordRequired: {"},{"line_number":30,"context_line":"    id: \u0027Login.passwordRequired\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_7e95c63e","line":27,"range":{"start_line":27,"start_character":21,"end_line":27,"end_character":30},"updated":"2017-01-12 17:19:35.000000000","message":"Should be \"Password\"?","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"eb785de20f7c56528fb78daf821eeedd479b24e9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  },"},{"line_number":25,"context_line":"  password: {"},{"line_number":26,"context_line":"    id: \u0027Login.password\u0027,"},{"line_number":27,"context_line":"    defaultMessage: \u0027password\u0027"},{"line_number":28,"context_line":"  },"},{"line_number":29,"context_line":"  passwordRequired: {"},{"line_number":30,"context_line":"    id: \u0027Login.passwordRequired\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_b993c8f9","line":27,"range":{"start_line":27,"start_character":21,"end_line":27,"end_character":30},"in_reply_to":"9a57fde8_7e95c63e","updated":"2017-01-12 17:36:18.000000000","message":"Done","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"e4838c222ff8f91d5af2ec979da0930339029ca2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  },"},{"line_number":29,"context_line":"  passwordRequired: {"},{"line_number":30,"context_line":"    id: \u0027Login.passwordRequired\u0027,"},{"line_number":31,"context_line":"    defaultMessage: \u0027passwordRequired\u0027"},{"line_number":32,"context_line":"  },"},{"line_number":33,"context_line":"  login: {"},{"line_number":34,"context_line":"    id: \u0027Login.login\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_7ea3069f","line":31,"range":{"start_line":31,"start_character":21,"end_line":31,"end_character":37},"updated":"2017-01-12 17:19:35.000000000","message":"I think this should be \"Password is required.\"","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"eb785de20f7c56528fb78daf821eeedd479b24e9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  },"},{"line_number":29,"context_line":"  passwordRequired: {"},{"line_number":30,"context_line":"    id: \u0027Login.passwordRequired\u0027,"},{"line_number":31,"context_line":"    defaultMessage: \u0027passwordRequired\u0027"},{"line_number":32,"context_line":"  },"},{"line_number":33,"context_line":"  login: {"},{"line_number":34,"context_line":"    id: \u0027Login.login\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_d9908cef","line":31,"range":{"start_line":31,"start_character":21,"end_line":31,"end_character":37},"in_reply_to":"9a57fde8_7ea3069f","updated":"2017-01-12 17:36:18.000000000","message":"Done","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"e4838c222ff8f91d5af2ec979da0930339029ca2","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  description: {"},{"line_number":42,"context_line":"    id: \u0027Login.description\u0027,"},{"line_number":43,"context_line":"    defaultMessage: \u0027TripleO will help you manage your OpenStack deployments. It\\\u0027s the best\\"},{"line_number":44,"context_line":"                    thing since sliced bread. We think you will really enjoy it!\u0027"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"});"},{"line_number":47,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_fe17f651","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":20},"updated":"2017-01-12 17:19:35.000000000","message":"The two strings should be concatenated like e.g. L36 at https://review.openstack.org/#/c/413657/3/src/js/components/deployment/DeploymentConfirmation.js, otherwise the long space is showing inside the JSON extracted messages after running npm run build.\n\nI\u0027m also wondering, could we use double quotes to avoid the need for backslashes, or is that Not Done? :)","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"8d1e1a3ce2d37f5ba746dac7aebdf9d920f0b260","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  description: {"},{"line_number":42,"context_line":"    id: \u0027Login.description\u0027,"},{"line_number":43,"context_line":"    defaultMessage: \u0027TripleO will help you manage your OpenStack deployments. It\\\u0027s the best\\"},{"line_number":44,"context_line":"                    thing since sliced bread. We think you will really enjoy it!\u0027"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"});"},{"line_number":47,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_b4be6ffd","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":20},"in_reply_to":"9a57fde8_5949fc8a","updated":"2017-01-12 17:47:58.000000000","message":"Yes, but there is a way to concatenate without having spaces in the actual string itself, like in the review I linked to :) (line 36, 37)","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"1f255ee575625771211bcf38c19bb1a5e94c8e03","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  description: {"},{"line_number":42,"context_line":"    id: \u0027Login.description\u0027,"},{"line_number":43,"context_line":"    defaultMessage: \u0027TripleO will help you manage your OpenStack deployments. It\\\u0027s the best\\"},{"line_number":44,"context_line":"                    thing since sliced bread. We think you will really enjoy it!\u0027"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"});"},{"line_number":47,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_b4c4af40","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":20},"in_reply_to":"9a57fde8_b4be6ffd","updated":"2017-01-12 17:53:15.000000000","message":"This is a matter of convention. I can comply with the other convention, but otherwise it hasn\u0027t been established.","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"eb785de20f7c56528fb78daf821eeedd479b24e9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  description: {"},{"line_number":42,"context_line":"    id: \u0027Login.description\u0027,"},{"line_number":43,"context_line":"    defaultMessage: \u0027TripleO will help you manage your OpenStack deployments. It\\\u0027s the best\\"},{"line_number":44,"context_line":"                    thing since sliced bread. We think you will really enjoy it!\u0027"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":"});"},{"line_number":47,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_5949fc8a","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":20},"in_reply_to":"9a57fde8_fe17f651","updated":"2017-01-12 17:36:18.000000000","message":"Heh, unfortunately we still have an 80 column limit for some bizarre reason :)  And lint prefers a single quote for strings, so we have to use the backslashes.  I know, not ideal.","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"e4838c222ff8f91d5af2ec979da0930339029ca2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            \u003cdiv className\u003d\"col-sm-7 col-md-6 col-lg-5 login\"\u003e"},{"line_number":101,"context_line":"              \u003cFormErrorList errors\u003d{this.props.formErrors.toJS()}/\u003e"},{"line_number":102,"context_line":"              \u003cFormsy.Form ref\u003d\"form\""},{"line_number":103,"context_line":"                   role\u003d\"form\""},{"line_number":104,"context_line":"                   className\u003d\"form-horizontal\""},{"line_number":105,"context_line":"                   onSubmit\u003d{this.handleLogin.bind(this)}"},{"line_number":106,"context_line":"                   onValid\u003d{this._enableButton.bind(this)}"},{"line_number":107,"context_line":"                   onInvalid\u003d{this._disableButton.bind(this)}\u003e"},{"line_number":108,"context_line":"                \u003cLoginInput"},{"line_number":109,"context_line":"                    name\u003d\"username\""},{"line_number":110,"context_line":"                    placeholder\u003d{this.props.intl.formatMessage(messages.username)}"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_1e7e7ae4","line":107,"range":{"start_line":103,"start_character":0,"end_line":107,"end_character":62},"updated":"2017-01-12 17:19:35.000000000","message":"It looks like your editor realigned line 103 to 131, causing the attributes (ref, role, etc) not to align anymore? I think the original way looks nicer, and it might be better to put it back the way it was anyway to not distract from the actual changes in the patch.","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"eb785de20f7c56528fb78daf821eeedd479b24e9","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            \u003cdiv className\u003d\"col-sm-7 col-md-6 col-lg-5 login\"\u003e"},{"line_number":101,"context_line":"              \u003cFormErrorList errors\u003d{this.props.formErrors.toJS()}/\u003e"},{"line_number":102,"context_line":"              \u003cFormsy.Form ref\u003d\"form\""},{"line_number":103,"context_line":"                   role\u003d\"form\""},{"line_number":104,"context_line":"                   className\u003d\"form-horizontal\""},{"line_number":105,"context_line":"                   onSubmit\u003d{this.handleLogin.bind(this)}"},{"line_number":106,"context_line":"                   onValid\u003d{this._enableButton.bind(this)}"},{"line_number":107,"context_line":"                   onInvalid\u003d{this._disableButton.bind(this)}\u003e"},{"line_number":108,"context_line":"                \u003cLoginInput"},{"line_number":109,"context_line":"                    name\u003d\"username\""},{"line_number":110,"context_line":"                    placeholder\u003d{this.props.intl.formatMessage(messages.username)}"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_f949d08f","line":107,"range":{"start_line":103,"start_character":0,"end_line":107,"end_character":62},"in_reply_to":"9a57fde8_1e7e7ae4","updated":"2017-01-12 17:36:18.000000000","message":"well the reason I did this was due to the 80 line character limit again.  See the below changes. I didn\u0027t notice the ref attr so I\u0027ll move that to the next line as well.","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"change_message_id":"1f255ee575625771211bcf38c19bb1a5e94c8e03","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            \u003cdiv className\u003d\"col-sm-7 col-md-6 col-lg-5 login\"\u003e"},{"line_number":101,"context_line":"              \u003cFormErrorList errors\u003d{this.props.formErrors.toJS()}/\u003e"},{"line_number":102,"context_line":"              \u003cFormsy.Form ref\u003d\"form\""},{"line_number":103,"context_line":"                   role\u003d\"form\""},{"line_number":104,"context_line":"                   className\u003d\"form-horizontal\""},{"line_number":105,"context_line":"                   onSubmit\u003d{this.handleLogin.bind(this)}"},{"line_number":106,"context_line":"                   onValid\u003d{this._enableButton.bind(this)}"},{"line_number":107,"context_line":"                   onInvalid\u003d{this._disableButton.bind(this)}\u003e"},{"line_number":108,"context_line":"                \u003cLoginInput"},{"line_number":109,"context_line":"                    name\u003d\"username\""},{"line_number":110,"context_line":"                    placeholder\u003d{this.props.intl.formatMessage(messages.username)}"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_34b0bfdd","line":107,"range":{"start_line":103,"start_character":0,"end_line":107,"end_character":62},"in_reply_to":"9a57fde8_d45213dd","updated":"2017-01-12 17:53:15.000000000","message":"You\u0027re right, it\u0027s 100. (line 6 eslintrc). Sorry for the confusion.  It\u0027s not this specific group of attributes that are extending past the limit, but rather making this set look like the set below.","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"8d1e1a3ce2d37f5ba746dac7aebdf9d920f0b260","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            \u003cdiv className\u003d\"col-sm-7 col-md-6 col-lg-5 login\"\u003e"},{"line_number":101,"context_line":"              \u003cFormErrorList errors\u003d{this.props.formErrors.toJS()}/\u003e"},{"line_number":102,"context_line":"              \u003cFormsy.Form ref\u003d\"form\""},{"line_number":103,"context_line":"                   role\u003d\"form\""},{"line_number":104,"context_line":"                   className\u003d\"form-horizontal\""},{"line_number":105,"context_line":"                   onSubmit\u003d{this.handleLogin.bind(this)}"},{"line_number":106,"context_line":"                   onValid\u003d{this._enableButton.bind(this)}"},{"line_number":107,"context_line":"                   onInvalid\u003d{this._disableButton.bind(this)}\u003e"},{"line_number":108,"context_line":"                \u003cLoginInput"},{"line_number":109,"context_line":"                    name\u003d\"username\""},{"line_number":110,"context_line":"                    placeholder\u003d{this.props.intl.formatMessage(messages.username)}"}],"source_content_type":"text/javascript","patch_set":1,"id":"9a57fde8_d45213dd","line":107,"range":{"start_line":103,"start_character":0,"end_line":107,"end_character":62},"in_reply_to":"9a57fde8_f949d08f","updated":"2017-01-12 17:47:58.000000000","message":"From what I\u0027ve seen on other patches, looks like the linter limit for tripleo-ui is 100 characters, not 80, which is why this was passing fine before?","commit_id":"604a601748894aa8aa7d71a2f76ad28aa2e39406"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"a76a75db4049ab3a709a3cc548ad150585ebaaf2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                   onSubmit\u003d{this.handleLogin.bind(this)}"},{"line_number":107,"context_line":"                   onValid\u003d{this._enableButton.bind(this)}"},{"line_number":108,"context_line":"                   onInvalid\u003d{this._disableButton.bind(this)}\u003e"},{"line_number":109,"context_line":"                \u003cLoginInput"},{"line_number":110,"context_line":"                    name\u003d\"username\""},{"line_number":111,"context_line":"                    placeholder\u003d{this.props.intl.formatMessage(messages.username)}"},{"line_number":112,"context_line":"                    title\u003d{this.props.intl.formatMessage(messages.username)}"},{"line_number":113,"context_line":"                    validationError\u003d{this.props.intl.formatMessage(messages.usernameRequired)}"},{"line_number":114,"context_line":"                    required"},{"line_number":115,"context_line":"                    autoFocus"},{"line_number":116,"context_line":"                /\u003e"},{"line_number":117,"context_line":"                \u003cLoginInput"},{"line_number":118,"context_line":"                    type\u003d\"password\""},{"line_number":119,"context_line":"                    name\u003d\"password\""},{"line_number":120,"context_line":"                    placeholder\u003d{this.props.intl.formatMessage(messages.password)}"},{"line_number":121,"context_line":"                    title\u003d{this.props.intl.formatMessage(messages.password)}"},{"line_number":122,"context_line":"                    validationError\u003d{this.props.intl.formatMessage(messages.passwordRequired)}"},{"line_number":123,"context_line":"                    required"},{"line_number":124,"context_line":"                /\u003e"},{"line_number":125,"context_line":"                \u003cdiv className\u003d\"form-group\"\u003e"},{"line_number":126,"context_line":"                  \u003cdiv className\u003d\"col-xs-offset-8 col-xs-4 col-sm-4 col-md-4 submit\"\u003e"},{"line_number":127,"context_line":"                    \u003cbutton"}],"source_content_type":"text/javascript","patch_set":4,"id":"5a3905b3_b5018408","line":124,"range":{"start_line":109,"start_character":0,"end_line":124,"end_character":18},"updated":"2017-01-23 08:33:56.000000000","message":"If you add the following line on top of the render method, you don\u0027t have to repeat \"this.props.intl.formatMessage\" all over again, but can just use {formatMessage(...)} :\n\n    const { formatMessage } \u003d this.props.intl;\n\nThis would make all lines short enough to put the first attribute right after the opening tag name again and align all others with it just fine.","commit_id":"417e17625557b6b73569fa936168f40b60c548b3"}]}