)]}'
{"src/js/actions/NodesActions.js":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"6c6783224f48c12f06ab70e1be77a95635a5f61e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"const messages \u003d defineMessages({"},{"line_number":18,"context_line":"  introspectionNotificationMessage: {"},{"line_number":19,"context_line":"    id: \u0027NodesActions.introspectionNotificationMessage\u0027,"},{"line_number":20,"context_line":"    defaultMessage: \u0027Selected nodes were successfully introspected\u0027"},{"line_number":21,"context_line":"  },"},{"line_number":22,"context_line":"  introspectionNotificationTitle: {"},{"line_number":23,"context_line":"    id: \u0027NodesActions.introspectionNotificationTitle\u0027,"}],"source_content_type":"text/javascript","patch_set":10,"id":"fa31d9ce_6381994a","line":20,"range":{"start_line":20,"start_character":54,"end_line":20,"end_character":67},"updated":"2017-02-10 15:56:04.000000000","message":"Missing full stop at end of sentence.","commit_id":"307385081980eea2090fca65038e070a5e7ddccc"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"6c6783224f48c12f06ab70e1be77a95635a5f61e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                    { node_uuids: nodeIds })"},{"line_number":115,"context_line":"      .then((response) \u003d\u003e {"},{"line_number":116,"context_line":"        if(response.state \u003d\u003d\u003d \u0027ERROR\u0027) {"},{"line_number":117,"context_line":"          dispatch(NotificationActions.notify({ title: \u0027Error\u0027, message: response.state_info }));"},{"line_number":118,"context_line":"          dispatch(this.finishOperation(nodeIds));"},{"line_number":119,"context_line":"        }"},{"line_number":120,"context_line":"      }).catch((error) \u003d\u003e {"}],"source_content_type":"text/javascript","patch_set":10,"id":"fa31d9ce_e3ee69eb","line":117,"range":{"start_line":117,"start_character":56,"end_line":117,"end_character":61},"updated":"2017-02-10 15:56:04.000000000","message":"Should this be i18n?","commit_id":"307385081980eea2090fca65038e070a5e7ddccc"}],"src/js/actions/PlansActions.js":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"6c6783224f48c12f06ab70e1be77a95635a5f61e","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            if(response.state \u003d\u003d\u003d \u0027ERROR\u0027) {"},{"line_number":249,"context_line":"              logger.error(\u0027Error in PlansActions.createPlan\u0027, response);"},{"line_number":250,"context_line":"              dispatch(NotificationActions.notify({"},{"line_number":251,"context_line":"                title: \u0027Error\u0027,"},{"line_number":252,"context_line":"                message: response.state_info"},{"line_number":253,"context_line":"              }));"},{"line_number":254,"context_line":"              dispatch(this.createPlanFailed());"}],"source_content_type":"text/javascript","patch_set":10,"id":"fa31d9ce_236321b3","line":251,"range":{"start_line":251,"start_character":24,"end_line":251,"end_character":29},"updated":"2017-02-10 15:56:04.000000000","message":"Is this something we may want to i18n?","commit_id":"307385081980eea2090fca65038e070a5e7ddccc"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"6c6783224f48c12f06ab70e1be77a95635a5f61e","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        browserHistory.push(\u0027/plans/list\u0027);"},{"line_number":298,"context_line":"      }"},{"line_number":299,"context_line":"      else {"},{"line_number":300,"context_line":"        dispatch(this.createPlanFailed([{ title: \u0027Error\u0027, message: payload.message }]));"},{"line_number":301,"context_line":"      }"},{"line_number":302,"context_line":"    };"},{"line_number":303,"context_line":"  },"}],"source_content_type":"text/javascript","patch_set":10,"id":"fa31d9ce_230a41d3","line":300,"range":{"start_line":300,"start_character":50,"end_line":300,"end_character":55},"updated":"2017-02-10 15:56:04.000000000","message":"Would this need i18n?","commit_id":"307385081980eea2090fca65038e070a5e7ddccc"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"6c6783224f48c12f06ab70e1be77a95635a5f61e","unresolved":false,"context_lines":[{"line_number":318,"context_line":"          ).then((response) \u003d\u003e {"},{"line_number":319,"context_line":"            if(response.state \u003d\u003d\u003d \u0027ERROR\u0027) {"},{"line_number":320,"context_line":"              logger.error(\u0027Error in PlansActions.createPlanFromTarball\u0027, response);"},{"line_number":321,"context_line":"              dispatch(this.createPlanFailed([{ title: \u0027Error\u0027, message: response.state_info }]));"},{"line_number":322,"context_line":"            }"},{"line_number":323,"context_line":"          }).catch((error) \u003d\u003e {"},{"line_number":324,"context_line":"            logger.error(\u0027Error in workflow in PlansActions.createPlanFromTarball\u0027, error);"}],"source_content_type":"text/javascript","patch_set":10,"id":"fa31d9ce_a3f631d5","line":321,"range":{"start_line":321,"start_character":56,"end_line":321,"end_character":61},"updated":"2017-02-10 15:56:04.000000000","message":"Same Q","commit_id":"307385081980eea2090fca65038e070a5e7ddccc"}],"src/js/actions/RegisterNodesActions.js":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"6c6783224f48c12f06ab70e1be77a95635a5f61e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                      ramdisk_name: \u0027bm-deploy-ramdisk\u0027 })"},{"line_number":63,"context_line":"      .then((response) \u003d\u003e {"},{"line_number":64,"context_line":"        if(response.state \u003d\u003d\u003d \u0027ERROR\u0027) {"},{"line_number":65,"context_line":"          const errors \u003d [{ title: \u0027Nodes Registration Failed\u0027, message: response.state_info }];"},{"line_number":66,"context_line":"          dispatch(this.startNodesRegistrationFailed(errors));"},{"line_number":67,"context_line":"        } else {"},{"line_number":68,"context_line":"          dispatch(this.startNodesRegistrationSuccess());"}],"source_content_type":"text/javascript","patch_set":10,"id":"fa31d9ce_4341f50a","line":65,"range":{"start_line":65,"start_character":36,"end_line":65,"end_character":61},"updated":"2017-02-10 15:56:04.000000000","message":"Is this something that would be displayed to the user?","commit_id":"307385081980eea2090fca65038e070a5e7ddccc"}],"src/js/components/notifications/Notification.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"d8e3d8268c588b093bc3bddddaaba1053ef65dd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a3c09a3_f9ed528f","updated":"2017-01-13 11:20:38.000000000","message":"Notification should not care about the I18n. Imagine that Notification is part of library such as react-patternfly. The contents for title and message needs to be already translated when passed to Notification as props","commit_id":"8e26918f8429e3958ca90df115c9138c3fc2ccc8"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"e73d8638cec4cac88fd7dc141f834037eb58021c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a3c09a3_b8265d14","in_reply_to":"7a3c09a3_f9ed528f","updated":"2017-01-13 13:39:23.000000000","message":"I agree, in a very general way. But I guess that\u0027s not how react-intl works. Messages can be defined anywhere, but the formatting is supposed to be done only inside of components. In case of the Notifications, the messages are often defined in actions which are outside the i18n context, so we can\u0027t format the messages there (unless we resort to some lower level hacking).\n\nHow about we format messages in the NotificationsToaster instead? We would still have to type check message and title there but this would at least keep the API of the Notifications component clean.","commit_id":"8e26918f8429e3958ca90df115c9138c3fc2ccc8"}],"src/js/selectors/i18n.js":[{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"da3f98f485f96d8b246e3a0fd7399d8e864ecc5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import { createSelector } from \u0027reselect\u0027;"},{"line_number":2,"context_line":"import { IntlProvider } from \u0027react-intl\u0027;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"import { MESSAGES } from \u0027../components/i18n/I18nProvider\u0027;"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"const languageSelector \u003d state \u003d\u003e state.i18n.get(\u0027language\u0027);"},{"line_number":7,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"3a461143_35f48059","line":4,"updated":"2017-01-31 13:59:22.000000000","message":"The messages should probably come from the store, not be imported from the component. But I\u0027d rather make that change in the language selector patch, because that\u0027s where the store is added.","commit_id":"6a7e15ca63caf2ce78ee0c968a1afc67a7c7cad0"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"6153cf24d6412da27fc1c0aa52ad5c156f2086b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import { createSelector } from \u0027reselect\u0027;"},{"line_number":2,"context_line":"import { IntlProvider } from \u0027react-intl\u0027;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"import { MESSAGES } from \u0027../components/i18n/I18nProvider\u0027;"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"const languageSelector \u003d state \u003d\u003e state.i18n.get(\u0027language\u0027);"},{"line_number":7,"context_line":""}],"source_content_type":"text/javascript","patch_set":5,"id":"3a461143_e01cf86b","line":4,"updated":"2017-01-31 14:02:32.000000000","message":"The messages should probably come from the store, not be imported from the component. But I\u0027d rather make that change in the language selector patch, because that\u0027s where the store is added.","commit_id":"58bd8c7ab827927a941477334886a169c7f2316b"}],"src/js/store.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"cf2277530811adcb66c1aa9e46bba91cfb6aaa91","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  appReducer,"},{"line_number":17,"context_line":"  {},"},{"line_number":18,"context_line":"  applyMiddleware("},{"line_number":19,"context_line":"    thunkMiddleware.withExtraArgument({ intl: getIntl }),"},{"line_number":20,"context_line":"    loggerMiddleware"},{"line_number":21,"context_line":"  )"},{"line_number":22,"context_line":");"}],"source_content_type":"text/javascript","patch_set":7,"id":"1a430d35_061d6273","line":19,"range":{"start_line":19,"start_character":40,"end_line":19,"end_character":53},"updated":"2017-02-03 11:25:15.000000000","message":"Nit: Maybe keeping this as getIntl is better, so .withExtraArgument({ getIntl }) as it is get function similar to getState","commit_id":"9a88965d0a33f26a89090fd52cea2ceb5ab4e4c5"}]}