)]}'
{"webpack.dev.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"33cdea1c60dee43b418c9b1f615955b842977186","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"module.exports \u003d env \u003d\u003e {"},{"line_number":6,"context_line":"  return merge(CommonConfig, {"},{"line_number":7,"context_line":"    devtool: \u0027inline-source-map\u0027,"},{"line_number":8,"context_line":"    devServer: {"},{"line_number":9,"context_line":"      contentBase: \u0027./dist\u0027,"},{"line_number":10,"context_line":"      host: \u00270.0.0.0\u0027,"}],"source_content_type":"text/javascript","patch_set":5,"id":"ff0f0b1f_a6d78fee","line":7,"updated":"2017-05-23 12:27:15.000000000","message":"inline-source-map tends to freeze my chrome dev tools ocasionally. Do you experience this too? Would you mind changing it to source-map as part of this patch?","commit_id":"e6a49fc8d2cd5874234d99663a54381422a1ba96"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"8c30735097802cf996f71ccc13a0cf861e06e3ba","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"module.exports \u003d env \u003d\u003e {"},{"line_number":6,"context_line":"  return merge(CommonConfig, {"},{"line_number":7,"context_line":"    devtool: \u0027inline-source-map\u0027,"},{"line_number":8,"context_line":"    devServer: {"},{"line_number":9,"context_line":"      contentBase: \u0027./dist\u0027,"},{"line_number":10,"context_line":"      host: \u00270.0.0.0\u0027,"}],"source_content_type":"text/javascript","patch_set":5,"id":"ff0f0b1f_940fee86","line":7,"in_reply_to":"ff0f0b1f_a6d78fee","updated":"2017-05-24 12:42:13.000000000","message":"Done","commit_id":"e6a49fc8d2cd5874234d99663a54381422a1ba96"}],"webpack.prod.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"4e95121b7473b8f74e41bdbb2e4a10d85faa8d0c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"limitations under the License.`;"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"module.exports \u003d env \u003d\u003e {"},{"line_number":23,"context_line":"  return merge(CommonConfig, {"},{"line_number":24,"context_line":"    plugins: ["},{"line_number":25,"context_line":"      new webpack.optimize.UglifyJsPlugin(),"},{"line_number":26,"context_line":"      new webpack.BannerPlugin(license)"}],"source_content_type":"text/javascript","patch_set":3,"id":"3f044301_8b592b36","line":23,"updated":"2017-05-12 09:16:05.000000000","message":"I think we should add devtool: \u0027source-map\u0027 to production to make sure that code in console is readable\nhttps://webpack.js.org/guides/production-build/#source-maps\n\nNote that to make sourcemaps work it needs to be explicitly enabled in UglifyJSPlugin configuration. Also \u0027cheap\u0027 sourcemaps don\u0027t work with UglifyJsPlugin.\n\nhttps://github.com/webpack-contrib/uglifyjs-webpack-plugin#options\nhttps://github.com/webpack/webpack/issues/2704","commit_id":"90584c1f4950f0838532e4541fac531c0e7a1d7c"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"4d7580c25b8eb994ee5fd9978daf2f1e88787de0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"limitations under the License.`;"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"module.exports \u003d env \u003d\u003e {"},{"line_number":23,"context_line":"  return merge(CommonConfig, {"},{"line_number":24,"context_line":"    plugins: ["},{"line_number":25,"context_line":"      new webpack.optimize.UglifyJsPlugin(),"},{"line_number":26,"context_line":"      new webpack.BannerPlugin(license)"}],"source_content_type":"text/javascript","patch_set":3,"id":"3f044301_2bd8d71b","line":23,"in_reply_to":"3f044301_8b592b36","updated":"2017-05-12 09:32:07.000000000","message":"Done","commit_id":"90584c1f4950f0838532e4541fac531c0e7a1d7c"},{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"4e95121b7473b8f74e41bdbb2e4a10d85faa8d0c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  return merge(CommonConfig, {"},{"line_number":24,"context_line":"    plugins: ["},{"line_number":25,"context_line":"      new webpack.optimize.UglifyJsPlugin(),"},{"line_number":26,"context_line":"      new webpack.BannerPlugin(license)"},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":"  });"},{"line_number":29,"context_line":"};"}],"source_content_type":"text/javascript","patch_set":3,"id":"3f044301_ab25075e","line":26,"updated":"2017-05-12 09:16:05.000000000","message":"I think it is worth to also add \u0027process.env.NODE_ENV\u0027 via DefinePlugin\n\nnew webpack.DefinePlugin({\n  \u0027process.env.NODE_ENV\u0027: JSON.stringify(\u0027production\u0027)\n}),\n\nhttps://facebook.github.io/react/docs/optimizing-performance.html#webpack\nhttps://webpack.js.org/guides/production-build/#node-environment-variable\n\nIt takes care of evaluating process.env.NODE_ENV to specified string, so we can eventually use production vs dev conditions in application code. Also IIUC it enables reac in production mode.\n\nThe same config should probably go to webpack.dev.js setting the value to JSON.stringify(\u0027development\u0027)","commit_id":"90584c1f4950f0838532e4541fac531c0e7a1d7c"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"4d7580c25b8eb994ee5fd9978daf2f1e88787de0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  return merge(CommonConfig, {"},{"line_number":24,"context_line":"    plugins: ["},{"line_number":25,"context_line":"      new webpack.optimize.UglifyJsPlugin(),"},{"line_number":26,"context_line":"      new webpack.BannerPlugin(license)"},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":"  });"},{"line_number":29,"context_line":"};"}],"source_content_type":"text/javascript","patch_set":3,"id":"3f044301_0bd51be5","line":26,"in_reply_to":"3f044301_ab25075e","updated":"2017-05-12 09:32:07.000000000","message":"Done","commit_id":"90584c1f4950f0838532e4541fac531c0e7a1d7c"}]}
