)]}'
{"src/js/components/deployment_plan/ConfigurePlanStep.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"bfb2dfc0f43e41b8e9a1763c43e3fdd3252dc3b0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \u003cdiv\u003e"},{"line_number":34,"context_line":"      \u003cDeploymentConfigurationSummary {...props} /\u003e"},{"line_number":35,"context_line":"      \u0026nbsp;"},{"line_number":36,"context_line":"      \u003cLink id\u003d\"Deployment__EditDeployment\" to\u003d\"/deployment-plan/configuration\"\u003e"},{"line_number":37,"context_line":"        \u003cFormattedMessage {...messages.editConfigurationLink} /\u003e"},{"line_number":38,"context_line":"      \u003c/Link\u003e"},{"line_number":39,"context_line":"    \u003c/div\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"5f201791_7998da73","line":36,"updated":"2017-06-27 15:02:14.000000000","message":"The general convention for id afaik is \u003cComponentName\u003e__\u003cElementDescription\u003e. I am aware of the fact that in some cases ComponentName does not fit very well, so maybe using higher parent level component may be better so how about DploymentPlan__EditDeploymentLink ?","commit_id":"2ac7016c05d5648451c99976450e547b64e39006"}],"src/js/components/deployment_plan/DeploymentConfiguration.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"bfb2dfc0f43e41b8e9a1763c43e3fdd3252dc3b0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \u003cul className\u003d\"nav nav-tabs\"\u003e"},{"line_number":59,"context_line":"          \u003cNavTab"},{"line_number":60,"context_line":"            location\u003d{location}"},{"line_number":61,"context_line":"            id\u003d\"DeploymentConfiguration__Overall\""},{"line_number":62,"context_line":"            to\u003d\"/deployment-plan/configuration/environment\""},{"line_number":63,"context_line":"          \u003e"},{"line_number":64,"context_line":"            \u003cFormattedMessage {...messages.overallSettings} /\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"5f201791_d9800ef8","line":61,"updated":"2017-06-27 15:02:14.000000000","message":"DeploymentConfiguration__OverallSettingsTab","commit_id":"2ac7016c05d5648451c99976450e547b64e39006"},{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"bfb2dfc0f43e41b8e9a1763c43e3fdd3252dc3b0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          \u003c/NavTab\u003e"},{"line_number":66,"context_line":"          \u003cNavTab"},{"line_number":67,"context_line":"            location\u003d{location}"},{"line_number":68,"context_line":"            id\u003d\"DeploymentConfiguration__Parameters\""},{"line_number":69,"context_line":"            to\u003d\"/deployment-plan/configuration/parameters\""},{"line_number":70,"context_line":"          \u003e"},{"line_number":71,"context_line":"            \u003cFormattedMessage {...messages.parameters} /\u003e"}],"source_content_type":"text/javascript","patch_set":2,"id":"5f201791_b97b1226","line":68,"updated":"2017-06-27 15:02:14.000000000","message":"DeploymentConfiguration__ParametersTab","commit_id":"2ac7016c05d5648451c99976450e547b64e39006"}],"src/js/components/environment_configuration/EnvironmentConfiguration.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"bfb2dfc0f43e41b8e9a1763c43e3fdd3252dc3b0","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          \u003cTab"},{"line_number":162,"context_line":"            key\u003d{index}"},{"line_number":163,"context_line":"            isActive\u003d{this.isTabActive(tabName)}"},{"line_number":164,"context_line":"            data-automation-id\u003d\"DeploymentConfiguration__CategoriesListItem\""},{"line_number":165,"context_line":"          \u003e"},{"line_number":166,"context_line":"            \u003ca href\u003d\"\" onClick\u003d{this.activateTab.bind(this, tabName)}\u003e"},{"line_number":167,"context_line":"              {topic.get(\u0027title\u0027)}"}],"source_content_type":"text/javascript","patch_set":2,"id":"5f201791_195b2687","line":164,"updated":"2017-06-27 15:02:14.000000000","message":"As discussed previously, I\u0027d prefer if we stick to a single way to define ids which is id attribute. According to discussion, this is introduced due to the fact that id has to be unique.\n\nI don\u0027t think it is valid/helpful to put the same id to all items in the list. The items in list should be easily accessible by it\u0027s wrapper element (DeploymentConfiguration__CategoriesList ul). If needed we can provide unique id for each item by appending index as we do with \u0027key\u0027 attribute which needs to be unique too.\n\nUdi is accessing the items via parent sucfficient? Is there any marginal impact on automation when doing so?","commit_id":"2ac7016c05d5648451c99976450e547b64e39006"}]}