)]}'
{"src/js/selectors/validations.js":[{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"e6359b64ff3da2981aa48491b10a76f099015822","unresolved":false,"context_lines":[{"line_number":118,"context_line":"          execution.get(\u0027workflow_name\u0027) \u003d\u003d\u003d MistralConstants.PLAN_CREATE) \u0026\u0026"},{"line_number":119,"context_line":"        execution.getIn([\u0027input\u0027, \u0027container\u0027]) \u003d\u003d\u003d planName"},{"line_number":120,"context_line":"    )"},{"line_number":121,"context_line":"    .sort((a, b) \u003d\u003e {"},{"line_number":122,"context_line":"      if (a.get(\u0027updated_at\u0027) \u003c b.get(\u0027updated_at\u0027)) {"},{"line_number":123,"context_line":"        return -1;"},{"line_number":124,"context_line":"      }"},{"line_number":125,"context_line":"      if (a.get(\u0027updated_at\u0027) \u003e b.get(\u0027updated_at\u0027)) {"},{"line_number":126,"context_line":"        return 1;"},{"line_number":127,"context_line":"      }"},{"line_number":128,"context_line":"      if (a.get(\u0027updated_at\u0027) \u003d\u003d\u003d b.get(\u0027updated_at\u0027)) {"},{"line_number":129,"context_line":"        return 0;"},{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":"    })"},{"line_number":132,"context_line":"    .last() || Map({}))"},{"line_number":133,"context_line":"    .get(\u0027updated_at\u0027, 0);"},{"line_number":134,"context_line":"};"}],"source_content_type":"text/javascript","patch_set":1,"id":"7f287b81_9e0e2239","line":131,"range":{"start_line":121,"start_character":1,"end_line":131,"end_character":6},"updated":"2017-09-06 23:49:28.000000000","message":"Since you\u0027re returning the \u0027updated_at\u0027 value, you can get an array of updated_at values right after filtering and you can sort it much more easily:\n\n.filter(...)\n  .map(execution \u003d\u003e execution.get(\u0027updated_at\u0027, 0))\n  .sort()\n  .last();","commit_id":"dce0ad2358e42c8ee1e00741f56fc40e08859e8a"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"f2c15820fe48d4e205096f7cad0cdf7f55d2c210","unresolved":false,"context_lines":[{"line_number":118,"context_line":"          execution.get(\u0027workflow_name\u0027) \u003d\u003d\u003d MistralConstants.PLAN_CREATE) \u0026\u0026"},{"line_number":119,"context_line":"        execution.getIn([\u0027input\u0027, \u0027container\u0027]) \u003d\u003d\u003d planName"},{"line_number":120,"context_line":"    )"},{"line_number":121,"context_line":"    .sort((a, b) \u003d\u003e {"},{"line_number":122,"context_line":"      if (a.get(\u0027updated_at\u0027) \u003c b.get(\u0027updated_at\u0027)) {"},{"line_number":123,"context_line":"        return -1;"},{"line_number":124,"context_line":"      }"},{"line_number":125,"context_line":"      if (a.get(\u0027updated_at\u0027) \u003e b.get(\u0027updated_at\u0027)) {"},{"line_number":126,"context_line":"        return 1;"},{"line_number":127,"context_line":"      }"},{"line_number":128,"context_line":"      if (a.get(\u0027updated_at\u0027) \u003d\u003d\u003d b.get(\u0027updated_at\u0027)) {"},{"line_number":129,"context_line":"        return 0;"},{"line_number":130,"context_line":"      }"},{"line_number":131,"context_line":"    })"},{"line_number":132,"context_line":"    .last() || Map({}))"},{"line_number":133,"context_line":"    .get(\u0027updated_at\u0027, 0);"},{"line_number":134,"context_line":"};"}],"source_content_type":"text/javascript","patch_set":1,"id":"7f287b81_f6dbffe9","line":131,"range":{"start_line":121,"start_character":1,"end_line":131,"end_character":6},"in_reply_to":"7f287b81_9e0e2239","updated":"2017-09-07 10:49:48.000000000","message":"Oh... Much better. Thanks!","commit_id":"dce0ad2358e42c8ee1e00741f56fc40e08859e8a"},{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"d4ae2ceee4747bcd269d9ef17ac25dc2095b7107","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    executions"},{"line_number":115,"context_line":"      .filter("},{"line_number":116,"context_line":"        execution \u003d\u003e"},{"line_number":117,"context_line":"          (execution.get(\u0027workflow_name\u0027) \u003d\u003d\u003d MistralConstants.PLAN_UPDATE ||"},{"line_number":118,"context_line":"            execution.get(\u0027workflow_name\u0027) \u003d\u003d\u003d MistralConstants.PLAN_CREATE) \u0026\u0026"},{"line_number":119,"context_line":"          execution.getIn([\u0027input\u0027, \u0027container\u0027]) \u003d\u003d\u003d planName"},{"line_number":120,"context_line":"      )"}],"source_content_type":"text/javascript","patch_set":2,"id":"7f287b81_3a014c39","line":117,"updated":"2017-09-08 11:32:57.000000000","message":"execution is a Record, so you can simplify this to\n[MistralConstants.PLAN_UPDATE, MistralConstants.PLAN_CREATE].includes(execution.workflow_name) \u0026\u0026 ...","commit_id":"6fa481f4c870eed1a70c2f15b8c3327432311394"},{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"d4ae2ceee4747bcd269d9ef17ac25dc2095b7107","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            execution.get(\u0027workflow_name\u0027) \u003d\u003d\u003d MistralConstants.PLAN_CREATE) \u0026\u0026"},{"line_number":119,"context_line":"          execution.getIn([\u0027input\u0027, \u0027container\u0027]) \u003d\u003d\u003d planName"},{"line_number":120,"context_line":"      )"},{"line_number":121,"context_line":"      .map(execution \u003d\u003e execution.get(\u0027updated_at\u0027, 0))"},{"line_number":122,"context_line":"      .sort()"},{"line_number":123,"context_line":"      .last() || 0"},{"line_number":124,"context_line":"  );"}],"source_content_type":"text/javascript","patch_set":2,"id":"7f287b81_bac3fcec","line":121,"updated":"2017-09-08 11:32:57.000000000","message":"Setting updated_at default to 0 in immutableRecords/workflowExecutions.js would simplify this to\n.map(execution \u003d\u003e execution.updated_at)","commit_id":"6fa481f4c870eed1a70c2f15b8c3327432311394"}]}