)]}'
{"tasks/upgrade/create-upgrade-scripts.yaml":[{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"c83d66c383ae16f6593eb46de32feabc1477dbc0","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  # needs to have fixed width, so remove any extra leading spaces from"},{"line_number":127,"context_line":"  # results via sed rather than in the grep expression itself."},{"line_number":128,"context_line":"  shell: |"},{"line_number":129,"context_line":"    grep -oP \u0027(^| )(?\u003c\u003d-e |--environment-file ) *[^ ]*(environments/docker|environments/services|environments/storage|environments/ceph-ansible|ci/environments)[^ ]*\u0027 {{ overcloud_deploy_script }} \\"},{"line_number":130,"context_line":"        | sed -E \u0027s/^ *//\u0027"},{"line_number":131,"context_line":"  register: services"},{"line_number":132,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_a67591ce","line":129,"updated":"2018-01-22 16:36:28.000000000","message":"Looks like it doesn\u0027t detect all environment files, for example:\n\nhttp://paste.openstack.org/show/650127/","commit_id":"05fc4f51a65717d3162f90e89ac81b06d1c6dce3"},{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"7d5a5fe5c709b7e4eda2e4d158f32abb2fd5e266","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  # needs to have fixed width, so remove any extra leading spaces from"},{"line_number":127,"context_line":"  # results via sed rather than in the grep expression itself."},{"line_number":128,"context_line":"  shell: |"},{"line_number":129,"context_line":"    grep -oP \u0027(^| )(?\u003c\u003d-e |--environment-file ) *[^ ]*(environments/docker|environments/services|environments/storage|environments/ceph-ansible|ci/environments)[^ ]*\u0027 {{ overcloud_deploy_script }} \\"},{"line_number":130,"context_line":"        | sed -E \u0027s/^ *//\u0027"},{"line_number":131,"context_line":"  register: services"},{"line_number":132,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_dc33d061","line":129,"in_reply_to":"7f96bb07_3cd67451","updated":"2018-01-22 17:19:18.000000000","message":"My bad in the first test, looks like it\u0027s doing the correct thing:\n\nhttp://paste.openstack.org/show/650172/","commit_id":"05fc4f51a65717d3162f90e89ac81b06d1c6dce3"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b1d7409b5379245ecb4015ad2a58ed61f7b8f32e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  # needs to have fixed width, so remove any extra leading spaces from"},{"line_number":127,"context_line":"  # results via sed rather than in the grep expression itself."},{"line_number":128,"context_line":"  shell: |"},{"line_number":129,"context_line":"    grep -oP \u0027(^| )(?\u003c\u003d-e |--environment-file ) *[^ ]*(environments/docker|environments/services|environments/storage|environments/ceph-ansible|ci/environments)[^ ]*\u0027 {{ overcloud_deploy_script }} \\"},{"line_number":130,"context_line":"        | sed -E \u0027s/^ *//\u0027"},{"line_number":131,"context_line":"  register: services"},{"line_number":132,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_e1262369","line":129,"in_reply_to":"7f96bb07_a67591ce","updated":"2018-01-22 16:50:58.000000000","message":"Thanks i\u0027ll probably just try removing (^| ) in the beginning. It was supposed to make it a bit safer, but we probably shouldn\u0027t really need it. Too bad the (?\u003c\u003d lookahead part has to be static in width, so i couldn\u0027t put the (^| ) condition in.","commit_id":"05fc4f51a65717d3162f90e89ac81b06d1c6dce3"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"3d0fe002230ffa618ad767760234b4e33a0c7b66","unresolved":false,"context_lines":[{"line_number":126,"context_line":"  # needs to have fixed width, so remove any extra leading spaces from"},{"line_number":127,"context_line":"  # results via sed rather than in the grep expression itself."},{"line_number":128,"context_line":"  shell: |"},{"line_number":129,"context_line":"    grep -oP \u0027(^| )(?\u003c\u003d-e |--environment-file ) *[^ ]*(environments/docker|environments/services|environments/storage|environments/ceph-ansible|ci/environments)[^ ]*\u0027 {{ overcloud_deploy_script }} \\"},{"line_number":130,"context_line":"        | sed -E \u0027s/^ *//\u0027"},{"line_number":131,"context_line":"  register: services"},{"line_number":132,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_3cd67451","line":129,"in_reply_to":"7f96bb07_e1262369","updated":"2018-01-22 17:08:47.000000000","message":"Upon further testing this seems to be working as intended. cinder-backup.yaml wasn\u0027t covered by the original condition either. But if we can find a better set of paths to match for, we can definitely amend this patch.","commit_id":"05fc4f51a65717d3162f90e89ac81b06d1c6dce3"}]}