)]}'
{"tasks/common/auxilary-facts.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"27e31e9190d00387bbc3f5560a1e47682bf6f04e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    roles_data: \"{{ roles_data_file.stdout }}\""},{"line_number":20,"context_line":"  set_fact:"},{"line_number":21,"context_line":"    roles_data: \"{{ (roles_data_file.stdout|length \u003e 0) | ternary(roles_data, default_roles_data)}}\""},{"line_number":22,"context_line":"    custom_roles_used: \"{{ (roles_data_file.stdout|length \u003e 0) | ternary(true, false)}}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f6a8fd7_3656d108","line":22,"updated":"2018-04-16 07:06:55.000000000","message":"We could get rid of this variable if we define \"default_roles_data\" in the role defaults file (defaults/main.yml) and use the condition (roles_data !\u003d default_roles_data) in https://review.openstack.org/#/c/560835/2/tasks/upgrade/overcloud_upgrade_prepare.yml@4. wdyt? \nAlso, this way we will be able to use the default_roles_data variable in some other tasks.","commit_id":"9bdfcc73622a62afb0e2215e024fc1ff054cbb80"}],"tasks/upgrade/adjust-roles-data.yaml":[{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"5fdec1d6af82b938fbc11c60a0063200c863c7a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: rename FluentdClient to Fluentd"},{"line_number":3,"context_line":"  # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1540546"},{"line_number":4,"context_line":"  replace:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_91c7f512","line":1,"updated":"2018-04-12 17:12:06.000000000","message":"Does this runs always? Including when the default roles_data is used, aka {{ roles_data }} \u003d\u003d /usr/share/openstack-tripleo-heat-templates/roles_data.yaml ? If that\u0027s the case I think we should limit it to only when custom roles file is in use.","commit_id":"16efd62af3f5111742743cabf0c98a3f7473e589"},{"author":{"_account_id":18851,"name":"Marius Cornea","email":"mcornea@redhat.com","username":"mcornea"},"change_message_id":"ae84883fe9eb1e1e5be47e0d61e658edec28bfdc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: rename FluentdClient to Fluentd"},{"line_number":3,"context_line":"  # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1540546"},{"line_number":4,"context_line":"  replace:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_29c1c854","line":1,"in_reply_to":"bf659307_461673aa","updated":"2018-04-13 13:50:58.000000000","message":"Even if they\u0027re not present I still think we should limit it to only when custom roles were used. \n\nPossibly it would fail with permission denied but still I don\u0027t think we want to touch files provided by rpm packages at all even if it would be just a noop.","commit_id":"16efd62af3f5111742743cabf0c98a3f7473e589"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"a59a946221860c8ba95496b80c15249cd3c577e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: rename FluentdClient to Fluentd"},{"line_number":3,"context_line":"  # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1540546"},{"line_number":4,"context_line":"  replace:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_461673aa","line":1,"in_reply_to":"bf659307_91c7f512","updated":"2018-04-13 05:44:34.000000000","message":"Yes, it runs always. If default roles_data is used those services ain\u0027t present there so it would be noop.","commit_id":"16efd62af3f5111742743cabf0c98a3f7473e589"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"880fe420a27fc6d6220f70a59651e8acf4d4813d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  replace:"},{"line_number":5,"context_line":"    path: \"{{ roles_data }}\""},{"line_number":6,"context_line":"    regexp: \u0027(\\s+)- OS::TripleO::Services::FluentdClient$\u0027"},{"line_number":7,"context_line":"    replace: \u0027\\1- OS::TripleO::Services::Fluentd\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: remove ManilaBackendGeneric resource"},{"line_number":10,"context_line":"  # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1541382"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_a8e4f9e0","line":7,"updated":"2018-04-13 09:46:45.000000000","message":"IIUC what Sofer said yesterday on call, we don\u0027t want to replace it like this, we want to remove FluentdClient. (Perhaps we should double check with MetMon though? It seems a bit strange that we\u0027d just remove it with no alternative.)","commit_id":"16efd62af3f5111742743cabf0c98a3f7473e589"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b26dd6ff978619911a135f7dbc45715bd1522ddf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  replace:"},{"line_number":5,"context_line":"    path: \"{{ roles_data }}\""},{"line_number":6,"context_line":"    regexp: \u0027(\\s+)- OS::TripleO::Services::FluentdClient$\u0027"},{"line_number":7,"context_line":"    replace: \u0027\\1- OS::TripleO::Services::Fluentd\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: remove ManilaBackendGeneric resource"},{"line_number":10,"context_line":"  # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1541382"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_eccc3ebc","line":7,"in_reply_to":"bf659307_a8e4f9e0","updated":"2018-04-13 14:15:22.000000000","message":"Discussed on IRC -- this replacement is correct.","commit_id":"16efd62af3f5111742743cabf0c98a3f7473e589"}]}