)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"f864a543f4dfbb22ca4e25242ae92687ecd8ebe2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"variables and add the template name in the"},{"line_number":18,"context_line":"src section of the task."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"It also removes the creation of the workload"},{"line_number":21,"context_line":"template from the upgrade/create-upgrade-scripts.yaml"},{"line_number":22,"context_line":"as it is being duplicated."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I443865bc95590a5cffcc28d98913110238e863b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3fa7e38b_1001d703","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":26},"updated":"2020-01-22 10:07:26.000000000","message":"I don\u0027t see to what it refers to, can you enlighten me ?","commit_id":"951306f3db73d3683e7b37fe823950fdc798c30b"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"e55dd110811b0ee0991f0580c58d6963478bab5a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"variables and add the template name in the"},{"line_number":18,"context_line":"src section of the task."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"It also removes the creation of the workload"},{"line_number":21,"context_line":"template from the upgrade/create-upgrade-scripts.yaml"},{"line_number":22,"context_line":"as it is being duplicated."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I443865bc95590a5cffcc28d98913110238e863b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"3fa7e38b_e3a79708","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":26},"in_reply_to":"3fa7e38b_1001d703","updated":"2020-01-22 11:19:35.000000000","message":"I guess it\u0027s referring to https://review.opendev.org/#/c/562957/20/defaults/main.yml@75, but it\u0027s not very well explained.\nWhat the patch is removing is the use of a variable to point at the workarounds template, but it doesn\u0027t touch the workarounds mechanism.","commit_id":"951306f3db73d3683e7b37fe823950fdc798c30b"}],"tasks/update/create-overcloud-update-scripts.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0724667228dc851702a1c6d7a497fadb8d873b48","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  import_tasks: ../common/auxilary-facts.yaml"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: create undercloud update script"},{"line_number":18,"context_line":"  vars:"},{"line_number":19,"context_line":"    log_prefix: \"update\""},{"line_number":20,"context_line":"  template:"},{"line_number":21,"context_line":"    src: \"undercloud_upgrade.sh.j2\""},{"line_number":22,"context_line":"    dest: \"{{ undercloud_update_script }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_74aec62f","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":24},"updated":"2020-01-27 15:28:59.000000000","message":"I don\u0027t see this used anywhere. What is it for?","commit_id":"f124dd5318d2f8fdd0c49d05e1c7dad27be9dabc"}],"tasks/upgrade/create-overcloud-upgrade-hosts-scripts.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"6966219e35e97a7a682ff204a4ba29f36f917e13","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    role_hosts: \"{{ oc_roles_hosts[role] }}\""},{"line_number":5,"context_line":"  template:"},{"line_number":6,"context_line":"    src: \"{{ overcloud_system_upgrade_template }}\""},{"line_number":7,"context_line":"    dest: \"{{ overcloud_system_upgrade_script_base }}-{{ item }}.sh\""},{"line_number":8,"context_line":"    mode: 0775"},{"line_number":9,"context_line":"    force: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_bcd400eb","line":6,"updated":"2019-12-13 14:20:01.000000000","message":"You added back the template variable that was added in patchset 5 and the jobs are failing again:\n\n2019-12-13 11:41:37.080804 | primary | TASK [tripleo-upgrade : create overcloud system upgrade script for Controller] ***\n2019-12-13 11:41:37.113746 | primary | Friday 13 December 2019  11:41:37 +0000 (0:00:00.353)       0:02:42.719 *******\n2019-12-13 11:41:37.158246 | primary | fatal: [undercloud]: FAILED! \u003d\u003e {}\n2019-12-13 11:41:37.158327 | primary |\n2019-12-13 11:41:37.158375 | primary | MSG:\n2019-12-13 11:41:37.158411 | primary |\n2019-12-13 11:41:37.158686 | primary | The task includes an option with an undefined variable. The error was: \u0027overcloud_system_upgrade_template\u0027 is undefined\n2019-12-13 11:41:37.158730 | primary |\n2019-12-13 11:41:37.159112 | primary | The error appears to be in \u0027/home/zuul/workspace/.quickstart/usr/local/share/ansible/roles/tripleo-upgrade/tasks/upgrade/create-overcloud-upgrade-hosts-scripts.yaml\u0027: line 2, column 3, but may\n2019-12-13 11:41:37.159859 | primary | be elsewhere in the file depending on the exact syntax problem.\n2019-12-13 11:41:37.159903 | primary |\n2019-12-13 11:41:37.159999 | primary | The offending line appears to be:\n2019-12-13 11:41:37.160035 | primary |\n2019-12-13 11:41:37.160077 | primary | ---\n2019-12-13 11:41:37.160221 | primary | - name: create overcloud system upgrade script for {{ role }}\n2019-12-13 11:41:37.160272 | primary |   ^ here\n2019-12-13 11:41:37.160429 | primary | We could be wrong, but this one looks like it might be an issue with\n2019-12-13 11:41:37.160601 | primary | missing quotes. Always quote template expression brackets when they\n2019-12-13 11:41:37.160692 | primary | start a value. For instance:\n2019-12-13 11:41:37.160728 | primary |\n2019-12-13 11:41:37.160792 | primary |     with_items:\n2019-12-13 11:41:37.160859 | primary |       - {{ foo }}\n2019-12-13 11:41:37.160895 | primary |\n2019-12-13 11:41:37.160968 | primary | Should be written as:\n2019-12-13 11:41:37.161004 | primary |\n2019-12-13 11:41:37.161066 | primary |     with_items:\n2019-12-13 11:41:37.161136 | primary |       - \"{{ foo }}\"","commit_id":"a60a268953a4c3f6151006962770f2e3bcf3294e"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"da0d6145e11c6c6ec18a3840a7d442feb9aadb86","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: create overcloud upgrade script for {{ role }}"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"    src: \"{{ overcloud_upgrade_run_template }}\""},{"line_number":15,"context_line":"    dest: \"{{ overcloud_upgrade_run_script_base }}-{{ item }}.sh\""},{"line_number":16,"context_line":"    mode: 0775"},{"line_number":17,"context_line":"    force: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_1664fae5","line":14,"updated":"2019-12-16 10:51:57.000000000","message":"Same here: https://review.opendev.org/#/c/562957/4..5/tasks/upgrade/create-overcloud-upgrade-hosts-scripts.yaml@14","commit_id":"ed754d4d22214786d87a81a0ef6976fcd2e43d5e"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"46a7f5b55c93afb77214e9ff5730d90fb3b9b7d0","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: create overcloud upgrade script for {{ role }}"},{"line_number":13,"context_line":"  template:"},{"line_number":14,"context_line":"    src: \"{{ overcloud_upgrade_run.sh.j2 }}\""},{"line_number":15,"context_line":"    dest: \"{{ overcloud_upgrade_run_script_base }}-{{ item }}.sh\""},{"line_number":16,"context_line":"    mode: 0775"},{"line_number":17,"context_line":"    force: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_6f9a1e61","line":14,"updated":"2019-12-17 16:03:30.000000000","message":"man...the curly braces.. this will misserably fail.","commit_id":"0b8c5e379ae546791565528ec66b1bce7f317c55"}],"tasks/upgrade/create-overcloud-upgrade-scripts.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"ae3b4024cf681eb85b65cc91c061138d5d3750de","unresolved":false,"context_lines":[{"line_number":87,"context_line":"- name: create online data migration script"},{"line_number":88,"context_line":"  template:"},{"line_number":89,"context_line":"    src: \"overcloud_upgrade_run.sh.j2\""},{"line_number":90,"context_line":"    dest: \"{{ overcloud_upgrade_run_script_base }}-{{ item }}.sh\""},{"line_number":91,"context_line":"    mode: 0775"},{"line_number":92,"context_line":"    force: true"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_99c5320c","line":90,"updated":"2019-12-20 09:28:39.000000000","message":"Why did you change this? This doesn\u0027t need to be modified...I believe you had a rebase error.\n\n\n2019-12-18 15:24:56.756094 | primary | TASK [tripleo-upgrade : create online data migration script] *******************\n2019-12-18 15:24:56.782950 | primary | Wednesday 18 December 2019  15:24:56 +0000 (0:00:03.713)       0:03:32.995 ****\n2019-12-18 15:24:56.825930 | primary | fatal: [undercloud]: FAILED! \u003d\u003e {}\n2019-12-18 15:24:56.826027 | primary |\n2019-12-18 15:24:56.826140 | primary | MSG:\n2019-12-18 15:24:56.826179 | primary |\n2019-12-18 15:24:56.826361 | primary | The task includes an option with an undefined variable. The error was: \u0027item\u0027 is undefined\n2019-12-18 15:24:56.826387 | primary |\n2019-12-18 15:24:56.826764 | primary | The error appears to be in \u0027/home/zuul/workspace/.quickstart/usr/local/share/ansible/roles/tripleo-upgrade/tasks/upgrade/create-overcloud-upgrade-scripts.yaml\u0027: line 87, column 3, but may\n2019-12-18 15:24:56.827684 | primary | be elsewhere in the file depending on the exact syntax problem.\n2019-12-18 15:24:56.827765 | primary |\n2019-12-18 15:24:56.827855 | primary | The offending line appears to be:\n2019-12-18 15:24:56.827881 | primary |\n2019-12-18 15:24:56.827906 | primary |\n2019-12-18 15:24:56.828007 | primary | - name: create online data migration script\n2019-12-18 15:24:56.828050 | primary |   ^ here","commit_id":"ff115ade20c9a9dff37a1839274607f9d191fa20"}]}