)]}'
{"tasks/common/adjust-roles-data.yaml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"5dc31b566d5f1c880b0ab579d58aeb6733e6a3a6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: rename FluentdClient to Fluentd"},{"line_number":3,"context_line":"  # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1540546"},{"line_number":4,"context_line":"  replace:"},{"line_number":5,"context_line":"    path: \"{{ roles_data }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_a9d5ca1b","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":39},"updated":"2018-08-01 09:47:57.000000000","message":"this happened between 2 releases, is this task valid for updates ?","commit_id":"53f91c2ec5596570388c827d0a3d35cc2f240b59"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"ba4ccbeb714f35a64f6def142594de171d885a48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: rename FluentdClient to Fluentd"},{"line_number":3,"context_line":"  # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1540546"},{"line_number":4,"context_line":"  replace:"},{"line_number":5,"context_line":"    path: \"{{ roles_data }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_d19470e9","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":39},"in_reply_to":"5f7c97a3_497436cd","updated":"2018-08-01 10:57:41.000000000","message":"I came up with another solution in PS #3, wdyt?","commit_id":"53f91c2ec5596570388c827d0a3d35cc2f240b59"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d9d2e45ed61877a2e8bf08ecab249a0ef25cef08","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: rename FluentdClient to Fluentd"},{"line_number":3,"context_line":"  # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1540546"},{"line_number":4,"context_line":"  replace:"},{"line_number":5,"context_line":"    path: \"{{ roles_data }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_497436cd","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":39},"in_reply_to":"5f7c97a3_a9d5ca1b","updated":"2018-08-01 10:14:41.000000000","message":"You are right, this could have some negative impact in updates. I\u0027ll have to leave it as it was and add the \"remove ManilaBackendGeneric resource\" task in updates create-script playbook.","commit_id":"53f91c2ec5596570388c827d0a3d35cc2f240b59"}],"tasks/update/overcloud_update_prepare.yml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"57dcaf76d6f0fe937aa0826b7edbc8b2ae38778e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: adjust role-data for Pike update"},{"line_number":3,"context_line":"  include: ../common/adjust-roles-data.yaml"},{"line_number":4,"context_line":"  when: custom_roles_used|bool"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: setup HEAT outputs via update prepare"},{"line_number":7,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_96acc5eb","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":30},"updated":"2018-07-31 14:01:28.000000000","message":"If service got removed in the middle of the cycle from roles_data.yaml this will fail.","commit_id":"0b1a5a5bf45781af6f9da933e8ef4d27a26f8673"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f52b5471b96d192eb884e5889baa34274895f9a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: adjust role-data for Pike update"},{"line_number":3,"context_line":"  include: ../common/adjust-roles-data.yaml"},{"line_number":4,"context_line":"  when: custom_roles_used|bool"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: setup HEAT outputs via update prepare"},{"line_number":7,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_4ebd1ccf","line":4,"range":{"start_line":4,"start_character":8,"end_line":4,"end_character":30},"in_reply_to":"5f7c97a3_96acc5eb","updated":"2018-08-01 08:58:02.000000000","message":"The case for the default roles_data.yml is handled by https://review.openstack.org/#/c/587723/ . This patch would cover the case in which the customize roles_data used for the update still includes this service.","commit_id":"0b1a5a5bf45781af6f9da933e8ef4d27a26f8673"}]}