)]}'
{"tasks/common/auxilary-facts.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"b9d5db2c1adcaaf453568ea1fe4ebb87f9044765","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- name: assert osd_scenario variable is set"},{"line_number":74,"context_line":"  shell: |"},{"line_number":75,"context_line":"    grep -R \u0027osd_scenario:\u0027 {{ item }}"},{"line_number":76,"context_line":"  with_items: \"{{ env_files }}\""},{"line_number":77,"context_line":"  failed_when: false"},{"line_number":78,"context_line":"  register: osd_found_file"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_5a511336","line":75,"updated":"2019-04-23 14:29:20.000000000","message":"You\u0027ll want one definition of CephAnsibleDisksConfig. Do you know that 100% of the time, for the scenario this code tests, what the devices list will be? If so you could ensure the same devices list is added in the template. An example of what it should look like is the following: \n\nparameter_defaults:\n  CephAnsibleDisksConfig:\n    devices:\n      - /dev/sdb\n      - /dev/sdc\n      - /dev/sdd\n    osd_scenario: collocated\n    osd_objectstore: filestore","commit_id":"084d1d8b8aeefb1c8b7df61641d3d337e0fa24fa"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"11194c9d54a71d47c048ee7174750ac1fe1c0913","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- name: assert osd_scenario variable is set"},{"line_number":74,"context_line":"  shell: |"},{"line_number":75,"context_line":"    grep -R \u0027osd_scenario:\u0027 {{ item }}"},{"line_number":76,"context_line":"  with_items: \"{{ env_files }}\""},{"line_number":77,"context_line":"  failed_when: false"},{"line_number":78,"context_line":"  register: osd_found_file"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_3d0539c3","line":75,"in_reply_to":"ffb9cba7_5a511336","updated":"2019-04-23 14:41:54.000000000","message":"My understanding is that you encountered this with the move to ceph-ansible 3.2. Though in this version the default changed since we want all new deployments using the lvm scenario, someone who is upgrading from 12 to 13 will need to stay on filestore and collocated (or non-collocated). Thus, if a deployment worked in the past without this scenario set, it should be set now. We can document this, but it would have been better if the initial deployment already had the osd_scenario set. \n\n\nhttps://github.com/ceph/ceph-ansible/blob/a1254d767ce6430ce017ca9d54b4a57390834c43/docs/source/osds/scenarios.rst","commit_id":"084d1d8b8aeefb1c8b7df61641d3d337e0fa24fa"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"998dfbaf3099c63656f86fcd07363ce192504fc4","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- name: assert osd_scenario variable is set"},{"line_number":74,"context_line":"  shell: |"},{"line_number":75,"context_line":"    grep -R \u0027osd_scenario:\u0027 {{ item }}"},{"line_number":76,"context_line":"  with_items: \"{{ env_files }}\""},{"line_number":77,"context_line":"  failed_when: false"},{"line_number":78,"context_line":"  register: osd_found_file"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_ddf5fdcc","line":75,"in_reply_to":"ffb9cba7_5a511336","updated":"2019-04-23 14:41:32.000000000","message":"Unfortunately no. Similar snippet is passed during deployment. And now during upgrade we need to determine what to set for \u0027osd_scenario\u0027, hence question - should it be set during P deployment?","commit_id":"084d1d8b8aeefb1c8b7df61641d3d337e0fa24fa"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"15962bbcab9de3400c114d2dba5722b5e7841085","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"- name: assert osd_scenario variable is set"},{"line_number":74,"context_line":"  shell: |"},{"line_number":75,"context_line":"    grep -R \u0027osd_scenario:\u0027 {{ item }}"},{"line_number":76,"context_line":"  with_items: \"{{ env_files }}\""},{"line_number":77,"context_line":"  failed_when: false"},{"line_number":78,"context_line":"  register: osd_found_file"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_3d8f7924","line":75,"in_reply_to":"ffb9cba7_ddf5fdcc","updated":"2019-04-23 14:46:30.000000000","message":"Yes, I think setting osd_scenario during the P deployment would be best.","commit_id":"084d1d8b8aeefb1c8b7df61641d3d337e0fa24fa"}],"templates/ceph-osd-scenario.yml.j2":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"9acc8309a87fad5a9195bd37c9f590066fc34c60","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"parameter_defaults:"},{"line_number":3,"context_line":"  CephAnsibleDisksConfig:"},{"line_number":4,"context_line":"    osd_scenario: collocated"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ffb9cba7_5a0b538d","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":24},"updated":"2019-04-23 14:19:43.000000000","message":"This variable is not additive so if you have defined it somewhere else, like the list of disks you are using then whichever one is defined later will be undefined.","commit_id":"084d1d8b8aeefb1c8b7df61641d3d337e0fa24fa"}]}