)]}'
{"defaults/main.yml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"2ee949771b3f86024db14a34f994ba19f3d4b33c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"py_ver: 2"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Enable SELinux on the undercloud"},{"line_number":260,"context_line":"undercloud_enable_selinux: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_18af11e4","line":260,"range":{"start_line":260,"start_character":27,"end_line":260,"end_character":32},"updated":"2019-06-05 10:57:34.000000000","message":"Is this a required(per documentation(future?)), otherwise it looks like a workaround which is easily missed being updated when the issue is fixed","commit_id":"049a1503669a2f63ed974c5a389d1aeac646f3a4"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"60763bb29a936407b2d80b140d74da323d187312","unresolved":false,"context_lines":[{"line_number":257,"context_line":"py_ver: 2"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Enable SELinux on the undercloud"},{"line_number":260,"context_line":"undercloud_enable_selinux: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_9ee0b2ce","line":260,"range":{"start_line":260,"start_character":27,"end_line":260,"end_character":32},"in_reply_to":"9fb8cfa7_18af11e4","updated":"2019-06-06 12:11:11.000000000","message":"Thanks for the comment. I removed the selinux enabling and created a workaround for it under \"pre_undercloud_upgrade_workarounds\" : \n\npre_undercloud_upgrade_workarounds:\n- selinux_disabled:\n    patch: false\n    basedir: \u0027\u0027\n    id: \u0027\u0027\n    command: \"grep -qxF \u0027undercloud_enable_selinux \u003d False\u0027 ~/undercloud.conf || sed -i \u0027/\\[DEFAULT\\]/a undercloud_enable_selinux \u003d False\u0027 undercloud.conf\"","commit_id":"049a1503669a2f63ed974c5a389d1aeac646f3a4"}],"tasks/upgrade/configure_uc_containers.yml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"33bb683f77bc5cf34e643b7b0f302d8b0fec2f1a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      local_ip \u003d 192.168.24.1/24"},{"line_number":23,"context_line":"      undercloud_public_host \u003d 192.168.24.2"},{"line_number":24,"context_line":"      undercloud_admin_host \u003d 192.168.24.3"},{"line_number":25,"context_line":"      container_images_file \u003d /home/stack/local_images.yaml"},{"line_number":26,"context_line":"      container_insecure_registries\u003dbrew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888"},{"line_number":27,"context_line":"      undercloud_ntp_servers \u003d clock.redhat.com,clock2.redhat.com"},{"line_number":28,"context_line":"      hieradata_override \u003d /home/stack/undercloud_hiera.yaml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_eb390e41","line":25,"updated":"2019-05-07 10:19:50.000000000","message":"There are few things that shouldn\u0027t we changed I believe. The undercloud, when upgrading, already includes an undercloud.conf which could have been customized. If we hardcore values, like the local_interface, or the local_ip, or the dhcp_start/end via this step, we can get a wrongly configured system.\n\nI think, the best approach would be to modify only the values we need to modify, which are the \"container_images_file\", \"container_insecure_registries\" (as mentioned in the previous comment, we\u0027ll need to do some conversion from the old release \"docker_insecure_registries\" and then assign the value we desire), the hieradata_override (I guess it should match with the name we have in the variable {{ undercloud_hiera }} and add the undercloud_enable_selinux to false (we should test manually if this is still needed). \n\nThe rest of parameters, imho, should remain as they are in the undercloud.conf.","commit_id":"bfda2669429a0a320479fa4bfde6373c63d2617a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"716a730aa71a3dad7260750ec8d9c6ae563fa09e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      undercloud_public_host \u003d 192.168.24.2"},{"line_number":24,"context_line":"      undercloud_admin_host \u003d 192.168.24.3"},{"line_number":25,"context_line":"      container_images_file \u003d /home/stack/local_images.yaml"},{"line_number":26,"context_line":"      container_insecure_registries\u003dbrew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888"},{"line_number":27,"context_line":"      undercloud_ntp_servers \u003d clock.redhat.com,clock2.redhat.com"},{"line_number":28,"context_line":"      hieradata_override \u003d /home/stack/undercloud_hiera.yaml"},{"line_number":29,"context_line":"      undercloud_enable_selinux \u003d false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ffb9cba7_d43fabb1","line":26,"updated":"2019-04-29 20:10:13.000000000","message":"we shouldn\u0027t push these hosts upstream. This hsoul dbe configirable input so we can keep these external to this role","commit_id":"bfda2669429a0a320479fa4bfde6373c63d2617a"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"30a72fdd75cfcf5d27c2608b7b7b696778fe83e7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      undercloud_public_host \u003d 192.168.24.2"},{"line_number":24,"context_line":"      undercloud_admin_host \u003d 192.168.24.3"},{"line_number":25,"context_line":"      container_images_file \u003d /home/stack/local_images.yaml"},{"line_number":26,"context_line":"      container_insecure_registries\u003dbrew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888"},{"line_number":27,"context_line":"      undercloud_ntp_servers \u003d clock.redhat.com,clock2.redhat.com"},{"line_number":28,"context_line":"      hieradata_override \u003d /home/stack/undercloud_hiera.yaml"},{"line_number":29,"context_line":"      undercloud_enable_selinux \u003d false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ffb9cba7_a11bbb7e","line":26,"in_reply_to":"ffb9cba7_d43fabb1","updated":"2019-05-01 19:01:41.000000000","message":"ack.  will move these to input.","commit_id":"bfda2669429a0a320479fa4bfde6373c63d2617a"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"33bb683f77bc5cf34e643b7b0f302d8b0fec2f1a","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- name: check docker_insecure_registries already defined in {{ undercloud_conf }}"},{"line_number":59,"context_line":"  shell: |"},{"line_number":60,"context_line":"    awk -F \u0027\u003d\u0027 \u0027/^docker_insecure_registries/ {gsub(/[[:space:]]/, \"\", $2); print $2 }\u0027 {{ undercloud_conf }}"},{"line_number":61,"context_line":"  failed_when: false"},{"line_number":62,"context_line":"  register: defined_insecure_registry"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfbec78f_8b7df21d","line":60,"updated":"2019-05-07 10:19:50.000000000","message":"If you see in this task, we try to look for the \"docker_insecure_registries\" entry in the undercloud.conf. But this parameter has migrated into  \"containers_insecure_registries\" in stein, so maybe we could try to swap the field name in one of the tasks from \"docker_insecure_registries\" into \"containers_insecure_registries\".","commit_id":"bfda2669429a0a320479fa4bfde6373c63d2617a"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f18d8b647b0423ceb5c6e71becb2634d043977ff","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            - set:"},{"line_number":90,"context_line":"                name_prefix: openstack-"},{"line_number":91,"context_line":"                namespace: \"{{ def_namespace }},{{ ceph_namespace }}\""},{"line_number":92,"context_line":"                tag: latest"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  when: custom_uc_containers.stat.exists"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_dd8380cb","line":92,"updated":"2019-05-23 10:58:09.000000000","message":"So, for the automation, this file should come created already with the right parameters before we call tripleo-upgrade role: https://github.com/redhat-openstack/infrared/blob/master/plugins/tripleo-undercloud/tasks/prepare_uc_images.yml#L89-L178 , so we can remove it. In fact, we\u0027re reading the namespace parameter from that file, which is being passed in {{ uc_containers_prepare_file }} (defaulted to https://github.com/openstack/tripleo-upgrade/blob/master/defaults/main.yml#L113)\n\nSorry for not clarifying it before, as in the guide we were creating our own one with the needed bits to work. I\u0027ll try to update the guide.","commit_id":"6c7c85fc2b212bd9d13e5ff79c73b04d8b6382f3"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f18d8b647b0423ceb5c6e71becb2634d043977ff","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  when: custom_uc_containers.stat.exists"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"- name: adjust existing container_insecure_registries for undercloud upgrade"},{"line_number":97,"context_line":"  vars:"},{"line_number":98,"context_line":"    reg_list: \u0027{{ defined_container_registry.stdout.split(\",\")|union([def_namespace])|union([ceph_namespace])|unique|join(\",\") }}\u0027"},{"line_number":99,"context_line":"  replace:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfb3d3c7_9f2bd280","line":96,"updated":"2019-05-23 10:58:09.000000000","message":"There is one case which we should contemplate too, which is container_insecure_registries parameter is not present but docker_insecure_registries is (which is what we\u0027ll get from the osp14 undercloud.conf). In that case we would need to do something similar to this task, merge the container_registries from what we had defined in docker_insecure_registries parameter with what we have in the def_namespace variable..etc, as we\u0027re doing in line #98. Then change the name of docker_insecure_registries field into container_insecure_registries (or add a new container_insecure_registries line with the merged registries and remove the line for the docker_insecure_registries, both options would work imho).\n\nHowever, if you want we can try to implement it in a follow up patch.","commit_id":"6c7c85fc2b212bd9d13e5ff79c73b04d8b6382f3"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"c97bcf4913965e5521f8b38e37d345dd4aabfba8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  shell: |"},{"line_number":21,"context_line":"    awk -F \u0027\u003d\u0027 \u0027/^container_insecure_registries/ {gsub(/[[:space:]]/, \"\", $2); print $2 }\u0027 {{ undercloud_conf }}"},{"line_number":22,"context_line":"  failed_when: false"},{"line_number":23,"context_line":"  register: defined_container_registry"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: check undercloud_enable_selinux already defined in {{ undercloud_conf }}"},{"line_number":26,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bfb3d3c7_d25a1f81","line":23,"updated":"2019-05-30 13:33:43.000000000","message":"https://docs.ansible.com/ansible/latest/modules/lineinfile_module.html","commit_id":"7c60b547394af98d6b181cc5d40fa5ff339017cc"}]}