)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"c2335177217a5a04f31ac005dd4248834d5abe5b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"by the execution of Leapp to perform the operating system"},{"line_number":12,"context_line":"upgrade in the undercloud."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Co-Authored: Natal Ngétal\u003chobbestigrou@erakis.eu\u003e"},{"line_number":15,"context_line":"Change-Id: Ided7f974c571c45ab83a59c6dd35ad522555caa3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bfb3d3c7_1b43286e","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":12},"updated":"2019-05-28 08:38:52.000000000","message":"https://help.github.com/en/articles/creating-a-commit-with-multiple-authors","commit_id":"07b59a9f08c362aa1cf2f2ec8b1a06314aedbb2a"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"b41bf06d5358876c5423c249c8cf0cf05c400b9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Automate the undercloud leapp upgrade."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch subscribes the node using the redhat_subscription"},{"line_number":10,"context_line":"module and install the needed bits for leapp to work, followed"},{"line_number":11,"context_line":"by the execution of Leapp to perform the operating system"},{"line_number":12,"context_line":"upgrade in the undercloud."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":26,"id":"9fb8cfa7_4f61f8d2","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":60},"updated":"2019-06-10 11:08:10.000000000","message":"it\u0027s not the case anymore, correct?","commit_id":"3cfcac6033bb77a57a27f46206ee21f7c905fceb"}],"infrared_plugin/main.yml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"032527660521cdae7b3b437072f32386d45e8ce2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  become_method: sudo"},{"line_number":8,"context_line":"  become_user: stack"},{"line_number":9,"context_line":"  vars:"},{"line_number":10,"context_line":"      # Explicit ansible_python_interpreter to allow connecting"},{"line_number":11,"context_line":"      # to different OS releases (EL7/8) while using delegate_to."},{"line_number":12,"context_line":"      ansible_python_interpreter: /usr/libexec/platform-python"},{"line_number":13,"context_line":"  pre_tasks:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fb8cfa7_c30b897a","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":6},"updated":"2019-06-10 05:56:37.000000000","message":"Those extra 2spaces make yamllint to fail","commit_id":"f9e6f22876650fc49d84d7dc29160ffc5c2883ae"}],"tasks/main.yml":[{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"dc96227b0fc1b0d6ba7966e5a4aee3c358776448","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  when: workload_launch"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- include: upgrade/main.yml"},{"line_number":14,"context_line":"  when: upgrade_noop|bool or undercloud_upgrade|bool or undercloud_os_upgrade|bool or overcloud_upgrade|bool"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: update/main.yml"},{"line_number":17,"context_line":"  when: update_noop|bool or undercloud_update|bool or overcloud_update|bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_5e052313","line":14,"range":{"start_line":14,"start_character":56,"end_line":14,"end_character":77},"updated":"2019-05-26 01:12:46.000000000","message":"Should not default value of \"undercloud_os_upgrade\" be added in default/main.yml (below undercloud_upgrade) ?\n\nAnother way could be to always define this fact, not only when \"install.undercloud.os.upgrade\" is true (meaning remove the \"when\" from the related set_fact task).","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"03b4015507a22dd066bf4010dcc730b33dcc265f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  when: workload_launch"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- include: upgrade/main.yml"},{"line_number":14,"context_line":"  when: upgrade_noop|bool or undercloud_upgrade|bool or undercloud_os_upgrade|bool or overcloud_upgrade|bool"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: update/main.yml"},{"line_number":17,"context_line":"  when: update_noop|bool or undercloud_update|bool or overcloud_update|bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_3662cbaf","line":14,"range":{"start_line":14,"start_character":56,"end_line":14,"end_character":77},"in_reply_to":"bfb3d3c7_5e052313","updated":"2019-05-27 14:02:58.000000000","message":"Right, thanks! we did it in the environment where we\u0027re tested but forgot to include it in the patch. Thanks for the notice.","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"cd8fb78d92841875479a7b50b3b0dea80e520aea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  when: workload_launch"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- include: upgrade/main.yml"},{"line_number":14,"context_line":"  when: upgrade_noop|bool or undercloud_upgrade|bool or undercloud_os_upgrade|bool or overcloud_upgrade|bool"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- include: update/main.yml"},{"line_number":17,"context_line":"  when: update_noop|bool or undercloud_update|bool or overcloud_update|bool"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_c02c3b49","line":14,"updated":"2019-06-04 11:25:11.000000000","message":"when: \u003e\n  upgrade_noop|bool or\n  undercloud_upgrade|bool or\n  undercloud_os_upgrade|bool or\n  overcloud_upgrade|bool\n\nit looks better IMHO","commit_id":"f9433644c84cce04861315f5535d9457188032c0"}],"tasks/upgrade/main.yml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"ddc247afda69a377de68ef8604b319a2bbc3baa0","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Upgrade operating system"},{"line_number":11,"context_line":"  import_tasks: undercloud_os_upgrade.yaml"},{"line_number":12,"context_line":"  when:  "},{"line_number":13,"context_line":"    - not use_oooq"},{"line_number":14,"context_line":"    - undercloud_os_upgrade"},{"line_number":15,"context_line":"  tags: undercloud_os_upgrade"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_a7452f45","line":12,"range":{"start_line":12,"start_character":7,"end_line":12,"end_character":9},"updated":"2019-05-30 09:37:40.000000000","message":"rogue spaces","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"dc96227b0fc1b0d6ba7966e5a4aee3c358776448","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  import_tasks: undercloud_os_upgrade.yaml"},{"line_number":12,"context_line":"  when:  "},{"line_number":13,"context_line":"    - not use_oooq"},{"line_number":14,"context_line":"    - undercloud_os_upgrade"},{"line_number":15,"context_line":"  tags: undercloud_os_upgrade"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- block:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_9e0f1b36","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":27},"updated":"2019-05-26 01:12:46.000000000","message":"2.8 deprecates evaluation of bare variable","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"938cd48fd7efa8e825bffa93e97eda8892dd831f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: apply pre undercloud OS upgrade workarounds"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    set -o pipefail"},{"line_number":16,"context_line":"    bash {{ working_dir }}/pre_undercloud_os_upgrade_workarounds.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e pre_undercloud_os_upgrade_workarounds.log"},{"line_number":17,"context_line":"  args:"},{"line_number":18,"context_line":"    chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fb8cfa7_00543cfe","line":15,"range":{"start_line":15,"start_character":4,"end_line":15,"end_character":19},"updated":"2019-06-08 13:55:24.000000000","message":"1. \"/bin/sh\" is used by default, pipefail might not be supported.\n\n2. \"set -o pipefail\" is ineffective (without effect on execution of pre_undercloud_os_upgrade_workarounds.sh). Tested with:\n\n$ cat script1.sh\n#!/bin/bash\nset -o pipefail\n$(dirname $BASH_SOURCE)/script2.sh\n\n$ cat script2.sh\n#!/bin/bash\nls /non/existent/path | xargs\necho \"end of script2: $?\"\n\n$ bash script1.sh \nls: cannot access \u0027/pouet\u0027: No such file or directory\nend of script2: 0","commit_id":"f9e6f22876650fc49d84d7dc29160ffc5c2883ae"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"938cd48fd7efa8e825bffa93e97eda8892dd831f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- name: apply pre undercloud OS upgrade workarounds"},{"line_number":14,"context_line":"  shell: |"},{"line_number":15,"context_line":"    set -o pipefail"},{"line_number":16,"context_line":"    bash {{ working_dir }}/pre_undercloud_os_upgrade_workarounds.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e pre_undercloud_os_upgrade_workarounds.log"},{"line_number":17,"context_line":"  args:"},{"line_number":18,"context_line":"    chdir: \"{{ working_dir }}\""},{"line_number":19,"context_line":"  when: upgrade_workarounds"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fb8cfa7_7d5eff44","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":8},"updated":"2019-06-08 13:55:24.000000000","message":"Isn\u0027t \"bash\" extraneous ? \"pre_undercloud_os_upgrade_workarounds.sh\" script is executable and shebang is \"#!/bin/bash\".","commit_id":"f9e6f22876650fc49d84d7dc29160ffc5c2883ae"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"680663034f5db72dc515126d45592e6299b48ee6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      args:"},{"line_number":19,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":20,"context_line":"      when: upgrade_workarounds|bool"},{"line_number":21,"context_line":"    "},{"line_number":22,"context_line":"    - name: Upgrade operating system"},{"line_number":23,"context_line":"      become: true"},{"line_number":24,"context_line":"      become_user: root"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"9fb8cfa7_a5265067","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":4},"updated":"2019-06-13 11:57:39.000000000","message":"rogue spaces","commit_id":"664007cee2ce7557cc11ca999b9e1ff618b4bc82"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"8df110fcc33990926d6a2c2e2650af7b8d7a0817","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      args:"},{"line_number":19,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":20,"context_line":"      when: upgrade_workarounds|bool"},{"line_number":21,"context_line":" "},{"line_number":22,"context_line":"    - name: Upgrade operating system"},{"line_number":23,"context_line":"      become: true"},{"line_number":24,"context_line":"      become_user: root"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9fb8cfa7_7897843b","line":21,"updated":"2019-06-14 13:22:26.000000000","message":"nit: rogue space","commit_id":"34d9bcbb84e6b21a7832b224d1069d9843f27ea3"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"6a1ee6398b50c4882b8e7efe7fbf6122d10347ac","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      args:"},{"line_number":19,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":20,"context_line":"      when: upgrade_workarounds|bool"},{"line_number":21,"context_line":" "},{"line_number":22,"context_line":"    - name: Upgrade operating system"},{"line_number":23,"context_line":"      become: true"},{"line_number":24,"context_line":"      become_user: root"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"9fb8cfa7_a1d8521e","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":1},"updated":"2019-06-17 09:19:53.000000000","message":"rogue space","commit_id":"a6b135cfc4c471da58258452029b25379a8e7201"}],"tasks/upgrade/undercloud_os_upgrade.yaml":[{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"dc96227b0fc1b0d6ba7966e5a4aee3c358776448","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Register the undercloud node with portal"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  become_user: \"root\""},{"line_number":5,"context_line":"  redhat_subscription:"},{"line_number":6,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_5e2c43ab","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":8},"updated":"2019-05-26 01:12:46.000000000","message":"all tasks use \"become\" (almost the same for \"become_user\"):\n- either a top level block with this keyword could be added\n- or keyword could be added in the import_tasks","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"03b4015507a22dd066bf4010dcc730b33dcc265f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Register the undercloud node with portal"},{"line_number":3,"context_line":"  become: yes"},{"line_number":4,"context_line":"  become_user: \"root\""},{"line_number":5,"context_line":"  redhat_subscription:"},{"line_number":6,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_5635ff8d","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":8},"in_reply_to":"bfb3d3c7_5e2c43ab","updated":"2019-05-27 14:02:58.000000000","message":"right, I was planning on adding it in a second iteration at import_tasks level, as we were still including some tasks (I wasn\u0027t sure if all the tasks would need become).Thanks for your comment.","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"dc96227b0fc1b0d6ba7966e5a4aee3c358776448","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    state: latest"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Leapp workarounds for overcloud"},{"line_number":38,"context_line":"  become: yes"},{"line_number":39,"context_line":"  block:"},{"line_number":40,"context_line":"    - name: Leapp configuration files needed"},{"line_number":41,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_7e54a721","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":8},"updated":"2019-05-26 01:12:46.000000000","message":"isn\u0027t \"become_user\" missing (default value of become_user is root but all other tasks in this file use \"become_user: root\") ?","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"dc96227b0fc1b0d6ba7966e5a4aee3c358776448","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  become: yes"},{"line_number":39,"context_line":"  block:"},{"line_number":40,"context_line":"    - name: Leapp configuration files needed"},{"line_number":41,"context_line":"      shell: |"},{"line_number":42,"context_line":"        set -eu"},{"line_number":43,"context_line":"        sudo mkdir -p /etc/leapp/files"},{"line_number":44,"context_line":"        sudo curl -ko /etc/leapp/files/pes-events.json \u0027https://gitlab.cee.redhat.com/leapp/oamg-rhel7-vagrant/raw/master/roles/init/files/leapp-data/pes-events.json\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_9e615b08","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":11},"updated":"2019-05-26 01:12:46.000000000","message":"\"script\" module could be used (or \"file\" and \"get_url\" modules).","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"03b4015507a22dd066bf4010dcc730b33dcc265f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  become: yes"},{"line_number":39,"context_line":"  block:"},{"line_number":40,"context_line":"    - name: Leapp configuration files needed"},{"line_number":41,"context_line":"      shell: |"},{"line_number":42,"context_line":"        set -eu"},{"line_number":43,"context_line":"        sudo mkdir -p /etc/leapp/files"},{"line_number":44,"context_line":"        sudo curl -ko /etc/leapp/files/pes-events.json \u0027https://gitlab.cee.redhat.com/leapp/oamg-rhel7-vagrant/raw/master/roles/init/files/leapp-data/pes-events.json\u0027"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_56697f1e","line":41,"range":{"start_line":41,"start_character":6,"end_line":41,"end_character":11},"in_reply_to":"bfb3d3c7_9e615b08","updated":"2019-05-27 14:02:58.000000000","message":"ack, thanks. I\u0027ll implement it in the next patchset (I\u0027d like to test it first)","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"dc96227b0fc1b0d6ba7966e5a4aee3c358776448","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    - name: Leapp configuration files needed"},{"line_number":41,"context_line":"      shell: |"},{"line_number":42,"context_line":"        set -eu"},{"line_number":43,"context_line":"        sudo mkdir -p /etc/leapp/files"},{"line_number":44,"context_line":"        sudo curl -ko /etc/leapp/files/pes-events.json \u0027https://gitlab.cee.redhat.com/leapp/oamg-rhel7-vagrant/raw/master/roles/init/files/leapp-data/pes-events.json\u0027"},{"line_number":45,"context_line":"        sudo curl -ko /etc/leapp/files/repomap.csv \u0027https://gitlab.cee.redhat.com/leapp/oamg-rhel7-vagrant/raw/master/roles/init/files/leapp-data/repomap.csv\u0027"},{"line_number":46,"context_line":"    - name: workaround ethX check"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_3e538f41","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":12},"updated":"2019-05-26 01:12:46.000000000","message":"isn\u0027t \"sudo\" extraneous (\"become\" keyword is used at block) ?","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"dc96227b0fc1b0d6ba7966e5a4aee3c358776448","unresolved":false,"context_lines":[{"line_number":68,"context_line":"- name: Run leapp upgrade (download packages)"},{"line_number":69,"context_line":"  become: yes"},{"line_number":70,"context_line":"  become_user: \"root\""},{"line_number":71,"context_line":"  shell: |"},{"line_number":72,"context_line":"    leapp upgrade --debug"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- name: Reboot system to perform the upgrade"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_be5e9f41","line":71,"range":{"start_line":71,"start_character":3,"end_line":71,"end_character":4},"updated":"2019-05-26 01:12:46.000000000","message":"\"command\" module can be used instead","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"03b4015507a22dd066bf4010dcc730b33dcc265f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"- name: Run leapp upgrade (download packages)"},{"line_number":69,"context_line":"  become: yes"},{"line_number":70,"context_line":"  become_user: \"root\""},{"line_number":71,"context_line":"  shell: |"},{"line_number":72,"context_line":"    leapp upgrade --debug"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"- name: Reboot system to perform the upgrade"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_761fe3b6","line":71,"range":{"start_line":71,"start_character":3,"end_line":71,"end_character":4},"in_reply_to":"bfb3d3c7_be5e9f41","updated":"2019-05-27 14:02:58.000000000","message":"As in a follow up patchset I\u0027m using pipe to log the output into a file, it\u0027s better to leave the shell module instead.","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"dc96227b0fc1b0d6ba7966e5a4aee3c358776448","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  become_user: \"root\""},{"line_number":83,"context_line":"  redhat_subscription:"},{"line_number":84,"context_line":"    state: absent"},{"line_number":85,"context_line":"  when: leapp_unregister"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_7e290799","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":24},"updated":"2019-05-26 01:12:46.000000000","message":"2.8 deprecates evaluation of bare variable, \"leapp_unregister|bool\" should be used","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"03b4015507a22dd066bf4010dcc730b33dcc265f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  become_user: \"root\""},{"line_number":83,"context_line":"  redhat_subscription:"},{"line_number":84,"context_line":"    state: absent"},{"line_number":85,"context_line":"  when: leapp_unregister"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_367babf5","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":24},"in_reply_to":"bfb3d3c7_7e290799","updated":"2019-05-27 14:02:58.000000000","message":"Done","commit_id":"33fe4d3ad6a39ce702178f4b8f590e59658b67c3"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"8910c5e6704090edeb8e5fdbb094bba04876c2ce","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        set -euo pipefail;"},{"line_number":47,"context_line":"        sed -i -e \u0027s/run(dnf_command + \\[data.name\\], callback_raw\u003d_logging_handler)/run(dnf_command + [data.name],"},{"line_number":48,"context_line":"        callback_raw\u003d_logging_handler, env\u003d{\"DM_DISABLE_UDEV\": \"1\"})/\u0027"},{"line_number":49,"context_line":"        /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/dnfshellrpmupgrade/actor.py"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Unconfigure rhos-release if present"},{"line_number":52,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bfb3d3c7_f742d1aa","line":49,"updated":"2019-05-29 08:10:23.000000000","message":"sed -i -E \u0027s/(run\\(dnf_command \\+ \\[data.name\\], callback_raw\u003d_logging_handler)\\)/\\1, env\u003d{\"DM_DISABLE_UDEV\": \"1\"})/g\u0027 /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/dnfshellrpmupgrade/actor.py","commit_id":"6879217d475b0d6f827d84a478cf51b3928e1d6e"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"ddc247afda69a377de68ef8604b319a2bbc3baa0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Register the undercloud node with portal"},{"line_number":3,"context_line":"  redhat_subscription:"},{"line_number":4,"context_line":"    state: present"},{"line_number":5,"context_line":"    username: \"{{ leapp_rhsm_username }}\""},{"line_number":6,"context_line":"    password: \"{{ leapp_rhsm_password }}\""},{"line_number":7,"context_line":"    server_hostname: \"{{ leapp_rhsm_server_hostname }}\""},{"line_number":8,"context_line":"    rhsm_baseurl: \"{{ leapp_rhsm_baseurl }}\""},{"line_number":9,"context_line":"    pool: \"{{ leapp_rhsm_pool }}\""},{"line_number":10,"context_line":"    force_register: \"{{ leapp_rhsm_force_reg }}\""},{"line_number":11,"context_line":"  when: leapp_rhsm_method \u003d\u003d \"portal\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Register the undercloud node with satellite"},{"line_number":14,"context_line":"  redhat_subscription:"},{"line_number":15,"context_line":"    state: present"},{"line_number":16,"context_line":"    activationkey: \"{{ leapp_rhsm_activationkey }}\""},{"line_number":17,"context_line":"    org_id: \"{{ leapp_rhsm_orgid }}\""},{"line_number":18,"context_line":"    server_hostname: \"{{ leapp_rhsm_server_hostname }}\""},{"line_number":19,"context_line":"    rhsm_baseurl: \"{{ leapp_rhsm_baseurl }}\""},{"line_number":20,"context_line":"    force_register: \"{{ leapp_rhsm_force_reg }}\""},{"line_number":21,"context_line":"  when: leapp_rhsm_method \u003d\u003d \"satellite\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Install leapp"},{"line_number":24,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bfb3d3c7_39536619","line":21,"range":{"start_line":2,"start_character":0,"end_line":21,"end_character":40},"updated":"2019-05-30 09:37:40.000000000","message":"For all previous version code that setups repos(satellite,portal,custom tooling) is decoupled from upgrade. Any specific reason to have it here?","commit_id":"3c20848fd62caf946fbef3cdf709944ec90cdb88"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"b279883eb81d70dd321ba83c02aab43acfde83f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Register the undercloud node with portal"},{"line_number":3,"context_line":"  redhat_subscription:"},{"line_number":4,"context_line":"    state: present"},{"line_number":5,"context_line":"    username: \"{{ leapp_rhsm_username }}\""},{"line_number":6,"context_line":"    password: \"{{ leapp_rhsm_password }}\""},{"line_number":7,"context_line":"    server_hostname: \"{{ leapp_rhsm_server_hostname }}\""},{"line_number":8,"context_line":"    rhsm_baseurl: \"{{ leapp_rhsm_baseurl }}\""},{"line_number":9,"context_line":"    pool: \"{{ leapp_rhsm_pool }}\""},{"line_number":10,"context_line":"    force_register: \"{{ leapp_rhsm_force_reg }}\""},{"line_number":11,"context_line":"  when: leapp_rhsm_method \u003d\u003d \"portal\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Register the undercloud node with satellite"},{"line_number":14,"context_line":"  redhat_subscription:"},{"line_number":15,"context_line":"    state: present"},{"line_number":16,"context_line":"    activationkey: \"{{ leapp_rhsm_activationkey }}\""},{"line_number":17,"context_line":"    org_id: \"{{ leapp_rhsm_orgid }}\""},{"line_number":18,"context_line":"    server_hostname: \"{{ leapp_rhsm_server_hostname }}\""},{"line_number":19,"context_line":"    rhsm_baseurl: \"{{ leapp_rhsm_baseurl }}\""},{"line_number":20,"context_line":"    force_register: \"{{ leapp_rhsm_force_reg }}\""},{"line_number":21,"context_line":"  when: leapp_rhsm_method \u003d\u003d \"satellite\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Install leapp"},{"line_number":24,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bfb3d3c7_3c0b54d6","line":21,"range":{"start_line":2,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"bfb3d3c7_39536619","updated":"2019-05-30 11:09:01.000000000","message":"ack, makes sense.","commit_id":"3c20848fd62caf946fbef3cdf709944ec90cdb88"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"3921057ed34655adcb371be5c191902c798ade3d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Register the undercloud node with portal"},{"line_number":3,"context_line":"  redhat_subscription:"},{"line_number":4,"context_line":"    state: present"},{"line_number":5,"context_line":"    username: \"{{ leapp_rhsm_username }}\""},{"line_number":6,"context_line":"    password: \"{{ leapp_rhsm_password }}\""},{"line_number":7,"context_line":"    server_hostname: \"{{ leapp_rhsm_server_hostname }}\""},{"line_number":8,"context_line":"    rhsm_baseurl: \"{{ leapp_rhsm_baseurl }}\""},{"line_number":9,"context_line":"    pool: \"{{ leapp_rhsm_pool }}\""},{"line_number":10,"context_line":"    force_register: \"{{ leapp_rhsm_force_reg }}\""},{"line_number":11,"context_line":"  when: leapp_rhsm_method \u003d\u003d \"portal\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Register the undercloud node with satellite"},{"line_number":14,"context_line":"  redhat_subscription:"},{"line_number":15,"context_line":"    state: present"},{"line_number":16,"context_line":"    activationkey: \"{{ leapp_rhsm_activationkey }}\""},{"line_number":17,"context_line":"    org_id: \"{{ leapp_rhsm_orgid }}\""},{"line_number":18,"context_line":"    server_hostname: \"{{ leapp_rhsm_server_hostname }}\""},{"line_number":19,"context_line":"    rhsm_baseurl: \"{{ leapp_rhsm_baseurl }}\""},{"line_number":20,"context_line":"    force_register: \"{{ leapp_rhsm_force_reg }}\""},{"line_number":21,"context_line":"  when: leapp_rhsm_method \u003d\u003d \"satellite\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Install leapp"},{"line_number":24,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9fb8cfa7_8d4bf385","line":21,"range":{"start_line":2,"start_character":0,"end_line":21,"end_character":40},"in_reply_to":"bfb3d3c7_3c0b54d6","updated":"2019-06-03 11:48:53.000000000","message":"So, it seems we can\u0027t deploy the undercloud with subscription and set rhos repos at the same time https://github.com/redhat-openstack/infrared/blob/master/plugins/tripleo-undercloud/setup_packages.yml#L32-L47 ...either we use a satellite server (to provide both things), or this looks like the best workaround to ensure we have the undercloud subscribed before running leapp.\nWould you be ok if I include these two tasks into a block and make a conditional \"leapp_subscribe\" set to false by default to subscribe the undercloud at will?","commit_id":"3c20848fd62caf946fbef3cdf709944ec90cdb88"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"ddc247afda69a377de68ef8604b319a2bbc3baa0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    name: leapp"},{"line_number":26,"context_line":"    state: latest"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Leapp workarounds for overcloud"},{"line_number":29,"context_line":"  block:"},{"line_number":30,"context_line":"    - name: Leapp configuration files needed"},{"line_number":31,"context_line":"      shell: |"},{"line_number":32,"context_line":"        set -eu"},{"line_number":33,"context_line":"        mkdir -p /etc/leapp/files"},{"line_number":34,"context_line":"        curl -k4sSLo /etc/leapp/files/pes-events.json \u0027https://gitlab.cee.redhat.com/leapp/oamg-rhel7-vagrant/raw/master/roles/init/files/leapp-data/pes-events.json\u0027"},{"line_number":35,"context_line":"        curl -k4sSLo /etc/leapp/files/repomap.csv \u0027https://gitlab.cee.redhat.com/leapp/oamg-rhel7-vagrant/raw/master/roles/init/files/leapp-data/repomap.csv\u0027"},{"line_number":36,"context_line":"    - name: workaround ethX check"},{"line_number":37,"context_line":"      shell: |"},{"line_number":38,"context_line":"        set -euo"},{"line_number":39,"context_line":"        sed -i -e \u0027s/(import FactsPhaseTag, IPUWorkflowTag)$/\\1, ExperimentalTag/\u0027 \\"},{"line_number":40,"context_line":"            /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/persistentnetnamesdisable/actor.py"},{"line_number":41,"context_line":"        sed -i -e \u0027s/(tags \u003d \\(FactsPhaseTag, IPUWorkflowTag)\\)/\\1, ExperimentalTag\\)/\u0027 \\"},{"line_number":42,"context_line":"            /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/persistentnetnamesdisable/actor.py"},{"line_number":43,"context_line":"    # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1712456"},{"line_number":44,"context_line":"    - name: workaround for grub-tools issue"},{"line_number":45,"context_line":"      shell: |"},{"line_number":46,"context_line":"        set -euo"},{"line_number":47,"context_line":"        sed -i -e \u0027s/(run\\(dnf_command + \\[data.name\\], callback_raw\u003d_logging_handler)\\)/\\1, env\u003d{\"DM_DISABLE_UDEV\": \"1\"}\\)/\u0027 \\"},{"line_number":48,"context_line":"            /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/dnfshellrpmupgrade/actor.py"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Unconfigure rhos-release if present"},{"line_number":51,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bfb3d3c7_9915b242","line":48,"range":{"start_line":28,"start_character":1,"end_line":48,"end_character":111},"updated":"2019-05-30 09:37:40.000000000","message":"Any reason why those are not in external workarounds file?","commit_id":"3c20848fd62caf946fbef3cdf709944ec90cdb88"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"b279883eb81d70dd321ba83c02aab43acfde83f9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    name: leapp"},{"line_number":26,"context_line":"    state: latest"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Leapp workarounds for overcloud"},{"line_number":29,"context_line":"  block:"},{"line_number":30,"context_line":"    - name: Leapp configuration files needed"},{"line_number":31,"context_line":"      shell: |"},{"line_number":32,"context_line":"        set -eu"},{"line_number":33,"context_line":"        mkdir -p /etc/leapp/files"},{"line_number":34,"context_line":"        curl -k4sSLo /etc/leapp/files/pes-events.json \u0027https://gitlab.cee.redhat.com/leapp/oamg-rhel7-vagrant/raw/master/roles/init/files/leapp-data/pes-events.json\u0027"},{"line_number":35,"context_line":"        curl -k4sSLo /etc/leapp/files/repomap.csv \u0027https://gitlab.cee.redhat.com/leapp/oamg-rhel7-vagrant/raw/master/roles/init/files/leapp-data/repomap.csv\u0027"},{"line_number":36,"context_line":"    - name: workaround ethX check"},{"line_number":37,"context_line":"      shell: |"},{"line_number":38,"context_line":"        set -euo"},{"line_number":39,"context_line":"        sed -i -e \u0027s/(import FactsPhaseTag, IPUWorkflowTag)$/\\1, ExperimentalTag/\u0027 \\"},{"line_number":40,"context_line":"            /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/persistentnetnamesdisable/actor.py"},{"line_number":41,"context_line":"        sed -i -e \u0027s/(tags \u003d \\(FactsPhaseTag, IPUWorkflowTag)\\)/\\1, ExperimentalTag\\)/\u0027 \\"},{"line_number":42,"context_line":"            /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/persistentnetnamesdisable/actor.py"},{"line_number":43,"context_line":"    # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1712456"},{"line_number":44,"context_line":"    - name: workaround for grub-tools issue"},{"line_number":45,"context_line":"      shell: |"},{"line_number":46,"context_line":"        set -euo"},{"line_number":47,"context_line":"        sed -i -e \u0027s/(run\\(dnf_command + \\[data.name\\], callback_raw\u003d_logging_handler)\\)/\\1, env\u003d{\"DM_DISABLE_UDEV\": \"1\"}\\)/\u0027 \\"},{"line_number":48,"context_line":"            /usr/share/leapp-repository/repositories/system_upgrade/el7toel8/actors/dnfshellrpmupgrade/actor.py"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Unconfigure rhos-release if present"},{"line_number":51,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bfb3d3c7_1c08d0d7","line":48,"range":{"start_line":28,"start_character":1,"end_line":48,"end_character":111},"in_reply_to":"bfb3d3c7_9915b242","updated":"2019-05-30 11:09:01.000000000","message":"That\u0027s a good comment and idea, indeed. I\u0027ll try to move them and add a pre-os_upgrade_workarounds, post-os_upgrade_workarounds section too. Thanks for the tip.","commit_id":"3c20848fd62caf946fbef3cdf709944ec90cdb88"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b36d1892ef04249c6dc73d2f4764ba87668ed050","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Install leapp"},{"line_number":3,"context_line":"  package:"},{"line_number":4,"context_line":"    name: leapp"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_c92bed7f","line":1,"updated":"2019-06-05 13:22:22.000000000","message":"This file contains a lot of RHEL specific stuff. I think within tripleo-upgrade this has been kind of acceptable historically, but can we at least call it undercloud_os_upgrade_rhel8.yaml? To make it apparent the file isn\u0027t generic, and keep an open door possibly for a _centos8.yaml variant later.","commit_id":"f9433644c84cce04861315f5535d9457188032c0"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"ee1c745c9b7bfab0f985376a527646b4b0e101e4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    name: leapp"},{"line_number":5,"context_line":"    state: latest"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Leapp workarounds for overcloud"},{"line_number":8,"context_line":"  block:"},{"line_number":9,"context_line":"    - name: Leapp configuration files needed"},{"line_number":10,"context_line":"      get_url:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_e980318e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":39},"updated":"2019-06-05 13:52:15.000000000","message":"Those workarounds are temporary, so when time comes those have to be removed. So maybe it makes sense to use workarounds mechanism, pre_undercloud_upgrade_workarounds.sh seems to be a good place, wdyt?","commit_id":"f9433644c84cce04861315f5535d9457188032c0"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"6d66efa9373b0543c18a18550f45e9c25e4ac10a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      retries: 60"},{"line_number":53,"context_line":"      delay: 3"},{"line_number":54,"context_line":"      ignore_errors: true"},{"line_number":55,"context_line":"      delegate_to: localhost"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    - name: waiting for the undercloud to be available"},{"line_number":58,"context_line":"      become: false"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9fb8cfa7_be59f65a","line":55,"range":{"start_line":55,"start_character":19,"end_line":55,"end_character":28},"updated":"2019-06-06 12:35:06.000000000","message":"here is how it\u0027s handled within IR, we cannot assume \u0027localhost\u0027 can reach \u0027undercloud\u0027","commit_id":"48b27f83c67251d27fe46cc1c5d87ac75b54fa05"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"df744d2bead0eec2e847c6b84bb6914f0cf709cd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        tee {{ working_dir }}/undercloud_leapp_upgrade.log"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# TODO: Substitute by reboot module when upstream CI will use 2.7 version"},{"line_number":39,"context_line":"- name: Reboot system to perform the upgrade"},{"line_number":40,"context_line":"  block:"},{"line_number":41,"context_line":"    - name: reboot the undercloud"},{"line_number":42,"context_line":"      shell: \"sleep 2 \u0026\u0026 shutdown -r now\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_1e38309e","line":39,"updated":"2019-06-07 08:15:00.000000000","message":"There is a code to do this - \ntasks/common/undercloud_validate_upgrade.yaml\nwith minor tweaks(skip ovs/kernel check) should fit here","commit_id":"c30bd3eaf4bdb423f1719c668e1113b9aa6b5cfc"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"05e557e20958f6d4a421e9d7eb15b2714d1b3c3c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"- name: Reboot system to perform the upgrade"},{"line_number":40,"context_line":"  block:"},{"line_number":41,"context_line":"    - name: reboot the undercloud"},{"line_number":42,"context_line":"      shell: \"sleep 2 \u0026\u0026 shutdown -r now\""},{"line_number":43,"context_line":"      async: 1"},{"line_number":44,"context_line":"      poll: 0"},{"line_number":45,"context_line":"      ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_7ec5ac5a","line":42,"updated":"2019-06-07 08:33:14.000000000","message":"sleep 2 can be replaced with delay: 2","commit_id":"c30bd3eaf4bdb423f1719c668e1113b9aa6b5cfc"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"05e557e20958f6d4a421e9d7eb15b2714d1b3c3c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        port: 22"},{"line_number":61,"context_line":"        host: \"{{ ansible_host }}\""},{"line_number":62,"context_line":"        search_regex: OpenSSH"},{"line_number":63,"context_line":"        timeout: 30"},{"line_number":64,"context_line":"      delegate_to: localhost"},{"line_number":65,"context_line":"      register: uc_reachable"},{"line_number":66,"context_line":"      retries: 40"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9fb8cfa7_5e9f885e","line":63,"updated":"2019-06-07 08:33:14.000000000","message":"The total upgrade may take longer than 30*40... 30*60 should be more fair to give 30 minutes to get it done. However, it\u0027s very related to conversion of block devices","commit_id":"c30bd3eaf4bdb423f1719c668e1113b9aa6b5cfc"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"938cd48fd7efa8e825bffa93e97eda8892dd831f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    state: latest"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Unconfigure rhos-release if present"},{"line_number":8,"context_line":"  block:"},{"line_number":9,"context_line":"    - name: Check if rhos-release is installed"},{"line_number":10,"context_line":"      package:"},{"line_number":11,"context_line":"        name: rhos-release"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fb8cfa7_606bb8b6","line":8,"range":{"start_line":8,"start_character":1,"end_line":8,"end_character":7},"updated":"2019-06-08 13:55:24.000000000","message":"No need to use a block here (no keyword used at block level)","commit_id":"f9e6f22876650fc49d84d7dc29160ffc5c2883ae"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"938cd48fd7efa8e825bffa93e97eda8892dd831f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - name: Remove rhos-release repos"},{"line_number":18,"context_line":"      command: rhos-release -x"},{"line_number":19,"context_line":"      when:"},{"line_number":20,"context_line":"        - rhos_release_installed.rc \u003d\u003d 0"},{"line_number":21,"context_line":"        - not rhos_release_installed.changed"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Remove conflicting packages"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fb8cfa7_80682cb9","line":20,"range":{"start_line":20,"start_character":33,"end_line":20,"end_character":35},"updated":"2019-06-08 13:55:24.000000000","message":"1. Don\u0027t use \"rc\" with non modules command, use \"is success\" instead (see https://github.com/ansible/ansible/blob/c50a75a41e902cebf9f6438818570306e3ea71ba/lib/ansible/executor/task_executor.py#L692).\n\n2. Since the previous task has \"failed_when: false\", \"rhos_release_installed is success\" is always true.","commit_id":"f9e6f22876650fc49d84d7dc29160ffc5c2883ae"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"757755786f277084b8dbad260e6b5594ed79a6f4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    - name: Remove rhos-release repos"},{"line_number":18,"context_line":"      command: rhos-release -x"},{"line_number":19,"context_line":"      when:"},{"line_number":20,"context_line":"        - rhos_release_installed.rc \u003d\u003d 0"},{"line_number":21,"context_line":"        - not rhos_release_installed.changed"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Remove conflicting packages"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fb8cfa7_d9dff637","line":20,"range":{"start_line":20,"start_character":33,"end_line":20,"end_character":35},"in_reply_to":"9fb8cfa7_80682cb9","updated":"2019-06-10 08:49:20.000000000","message":"Tried with 2.7.10:\n\u0027is success\u0027 as well as \u0027succeeded\u0027 are executed, despite task\u0027s rc being \u00271\u0027, while current evaluation works as expected","commit_id":"f9e6f22876650fc49d84d7dc29160ffc5c2883ae"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"938cd48fd7efa8e825bffa93e97eda8892dd831f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      command: rhos-release -x"},{"line_number":19,"context_line":"      when:"},{"line_number":20,"context_line":"        - rhos_release_installed.rc \u003d\u003d 0"},{"line_number":21,"context_line":"        - not rhos_release_installed.changed"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Remove conflicting packages"},{"line_number":24,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fb8cfa7_80ad8cea","line":21,"range":{"start_line":21,"start_character":36,"end_line":21,"end_character":44},"updated":"2019-06-08 13:55:24.000000000","message":"Use Jinja test (\"rhos_release_installed is not changed\") instead of directly reading the attribute.","commit_id":"f9e6f22876650fc49d84d7dc29160ffc5c2883ae"},{"author":{"_account_id":25403,"name":"Pierre-Louis Bonicoli","email":"pierre-louis.bonicoli@libregerbil.fr","username":"pilou"},"change_message_id":"938cd48fd7efa8e825bffa93e97eda8892dd831f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- name: Unregister the node once the OS was upgraded if desired"},{"line_number":42,"context_line":"  redhat_subscription:"},{"line_number":43,"context_line":"    state: absent"},{"line_number":44,"context_line":"  when: leapp_unregister"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9fb8cfa7_a07bf078","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":24},"updated":"2019-06-08 13:55:24.000000000","message":"Don\u0027t use bare variable in condition, this is deprecated since Ansible 2.8. leapp_unregister is a boolean, \"when: leapp_unregister|bool\" can be used here.","commit_id":"f9e6f22876650fc49d84d7dc29160ffc5c2883ae"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"8df110fcc33990926d6a2c2e2650af7b8d7a0817","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Remove old RHEL7 packages"},{"line_number":3,"context_line":"  command: yum remove -y *el7ost* *openvswitch* *el7fdp* python2*"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Install leapp"},{"line_number":6,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9fb8cfa7_98b358e9","line":3,"updated":"2019-06-14 13:22:26.000000000","message":"As discussed on IRC this list probably needs to change or we\u0027ll remove subscription-manager and effectively unsubscribe the machine IIRC.","commit_id":"34d9bcbb84e6b21a7832b224d1069d9843f27ea3"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"8df110fcc33990926d6a2c2e2650af7b8d7a0817","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    name:"},{"line_number":27,"context_line":"      - python-jsonpointer"},{"line_number":28,"context_line":"      - python-PyMySQL"},{"line_number":29,"context_line":"      - rhos-release"},{"line_number":30,"context_line":"    state: absent"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"- name: Run leapp upgrade (download packages)"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9fb8cfa7_98e838b3","line":29,"updated":"2019-06-14 13:22:26.000000000","message":"When we amend the removal list on line 3, we can amend this too probably. At least drop the python-* packages.","commit_id":"34d9bcbb84e6b21a7832b224d1069d9843f27ea3"}]}