)]}'
{"tasks/upgrade/create-overcloud-upgrade-scripts.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"021bf62b06f5001d6e3a4aa36cd861ccf1884ab2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    dest: \"{{ working_dir }}/disable-leapp.yaml\""},{"line_number":113,"context_line":"    mode: 0755"},{"line_number":114,"context_line":"    force: true"},{"line_number":115,"context_line":"  when: tripleo_upgrade_disable_leapp|default(false)|bool"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"- name: import tasks from sh_config_skip_host"},{"line_number":118,"context_line":"  import_tasks: ../common/ssh_config_skip_host.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_31c49992","line":115,"updated":"2019-06-18 09:54:32.000000000","message":"I have one suggestion to do not need to change the fs file too (https://review.opendev.org/#/c/665114/1), if I understand correctly you don\u0027t want to run leapp mostly upstream right? Why not using the use_oooq variable? it\u0027s already set to true upstream (you can find it in the FS file) and false downstream, so one change would suffice.","commit_id":"9991508d0e372d8d5d6b09f1a22c1bcd4230e2b2"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"b18848629c66781da3b5d6ec06b4ac04d707b1ea","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    dest: \"{{ working_dir }}/disable-leapp.yaml\""},{"line_number":113,"context_line":"    mode: 0755"},{"line_number":114,"context_line":"    force: true"},{"line_number":115,"context_line":"  when: tripleo_upgrade_disable_leapp|default(false)|bool"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"- name: import tasks from sh_config_skip_host"},{"line_number":118,"context_line":"  import_tasks: ../common/ssh_config_skip_host.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_8ca20c4b","line":115,"in_reply_to":"9fb8cfa7_31c49992","updated":"2019-06-18 11:15:33.000000000","message":"Ok that makes sense, i\u0027ll use that var.","commit_id":"9991508d0e372d8d5d6b09f1a22c1bcd4230e2b2"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"85417859346a03868d6f9cce5c2bc97eda5e96ed","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    dest: \"{{ working_dir }}/disable-leapp.yaml\""},{"line_number":113,"context_line":"    mode: 0755"},{"line_number":114,"context_line":"    force: true"},{"line_number":115,"context_line":"  when: tripleo_upgrade_disable_leapp|default(false)|bool"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"- name: import tasks from sh_config_skip_host"},{"line_number":118,"context_line":"  import_tasks: ../common/ssh_config_skip_host.yml"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_6726d36b","line":115,"in_reply_to":"9fb8cfa7_31c49992","updated":"2019-06-18 11:42:04.000000000","message":"Well I think it makes sense but we are obfuscating things here a lot for people just dont care about what is oooq.","commit_id":"9991508d0e372d8d5d6b09f1a22c1bcd4230e2b2"}]}
