)]}'
{"defaults/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c9b4de6b3e3c9a66b4d6a0b30fc4ebc554a4a600","unresolved":false,"context_lines":[{"line_number":258,"context_line":"leapp_unregister: true"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"# order priority of roles for processing"},{"line_number":261,"context_line":"role_sort_order:"},{"line_number":262,"context_line":"  - Controller"},{"line_number":263,"context_line":"  - Compute"},{"line_number":264,"context_line":"  - Ceph"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_d9886723","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":15},"updated":"2019-08-29 20:46:51.000000000","message":"How is this var different to the roles_upgrade_order var above?","commit_id":"3b32a3d66447aa2f296b96e94b0df4ea1c4541ed"}],"tasks/common/load_roles_from_inventory.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c9b4de6b3e3c9a66b4d6a0b30fc4ebc554a4a600","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  vars:"},{"line_number":43,"context_line":"    oc_host_list: \u003e-"},{"line_number":44,"context_line":"      {%- set oc_host_list\u003d[] %}"},{"line_number":45,"context_line":"      {%- for role in sort_order %}"},{"line_number":46,"context_line":"      {%-   if oc_roles_hosts[role] is defined %}"},{"line_number":47,"context_line":"      {%-     for host in oc_roles_hosts[role][\u0027hosts\u0027].keys() | sort %}"},{"line_number":48,"context_line":"      {%-       set _ \u003d oc_host_list.append(host) %}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_99b0afff","line":45,"range":{"start_line":45,"start_character":22,"end_line":45,"end_character":32},"updated":"2019-08-29 20:46:51.000000000","message":"role_sort_order","commit_id":"3b32a3d66447aa2f296b96e94b0df4ea1c4541ed"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"c9b4de6b3e3c9a66b4d6a0b30fc4ebc554a4a600","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      {%-   endif %}"},{"line_number":51,"context_line":"      {%- endfor %}"},{"line_number":52,"context_line":"      {%- for role in oc_roles_hosts.keys() | sort %}"},{"line_number":53,"context_line":"      {%-     if role not in sort_order %}"},{"line_number":54,"context_line":"      {%-         for host in oc_roles_hosts[role][\u0027hosts\u0027].keys() | sort %}"},{"line_number":55,"context_line":"      {%-             set _ \u003d oc_host_list.append(host) %}"},{"line_number":56,"context_line":"      {%-         endfor %}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_59ceb783","line":53,"range":{"start_line":53,"start_character":29,"end_line":53,"end_character":39},"updated":"2019-08-29 20:46:51.000000000","message":"role_sort_order","commit_id":"3b32a3d66447aa2f296b96e94b0df4ea1c4541ed"}],"tasks/upgrade/create-overcloud-upgrade-scripts.yaml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"e0f17423bb04e6ac2e9d8343183961c9f0fd42ad","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    dest: \"{{ overcloud_upgrade_run_script_base }}-{{ item }}.sh\""},{"line_number":74,"context_line":"    mode: 0775"},{"line_number":75,"context_line":"    force: true"},{"line_number":76,"context_line":"  loop: \"{{ oc_roles_hosts.values()|flatten }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: create online data migration script"},{"line_number":79,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_fac6559a","line":76,"range":{"start_line":76,"start_character":11,"end_line":76,"end_character":20},"updated":"2019-07-15 08:49:54.000000000","message":"oc_roles has a list of roles with 1st element being set to Controller role. If this is still a requirement, to start with controller upgrades, U need to get roles order from oc_roles variable","commit_id":"03fca50b9fa646f4973cbed5ea5f8f02c756f162"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"664ebceb975f28945169accfb5b0e1ccd6918a16","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    dest: \"{{ overcloud_upgrade_run_script_base }}-{{ item }}.sh\""},{"line_number":74,"context_line":"    mode: 0775"},{"line_number":75,"context_line":"    force: true"},{"line_number":76,"context_line":"  loop: \"{{ oc_roles_hosts.values()|flatten }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: create online data migration script"},{"line_number":79,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_132456ae","line":76,"range":{"start_line":76,"start_character":11,"end_line":76,"end_character":20},"in_reply_to":"7faddb67_fac6559a","updated":"2019-07-17 09:30:18.000000000","message":"Done","commit_id":"03fca50b9fa646f4973cbed5ea5f8f02c756f162"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"6484daa2d61e7321ceffe6186ab9a6e7d3683161","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    dest: \"{{ overcloud_upgrade_run_script_base }}-{{ item }}.sh\""},{"line_number":74,"context_line":"    mode: 0775"},{"line_number":75,"context_line":"    force: true"},{"line_number":76,"context_line":"  loop: \"{{ oc_roles_hosts.values()|flatten }}\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- name: create online data migration script"},{"line_number":79,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_ee8bf364","line":76,"range":{"start_line":76,"start_character":11,"end_line":76,"end_character":20},"in_reply_to":"7faddb67_fac6559a","updated":"2019-07-15 13:26:52.000000000","message":"That\u0027s a very good comment. I thought I was taking that into account but I realized that when I added the oc_roles_hosts variable I build it from scratch, instead of taking it from oc_roles (which is already ordered) https://github.com/openstack/tripleo-upgrade/blob/88a6de37a5ef9151e2ed160a1ff6052e875cd0cf/tasks/common/load_roles_from_inventory.yaml#L38 . I\u0027ll fix it and submit a patch for it.","commit_id":"03fca50b9fa646f4973cbed5ea5f8f02c756f162"}]}