)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b8c5044185402b29f965258ef2dfc9acf62ac424","unresolved":false,"context_lines":[{"line_number":12,"context_line":"setted to true enables an environment variable LEAPP_DEVEL_SKIP_RHSM"},{"line_number":13,"context_line":"which skips the subscription check."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[0] - https://gitlab.cee.redhat.com/osp15/osp-upgrade-el8/tree/master#upgrading-the-undercloud"},{"line_number":16,"context_line":"Change-Id: Ifca276dabad3c87f86681704d4fad0658c66f4b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_d26f5126","line":15,"updated":"2019-08-22 20:47:04.000000000","message":"plz don\u0027t reference internal urls in upstream changes","commit_id":"b7032f99e85e71d30cc990f7fca86dd5f4bede85"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f671d0de6106d8e5e5d1961163103e0f0a2137dc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"setted to true enables an environment variable LEAPP_DEVEL_SKIP_RHSM"},{"line_number":13,"context_line":"which skips the subscription check."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[0] - https://gitlab.cee.redhat.com/osp15/osp-upgrade-el8/tree/master#upgrading-the-undercloud"},{"line_number":16,"context_line":"Change-Id: Ifca276dabad3c87f86681704d4fad0658c66f4b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_55655348","line":15,"in_reply_to":"7faddb67_d26f5126","updated":"2019-08-27 10:25:24.000000000","message":"ack, changed. thanks","commit_id":"b7032f99e85e71d30cc990f7fca86dd5f4bede85"}],"tasks/upgrade/undercloud_os_upgrade.yaml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"d71d720d07f00023425b8fc53a3e4792f8251a25","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- name: Run leapp upgrade (download packages)"},{"line_number":42,"context_line":"  shell: |"},{"line_number":43,"context_line":"    set -o pipefail"},{"line_number":44,"context_line":"    {{ \u0027LEAPP_DEVEL_SKIP_RHSM\u003d1 sudo -E\u0027 if leapp_unsubscribed|bool }} leapp upgrade --debug 2\u003e\u00261 | \\"},{"line_number":45,"context_line":"        tee {{ working_dir }}/undercloud_leapp_upgrade.log"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Reboot the undercloud"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_4d90ed4a","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":70},"updated":"2019-07-17 07:59:09.000000000","message":"If this variable adjusts leapp\u0027s behavior but requires some extra steps, I\u0027d rather add those steps here and not rely on them being passed by some external file/command. For e.g.:\n\n  shell:|\n    set -o pipefail\n    {% if leapp_var|bool %}\n    do step one;\n    do step 2\n    export LEAP...\n    {% endif %}\n    leap upgrade ...","commit_id":"3dfa3e4aaaa48d46235b42979071bdf6dfedb663"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f9a03935dbb65aaa2b69fa99bb7b9ad266e239e7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- name: Run leapp upgrade (download packages)"},{"line_number":42,"context_line":"  shell: |"},{"line_number":43,"context_line":"    set -o pipefail"},{"line_number":44,"context_line":"    {{ \u0027LEAPP_DEVEL_SKIP_RHSM\u003d1 sudo -E\u0027 if leapp_unsubscribed|bool }} leapp upgrade --debug 2\u003e\u00261 | \\"},{"line_number":45,"context_line":"        tee {{ working_dir }}/undercloud_leapp_upgrade.log"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Reboot the undercloud"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_994e24bf","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":70},"in_reply_to":"7faddb67_3b6368b4","updated":"2019-07-17 14:52:51.000000000","message":"that\u0027s a very good point. Thanks for the review.","commit_id":"3dfa3e4aaaa48d46235b42979071bdf6dfedb663"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"6e9025d4889a7106f8ad502eb2d65081bed6bd1c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- name: Run leapp upgrade (download packages)"},{"line_number":42,"context_line":"  shell: |"},{"line_number":43,"context_line":"    set -o pipefail"},{"line_number":44,"context_line":"    {{ \u0027LEAPP_DEVEL_SKIP_RHSM\u003d1 sudo -E\u0027 if leapp_unsubscribed|bool }} leapp upgrade --debug 2\u003e\u00261 | \\"},{"line_number":45,"context_line":"        tee {{ working_dir }}/undercloud_leapp_upgrade.log"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Reboot the undercloud"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_530baed4","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":70},"in_reply_to":"7faddb67_4d90ed4a","updated":"2019-07-17 09:43:23.000000000","message":"The main issue is that those required steps are related to the repository setting up: https://gitlab.cee.redhat.com/osp15/osp-upgrade-el8/blob/master/infrared/workarounds/rhos_15_upgrade_workarounds_unregistered.yaml#L40-53 which we agreed on leaving outside the tripleo-upgrade repo. That\u0027s why I decided to leave them aside as part of the  workarounds file. Other option could be transforming the leapp execution into a script (templating it in some leapp_run.sh) and do all of this via workarounds (pre_undercloud_os_upgrade_workarounds).","commit_id":"3dfa3e4aaaa48d46235b42979071bdf6dfedb663"},{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"211f6a7245c15dfd00b58ec60ac385b8b6b07648","unresolved":false,"context_lines":[{"line_number":41,"context_line":"- name: Run leapp upgrade (download packages)"},{"line_number":42,"context_line":"  shell: |"},{"line_number":43,"context_line":"    set -o pipefail"},{"line_number":44,"context_line":"    {{ \u0027LEAPP_DEVEL_SKIP_RHSM\u003d1 sudo -E\u0027 if leapp_unsubscribed|bool }} leapp upgrade --debug 2\u003e\u00261 | \\"},{"line_number":45,"context_line":"        tee {{ working_dir }}/undercloud_leapp_upgrade.log"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Reboot the undercloud"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_3b6368b4","line":44,"range":{"start_line":44,"start_character":4,"end_line":44,"end_character":70},"in_reply_to":"7faddb67_530baed4","updated":"2019-07-17 13:07:35.000000000","message":"so condition should be:\n  if leapp_unsubscribe|bool and workarounds|bool\ncorrect?","commit_id":"3dfa3e4aaaa48d46235b42979071bdf6dfedb663"}]}