)]}'
{"tasks/upgrade/main.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d5533dbcfb7245e513584d95336a1305e46d85a9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  args:"},{"line_number":5,"context_line":"    apply:"},{"line_number":6,"context_line":"      tags: create_undercloud_upgrade_scripts"},{"line_number":7,"context_line":"  tags: create_undercloud_upgrade_scripts"},{"line_number":8,"context_line":"  when: \u003e"},{"line_number":9,"context_line":"      upgrade_noop|bool or"},{"line_number":10,"context_line":"      undercloud_upgrade|bool or"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_df20b5fa","line":7,"updated":"2019-09-17 12:55:40.000000000","message":"I think this can just change to \u0027tags: always\u0027 - due to the \u0027apply\u0027 args above, all included tasks will get the \u0027create_undercloud_upgrade_scripts\u0027 tag.","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"48c1f5a5df5bcb056e9e2c48f69899b4a85afe94","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  args:"},{"line_number":5,"context_line":"    apply:"},{"line_number":6,"context_line":"      tags: create_undercloud_upgrade_scripts"},{"line_number":7,"context_line":"  tags: create_undercloud_upgrade_scripts"},{"line_number":8,"context_line":"  when: \u003e"},{"line_number":9,"context_line":"      upgrade_noop|bool or"},{"line_number":10,"context_line":"      undercloud_upgrade|bool or"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_f29fd1b1","line":7,"in_reply_to":"3fa7e38b_df20b5fa","updated":"2019-09-23 09:22:49.000000000","message":"Done","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1980e583141cf4ef51af64a9734cbd0a065ac71e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      become: true"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    ######## OS upgrade + Overcloud node upgrade run #######"},{"line_number":125,"context_line":"    - include_tasks: overcloud_upgrade_roles.yaml"},{"line_number":126,"context_line":"      loop: \"{{ oc_roles }}\""},{"line_number":127,"context_line":"      loop_control:"},{"line_number":128,"context_line":"        loop_var: role"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_5c9e1308","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":19},"updated":"2019-09-17 12:13:36.000000000","message":"Use import_tasks here, given that there\u0027s no conditional.","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5fb10d2d45f14254c012f7b911017bc86138f1ed","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      become: true"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    ######## OS upgrade + Overcloud node upgrade run #######"},{"line_number":125,"context_line":"    - include_tasks: overcloud_upgrade_roles.yaml"},{"line_number":126,"context_line":"      loop: \"{{ oc_roles }}\""},{"line_number":127,"context_line":"      loop_control:"},{"line_number":128,"context_line":"        loop_var: role"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_bc670726","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":19},"in_reply_to":"3fa7e38b_5c9e1308","updated":"2019-09-17 12:17:17.000000000","message":"nvm, import_tasks doesn\u0027t work with loops :/","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"48c1f5a5df5bcb056e9e2c48f69899b4a85afe94","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      become: true"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    ######## OS upgrade + Overcloud node upgrade run #######"},{"line_number":125,"context_line":"    - include_tasks: overcloud_upgrade_roles.yaml"},{"line_number":126,"context_line":"      loop: \"{{ oc_roles }}\""},{"line_number":127,"context_line":"      loop_control:"},{"line_number":128,"context_line":"        loop_var: role"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_326009cf","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":19},"in_reply_to":"3fa7e38b_9f055d7d","updated":"2019-09-23 09:22:49.000000000","message":"Done","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"28d5633553be422bb151ef93a21dfb18ad72c52d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      become: true"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    ######## OS upgrade + Overcloud node upgrade run #######"},{"line_number":125,"context_line":"    - include_tasks: overcloud_upgrade_roles.yaml"},{"line_number":126,"context_line":"      loop: \"{{ oc_roles }}\""},{"line_number":127,"context_line":"      loop_control:"},{"line_number":128,"context_line":"        loop_var: role"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_9f055d7d","line":125,"range":{"start_line":125,"start_character":6,"end_line":125,"end_character":19},"in_reply_to":"3fa7e38b_bc670726","updated":"2019-09-17 12:52:17.000000000","message":"To ensure that the included task\u0027s tags are available, this task must be tagged with the \u0027always\u0027 tag.","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"}],"tasks/upgrade/overcloud_upgrade_hosts.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2a8c04e8144aec48328bf235b9032274a152a58b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when: upgrade_workarounds"},{"line_number":10,"context_line":"  tags: overcloud_system_upgrade"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- block:"},{"line_number":13,"context_line":"    - name: run the RHEL upgrade steps for the host {{ host }}"},{"line_number":14,"context_line":"      shell: |"},{"line_number":15,"context_line":"        set -o pipefail"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_59c47792","line":12,"updated":"2019-08-29 20:41:02.000000000","message":"If the sole purpose of this block is to apply a tag to the tags in it, then the task above and below can be added. Either that or drop the block and tag each task. Personally, I prefer the latter approach.","commit_id":"097e5400e644159508324f18070f741c4327ec02"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f9b5d5e978ecebec75c3d7e845b64ae46dca9457","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when: upgrade_workarounds"},{"line_number":10,"context_line":"  tags: overcloud_system_upgrade"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- block:"},{"line_number":13,"context_line":"    - name: run the RHEL upgrade steps for the host {{ host }}"},{"line_number":14,"context_line":"      shell: |"},{"line_number":15,"context_line":"        set -o pipefail"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_56c1994d","line":12,"in_reply_to":"7faddb67_59c47792","updated":"2019-08-30 11:30:22.000000000","message":"Done","commit_id":"097e5400e644159508324f18070f741c4327ec02"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2a8c04e8144aec48328bf235b9032274a152a58b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    chdir: \"{{ working_dir }}\""},{"line_number":52,"context_line":"  when: workload_launch|bool"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- block:"},{"line_number":55,"context_line":"    - name: run overcloud major upgrade for the host {{ host }}"},{"line_number":56,"context_line":"      shell: |"},{"line_number":57,"context_line":"        set -o pipefail"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_b9400b08","line":54,"updated":"2019-08-29 20:41:02.000000000","message":"If the sole purpose of this block is to apply a tag to the tags in it, then the task below can be added. Either that or drop the block and tag each task. Personally, I prefer the latter approach.","commit_id":"097e5400e644159508324f18070f741c4327ec02"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"248a27a057c3d4a7b4549fc865fbec4fefafae33","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  args:"},{"line_number":8,"context_line":"    chdir: \"{{ working_dir }}\""},{"line_number":9,"context_line":"  when: upgrade_workarounds"},{"line_number":10,"context_line":"  tags: overcloud_system_upgrade"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: run the RHEL upgrade steps for the host {{ host }}"},{"line_number":13,"context_line":"  shell: |"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_9cefab86","line":10,"updated":"2019-09-17 12:10:01.000000000","message":"Since include_role is used these tags may be skipped if we run ansible with --tag\u003d\u0027overcloud_system_upgrade\u0027","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"}],"tasks/upgrade/overcloud_upgrade_roles.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"28d5633553be422bb151ef93a21dfb18ad72c52d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  loop: \"{{ oc_roles_hosts[role] }}\""},{"line_number":4,"context_line":"  loop_control:"},{"line_number":5,"context_line":"    loop_var: host"},{"line_number":6,"context_line":"  when: \"{{ role !\u003d \u0027all\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_bf0a9987","line":6,"updated":"2019-09-17 12:52:17.000000000","message":"To ensure that the included task\u0027s tags are available, this task must be tagged with the \u0027always\u0027 tag.","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"48c1f5a5df5bcb056e9e2c48f69899b4a85afe94","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  loop: \"{{ oc_roles_hosts[role] }}\""},{"line_number":4,"context_line":"  loop_control:"},{"line_number":5,"context_line":"    loop_var: host"},{"line_number":6,"context_line":"  when: \"{{ role !\u003d \u0027all\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_92a45d0a","line":6,"in_reply_to":"3fa7e38b_bf0a9987","updated":"2019-09-23 09:22:49.000000000","message":"Done","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"}],"tasks/upgrade/overcloud_upgrade_run.yml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6921ad819436f9664c5bdcb84ec123220f2b671d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: run overcloud major upgrade for the host {{ host }}"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    set -o pipefail"},{"line_number":5,"context_line":"    bash {{ overcloud_upgrade_run_script_base }}-{{ host }}.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e \\"},{"line_number":6,"context_line":"        {{ working_dir }}/overcloud_upgrade_run_{{ host }}.log"},{"line_number":7,"context_line":"  register: overcloud_upgrade_res"},{"line_number":8,"context_line":"  ignore_errors: true"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: was the overcloud upgrade composable step successful."},{"line_number":11,"context_line":"  fail: msg\u003d\"Overcloud upgrade composable step failed for {{ host }}... :(\""},{"line_number":12,"context_line":"  when: overcloud_upgrade_res.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_380d7137","line":12,"range":{"start_line":2,"start_character":0,"end_line":12,"end_character":37},"updated":"2019-09-16 16:51:18.000000000","message":"Why ignore errors on the first task, then make it fail on the second? If you remove ignore_errors on the first then it will fail at that task.","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"48c1f5a5df5bcb056e9e2c48f69899b4a85afe94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: run overcloud major upgrade for the host {{ host }}"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    set -o pipefail"},{"line_number":5,"context_line":"    bash {{ overcloud_upgrade_run_script_base }}-{{ host }}.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e \\"},{"line_number":6,"context_line":"        {{ working_dir }}/overcloud_upgrade_run_{{ host }}.log"},{"line_number":7,"context_line":"  register: overcloud_upgrade_res"},{"line_number":8,"context_line":"  ignore_errors: true"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: was the overcloud upgrade composable step successful."},{"line_number":11,"context_line":"  fail: msg\u003d\"Overcloud upgrade composable step failed for {{ host }}... :(\""},{"line_number":12,"context_line":"  when: overcloud_upgrade_res.rc !\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_e282a64f","line":12,"range":{"start_line":2,"start_character":0,"end_line":12,"end_character":37},"in_reply_to":"3fa7e38b_380d7137","updated":"2019-09-23 09:22:49.000000000","message":"I know, the intention is to provide a better logging on what  has happened. So we capture the result code of the script execution and if it went wrong we log in the task that it was during the overlcoud upgade step. Is there any other way to provide a message when a task fails?","commit_id":"97cf0a6f58bd223ad8ab60a48d45c24c3d892bc0"}],"templates/overcloud_upgrade_run.sh.j2":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2a8c04e8144aec48328bf235b9032274a152a58b","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"source {{ undercloud_rc }}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"echo \"[$(date)] Runing major upgrade {{ playbook }} playbook for {{ elements }} role\""},{"line_number":45,"context_line":"openstack overcloud upgrade run \\"},{"line_number":46,"context_line":"        --stack {{ overcloud_stack_name }} \\"},{"line_number":47,"context_line":"        {% if tripleo_upgrade_debug|bool -%}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7faddb67_f908c3d9","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":22},"updated":"2019-08-29 20:41:02.000000000","message":"Spelling error: It should be \u0027running\u0027.","commit_id":"097e5400e644159508324f18070f741c4327ec02"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f9b5d5e978ecebec75c3d7e845b64ae46dca9457","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"source {{ undercloud_rc }}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"echo \"[$(date)] Runing major upgrade {{ playbook }} playbook for {{ elements }} role\""},{"line_number":45,"context_line":"openstack overcloud upgrade run \\"},{"line_number":46,"context_line":"        --stack {{ overcloud_stack_name }} \\"},{"line_number":47,"context_line":"        {% if tripleo_upgrade_debug|bool -%}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7faddb67_d6b589ee","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":22},"in_reply_to":"7faddb67_f908c3d9","updated":"2019-08-30 11:30:22.000000000","message":"Done","commit_id":"097e5400e644159508324f18070f741c4327ec02"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2a8c04e8144aec48328bf235b9032274a152a58b","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"source {{ undercloud_rc }}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"echo \"[$(date)] Runing major upgrade for {{ elements }} hosts\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"openstack overcloud upgrade run \\"},{"line_number":107,"context_line":"        --stack {{ overcloud_stack_name }} \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7faddb67_59f797d5","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":22},"updated":"2019-08-29 20:41:02.000000000","message":"Spelling error: It should be \u0027running\u0027.","commit_id":"097e5400e644159508324f18070f741c4327ec02"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"f9b5d5e978ecebec75c3d7e845b64ae46dca9457","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"source {{ undercloud_rc }}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"echo \"[$(date)] Runing major upgrade for {{ elements }} hosts\""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"openstack overcloud upgrade run \\"},{"line_number":107,"context_line":"        --stack {{ overcloud_stack_name }} \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7faddb67_96cb9170","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":22},"in_reply_to":"7faddb67_59f797d5","updated":"2019-08-30 11:30:22.000000000","message":"Done","commit_id":"097e5400e644159508324f18070f741c4327ec02"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"92d66634277f8ec8597ea7802110e51c90b46474","unresolved":false,"context_lines":[{"line_number":13,"context_line":"   elements \u003d [\u0027controller-0\u0027, \u0027controller-1\u0027]"},{"line_number":14,"context_line":"#}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% set elements \u003d oc_roles_hosts[role][0:oc_roles_hosts[role].index(item)+1] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if overcloud_upgrade_multibooks|bool %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3fa7e38b_ab3b1436","line":16,"updated":"2019-09-19 11:06:50.000000000","message":"Oki, I have my answer -\u003e https://review.opendev.org/#/c/680595/","commit_id":"9e23fa6cdbba672e5b1b6094760df8131bd6d254"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"b180d617470728bc8c2a7bb47cf59091583be532","unresolved":false,"context_lines":[{"line_number":13,"context_line":"   elements \u003d [\u0027controller-0\u0027, \u0027controller-1\u0027]"},{"line_number":14,"context_line":"#}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% set elements \u003d oc_roles_hosts[role][0:oc_roles_hosts[role].index(item)+1] %}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if overcloud_upgrade_multibooks|bool %}"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"3fa7e38b_d4bb9de2","line":16,"range":{"start_line":16,"start_character":7,"end_line":16,"end_character":76},"updated":"2019-09-18 16:24:05.000000000","message":"how de we enforce that we start by the bootstrap node, maybe it\u0027s obvious but I\u0027m nearly eod ?","commit_id":"9e23fa6cdbba672e5b1b6094760df8131bd6d254"}]}