)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"588c9286a41aff63a3db9cf4f9932d3eaf071952","unresolved":false,"context_lines":[{"line_number":10,"context_line":"being a little bit left away in comparision with what it was implemented"},{"line_number":11,"context_line":"for the upgrades one. This patch allows minor updates to benefit from"},{"line_number":12,"context_line":"the same workarounds mechanism, at the same time that any improvement"},{"line_number":13,"context_line":"in the upgrades mechanism will be available for updats too."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, it was removed the references to the {{ working_dir }} variable"},{"line_number":16,"context_line":"in those shell tasks which have the argument changing directory to that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_2a232258","line":13,"updated":"2019-09-26 10:05:11.000000000","message":"updates","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"9e808fd95c6fec846d1f83579342321ed95fceb1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"being a little bit left away in comparision with what it was implemented"},{"line_number":11,"context_line":"for the upgrades one. This patch allows minor updates to benefit from"},{"line_number":12,"context_line":"the same workarounds mechanism, at the same time that any improvement"},{"line_number":13,"context_line":"in the upgrades mechanism will be available for updats too."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also, it was removed the references to the {{ working_dir }} variable"},{"line_number":16,"context_line":"in those shell tasks which have the argument changing directory to that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_f1441276","line":13,"in_reply_to":"3fa7e38b_2a232258","updated":"2019-11-14 13:51:55.000000000","message":"Done","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"}],"tasks/update/create-overcloud-update-scripts.yaml":[{"author":{"_account_id":21537,"name":"Yurii Prokulevych","email":"yprokule@redhat.com","username":"yprokule"},"change_message_id":"28f9500decc26d870d276d0d77ec08d61834d90d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    mode: 0775"},{"line_number":22,"context_line":"    force: true"},{"line_number":23,"context_line":"  loop:"},{"line_number":24,"context_line":"    - \u0027pre_overcloud_update_prepare_workarounds\u0027"},{"line_number":25,"context_line":"    - \u0027post_overcloud_update_prepare_workarounds\u0027"},{"line_number":26,"context_line":"    - \u0027pre_overcloud_update_run_workarounds\u0027"},{"line_number":27,"context_line":"    - \u0027post_overcloud_update_run_workarounds\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_bc3d3cc5","line":24,"range":{"start_line":24,"start_character":7,"end_line":24,"end_character":47},"updated":"2019-09-25 06:51:38.000000000","message":"those items have to be added to templates/workarounds.sh.j2","commit_id":"3d6b02913720c19322789003a16d3c8285a35d42"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"d78e14106d1e4a20a51efc11786b5f39a52c281b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    mode: 0775"},{"line_number":22,"context_line":"    force: true"},{"line_number":23,"context_line":"  loop:"},{"line_number":24,"context_line":"    - \u0027pre_overcloud_update_prepare_workarounds\u0027"},{"line_number":25,"context_line":"    - \u0027post_overcloud_update_prepare_workarounds\u0027"},{"line_number":26,"context_line":"    - \u0027pre_overcloud_update_run_workarounds\u0027"},{"line_number":27,"context_line":"    - \u0027post_overcloud_update_run_workarounds\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_f8e73d11","line":24,"range":{"start_line":24,"start_character":7,"end_line":24,"end_character":47},"in_reply_to":"3fa7e38b_bc3d3cc5","updated":"2019-09-25 09:07:37.000000000","message":"Thanks a lot, I totally forgot about that. I also left away the undercloud_update workarounds rendering. Done","commit_id":"3d6b02913720c19322789003a16d3c8285a35d42"}],"tasks/update/main.yml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"588c9286a41aff63a3db9cf4f9932d3eaf071952","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":72,"context_line":"      when: updates_workarounds|bool"},{"line_number":73,"context_line":"      tags:"},{"line_number":74,"context_line":"        - overcloud_update_prepare"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    - name: import oc update prepare tasks"},{"line_number":77,"context_line":"      import_tasks: overcloud_update_prepare.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_4a20de48","line":74,"updated":"2019-09-26 10:05:11.000000000","message":"I think we should add overcloud_update tag here to follow the convention used in the next task.  You want this apply if you add the tag overcloud_update and the bool update_workarounds is true.","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"588c9286a41aff63a3db9cf4f9932d3eaf071952","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":90,"context_line":"      when: updates_workarounds|bool"},{"line_number":91,"context_line":"      tags:"},{"line_number":92,"context_line":"        - overcloud_update_prepare"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    - name: prepare containers for overcloud update"},{"line_number":95,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_ea18aa1e","line":92,"updated":"2019-09-26 10:05:11.000000000","message":"Same","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"588c9286a41aff63a3db9cf4f9932d3eaf071952","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      shell: |"},{"line_number":98,"context_line":"        set -o pipefail"},{"line_number":99,"context_line":"        bash {{ working_dir }}/overcloud_prepare_containers.sh {{ timestamper_cmd }} \u003e overcloud_update_prepare_containers.log"},{"line_number":100,"context_line":"      tags: overcloud_update_prepare_containers"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    - name: Ensure ansible-pacemaker module is present in CI."},{"line_number":103,"context_line":"      package:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_0a1666f2","line":100,"updated":"2019-09-26 10:05:11.000000000","message":"Those tags are so \"after thought\", I think overcloud_update belong here as well. (unrelated to your review though)","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"588c9286a41aff63a3db9cf4f9932d3eaf071952","unresolved":false,"context_lines":[{"line_number":156,"context_line":"      args:"},{"line_number":157,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":158,"context_line":"      when: updates_workarounds|bool"},{"line_number":159,"context_line":"      tags: overcloud_update_converge"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    - name: import overcloud update converge tasks"},{"line_number":162,"context_line":"      import_tasks: overcloud_update_converge.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_aad4f220","line":159,"updated":"2019-09-26 10:05:11.000000000","message":"same here","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"588c9286a41aff63a3db9cf4f9932d3eaf071952","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    - name: import overcloud update converge tasks"},{"line_number":162,"context_line":"      import_tasks: overcloud_update_converge.yml"},{"line_number":163,"context_line":"      tags: overcloud_update_converge"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    - name: apply post overcloud update converge workarounds"},{"line_number":166,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_cad92e57","line":163,"updated":"2019-09-26 10:05:11.000000000","message":"and there","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"588c9286a41aff63a3db9cf4f9932d3eaf071952","unresolved":false,"context_lines":[{"line_number":171,"context_line":"      args:"},{"line_number":172,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":173,"context_line":"      when: updates_workarounds|bool"},{"line_number":174,"context_line":"      tags: overcloud_update_converge"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    - name: validate overcloud docker images/containers"},{"line_number":177,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_6ada7a4b","line":174,"updated":"2019-09-26 10:05:11.000000000","message":"here as well (overcloud_update tag)","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"}],"workarounds":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"588c9286a41aff63a3db9cf4f9932d3eaf071952","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        basedir: \u0027\u0027"},{"line_number":28,"context_line":"        id: \u0027\u0027"},{"line_number":29,"context_line":"        ansible_hosts: \"overcloud\""},{"line_number":30,"context_line":"        command: \u0027Ansible task to run in overcloud nodes\u0027"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa7e38b_8adfb638","line":30,"updated":"2019-09-26 10:05:11.000000000","message":"Rogue file or example file ?  If rogue file it\u0027s still a good idea to add an example file but in the tests directory and with some update tasks as well.\n\nFurthermore we should add some missing update_workarounds variable in the readme.","commit_id":"8c35463a75d7ce18920fa491b9f1cd40f37d3ab9"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"8f28af8f5dd5fe889987ee56bfb6a270bfcf348f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"pre_undercloud_upgrade_workarounds:"},{"line_number":3,"context_line":"    - rhbz1:"},{"line_number":4,"context_line":"        patch: true"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fa7e38b_a2440075","line":1,"updated":"2019-09-27 11:34:18.000000000","message":"Still don\u0027t think that this file belongs here, but more in the test directory.\nFurthermore if we add a exemple file, we should add type of workaround (ie, some update as well)","commit_id":"efdf893e15e682bf39a293fd3a620a9bcdeb24d9"}]}