)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ab97e9cd74d01363c6504b54d6dfabfc1c38176d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Try to fix our way of spawning scripts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We should always default to executable /usr/bin/bash instead of"},{"line_number":10,"context_line":"adding bash into shell command as it might cause hangs for example"},{"line_number":11,"context_line":"in the timestamper awk waiting for bash and not the script"},{"line_number":12,"context_line":"we wanted to run."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_6806211f","line":9,"range":{"start_line":9,"start_character":17,"end_line":9,"end_character":52},"updated":"2020-09-16 09:53:54.000000000","message":"It\u0027s my understanding that all RHEL has the default of /bin/sh -\u003e bash, so there should be no *need* to set the executable.\n\nPersonally, though, I do prefer it being set to ensure that there\u0027s no ambiguity.","commit_id":"83943c8b673504a0a7059156e9c1794a5161f511"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"07d54d12c207a967123085847cdad6e86c9c8bf0","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We should always have in mind reruns and never overwrite already"},{"line_number":17,"context_line":"existing logs. Always use tee -a or \u003e\u003e."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I987c124eecd9d3d906cac7f9ab18ac4fc28165e3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f560f44_68572a28","line":18,"updated":"2020-09-17 09:27:09.000000000","message":"bug id?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"}],"tasks/fast-forward-upgrade/main.yml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0789afa98c48150ba8a3dbd3fb8a76791b246127","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- block:"},{"line_number":11,"context_line":"    - name: apply pre FFU undercloud OS upgrade workarounds"},{"line_number":12,"context_line":"      shell: |"},{"line_number":13,"context_line":"        pre_ffu_undercloud_os_upgrade_workarounds.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e pre_ffu_undercloud_os_upgrade_workarounds.log"},{"line_number":14,"context_line":"      args:"},{"line_number":15,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":16,"context_line":"        executable: /usr/bin/bash"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_013e658a","line":13,"updated":"2020-09-16 08:37:08.000000000","message":"set -o pipefail seems required here, timestamper_cmd is a \"| blah\" stuff.\n\nfalse | true : without pipefail returns true\nfalse | true : with pipefail returns false (as expected)\n\nso I\u0027m wondering if removing it won\u0027t make it always a success?\n\nHere a complete example relative to your comment about the script inside having pipefail:\n\n   cat has-pipefail-and-fails.sh\n   #!/bin/bash\n   set -o pipefail\n   false | true\n   \n   cat test-withpipefail.sh \n   #!/bin/bash\n   set -o pipefail\n   ./has-pipefail-and-fails.sh | true\n   \n   cat test-nopipefail.sh\n   #!/bin/bash\n   ./has-pipefail-and-fails.sh | true\n\nthen \n\n./test-withpipefail.sh -\u003e rc\u003d1 as expected\n./test-nopipefail.sh   -\u003e rc\u003d0 .. bummer.\n\nwhat am i missing ?","commit_id":"69f3849fb51ba370ef63d91e7af184199205f102"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0789afa98c48150ba8a3dbd3fb8a76791b246127","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        pre_ffu_undercloud_os_upgrade_workarounds.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e pre_ffu_undercloud_os_upgrade_workarounds.log"},{"line_number":14,"context_line":"      args:"},{"line_number":15,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":16,"context_line":"        executable: /usr/bin/bash"},{"line_number":17,"context_line":"      when: ffu_upgrade_workarounds|bool"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Clean up httpd folder"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_616761b9","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":33},"updated":"2020-09-16 08:37:08.000000000","message":"Ansible may choose /bin/sh ?","commit_id":"69f3849fb51ba370ef63d91e7af184199205f102"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        pre_ffu_undercloud_os_upgrade_workarounds.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e pre_ffu_undercloud_os_upgrade_workarounds.log"},{"line_number":14,"context_line":"      args:"},{"line_number":15,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":16,"context_line":"        executable: /usr/bin/bash"},{"line_number":17,"context_line":"      when: ffu_upgrade_workarounds|bool"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    - name: Clean up httpd folder"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9f560f44_c8eacdd6","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":33},"in_reply_to":"9f560f44_616761b9","updated":"2020-09-16 10:22:33.000000000","message":"by default it chooses /bin/sh which doesn\u0027t use pipefails","commit_id":"69f3849fb51ba370ef63d91e7af184199205f102"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    - name: launch workload"},{"line_number":102,"context_line":"      shell: |"},{"line_number":103,"context_line":"        set -o pipefail"},{"line_number":104,"context_line":"        {{ workload_launch_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e workload_launch.log"},{"line_number":105,"context_line":"      args:"},{"line_number":106,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":107,"context_line":"        executable: /usr/bin/bash"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_e8c6b168","line":104,"updated":"2020-09-16 10:22:33.000000000","message":"should we use ./{{ workload_launch_script }}","commit_id":"21d2e5d8a2255f4bc9526fe439e7c22e3ebae921"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"164ba7369760bdd9c7edf5c140e58445d5c80d0c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      args:"},{"line_number":154,"context_line":"        chdir: \"{{ working_dir }}\""},{"line_number":155,"context_line":"        executable: /usr/bin/bash"},{"line_number":156,"context_line":"      shell: |"},{"line_number":157,"context_line":"        set -o pipefail"},{"line_number":158,"context_line":"        ./overcloud_prepare_containers.sh {{ timestamper_cmd }} \u003e\u003e overcloud_upgrade_prepare_containers.log"},{"line_number":159,"context_line":"      tags: overcloud_upgrade_prepare_containers"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_e8b5fa7f","line":156,"updated":"2020-09-17 09:26:14.000000000","message":"nitpick: can we move shell: before args:?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"}],"tasks/main.yml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- name: launch workload"},{"line_number":10,"context_line":"  shell: |"},{"line_number":11,"context_line":"    set -o pipefail"},{"line_number":12,"context_line":"    {{ workload_launch_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e workload_launch.log"},{"line_number":13,"context_line":"  args:"},{"line_number":14,"context_line":"    chdir: \"{{ working_dir }}\""},{"line_number":15,"context_line":"    executable: /usr/bin/bash"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_a8915956","line":12,"updated":"2020-09-16 10:22:33.000000000","message":"./","commit_id":"21d2e5d8a2255f4bc9526fe439e7c22e3ebae921"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"- name: workload cleanup"},{"line_number":43,"context_line":"  shell: |"},{"line_number":44,"context_line":"    set -o pipefail"},{"line_number":45,"context_line":"    {{ workload_launch_script }} cleanup 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e workload_cleanup.log"},{"line_number":46,"context_line":"  args:"},{"line_number":47,"context_line":"    chdir: \"{{ working_dir }}\""},{"line_number":48,"context_line":"    executable: /usr/bin/bash"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_68a8e18b","line":45,"updated":"2020-09-16 10:22:33.000000000","message":"./","commit_id":"21d2e5d8a2255f4bc9526fe439e7c22e3ebae921"}],"tasks/update/main.yml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    - name: update undercloud"},{"line_number":30,"context_line":"      shell: |"},{"line_number":31,"context_line":"          set -o pipefail"},{"line_number":32,"context_line":"          {{ undercloud_update_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":33,"context_line":"            undercloud_update.log"},{"line_number":34,"context_line":"      args:"},{"line_number":35,"context_line":"        chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_c8980d77","line":32,"updated":"2020-09-16 10:22:33.000000000","message":"./","commit_id":"21d2e5d8a2255f4bc9526fe439e7c22e3ebae921"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    - name: validate overcloud docker images/containers"},{"line_number":185,"context_line":"      shell: |"},{"line_number":186,"context_line":"          set -o pipefail"},{"line_number":187,"context_line":"          {{ overcloud_validate_images_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":188,"context_line":"            validate_oc_images_containers.log"},{"line_number":189,"context_line":"      args:"},{"line_number":190,"context_line":"        chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_688101fc","line":187,"updated":"2020-09-16 10:22:33.000000000","message":"./","commit_id":"21d2e5d8a2255f4bc9526fe439e7c22e3ebae921"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"ed2eaef90911acda5a016e1973cc7bd43ae4fa66","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- block:"},{"line_number":12,"context_line":"    - name: apply pre undercloud update workarounds"},{"line_number":13,"context_line":"      shell: |"},{"line_number":14,"context_line":"          set -o pipefail"},{"line_number":15,"context_line":"          ./pre_undercloud_update_workarounds.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":16,"context_line":"            pre_undercloud_update_workarounds.log"},{"line_number":17,"context_line":"      args:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_ab9e5c66","line":14,"updated":"2020-09-17 09:51:48.000000000","message":"Why did you remove the undercloud_rc sourcing?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"043e0deef4f0f6669043302c6db85366352475c9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    - name: update undercloud"},{"line_number":30,"context_line":"      shell: |"},{"line_number":31,"context_line":"          set -o pipefail"},{"line_number":32,"context_line":"          {{ undercloud_update_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":33,"context_line":"            undercloud_update.log"},{"line_number":34,"context_line":"      args:"},{"line_number":35,"context_line":"        chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_8b76f8a2","line":32,"updated":"2020-09-17 09:33:24.000000000","message":"Is undercloud_upgrade_script a full path or relative path? Do we need ./ here?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"ed2eaef90911acda5a016e1973cc7bd43ae4fa66","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    - name: apply post overcloud update prepare workarounds"},{"line_number":85,"context_line":"      shell: |"},{"line_number":86,"context_line":"          set -o pipefail"},{"line_number":87,"context_line":"          ./post_overcloud_update_prepare_workarounds.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":88,"context_line":"            post_overcloud_update_prepare_workarounds.log"},{"line_number":89,"context_line":"      args:"},{"line_number":90,"context_line":"        chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_8ba1d8ab","line":87,"updated":"2020-09-17 09:51:48.000000000","message":"Maybe here it isn\u0027t needed, but removing it in line 15 might be problematic. Or could you point me to the place where we source the stackrc before this code?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"043e0deef4f0f6669043302c6db85366352475c9","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    - name: validate overcloud docker images/containers"},{"line_number":185,"context_line":"      shell: |"},{"line_number":186,"context_line":"          set -o pipefail"},{"line_number":187,"context_line":"          {{ overcloud_validate_images_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":188,"context_line":"            validate_oc_images_containers.log"},{"line_number":189,"context_line":"      args:"},{"line_number":190,"context_line":"        chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_cba59005","line":187,"updated":"2020-09-17 09:33:24.000000000","message":"Is overcloud_validate_images_script a full path or relative path? Do we need ./ here?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"}],"tasks/upgrade/overcloud_upgrade_converge.yml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: run major upgrade converge step"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    set -o pipefail"},{"line_number":5,"context_line":"    {{ overcloud_upgrade_converge_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":6,"context_line":"        overcloud_upgrade_converge.log"},{"line_number":7,"context_line":"  args:"},{"line_number":8,"context_line":"    chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_e874f138","line":5,"updated":"2020-09-16 10:22:33.000000000","message":"./","commit_id":"21d2e5d8a2255f4bc9526fe439e7c22e3ebae921"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"043e0deef4f0f6669043302c6db85366352475c9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: run major upgrade converge step"},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    set -o pipefail"},{"line_number":5,"context_line":"    {{ overcloud_upgrade_converge_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":6,"context_line":"        overcloud_upgrade_converge.log"},{"line_number":7,"context_line":"  args:"},{"line_number":8,"context_line":"    chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_0ba7880b","line":5,"updated":"2020-09-17 09:33:24.000000000","message":"Is overcloud_upgrade_converge_script a full path or relative path? Do we need ./ here?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"}],"tasks/upgrade/overcloud_upgrade_prepare.yml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"- name: setup HEAT outputs via upgrade prepare"},{"line_number":38,"context_line":"  shell: |"},{"line_number":39,"context_line":"    set -o pipefail"},{"line_number":40,"context_line":"    {{ overcloud_upgrade_prepare_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":41,"context_line":"        overcloud_upgrade_prepare.log"},{"line_number":42,"context_line":"  args:"},{"line_number":43,"context_line":"    chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_a89f994f","line":40,"updated":"2020-09-16 10:22:33.000000000","message":"./","commit_id":"21d2e5d8a2255f4bc9526fe439e7c22e3ebae921"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"043e0deef4f0f6669043302c6db85366352475c9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"- name: setup HEAT outputs via upgrade prepare"},{"line_number":38,"context_line":"  shell: |"},{"line_number":39,"context_line":"    set -o pipefail"},{"line_number":40,"context_line":"    {{ overcloud_upgrade_prepare_script }} 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":41,"context_line":"        overcloud_upgrade_prepare.log"},{"line_number":42,"context_line":"  args:"},{"line_number":43,"context_line":"    chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_6bb60441","line":40,"updated":"2020-09-17 09:33:24.000000000","message":"Is overcloud_upgrade_prepare_script a full path or relative path? Do we need ./ here?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"}],"tasks/upgrade/overcloud_upgrade_run.yml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f4d626497bba14f936bdb1a04fd522b15349ddf4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: \"run overcloud major upgrade for the role {{ item }}\""},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    set -o pipefail"},{"line_number":5,"context_line":"    {{ overcloud_upgrade_run_script_base }}-{{ item }}.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":6,"context_line":"        {{ overcloud_upgrade_run_script_base }}-{{ item }}.log"},{"line_number":7,"context_line":"  args:"},{"line_number":8,"context_line":"    chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f560f44_48b4fdd1","line":5,"updated":"2020-09-16 10:22:33.000000000","message":"./","commit_id":"21d2e5d8a2255f4bc9526fe439e7c22e3ebae921"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"043e0deef4f0f6669043302c6db85366352475c9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: \"run overcloud major upgrade for the role {{ item }}\""},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    set -o pipefail"},{"line_number":5,"context_line":"    {{ overcloud_upgrade_run_script_base }}-{{ item }}.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":6,"context_line":"        {{ overcloud_upgrade_run_script_base }}-{{ item }}.log"},{"line_number":7,"context_line":"  args:"},{"line_number":8,"context_line":"    chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_4bb18044","line":5,"updated":"2020-09-17 09:33:24.000000000","message":"Is overcloud_upgrade_run_script a full path or relative path? Do we need ./ here?","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"ed2eaef90911acda5a016e1973cc7bd43ae4fa66","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: \"run overcloud major upgrade for the role {{ item }}\""},{"line_number":3,"context_line":"  shell: |"},{"line_number":4,"context_line":"    set -o pipefail"},{"line_number":5,"context_line":"    {{ overcloud_upgrade_run_script_base }}-{{ item }}.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e \\"},{"line_number":6,"context_line":"        {{ overcloud_upgrade_run_script_base }}-{{ item }}.log"},{"line_number":7,"context_line":"  args:"},{"line_number":8,"context_line":"    chdir: \"{{ working_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9f560f44_cb00f069","line":5,"in_reply_to":"9f560f44_4bb18044","updated":"2020-09-17 09:51:48.000000000","message":"It\u0027s an absolute path https://github.com/openstack/tripleo-upgrade/blob/master/defaults/main.yml#L86","commit_id":"94a6f729cdaa074d018995ac281624dca025c856"}]}