)]}'
{"tasks/fast-forward-upgrade/create-overcloud-ffu-hosts-scripts.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fc370524df6acd90d759dabe1b72cc588bcd55c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  when: pcs_present"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: create compute pre upgrade script for {{ item }}"},{"line_number":7,"context_line":"  when: compute_present|bool or workload_launch|bool"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    node_name: \"{{ item | reject(\u0027none\u0027) | join(\u0027,\u0027) }}\""},{"line_number":10,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fffc6b78_09034f44","line":7,"range":{"start_line":7,"start_character":32,"end_line":7,"end_character":52},"updated":"2020-11-19 21:53:54.000000000","message":"cast items should have a space between the filter.","commit_id":"822659b2e4096bdc3697aeb4060afa5522e39050"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fc370524df6acd90d759dabe1b72cc588bcd55c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  when: pcs_present"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: create compute pre upgrade script for {{ item }}"},{"line_number":7,"context_line":"  when: compute_present|bool or workload_launch|bool"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    node_name: \"{{ item | reject(\u0027none\u0027) | join(\u0027,\u0027) }}\""},{"line_number":10,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fffc6b78_69f49b5c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2020-11-19 21:53:54.000000000","message":"even when one item is used we prefer the items to be written in list format\n\n  - compute_present|bool or workload_launch|bool","commit_id":"822659b2e4096bdc3697aeb4060afa5522e39050"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fc370524df6acd90d759dabe1b72cc588bcd55c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  when: pcs_present"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: create compute pre upgrade script for {{ item }}"},{"line_number":7,"context_line":"  when: compute_present|bool or workload_launch|bool"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    node_name: \"{{ item | reject(\u0027none\u0027) | join(\u0027,\u0027) }}\""},{"line_number":10,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fffc6b78_49fd5739","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":28},"updated":"2020-11-19 21:53:54.000000000","message":"we generally like to see the filters have parenthesis around them when creating a string conditional.\n\n  - (compute_present | bool) or (workload_launch | bool)","commit_id":"822659b2e4096bdc3697aeb4060afa5522e39050"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"61c7a8fbd5ef64096d5cf1448550b6d762aabb98","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  when: pcs_present"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: create compute pre upgrade script for {{ item }}"},{"line_number":7,"context_line":"  when: compute_present|bool or workload_launch|bool"},{"line_number":8,"context_line":"  vars:"},{"line_number":9,"context_line":"    node_name: \"{{ item | reject(\u0027none\u0027) | join(\u0027,\u0027) }}\""},{"line_number":10,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fe43af4_10678d98","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":28},"in_reply_to":"fffc6b78_49fd5739","updated":"2020-11-22 07:34:54.000000000","message":"Ack","commit_id":"822659b2e4096bdc3697aeb4060afa5522e39050"}],"tasks/fast-forward-upgrade/overcloud_upgrade_hosts.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"fc370524df6acd90d759dabe1b72cc588bcd55c7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  tags: ffu_overcloud_system_upgrade"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: run the pre upgrade script for the host {{ host }}"},{"line_number":15,"context_line":"  when: compute_present|bool or workload_launch|bool"},{"line_number":16,"context_line":"  shell: |"},{"line_number":17,"context_line":"    set -o pipefail"},{"line_number":18,"context_line":"    ./{{ host }}_upgrade_pre.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e {{ host }}_upgrade_pre.log"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fffc6b78_29fa9341","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":52},"updated":"2020-11-19 21:53:54.000000000","message":"same as previous file.","commit_id":"822659b2e4096bdc3697aeb4060afa5522e39050"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"61c7a8fbd5ef64096d5cf1448550b6d762aabb98","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  tags: ffu_overcloud_system_upgrade"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: run the pre upgrade script for the host {{ host }}"},{"line_number":15,"context_line":"  when: compute_present|bool or workload_launch|bool"},{"line_number":16,"context_line":"  shell: |"},{"line_number":17,"context_line":"    set -o pipefail"},{"line_number":18,"context_line":"    ./{{ host }}_upgrade_pre.sh 2\u003e\u00261 {{ timestamper_cmd }} \u003e\u003e {{ host }}_upgrade_pre.log"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d6e0834b_1544fc39","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":52},"in_reply_to":"fffc6b78_29fa9341","updated":"2020-11-22 07:34:54.000000000","message":"Ack","commit_id":"822659b2e4096bdc3697aeb4060afa5522e39050"}],"templates/node_upgrade_pre.sh.j2":[{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"303f0b147b0b04c2e389116239ea9e09bed5b22b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"HOST\u003d$(openstack compute service list -f value -c Host | grep {{ node_name }} )"},{"line_number":5,"context_line":"INSTANCE_COUNT\u003d$(openstack server list --all --host ${HOST} -f json | jq -r -c \u0027[.[] | select(.Status | contains(\"ACTIVE\"))] | length\u0027)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ $INSTANCE_COUNT \u003d\u003d 0 ]; then"},{"line_number":8,"context_line":"   nova host-evacuate-live ${HOST}"},{"line_number":9,"context_line":"else"},{"line_number":10,"context_line":"   echo \"No vms in active state on ${HOST}\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1f621f24_8efcd3b5","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":23},"updated":"2020-11-12 10:08:35.000000000","message":"Fix !\u003d","commit_id":"68067665ad3cab480365b87f6fa75c25f537788c"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"7f1c4a36122c11e8cc34c1195cd6d91325b05daa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"HOST\u003d$(openstack compute service list -f value -c Host | grep {{ node_name }} )"},{"line_number":5,"context_line":"INSTANCE_COUNT\u003d$(openstack server list --all --host ${HOST} -f json | jq -r -c \u0027[.[] | select(.Status | contains(\"ACTIVE\"))] | length\u0027)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ $INSTANCE_COUNT \u003d\u003d 0 ]; then"},{"line_number":8,"context_line":"   nova host-evacuate-live ${HOST}"},{"line_number":9,"context_line":"else"},{"line_number":10,"context_line":"   echo \"No vms in active state on ${HOST}\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"1f621f24_eed5871d","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":23},"in_reply_to":"1f621f24_8efcd3b5","updated":"2020-11-12 10:11:55.000000000","message":"Done","commit_id":"68067665ad3cab480365b87f6fa75c25f537788c"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"e2d3329aff9c033b2100467e4721a43823e393da","unresolved":true,"context_lines":[{"line_number":14,"context_line":"elapsed_seconds\u003d0"},{"line_number":15,"context_line":"while [ $INSTANCE_COUNT !\u003d 0 ]; do"},{"line_number":16,"context_line":"    echo \"Waiting for ${HOST} to get quiesced ...\""},{"line_number":17,"context_line":"    INSTANCE_COUNT\u003d$(openstack server list --all --host ${HOST} -f json | jq -r -c \u0027[.[] | select(.Status | contains(\"ACTIVE\") or contains(\"PAUSED\") or contains(\"MIGRATING\"))] | length\u0027)"},{"line_number":18,"context_line":"    if [ $INSTANCE_COUNT \u003d\u003d 0 ]; then"},{"line_number":19,"context_line":"        break"},{"line_number":20,"context_line":"    fi"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"15fc91bf_86105e64","line":17,"updated":"2020-11-23 12:00:12.000000000","message":"https://docs.openstack.org/api-guide/compute/server_concepts.html\n\nAccording to doc there are more statuses we need to catch PASSWORD, BUILD or RESIZE at least. T","commit_id":"b8d3218d1e40d3593d022d66ad3d91ccf01adf85"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"468516c0a11719486fc8fc0cfe614379ea0eae2a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"elapsed_seconds\u003d0"},{"line_number":15,"context_line":"while [ $INSTANCE_COUNT !\u003d 0 ]; do"},{"line_number":16,"context_line":"    echo \"Waiting for ${HOST} to get quiesced ...\""},{"line_number":17,"context_line":"    INSTANCE_COUNT\u003d$(openstack server list --all --host ${HOST} -f json | jq -r -c \u0027[.[] | select(.Status | contains(\"ACTIVE\") or contains(\"PAUSED\") or contains(\"MIGRATING\"))] | length\u0027)"},{"line_number":18,"context_line":"    if [ $INSTANCE_COUNT \u003d\u003d 0 ]; then"},{"line_number":19,"context_line":"        break"},{"line_number":20,"context_line":"    fi"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"e3b02914_adc8ba5e","line":17,"in_reply_to":"0c57d677_8f21e924","updated":"2020-11-25 18:37:07.000000000","message":"Ok, fair enough","commit_id":"b8d3218d1e40d3593d022d66ad3d91ccf01adf85"},{"author":{"_account_id":20171,"name":"Yariv","email":"yrachman@redhat.com","username":"Yarboa"},"change_message_id":"3de5cdb7283b5ca507a65c49fa14c9c0f29a2fb4","unresolved":true,"context_lines":[{"line_number":14,"context_line":"elapsed_seconds\u003d0"},{"line_number":15,"context_line":"while [ $INSTANCE_COUNT !\u003d 0 ]; do"},{"line_number":16,"context_line":"    echo \"Waiting for ${HOST} to get quiesced ...\""},{"line_number":17,"context_line":"    INSTANCE_COUNT\u003d$(openstack server list --all --host ${HOST} -f json | jq -r -c \u0027[.[] | select(.Status | contains(\"ACTIVE\") or contains(\"PAUSED\") or contains(\"MIGRATING\"))] | length\u0027)"},{"line_number":18,"context_line":"    if [ $INSTANCE_COUNT \u003d\u003d 0 ]; then"},{"line_number":19,"context_line":"        break"},{"line_number":20,"context_line":"    fi"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"0c57d677_8f21e924","line":17,"in_reply_to":"15fc91bf_86105e64","updated":"2020-11-24 13:32:59.000000000","message":"I think maybe RESIZE should be added, since this related to cold migration.\nThe script here is for live migration use case only, as per now 😊.\nIf machines are in other status, they should be called migrated, different mechanism w/resize needed.\n\nI would like to hear your thoughts here.","commit_id":"b8d3218d1e40d3593d022d66ad3d91ccf01adf85"}]}