)]}'
{"validations/library/ini.py":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"3ed686cef30e84551f93901a368c7d1f6f095802","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        try:"},{"line_number":47,"context_line":"            config.read(ini_file_path)"},{"line_number":48,"context_line":"        except Exception:"},{"line_number":49,"context_line":"            module.fail_json(msg\u003d\"The file \u0027{}\u0027 is not in a valid INI format.\""},{"line_number":50,"context_line":"                             .format(ini_file_path))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        section \u003d module.params.get(\u0027section\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_57dc2612","line":49,"updated":"2016-09-23 11:17:59.000000000","message":"Just for the record I\u0027d go with a more generic error message like \"Failed to parse {}\" or similar instead of making assumption on while config.read has failed.","commit_id":"8502c3ad51787838c120d347266fd29324011aca"},{"author":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"change_message_id":"7defd264ba68d0f22b51d7c235a2d617aa35438b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        try:"},{"line_number":47,"context_line":"            config.read(ini_file_path)"},{"line_number":48,"context_line":"        except Exception:"},{"line_number":49,"context_line":"            module.fail_json(msg\u003d\"The file \u0027{}\u0027 is not in a valid INI format.\""},{"line_number":50,"context_line":"                             .format(ini_file_path))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        section \u003d module.params.get(\u0027section\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_32916853","line":49,"in_reply_to":"5a8bc5a2_57dc2612","updated":"2016-09-23 11:35:32.000000000","message":"I\u0027ll change that.","commit_id":"8502c3ad51787838c120d347266fd29324011aca"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"3ed686cef30e84551f93901a368c7d1f6f095802","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        except ConfigParser.Error:"},{"line_number":61,"context_line":"            msg \u003d (\"There is no key \u0027{}\u0027 under the section \u0027{}\u0027 in file {}.\""},{"line_number":62,"context_line":"                   .format(key, section, ini_file_path))"},{"line_number":63,"context_line":"            module.exit_json(msg\u003dmsg, changed\u003dFalse, value\u003dNone)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        missing_file_message \u003d \"Could not open the ini file: \u0027{}\u0027\".format("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_77d762ed","line":63,"updated":"2016-09-23 11:17:59.000000000","message":"Shouldn\u0027t this return an error? You could either change your \u0027ignore_missing_file\u0027 into \u0027ignore_errors\u0027 or add a new \u0027ignore_missing_key\u0027 parameter.","commit_id":"8502c3ad51787838c120d347266fd29324011aca"},{"author":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"change_message_id":"7defd264ba68d0f22b51d7c235a2d617aa35438b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        except ConfigParser.Error:"},{"line_number":61,"context_line":"            msg \u003d (\"There is no key \u0027{}\u0027 under the section \u0027{}\u0027 in file {}.\""},{"line_number":62,"context_line":"                   .format(key, section, ini_file_path))"},{"line_number":63,"context_line":"            module.exit_json(msg\u003dmsg, changed\u003dFalse, value\u003dNone)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    else:"},{"line_number":66,"context_line":"        missing_file_message \u003d \"Could not open the ini file: \u0027{}\u0027\".format("}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_32ca486f","line":63,"in_reply_to":"5a8bc5a2_77d762ed","updated":"2016-09-23 11:35:32.000000000","message":"I thought about that, but this will make it simpler and you can check for None or use the `default` filter from Ansible.","commit_id":"8502c3ad51787838c120d347266fd29324011aca"}]}
