)]}'
{"id":"openstack%2Ftripleo-validations~430681","triplet_id":"openstack%2Ftripleo-validations~master~I2ff2c84601cb63def82b08f3fb670c0f6acd1915","project":"openstack/tripleo-validations","branch":"master","topic":"dhcp_raw_socket","hashtags":[],"change_id":"I2ff2c84601cb63def82b08f3fb670c0f6acd1915","subject":"Drop scapy dependency","status":"MERGED","created":"2017-02-08 09:27:56.000000000","updated":"2017-04-12 15:45:29.000000000","submitted":"2017-04-12 15:40:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c21c64f3afb5a30ba40c029594ba0cda53bf0728","_number":430681,"virtual_id_number":430681,"owner":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},{"value":0,"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":0,"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},{"value":0,"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},{"value":2,"date":"2017-04-12 15:40:02.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"all":[{"value":0,"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2017-04-12 15:31:10.000000000","_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},{"value":0,"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":1,"date":"2017-04-12 12:45:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},{"value":2,"date":"2017-04-12 09:26:43.000000000","_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"all":[{"value":0,"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":1,"date":"2017-04-12 15:31:10.000000000","_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},{"value":0,"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":0,"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},{"value":0,"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-16 15:51:28.000000000","updated_by":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"reviewer":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"state":"REVIEWER"},{"updated":"2017-03-23 17:03:02.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2017-04-12 09:26:43.000000000","updated_by":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"reviewer":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"state":"REVIEWER"},{"updated":"2017-04-12 12:45:33.000000000","updated_by":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"reviewer":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"state":"REVIEWER"},{"updated":"2017-04-12 15:31:10.000000000","updated_by":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"reviewer":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"state":"REVIEWER"},{"updated":"2017-04-12 15:40:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"12b45d730590f528d6d7bd90c83df1ae817f8fcc","author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"date":"2017-02-08 09:27:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d20782badc91a104794436e040abeda9eb228849","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-08 09:32:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tripleo-validations-docs-ubuntu-xenial http://docs-draft.openstack.org/81/430681/1/check/gate-tripleo-validations-docs-ubuntu-xenial/8148026//doc/build/html/ : SUCCESS in 1m 45s\n- gate-tripleo-validations-pep8-ubuntu-xenial http://logs.openstack.org/81/430681/1/check/gate-tripleo-validations-pep8-ubuntu-xenial/e0fa266/ : SUCCESS in 3m 07s\n- gate-tripleo-validations-python27-ubuntu-xenial http://logs.openstack.org/81/430681/1/check/gate-tripleo-validations-python27-ubuntu-xenial/9ce5df2/ : SUCCESS in 1m 43s","accounts_in_message":[],"_revision_number":1},{"id":"f862888382a847e3493f1ef86c434b7889a77001","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-02-12 17:55:56.000000000","message":"Patch Set 1: Code-Review-1\n\nIs there a problem with scapy that is serious enough to write so much code for reinventing what it implements? If so, please explain this problem in the commit message.","accounts_in_message":[],"_revision_number":1},{"id":"299e7e6b173c1ad427a7d4c270d59f129caca059","author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"date":"2017-02-16 15:51:28.000000000","message":"Patch Set 1:\n\nI believe the issue is that scapy is not packaged and was installed via pip in a virtualenv.","accounts_in_message":[],"_revision_number":1},{"id":"0651369d0990689f3bcd8204b8f19d5a48d2e842","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-02-16 16:45:55.000000000","message":"Patch Set 1:\n\nIs there something blocking packaging?","accounts_in_message":[],"_revision_number":1},{"id":"335401c4b3f0199c0b9d3e62c805e15a5ee9f0d9","author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"date":"2017-02-20 15:42:09.000000000","message":"Patch Set 1:\n\n@dtantsur: this is one less dependency to install and will ensure the validation works in the event the nodes are on an isolated network and don\u0027t have access to a package repository.","accounts_in_message":[],"_revision_number":1},{"id":"facd9367e9eb003158ff90c21a04c1dc9fdddb78","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-02-20 15:43:09.000000000","message":"Patch Set 1:\n\n\"One less dependency\" is a good argument when you don\u0027t end up writing 200 lines of complex code to replace it..","accounts_in_message":[],"_revision_number":1},{"id":"911dd673828a6b416e12395583d19fbc09f8a7c5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-07 10:40:33.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"b512d5d2b178ca9f721641f90c15a311bf4a5ae4","author":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"date":"2017-03-23 15:46:20.000000000","message":"Patch Set 1: Code-Review+1\n\nSo one thing about scapy is that it\u0027s licensed under GPLv2 which I think means we can\u0027t use it as a dependency and keep our Apache license.\n\nSo unless we want to relicense tripleo-validations (which is not desirable to my knowledge), we are obligated to either remove scapy or the rogue dhcp validation. I am in favour of the former.","accounts_in_message":[],"_revision_number":1},{"id":"f20ba3a22c36abef1c4845ee78738a52f779acf0","author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"date":"2017-03-23 15:46:25.000000000","message":"Patch Set 1:\n\nNot having to create and maintain a package for the life of the dependency is a pretty good reason for writing 200 lines of code and removing said dependency, especially for something relatively minor.","accounts_in_message":[],"_revision_number":1},{"id":"b90dc64768cf6c000ec0e712277bd612be43716c","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2017-03-23 17:03:02.000000000","message":"Patch Set 1: -Code-Review\n\n\u003e Not having to create and maintain a package for the life of the dependency is a pretty good reason\n\nMmm, no, not really. Anyway,\n\n\u003e It\u0027s licensed under GPLv2 which I think means we can\u0027t use it as a dependency and keep our Apache license\n\nThis *is* a very serious reason, so I\u0027m withdrawing my objections. I haven\u0027t reviewed the code, much, so not putting +1 yet.","accounts_in_message":[],"_revision_number":1},{"id":"40eba2a832068c62c05c1a4005fa3dee2c82e5fe","author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"date":"2017-03-29 10:04:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cc2da0141d7f2f673e48f5be4c4bcd68e7624423","author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"date":"2017-03-29 10:05:33.000000000","message":"Patch Set 2:\n\nPS 2 only resolved a merge conflict.","accounts_in_message":[],"_revision_number":2},{"id":"584041101dd292ad103cc08c230885c431636cc1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-29 10:12:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tripleo-validations-docs-ubuntu-xenial http://docs-draft.openstack.org/81/430681/2/check/gate-tripleo-validations-docs-ubuntu-xenial/e62d1b1//doc/build/html/ : SUCCESS in 2m 05s\n- gate-tripleo-validations-pep8-ubuntu-xenial http://logs.openstack.org/81/430681/2/check/gate-tripleo-validations-pep8-ubuntu-xenial/c23a927/ : SUCCESS in 3m 10s\n- gate-tripleo-validations-python27-ubuntu-xenial http://logs.openstack.org/81/430681/2/check/gate-tripleo-validations-python27-ubuntu-xenial/03f0ad4/ : SUCCESS in 2m 57s","accounts_in_message":[],"_revision_number":2},{"id":"4b99a78f59f5bcbedb85b122bacc841933a06ff7","author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"date":"2017-04-03 21:17:58.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e4c8ad4f08b790acb838a5e9d890ebf4762ed08e","author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"date":"2017-04-10 16:04:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"23148f2b7bfabb14d5c671e8f87e9ecab5beabbc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-10 16:08:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tripleo-validations-docs-ubuntu-xenial http://docs-draft.openstack.org/81/430681/3/check/gate-tripleo-validations-docs-ubuntu-xenial/94cf4c4//doc/build/html/ : SUCCESS in 2m 19s\n- gate-tripleo-validations-pep8-ubuntu-xenial http://logs.openstack.org/81/430681/3/check/gate-tripleo-validations-pep8-ubuntu-xenial/5076e9a/ : SUCCESS in 2m 46s\n- gate-tripleo-validations-python27-ubuntu-xenial http://logs.openstack.org/81/430681/3/check/gate-tripleo-validations-python27-ubuntu-xenial/8bb6fc1/ : SUCCESS in 2m 47s","accounts_in_message":[],"_revision_number":3},{"id":"32d1166b0bc01832b55a49e519fc2b75d71df87b","author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"date":"2017-04-11 15:20:54.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0a1d20ca8b6df3df3086e452423846852c92111f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-11 15:26:29.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tripleo-validations-docs-ubuntu-xenial http://docs-draft.openstack.org/81/430681/4/check/gate-tripleo-validations-docs-ubuntu-xenial/422efe1//doc/build/html/ : SUCCESS in 4m 56s\n- gate-tripleo-validations-pep8-ubuntu-xenial http://logs.openstack.org/81/430681/4/check/gate-tripleo-validations-pep8-ubuntu-xenial/d377a72/ : SUCCESS in 3m 42s\n- gate-tripleo-validations-python27-ubuntu-xenial http://logs.openstack.org/81/430681/4/check/gate-tripleo-validations-python27-ubuntu-xenial/16a2a81/ : SUCCESS in 2m 39s","accounts_in_message":[],"_revision_number":4},{"id":"e97a78048e1d35d36ac760fd0800a490d6f19798","author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"date":"2017-04-12 06:51:57.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"0e36d3e811c6108095513e08f4476b7f514e8d8e","author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"date":"2017-04-12 06:54:04.000000000","message":"Patch Set 5:\n\nHi Florian, I changed it back to the previous version since the select was returning immediately after the first packet read on the socket, and implemented a proper timeout. Can you give it a try?","accounts_in_message":[],"_revision_number":5},{"id":"04a5b7497983651610d3c8820dff67605bf4b30e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-12 06:57:04.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tripleo-validations-docs-ubuntu-xenial http://docs-draft.openstack.org/81/430681/5/check/gate-tripleo-validations-docs-ubuntu-xenial/cb857c0//doc/build/html/ : SUCCESS in 2m 47s\n- gate-tripleo-validations-pep8-ubuntu-xenial http://logs.openstack.org/81/430681/5/check/gate-tripleo-validations-pep8-ubuntu-xenial/197d27b/ : SUCCESS in 3m 46s\n- gate-tripleo-validations-python27-ubuntu-xenial http://logs.openstack.org/81/430681/5/check/gate-tripleo-validations-python27-ubuntu-xenial/74591dc/ : SUCCESS in 3m 25s","accounts_in_message":[],"_revision_number":5},{"id":"5df90237864760e51fff4d871d17a17fdb1503d4","author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"date":"2017-04-12 09:26:43.000000000","message":"Patch Set 5: Code-Review+2\n\nThanks for the update! Works for me.","accounts_in_message":[],"_revision_number":5},{"id":"53782638f6e7a93ca6f76afef8133f83856ebdeb","author":{"_account_id":10112,"name":"Jason E. Rist","email":"jrist@redhat.com","username":"jrist"},"date":"2017-04-12 12:45:33.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"cd30408d0d8257d2f25c1e155082dd5b789d4ee9","author":{"_account_id":4330,"name":"Tomas Sedovic","email":"tsedovic@redhat.com","username":"tomas-8c8"},"date":"2017-04-12 15:31:10.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\nThanks! FYI this means we can turn `validations/files/rogue_dhcp.py` into a normal Ansible module (it was a separate script just because of the virtualenv workaround). But that should happen in a separate patch.","accounts_in_message":[],"_revision_number":5},{"id":"41160c4c804bf8c0e78b022ef72b9896fbd62383","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-12 15:35:30.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"4c3f73ff863f8bee505c50b9be08cf868aba7318","date":"2017-04-12 15:40:02.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5},{"id":"19a00ca4b258aac5188b539f846cbda92428465e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-12 15:40:02.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tripleo-validations-docs-ubuntu-xenial http://docs-draft.openstack.org/81/430681/5/gate/gate-tripleo-validations-docs-ubuntu-xenial/7bb6a7e//doc/build/html/ : SUCCESS in 3m 15s\n- gate-tripleo-validations-pep8-ubuntu-xenial http://logs.openstack.org/81/430681/5/gate/gate-tripleo-validations-pep8-ubuntu-xenial/7a09da0/ : SUCCESS in 3m 06s\n- gate-tripleo-validations-python27-ubuntu-xenial http://logs.openstack.org/81/430681/5/gate/gate-tripleo-validations-python27-ubuntu-xenial/49d2cdc/ : SUCCESS in 2m 13s","accounts_in_message":[],"_revision_number":5},{"id":"efdc521e9be1063243789f34ae6dd8b7f7c51ecc","author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"date":"2017-04-12 15:45:29.000000000","message":"Patch Set 5: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ocata as commit 5f4ecf02670287675b915fae527abd0a000464e4","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"ca3ef23a45b12e72a557f426be04e29804b1c510","revisions":{"188f3b71769cc8c40d68654155b46d9790b8555f":{"kind":"REWORK","_number":1,"created":"2017-02-08 09:27:56.000000000","uploader":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"ref":"refs/changes/81/430681/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/81/430681/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/1"}}},"commit":{"parents":[{"commit":"6b928f1c15fa68172c5981fd5581853e0ac5deb0","subject":"Add reno for release notes management","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/6b928f1c15fa68172c5981fd5581853e0ac5deb0"}]}],"author":{"name":"Martin André","email":"m.andre@redhat.com","date":"2017-02-08 09:22:20.000000000","tz":60},"committer":{"name":"Martin André","email":"m.andre@redhat.com","date":"2017-02-08 09:22:20.000000000","tz":60},"subject":"Drop scapy dependency","message":"Drop scapy dependency\n\nThis avoids installing a new dependency to run the DHCP validations.\nThe rogue_dhcp.py script now uses raw sockets to send DHCP Discover\nrequests and wait for responses.\n\nChange-Id: I2ff2c84601cb63def82b08f3fb670c0f6acd1915\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/188f3b71769cc8c40d68654155b46d9790b8555f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/188f3b71769cc8c40d68654155b46d9790b8555f"}]},"branch":"refs/heads/master"},"06557f3887af7846097682581b46ed9ea9290688":{"kind":"REWORK","_number":2,"created":"2017-03-29 10:04:39.000000000","uploader":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"ref":"refs/changes/81/430681/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/81/430681/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/2"}}},"commit":{"parents":[{"commit":"c15f4696d68dbab2d61c9ce3bf158551300229d1","subject":"Update reno for stable/ocata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/c15f4696d68dbab2d61c9ce3bf158551300229d1"}]}],"author":{"name":"Martin André","email":"m.andre@redhat.com","date":"2017-02-08 09:22:20.000000000","tz":60},"committer":{"name":"Florian Fuchs","email":"flfuchs@redhat.com","date":"2017-03-29 10:03:27.000000000","tz":120},"subject":"Drop scapy dependency","message":"Drop scapy dependency\n\nThis avoids installing a new dependency to run the DHCP validations.\nThe rogue_dhcp.py script now uses raw sockets to send DHCP Discover\nrequests and wait for responses.\n\nChange-Id: I2ff2c84601cb63def82b08f3fb670c0f6acd1915\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/06557f3887af7846097682581b46ed9ea9290688"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/06557f3887af7846097682581b46ed9ea9290688"}]},"branch":"refs/heads/master"},"243e61978326e0748f8cfd3ce6c9b71930a6fd9d":{"kind":"REWORK","_number":3,"created":"2017-04-10 16:04:21.000000000","uploader":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"ref":"refs/changes/81/430681/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/81/430681/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/3"}}},"commit":{"parents":[{"commit":"c15f4696d68dbab2d61c9ce3bf158551300229d1","subject":"Update reno for stable/ocata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/c15f4696d68dbab2d61c9ce3bf158551300229d1"}]}],"author":{"name":"Martin André","email":"m.andre@redhat.com","date":"2017-02-08 09:22:20.000000000","tz":60},"committer":{"name":"Florian Fuchs","email":"flfuchs@redhat.com","date":"2017-04-10 16:04:07.000000000","tz":0},"subject":"Drop scapy dependency","message":"Drop scapy dependency\n\nThis avoids installing a new dependency to run the DHCP validations.\nThe rogue_dhcp.py script now uses raw sockets to send DHCP Discover\nrequests and wait for responses.\n\nChange-Id: I2ff2c84601cb63def82b08f3fb670c0f6acd1915\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/243e61978326e0748f8cfd3ce6c9b71930a6fd9d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/243e61978326e0748f8cfd3ce6c9b71930a6fd9d"}]},"branch":"refs/heads/master"},"c92e9c0c2f1e5ebe8795320ff19afbbdb01c2d32":{"kind":"REWORK","_number":4,"created":"2017-04-11 15:20:54.000000000","uploader":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"ref":"refs/changes/81/430681/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/81/430681/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/4"}}},"commit":{"parents":[{"commit":"c15f4696d68dbab2d61c9ce3bf158551300229d1","subject":"Update reno for stable/ocata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/c15f4696d68dbab2d61c9ce3bf158551300229d1"}]}],"author":{"name":"Martin André","email":"m.andre@redhat.com","date":"2017-02-08 09:22:20.000000000","tz":60},"committer":{"name":"Florian Fuchs","email":"flfuchs@redhat.com","date":"2017-04-11 15:20:35.000000000","tz":120},"subject":"Drop scapy dependency","message":"Drop scapy dependency\n\nThis avoids installing a new dependency to run the DHCP validations.\nThe rogue_dhcp.py script now uses raw sockets to send DHCP Discover\nrequests and wait for responses.\n\nChange-Id: I2ff2c84601cb63def82b08f3fb670c0f6acd1915\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/c92e9c0c2f1e5ebe8795320ff19afbbdb01c2d32"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/c92e9c0c2f1e5ebe8795320ff19afbbdb01c2d32"}]},"branch":"refs/heads/master"},"ca3ef23a45b12e72a557f426be04e29804b1c510":{"kind":"REWORK","_number":5,"created":"2017-04-12 06:51:57.000000000","uploader":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"ref":"refs/changes/81/430681/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/81/430681/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/81/430681/5"}}},"commit":{"parents":[{"commit":"c15f4696d68dbab2d61c9ce3bf158551300229d1","subject":"Update reno for stable/ocata","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/c15f4696d68dbab2d61c9ce3bf158551300229d1"}]}],"author":{"name":"Martin André","email":"m.andre@redhat.com","date":"2017-02-08 09:22:20.000000000","tz":60},"committer":{"name":"Martin André","email":"m.andre@redhat.com","date":"2017-04-12 06:50:56.000000000","tz":120},"subject":"Drop scapy dependency","message":"Drop scapy dependency\n\nThis avoids installing a new dependency to run the DHCP validations.\nThe rogue_dhcp.py script now uses raw sockets to send DHCP Discover\nrequests and wait for responses.\n\nThis commit also changes the timeout to 5 seconds instead of 30 as it\nis already plenty of time for a DHCP server to respond.\n\nChange-Id: I2ff2c84601cb63def82b08f3fb670c0f6acd1915\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/ca3ef23a45b12e72a557f426be04e29804b1c510"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/ca3ef23a45b12e72a557f426be04e29804b1c510"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}