)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"18959ca285479abdc5dbcacb845049cbe5ca3710","unresolved":false,"context_lines":[{"line_number":11,"context_line":"check_package_update module which uses yum list to find available"},{"line_number":12,"context_line":"versions of a package."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint pre-upgrade-validations"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I19660980618fae318555401f5a7be01cb4d0ef2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf659307_541bd619","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":45},"updated":"2018-04-10 13:05:49.000000000","message":"Oh and this link doesn\u0027t seem to be working.","commit_id":"ad71af8eb66e327b8d4e14ca16f564f611130cb8"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"317b666adff984772fc405ad5f6fede04561f2e1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"check_package_update module which uses yum list to find available"},{"line_number":12,"context_line":"versions of a package."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements: blueprint pre-upgrade-validations"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I19660980618fae318555401f5a7be01cb4d0ef2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf659307_e0e0e199","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":45},"in_reply_to":"bf659307_541bd619","updated":"2018-04-12 15:37:09.000000000","message":"I think that\u0027s because the bp has been implemented since the patch was last updated. I\u0027ll remove the link.","commit_id":"ad71af8eb66e327b8d4e14ca16f564f611130cb8"}],"validations/check-latest-minor-version.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"712e0bb197aad7e4132822dfadbb435d9ad7cb22","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - name: Check if current version is latest minor"},{"line_number":20,"context_line":"    with_items: \"{{ updates.results }}\""},{"line_number":21,"context_line":"    assert:"},{"line_number":22,"context_line":"      that: \"item.latest_minor_version \u003d\u003d item.current_version or item.latest_minor_version \u003d\u003d None\""},{"line_number":23,"context_line":"      msg: \"A newer version of the {{ item.name }} is available package: {{ item.latest_minor_version }} (currently {{ item.current_version }}).\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f1a1f67_74d75dc1","line":22,"range":{"start_line":22,"start_character":63,"end_line":22,"end_character":98},"updated":"2017-07-13 08:42:38.000000000","message":"why would that happen? would it make more sense to push that check (if minor/major are none) to the https://review.openstack.org/#/c/476517/1/validations/library/check_package_update.py@65","commit_id":"5846594987a5fcde3a6a3e9b4aee2730d7d4509c"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"e6e0515131aeada29e873e93163ae9c022f90583","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - name: Check if current version is latest minor"},{"line_number":20,"context_line":"    with_items: \"{{ updates.results }}\""},{"line_number":21,"context_line":"    assert:"},{"line_number":22,"context_line":"      that: \"item.latest_minor_version \u003d\u003d item.current_version or item.latest_minor_version \u003d\u003d None\""},{"line_number":23,"context_line":"      msg: \"A newer version of the {{ item.name }} is available package: {{ item.latest_minor_version }} (currently {{ item.current_version }}).\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df3967d1_ca98be6b","line":22,"range":{"start_line":22,"start_character":63,"end_line":22,"end_character":98},"in_reply_to":"1f1a1f67_74d75dc1","updated":"2017-07-31 14:31:34.000000000","message":"Right. The module now assigns the current version as latest minor if nothing else can be found. So the None case will not occur any more.","commit_id":"5846594987a5fcde3a6a3e9b4aee2730d7d4509c"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"0f72990704d3c948257536ef2ba3a142776eee72","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    with_items: \"{{ updates.results }}\""},{"line_number":21,"context_line":"    assert:"},{"line_number":22,"context_line":"      that: \"item.latest_minor_version \u003d\u003d item.current_version\""},{"line_number":23,"context_line":"      msg: \"A newer version of the {{ item.name }} is available package: {{ item.latest_minor_version }} (currently {{ item.current_version }}).\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_0edd5113","line":23,"range":{"start_line":23,"start_character":64,"end_line":23,"end_character":71},"updated":"2018-04-10 12:33:39.000000000","message":"I think it reads a bit better if the word \"package\" comes before \"is available\".","commit_id":"ad71af8eb66e327b8d4e14ca16f564f611130cb8"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"317b666adff984772fc405ad5f6fede04561f2e1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    with_items: \"{{ updates.results }}\""},{"line_number":21,"context_line":"    assert:"},{"line_number":22,"context_line":"      that: \"item.latest_minor_version \u003d\u003d item.current_version\""},{"line_number":23,"context_line":"      msg: \"A newer version of the {{ item.name }} is available package: {{ item.latest_minor_version }} (currently {{ item.current_version }}).\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_60e371d9","line":23,"range":{"start_line":23,"start_character":64,"end_line":23,"end_character":71},"in_reply_to":"bf659307_0edd5113","updated":"2018-04-12 15:37:09.000000000","message":"Done","commit_id":"ad71af8eb66e327b8d4e14ca16f564f611130cb8"}],"validations/library/check_package_update.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"712e0bb197aad7e4132822dfadbb435d9ad7cb22","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    packages \u003d list([get_package_details(line) for line in output.split(\u0027\\n\u0027)"},{"line_number":68,"context_line":"                     if \u0027{i.name}.{i.arch}\u0027.format(i\u003dinstalled) in line])"},{"line_number":69,"context_line":"    # Get all packages with the same major version"},{"line_number":70,"context_line":"    minor \u003d sorted((p for p in packages"},{"line_number":71,"context_line":"                    if p.version[0] \u003d\u003d installed.version[0]))"},{"line_number":72,"context_line":"    if len(minor) \u003e 0:"},{"line_number":73,"context_line":"        latest_minor \u003d minor[-1].version"},{"line_number":74,"context_line":"    # Get all packages with the highest available major version"},{"line_number":75,"context_line":"    major \u003d sorted((p for p in packages"},{"line_number":76,"context_line":"                    if p.version[0] \u003e installed.version[0]))"},{"line_number":77,"context_line":"    if len(major) \u003e 0:"},{"line_number":78,"context_line":"        latest_major \u003d major[-1].version"},{"line_number":79,"context_line":"    return latest_minor, latest_major"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f1a1f67_f4cb6d1b","line":78,"range":{"start_line":70,"start_character":0,"end_line":78,"end_character":40},"updated":"2017-07-13 08:42:38.000000000","message":"i spent a while staring at this before noticing the difference was \u003d\u003d  vs \u003e \n\n:/","commit_id":"5846594987a5fcde3a6a3e9b4aee2730d7d4509c"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"e6e0515131aeada29e873e93163ae9c022f90583","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    packages \u003d list([get_package_details(line) for line in output.split(\u0027\\n\u0027)"},{"line_number":68,"context_line":"                     if \u0027{i.name}.{i.arch}\u0027.format(i\u003dinstalled) in line])"},{"line_number":69,"context_line":"    # Get all packages with the same major version"},{"line_number":70,"context_line":"    minor \u003d sorted((p for p in packages"},{"line_number":71,"context_line":"                    if p.version[0] \u003d\u003d installed.version[0]))"},{"line_number":72,"context_line":"    if len(minor) \u003e 0:"},{"line_number":73,"context_line":"        latest_minor \u003d minor[-1].version"},{"line_number":74,"context_line":"    # Get all packages with the highest available major version"},{"line_number":75,"context_line":"    major \u003d sorted((p for p in packages"},{"line_number":76,"context_line":"                    if p.version[0] \u003e installed.version[0]))"},{"line_number":77,"context_line":"    if len(major) \u003e 0:"},{"line_number":78,"context_line":"        latest_major \u003d major[-1].version"},{"line_number":79,"context_line":"    return latest_minor, latest_major"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_4a9e0e64","line":78,"range":{"start_line":70,"start_character":0,"end_line":78,"end_character":40},"in_reply_to":"1f1a1f67_f4cb6d1b","updated":"2017-07-31 14:31:34.000000000","message":"Do you think this should be changed? For now I added an emphasis in the comment...","commit_id":"5846594987a5fcde3a6a3e9b4aee2730d7d4509c"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"51c2607062e9ed9271a8f2bd04d9d22fabbb6b71","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    packages \u003d list([get_package_details(line) for line in output.split(\u0027\\n\u0027)"},{"line_number":68,"context_line":"                     if \u0027{i.name}.{i.arch}\u0027.format(i\u003dinstalled) in line])"},{"line_number":69,"context_line":"    # Get all packages with the same major version"},{"line_number":70,"context_line":"    minor \u003d sorted((p for p in packages"},{"line_number":71,"context_line":"                    if p.version[0] \u003d\u003d installed.version[0]))"},{"line_number":72,"context_line":"    if len(minor) \u003e 0:"},{"line_number":73,"context_line":"        latest_minor \u003d minor[-1].version"},{"line_number":74,"context_line":"    # Get all packages with the highest available major version"},{"line_number":75,"context_line":"    major \u003d sorted((p for p in packages"},{"line_number":76,"context_line":"                    if p.version[0] \u003e installed.version[0]))"},{"line_number":77,"context_line":"    if len(major) \u003e 0:"},{"line_number":78,"context_line":"        latest_major \u003d major[-1].version"},{"line_number":79,"context_line":"    return latest_minor, latest_major"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_fd1b3718","line":78,"range":{"start_line":70,"start_character":0,"end_line":78,"end_character":40},"in_reply_to":"df3967d1_4a9e0e64","updated":"2017-08-01 07:39:20.000000000","message":"thanks Florian, it was more in case it is helpful for anyone else looking and thanks for adding the comments which help imo (but that is in itself a controversial issue ;) - i mean addig comments like this )","commit_id":"5846594987a5fcde3a6a3e9b4aee2730d7d4509c"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"0f72990704d3c948257536ef2ba3a142776eee72","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    installed_stdout, installed_stderr \u003d _command("},{"line_number":119,"context_line":"        [pkg_mgr, \u0027list\u0027, \u0027installed\u0027, package])"},{"line_number":120,"context_line":"    # Fail the module if for some we can\u0027t lookup the current package."},{"line_number":121,"context_line":"    if installed_stderr !\u003d \u0027\u0027:"},{"line_number":122,"context_line":"        module.fail_json(msg\u003dinstalled_stderr)"},{"line_number":123,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_9112e057","line":120,"range":{"start_line":120,"start_character":33,"end_line":120,"end_character":34},"updated":"2018-04-10 12:33:39.000000000","message":"\"reason\" missing, I think?","commit_id":"ad71af8eb66e327b8d4e14ca16f564f611130cb8"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"317b666adff984772fc405ad5f6fede04561f2e1","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    installed_stdout, installed_stderr \u003d _command("},{"line_number":119,"context_line":"        [pkg_mgr, \u0027list\u0027, \u0027installed\u0027, package])"},{"line_number":120,"context_line":"    # Fail the module if for some we can\u0027t lookup the current package."},{"line_number":121,"context_line":"    if installed_stderr !\u003d \u0027\u0027:"},{"line_number":122,"context_line":"        module.fail_json(msg\u003dinstalled_stderr)"},{"line_number":123,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_6095b131","line":120,"range":{"start_line":120,"start_character":33,"end_line":120,"end_character":34},"in_reply_to":"bf659307_9112e057","updated":"2018-04-12 15:37:09.000000000","message":"Done","commit_id":"ad71af8eb66e327b8d4e14ca16f564f611130cb8"}]}