)]}'
{"tools/validate-files.py":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"10b065cb073d775814a64c945d59559942406870","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def validate_library_file(file_path):"},{"line_number":25,"context_line":"    with open(file_path) as f:"},{"line_number":26,"context_line":"        file_content \u003d f.read()"},{"line_number":27,"context_line":"        if \u0027DOCUMENTATION \u003d \u0027 not in file_content \\"},{"line_number":28,"context_line":"                or \u0027EXAMPLES \u003d \u0027 not in file_content:"},{"line_number":29,"context_line":"            if quiet \u003c 1:"},{"line_number":30,"context_line":"                print(\u0027Missing ansible documentation in %s\u0027 % file_path)"},{"line_number":31,"context_line":"            return 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_0dce872c","line":28,"range":{"start_line":27,"start_character":12,"end_line":28,"end_character":28},"updated":"2017-10-09 06:39:40.000000000","message":"assuming we\u0027re talking about the ones in tripleo-validations/validations/library/*.py (as in L63 below) most of the files in there will fail this (afaics only icmp_ping.py has these)\n\nso do we need to add these to all the others as well?","commit_id":"3b9d39b2e4a5f3e1e5c10c2dc000da8a5989ed9b"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"873f23fc13e96939fd5f0f13bf1f08d38d68d468","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def validate_library_file(file_path):"},{"line_number":25,"context_line":"    with open(file_path) as f:"},{"line_number":26,"context_line":"        file_content \u003d f.read()"},{"line_number":27,"context_line":"        if \u0027DOCUMENTATION \u003d \u0027 not in file_content \\"},{"line_number":28,"context_line":"                or \u0027EXAMPLES \u003d \u0027 not in file_content:"},{"line_number":29,"context_line":"            if quiet \u003c 1:"},{"line_number":30,"context_line":"                print(\u0027Missing ansible documentation in %s\u0027 % file_path)"},{"line_number":31,"context_line":"            return 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_5eb2e74a","line":28,"range":{"start_line":27,"start_character":12,"end_line":28,"end_character":28},"in_reply_to":"7f515b1d_0dce872c","updated":"2017-10-09 08:37:20.000000000","message":"We\u0027ve added the missing documentation in the parent commit I2792589728a198fa66e4110492efabcdd017d89a. This one makes sure we do not land a library without the needed documentation strings.","commit_id":"3b9d39b2e4a5f3e1e5c10c2dc000da8a5989ed9b"}]}