)]}'
{"validations/openshift-nw-requirements.yaml":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"971378b368218a660faa7c09716687971b34f4f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    metadata:"},{"line_number":5,"context_line":"      name: Check network requirements for an OpenShift deployment"},{"line_number":6,"context_line":"      description: |"},{"line_number":7,"context_line":"        Checks if an external network has been configured on the overcloud."},{"line_number":8,"context_line":"      groups:"},{"line_number":9,"context_line":"      - post-deployment"},{"line_number":10,"context_line":"      - openshift"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_5c400c05","line":7,"updated":"2018-07-25 09:00:14.000000000","message":"There are basically two ways to deploy OpenShift on OpenStack, the first one deploys openshift in a tenant\u0027s openstack (i.e. overcloud), the second one deploys openshift with tripleo, via the undercloud. The two alternatives don\u0027t have the same requirements.\n\nHere we\u0027re focussing on the case where openshift is deployed in the overcloud. It is not necessary bad, just something to keep in mind for later.","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"35356c08d0895065ce1ef1151a6d39bcf8946196","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    metadata:"},{"line_number":5,"context_line":"      name: Check network requirements for an OpenShift deployment"},{"line_number":6,"context_line":"      description: |"},{"line_number":7,"context_line":"        Checks if an external network has been configured on the overcloud."},{"line_number":8,"context_line":"      groups:"},{"line_number":9,"context_line":"      - post-deployment"},{"line_number":10,"context_line":"      - openshift"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_f06c8206","line":7,"in_reply_to":"5f7c97a3_5c400c05","updated":"2018-07-26 07:45:01.000000000","message":"I changed the name and the description to make it more obvious that this only covers the OS on top of OS use case.","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"971378b368218a660faa7c09716687971b34f4f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      description: |"},{"line_number":7,"context_line":"        Checks if an external network has been configured on the overcloud."},{"line_number":8,"context_line":"      groups:"},{"line_number":9,"context_line":"      - post-deployment"},{"line_number":10,"context_line":"      - openshift"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_fc4eb837","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":23},"updated":"2018-07-25 09:00:14.000000000","message":"AFAIK this will trigger the validation when calling the \u0027post-deployment\u0027 or \u0027openshift\u0027 groups.\nThe problem is, this validation is not relevant in \u0027post-deployment\u0027 unless you\u0027re deploying openshift. How do we ensure it doesn\u0027t run (or at least it doesn\u0027t report failure) in the general case?","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"35356c08d0895065ce1ef1151a6d39bcf8946196","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      description: |"},{"line_number":7,"context_line":"        Checks if an external network has been configured on the overcloud."},{"line_number":8,"context_line":"      groups:"},{"line_number":9,"context_line":"      - post-deployment"},{"line_number":10,"context_line":"      - openshift"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  tasks:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_b0760ad5","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":23},"in_reply_to":"5f7c97a3_fc4eb837","updated":"2018-07-26 07:45:01.000000000","message":"I removed the post-deployment group.","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"971378b368218a660faa7c09716687971b34f4f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        Checks if an external network has been configured on the overcloud."},{"line_number":8,"context_line":"      groups:"},{"line_number":9,"context_line":"      - post-deployment"},{"line_number":10,"context_line":"      - openshift"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  tasks:"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_1c4a9423","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":17},"updated":"2018-07-25 09:00:14.000000000","message":"Maybe we\u0027ll need to think about a way to differentiate between \"openshift on overcloud\" and \"openshift via tripleo\".","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"35356c08d0895065ce1ef1151a6d39bcf8946196","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        Checks if an external network has been configured on the overcloud."},{"line_number":8,"context_line":"      groups:"},{"line_number":9,"context_line":"      - post-deployment"},{"line_number":10,"context_line":"      - openshift"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  tasks:"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_1041fe63","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":17},"in_reply_to":"5f7c97a3_1c4a9423","updated":"2018-07-26 07:45:01.000000000","message":"Renamed to openshift-on-openstack","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"971378b368218a660faa7c09716687971b34f4f9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  tasks:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  # Get auth token and service catalog from Keystone and extract service urls."},{"line_number":15,"context_line":"  - name: Get token and catalog from Keystone"},{"line_number":16,"context_line":"    uri:"},{"line_number":17,"context_line":"      url: \"{{ overcloud_keystone_url"},{"line_number":18,"context_line":"               | urlsplit(\u0027scheme\u0027) }}://{{ overcloud_keystone_url"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_5cf9ec4c","line":15,"updated":"2018-07-25 09:00:14.000000000","message":"I can foresee this being used more than once, should it go into a shared library maybe?\n\nHave you also considered using shade to query the overcloud\u0027s services?","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"},{"author":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"change_message_id":"35356c08d0895065ce1ef1151a6d39bcf8946196","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  tasks:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  # Get auth token and service catalog from Keystone and extract service urls."},{"line_number":15,"context_line":"  - name: Get token and catalog from Keystone"},{"line_number":16,"context_line":"    uri:"},{"line_number":17,"context_line":"      url: \"{{ overcloud_keystone_url"},{"line_number":18,"context_line":"               | urlsplit(\u0027scheme\u0027) }}://{{ overcloud_keystone_url"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_b0fdaa0a","line":15,"in_reply_to":"5f7c97a3_5cf9ec4c","updated":"2018-07-26 07:45:01.000000000","message":"In an earlier revision I used the built-in os_* ansible modules (which are based on shade), but ran into issues with env variables that contained undercloud credentials and were auto-recognized by the os_* modules. \n\nI\u0027m not sure if this is an issue with shade or the os_* ansible modules, but it\u0027s sure worth exploring.\n\nHow about I investigate that further and the do one of the two in a follow-up patch: \n- switch to using shade\n- refactor this into code that can be shared.","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"9292d353fd5b0ce5c9cb11857f07b903f8ffc6f9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  tasks:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  # Get auth token and service catalog from Keystone and extract service urls."},{"line_number":15,"context_line":"  - name: Get token and catalog from Keystone"},{"line_number":16,"context_line":"    uri:"},{"line_number":17,"context_line":"      url: \"{{ overcloud_keystone_url"},{"line_number":18,"context_line":"               | urlsplit(\u0027scheme\u0027) }}://{{ overcloud_keystone_url"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_bb4a6b21","line":15,"in_reply_to":"5f7c97a3_b0fdaa0a","updated":"2018-07-26 07:56:48.000000000","message":"I see. Maybe there is a way to disable this behavior for shade as it\u0027s likely to cause trouble for tripleo in general when working with the overcloud.\n\nWhat you\u0027re suggesting sounds reasonable. Be sure to create a bug for the tech debt.","commit_id":"c352c36ae3006608916b419d0a8e21d52f7f4979"}]}