)]}'
{"id":"openstack%2Ftripleo-validations~627069","triplet_id":"openstack%2Ftripleo-validations~stable%2Frocky~Ieb38d974fbe2291a2cd3bb1a9d4df9cd971bd098","project":"openstack/tripleo-validations","branch":"stable/rocky","topic":"undercloud_conf","hashtags":[],"change_id":"Ieb38d974fbe2291a2cd3bb1a9d4df9cd971bd098","subject":"Fix dhcp-provisioning validation","status":"MERGED","created":"2018-12-23 10:43:32.000000000","updated":"2019-01-19 05:08:02.000000000","submitted":"2019-01-19 05:08:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"627069-1547874482780-eaa21e4c","meta_rev_id":"198992a0e7a2a999092f9061b81e556afb10009a","_number":627069,"virtual_id_number":627069,"owner":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-01-19 05:08:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-01-18 23:59:24.000000000","_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":2,"date":"2019-01-18 23:59:24.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-01-18 23:59:38.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-01-01 01:47:31.000000000","updated_by":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"reviewer":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"state":"REVIEWER"},{"updated":"2019-01-02 10:11:26.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-01-18 23:59:38.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-01-19 05:08:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"06e52ab3bca954c1ab4a435520390698a82d213d","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2018-12-23 10:43:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8dcdfb49d8fd0d5b91528fd9a358342e1373cee1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-12-23 12:56:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- noop noop : SUCCESS in 0s\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/69/627069/1/check/tripleo-ci-centos-7-containers-multinode/0512514/ : SUCCESS in 2h 06m 13s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/69/627069/1/check/tripleo-ci-centos-7-undercloud-containers/826f717/ : SUCCESS in 1h 26m 49s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/69/627069/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/ed6722e/ : SUCCESS in 2h 11m 51s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/69/627069/1/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/ffdcb18/ : SUCCESS in 1h 44m 16s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/69/627069/1/check/tripleo-ci-centos-7-standalone/5fd8859/ : SUCCESS in 1h 40m 07s\n- openstack-tox-pep8 http://logs.openstack.org/69/627069/1/check/openstack-tox-pep8/0743400/ : SUCCESS in 5m 06s\n- openstack-tox-py27 http://logs.openstack.org/69/627069/1/check/openstack-tox-py27/0c614db/ : SUCCESS in 5m 04s\n- openstack-tox-py35 http://logs.openstack.org/69/627069/1/check/openstack-tox-py35/0bcca8e/ : SUCCESS in 4m 26s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/627069/1/check/build-openstack-sphinx-docs/c620b32/html/ : SUCCESS in 4m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/627069/1/check/openstack-tox-lower-constraints/dc63f2c/ : SUCCESS in 4m 25s","accounts_in_message":[],"_revision_number":1},{"id":"24be297eb10c2fb5bd3d66557cc8bfa72e21139b","author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"date":"2019-01-01 01:47:31.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8c99ef06656cd926780f76dc40e06714324dabe7","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-01-02 10:11:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"496d37fb40c14c3012156a6355de41a635883ea4","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-01-18 23:59:24.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"d756525142a1461f235e6ae32c1c882d2391853a","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-01-18 23:59:38.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6288ba0cd7fa548da27f3aa83ac024ea094a7a85","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-19 02:32:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/69/627069/2/check/tripleo-ci-centos-7-containers-multinode/3c1eca7/ : SUCCESS in 2h 12m 11s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/69/627069/2/check/tripleo-ci-centos-7-undercloud-containers/22c63a2/ : SUCCESS in 1h 35m 15s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/69/627069/2/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/b49c637/ : SUCCESS in 2h 30m 09s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/69/627069/2/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/1f2ca82/ : FAILURE in 1h 55m 48s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/69/627069/2/check/tripleo-ci-centos-7-standalone/853bdc9/ : SUCCESS in 1h 50m 50s\n- openstack-tox-pep8 http://logs.openstack.org/69/627069/2/check/openstack-tox-pep8/7470acc/ : SUCCESS in 6m 07s\n- openstack-tox-py27 http://logs.openstack.org/69/627069/2/check/openstack-tox-py27/c4bae73/ : SUCCESS in 5m 28s\n- openstack-tox-py35 http://logs.openstack.org/69/627069/2/check/openstack-tox-py35/19e4934/ : SUCCESS in 5m 28s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/627069/2/check/build-openstack-sphinx-docs/77964fb/html/ : SUCCESS in 5m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/627069/2/check/openstack-tox-lower-constraints/4e042c3/ : SUCCESS in 4m 41s","accounts_in_message":[],"_revision_number":2},{"id":"f9425d41f5331a5de7abec3d7bb4e61fe8cdf29d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-19 02:32:29.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"43a09432a0264137594e9d979d94021b991e920c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-19 05:08:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"dff7cdbc772906a17a511d4562f624a4aa8ff004","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-01-19 05:08:02.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/69/627069/2/gate/tripleo-ci-centos-7-containers-multinode/a4a2817/ : SUCCESS in 2h 06m 43s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/69/627069/2/gate/tripleo-ci-centos-7-standalone/72f5d35/ : SUCCESS in 1h 59m 26s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/69/627069/2/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/754c43a/ : SUCCESS in 2h 06m 00s\n- openstack-tox-pep8 http://logs.openstack.org/69/627069/2/gate/openstack-tox-pep8/87b6317/ : SUCCESS in 6m 17s\n- openstack-tox-py27 http://logs.openstack.org/69/627069/2/gate/openstack-tox-py27/927b6db/ : SUCCESS in 4m 26s\n- openstack-tox-py35 http://logs.openstack.org/69/627069/2/gate/openstack-tox-py35/97394fa/ : SUCCESS in 4m 36s\n- build-openstack-sphinx-docs http://logs.openstack.org/69/627069/2/gate/build-openstack-sphinx-docs/0974e70/html/ : SUCCESS in 4m 02s\n- openstack-tox-lower-constraints http://logs.openstack.org/69/627069/2/gate/openstack-tox-lower-constraints/08018bf/ : SUCCESS in 5m 35s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b3785166e966af8f663c6a540f702467673321fe","revisions":{"c6022435264e8f326dfa153c3d34cc5069ed8e88":{"kind":"REWORK","_number":1,"created":"2018-12-23 10:43:32.000000000","uploader":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"ref":"refs/changes/69/627069/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/69/627069/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/69/627069/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/69/627069/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/69/627069/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/69/627069/1"}}},"commit":{"parents":[{"commit":"8330dd7eb81e4e8f8af1088e43f84a9655a7cb83","subject":"Fix check-network-gateway validation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/8330dd7eb81e4e8f8af1088e43f84a9655a7cb83"}]}],"author":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2018-12-18 09:34:15.000000000","tz":60},"committer":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2018-12-23 10:42:34.000000000","tz":60},"subject":"Fix dhcp-provisioning validation","message":"Fix dhcp-provisioning validation\n\nThe `undercloud.conf` file has now 2 sections (DEFAULT and ctlplane-subnet).\nA small numbers of parameters have been deprecated and moved to the\nctlplane-subnet section. Morever, the `undercloud_conf` custom plugin has some\nissues to generate facts coming from the \u0027undercloud.conf\u0027 file due to the new\nsection.\n\nThis patch proposes to use the \u0027ini\u0027 custom plugin to get parameter\u0027s\nvalues from the undercloud.conf file instead of using the \u0027undercloud_conf\u0027\ncustom plugin.\n\nChange-Id: Ieb38d974fbe2291a2cd3bb1a9d4df9cd971bd098\nSigned-off-by: Gael Chamoulaud \u003cgchamoul@redhat.com\u003e\n(cherry picked from commit e69d6045a4d3ea130f193be365d00356be3e2d2e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/c6022435264e8f326dfa153c3d34cc5069ed8e88"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/c6022435264e8f326dfa153c3d34cc5069ed8e88"}]},"branch":"refs/heads/stable/rocky"},"b3785166e966af8f663c6a540f702467673321fe":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-01-18 23:59:24.000000000","uploader":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"ref":"refs/changes/69/627069/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/69/627069/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/69/627069/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/69/627069/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/69/627069/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/69/627069/2"}}},"commit":{"parents":[{"commit":"25d0d1f3bf7594319fa5bbd28a0515085cd3cad6","subject":"Merge \"Fix overcloud neutron sanity validation\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/25d0d1f3bf7594319fa5bbd28a0515085cd3cad6"}]}],"author":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2018-12-18 09:34:15.000000000","tz":60},"committer":{"name":"Alex Schultz","email":"aschultz@redhat.com","date":"2019-01-18 23:59:24.000000000","tz":0},"subject":"Fix dhcp-provisioning validation","message":"Fix dhcp-provisioning validation\n\nThe `undercloud.conf` file has now 2 sections (DEFAULT and ctlplane-subnet).\nA small numbers of parameters have been deprecated and moved to the\nctlplane-subnet section. Morever, the `undercloud_conf` custom plugin has some\nissues to generate facts coming from the \u0027undercloud.conf\u0027 file due to the new\nsection.\n\nThis patch proposes to use the \u0027ini\u0027 custom plugin to get parameter\u0027s\nvalues from the undercloud.conf file instead of using the \u0027undercloud_conf\u0027\ncustom plugin.\n\nChange-Id: Ieb38d974fbe2291a2cd3bb1a9d4df9cd971bd098\nSigned-off-by: Gael Chamoulaud \u003cgchamoul@redhat.com\u003e\n(cherry picked from commit e69d6045a4d3ea130f193be365d00356be3e2d2e)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/b3785166e966af8f663c6a540f702467673321fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/b3785166e966af8f663c6a540f702467673321fe"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}