)]}'
{"scripts/tripleo-ansible-inventory":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"567b60e2948fe8e19208ae7dae1982fd977f776f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        ansible_ssh_user\u003dconfigs.ansible_ssh_user,"},{"line_number":141,"context_line":"        plan_name\u003dconfigs.stack or configs.plan,"},{"line_number":142,"context_line":"        ansible_python_interpreter\u003dconfigs.ansible_python_interpreter,"},{"line_number":143,"context_line":"        undercloud_connection\u003dconfigs.undercloud_connection,"},{"line_number":144,"context_line":"        serial\u003dconfigs.serial)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    if configs.list:"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_51c91577","line":143,"updated":"2019-08-23 11:33:26.000000000","message":"Until the local vs ssh default is resolve I think that this line should go into\ninto https://review.opendev.org/#/c/676415/ which will then be called something\nlike \"add missing options to tripleo-ansible-inventory. The concern in that review\nis that we need thoses option to be able to run ansible commands during update/upgrade\nlike it\u0027s done during deployment.  Let\u0027s separate the two concerns. WDYT?","commit_id":"e5c8231c61796d6907d7361e146ef66479539035"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"349743ac18c3620c4f768c564c34c2b1a846aefe","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        ansible_ssh_user\u003dconfigs.ansible_ssh_user,"},{"line_number":141,"context_line":"        plan_name\u003dconfigs.stack or configs.plan,"},{"line_number":142,"context_line":"        ansible_python_interpreter\u003dconfigs.ansible_python_interpreter,"},{"line_number":143,"context_line":"        undercloud_connection\u003dconfigs.undercloud_connection,"},{"line_number":144,"context_line":"        serial\u003dconfigs.serial)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    if configs.list:"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"7faddb67_0cba896d","line":143,"in_reply_to":"7faddb67_51c91577","updated":"2019-08-26 10:22:03.000000000","message":"That\u0027s a good suggestion, indeed. I\u0027m going to give it a try.","commit_id":"e5c8231c61796d6907d7361e146ef66479539035"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"3f6e74c1bc1d5262ee4b652068697556b8ac37a8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                              \u0027will take precedence.\u0027)),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027ansible_ssh_user\u0027, default\u003dos.environ.get(\u0027ANSIBLE_SSH_USER\u0027,"},{"line_number":56,"context_line":"               \u0027heat-admin\u0027)),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027undercloud-connection\u0027,"},{"line_number":58,"context_line":"               default\u003dinv.UNDERCLOUD_CONNECTION_LOCAL,"},{"line_number":59,"context_line":"               help\u003d(\u0027Ansible connection to the undercloud, either \"local\" \u0027"},{"line_number":60,"context_line":"                     \u0027or \"ssh\". Defaults to \"local\".\u0027)),"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7faddb67_89d86bf0","line":57,"updated":"2019-08-29 09:27:12.000000000","message":"\"leave it as it is\", you mean SSH ?  Given the default in the tripleo-common/inventory.py I would have the same here as well for consistency, so it\u0027s +2 for me.","commit_id":"d253d52f3fb7674dfe7b2b63004aba85a9b561b3"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"343c44ba0a3a4ff895e06abcfe1f4aaddc892736","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                              \u0027will take precedence.\u0027)),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027ansible_ssh_user\u0027, default\u003dos.environ.get(\u0027ANSIBLE_SSH_USER\u0027,"},{"line_number":56,"context_line":"               \u0027heat-admin\u0027)),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027undercloud-connection\u0027,"},{"line_number":58,"context_line":"               default\u003dinv.UNDERCLOUD_CONNECTION_LOCAL,"},{"line_number":59,"context_line":"               help\u003d(\u0027Ansible connection to the undercloud, either \"local\" \u0027"},{"line_number":60,"context_line":"                     \u0027or \"ssh\". Defaults to \"local\".\u0027)),"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7faddb67_a6431411","line":57,"updated":"2019-08-29 07:49:02.000000000","message":"Up to know, the default value has been local and it did not impact in other operations. Every time we need it to be ssh it\u0027s already properly defined in the right place. Besides, the default value in TripleoInventory is also local https://github.com/openstack/tripleo-common/blob/master/tripleo_common/inventory.py#L95 . Imho, the right thing is to leave it as it is.","commit_id":"d253d52f3fb7674dfe7b2b63004aba85a9b561b3"}]}