)]}'
{"playbooks/service-status.yaml":[{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"87d21b455c342e69827db38c43eb9e239fa84551","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        a failed service."},{"line_number":9,"context_line":"      groups:"},{"line_number":10,"context_line":"        - prep"},{"line_number":11,"context_line":"        - pre-deployment"},{"line_number":12,"context_line":"        - pre-upgrade"},{"line_number":13,"context_line":"        - post-deployment"},{"line_number":14,"context_line":"        - post-upgrade"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_2fe4d7ab","line":11,"updated":"2019-07-29 16:58:38.000000000","message":"I guess that even though we don\u0027t have the system deployed this validation could be helpful too at this stage.","commit_id":"1265e2f6675b95bf7487fe041066d8de3164e39e"}],"roles/service-status/tasks/main.yaml":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"94575e466314569eaf598b57af3b7a0c15537bcc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- name: Fails if we find failed units"},{"line_number":8,"context_line":"  assert:"},{"line_number":9,"context_line":"    that:"},{"line_number":10,"context_line":"      - sstemd_status.stdout_lines|length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffb9cba7_113d2edc","line":10,"updated":"2019-05-02 15:01:56.000000000","message":"typo here s/sstemd_status/systemd_status/","commit_id":"96216ec19fceab6985a2958fb39abf29597b37c8"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"d17a5a75a6c3957c5db30cec6d51ff9a4a3dce58","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- name: Fails if we find failed units"},{"line_number":8,"context_line":"  assert:"},{"line_number":9,"context_line":"    that:"},{"line_number":10,"context_line":"      - sstemd_status.stdout_lines|length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_8990d997","line":10,"in_reply_to":"ffb9cba7_113d2edc","updated":"2019-05-02 15:12:04.000000000","message":"duh... I was high while typing (at about 11\u0027000m high to be precise ;))","commit_id":"96216ec19fceab6985a2958fb39abf29597b37c8"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"e97503333f7820dc0ae9fbb0a544ac9602c1f00a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: get failed systemd units"},{"line_number":3,"context_line":"  shell: \u003e"},{"line_number":4,"context_line":"    systemctl list-units --failed --plain --no-legend --no-pager"},{"line_number":5,"context_line":"  register: systemd_status"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Fails if we find failed units"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_ce2e5842","line":4,"updated":"2019-05-10 12:53:50.000000000","message":"Could we just check units related to Openstack/TripleO components instead of being global ?","commit_id":"3b4afa60d7b1253d24905656ff377336f978d9b7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2e84ae2284327f58d30dcb1ba059ad5789b01230","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: get failed systemd units"},{"line_number":3,"context_line":"  shell: \u003e"},{"line_number":4,"context_line":"    systemctl list-units --failed --plain --no-legend --no-pager"},{"line_number":5,"context_line":"  register: systemd_status"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Fails if we find failed units"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_53867968","line":4,"in_reply_to":"dfbec78f_ce2e5842","updated":"2019-05-13 07:23:10.000000000","message":"Why? most of the services are managed within tripleo anyway. Using a list would make it less useful, and using some patter will lead to some other issues, like new services not having the same pattern.","commit_id":"3b4afa60d7b1253d24905656ff377336f978d9b7"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"e97503333f7820dc0ae9fbb0a544ac9602c1f00a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- name: Fails if we find failed units"},{"line_number":8,"context_line":"  assert:"},{"line_number":9,"context_line":"    that:"},{"line_number":10,"context_line":"      - systemd_status.stdout_lines|length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_ee31dca3","line":10,"updated":"2019-05-10 12:53:50.000000000","message":"If you want to use the assert module, it would be better to add fail_msg (listing all the failed units) and/or success_msg (just for saying something positive here ;-).\nOtherwise, we won\u0027t have any interesting informations while using the custom callback plugin (validations_output.py) used by Mistral by default.\n\nTask \u0027service-status :  Fails if we find failed units\u0027 failed:\nHost: undercloud\nMessage: Assertion failed\n\nFailure! The validation failed for all hosts:\n* undercloud","commit_id":"3b4afa60d7b1253d24905656ff377336f978d9b7"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"2e84ae2284327f58d30dcb1ba059ad5789b01230","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- name: Fails if we find failed units"},{"line_number":8,"context_line":"  assert:"},{"line_number":9,"context_line":"    that:"},{"line_number":10,"context_line":"      - systemd_status.stdout_lines|length \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dfbec78f_738b7d6d","line":10,"in_reply_to":"dfbec78f_ee31dca3","updated":"2019-05-13 07:23:10.000000000","message":"right, will correct that.","commit_id":"3b4afa60d7b1253d24905656ff377336f978d9b7"}]}