)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"0e9d6c6d9ade7c03bc42c91fc5a7571cc76463a0","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ceph-ansible deployed ceph will not benefit from hiera data so"},{"line_number":13,"context_line":"remove task to get it from the enabled_services list and instead"},{"line_number":14,"context_line":"assume a ceph_mon is deployed because the inflight-validations"},{"line_number":15,"context_line":"will call it only for the appropriate node. We will also worry"},{"line_number":16,"context_line":"about identifying the correct node by using delegate_to"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_7a21814d","line":14,"updated":"2019-05-05 13:17:57.000000000","message":"Every validations should be run manually through the Ansible CLI or Mistral so if you remove this task it will fail every time it runs on the deployment without Ceph installed. This will allow the validation to normally run and succeed if this is the case.","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7caddc55d836d275b1c0d2ff2f0eb07d1c069e10","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ceph-ansible deployed ceph will not benefit from hiera data so"},{"line_number":13,"context_line":"remove task to get it from the enabled_services list and instead"},{"line_number":14,"context_line":"assume a ceph_mon is deployed because the inflight-validations"},{"line_number":15,"context_line":"will call it only for the appropriate node. We will also worry"},{"line_number":16,"context_line":"about identifying the correct node by using delegate_to"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_8ee99681","line":14,"in_reply_to":"dfbec78f_7a21814d","updated":"2019-05-05 18:11:28.000000000","message":"Thanks for pointing that out. I agree we can\u0027t break validations. \n\nI was hoping to get this working without hiera. Perhaps basing the test on if the inventory contains a ceph mon is an alternative.","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"}],"roles/ceph/tasks/ceph-health.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"825b53980afe401ce89d94a887be1cd32eefd1ad","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get ceph health"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  shell: {{ container_binary }} exec ceph-mon-{{ ansible_hostname }} ceph health | awk \u0027{print $1}\u0027"},{"line_number":5,"context_line":"  register: ceph_health"},{"line_number":6,"context_line":"  # This is a hack, I need a way to delegate to a host with a ceph-mon"},{"line_number":7,"context_line":"  # This is what I would use with a ceph-ansible inventory"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_8bcd0d5f","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":28},"updated":"2019-05-04 23:45:51.000000000","message":"you might want to check how the mysql validation finds the correct \"container\" binary:\nhttps://github.com/openstack/tripleo-validations/blob/master/roles/mysql-open-files-limit/tasks/main.yml#L2-L4","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7caddc55d836d275b1c0d2ff2f0eb07d1c069e10","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Get ceph health"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  shell: {{ container_binary }} exec ceph-mon-{{ ansible_hostname }} ceph health | awk \u0027{print $1}\u0027"},{"line_number":5,"context_line":"  register: ceph_health"},{"line_number":6,"context_line":"  # This is a hack, I need a way to delegate to a host with a ceph-mon"},{"line_number":7,"context_line":"  # This is what I would use with a ceph-ansible inventory"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_ae71fae2","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":28},"in_reply_to":"dfbec78f_8bcd0d5f","updated":"2019-05-05 18:11:28.000000000","message":"thanks.","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"825b53980afe401ce89d94a887be1cd32eefd1ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # This is a hack, I need a way to delegate to a host with a ceph-mon"},{"line_number":7,"context_line":"  # This is what I would use with a ceph-ansible inventory"},{"line_number":8,"context_line":"  # delegate_to: \"{{ groups[mon_group_name][0] }}\""},{"line_number":9,"context_line":"  delegate_to: overcloud-controller-0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_cbeb05ae","line":9,"updated":"2019-05-04 23:45:51.000000000","message":"is this ceph-ansible inventory different from the dynamic inventory we already have? Care to give some pointer on that?","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"e4b5dadb7f4bb389df5c3820fb920732aba77da6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # This is a hack, I need a way to delegate to a host with a ceph-mon"},{"line_number":7,"context_line":"  # This is what I would use with a ceph-ansible inventory"},{"line_number":8,"context_line":"  # delegate_to: \"{{ groups[mon_group_name][0] }}\""},{"line_number":9,"context_line":"  delegate_to: overcloud-controller-0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_e09bed6f","line":9,"in_reply_to":"dfbec78f_bab139e4","updated":"2019-05-14 21:14:56.000000000","message":"\u003e The ceph-health playbook is already targeting the Controllers\n \u003e group. So Ansible will execute those tasks on the Overcloud\n \u003e Controllers. No need to use the \u0027delegate_to\u0027 IMHO here as we\n \u003e should have the information from the tripleo-ansible-inventory.","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7caddc55d836d275b1c0d2ff2f0eb07d1c069e10","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # This is a hack, I need a way to delegate to a host with a ceph-mon"},{"line_number":7,"context_line":"  # This is what I would use with a ceph-ansible inventory"},{"line_number":8,"context_line":"  # delegate_to: \"{{ groups[mon_group_name][0] }}\""},{"line_number":9,"context_line":"  delegate_to: overcloud-controller-0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_2ee18a9b","line":9,"in_reply_to":"dfbec78f_bab139e4","updated":"2019-05-05 18:11:28.000000000","message":"OK, I\u0027ve removed the delegate_to for now but what about solving the issue below though in a follow up patch?\n\nIt\u0027s going to need to run the task on one of the monitors wherever OS::TripleO::Services::CephMon [1] service is composed. Assuming I do the tripleo inventory updates (in my comment above) and have a good way to refer to one of the monitors won\u0027t I want the delegate_to one of those mons since always running this on Controllers won\u0027t cover all cases.? E.g. we have edge and multi-ceph architectures where the Mons run on the HCI nodes [2]. I don\u0027t think we can merge [3] until that\u0027s addressed.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/roles_data.yaml#L56\n\n[2] https://github.com/openstack/tripleo-heat-templates/blob/master/roles/HciCephMon.yaml\n\n[3] https://review.opendev.org/#/c/657175/","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"0e9d6c6d9ade7c03bc42c91fc5a7571cc76463a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # This is a hack, I need a way to delegate to a host with a ceph-mon"},{"line_number":7,"context_line":"  # This is what I would use with a ceph-ansible inventory"},{"line_number":8,"context_line":"  # delegate_to: \"{{ groups[mon_group_name][0] }}\""},{"line_number":9,"context_line":"  delegate_to: overcloud-controller-0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_bab139e4","line":9,"in_reply_to":"dfbec78f_cbeb05ae","updated":"2019-05-05 13:17:57.000000000","message":"The ceph-health playbook is already targeting the Controllers group. So Ansible will execute those tasks on the Overcloud Controllers. No need to use the \u0027delegate_to\u0027 IMHO here as we should have the information from the tripleo-ansible-inventory.","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7caddc55d836d275b1c0d2ff2f0eb07d1c069e10","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # This is a hack, I need a way to delegate to a host with a ceph-mon"},{"line_number":7,"context_line":"  # This is what I would use with a ceph-ansible inventory"},{"line_number":8,"context_line":"  # delegate_to: \"{{ groups[mon_group_name][0] }}\""},{"line_number":9,"context_line":"  delegate_to: overcloud-controller-0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_6e52226a","line":9,"in_reply_to":"dfbec78f_cbeb05ae","updated":"2019-05-05 18:11:28.000000000","message":"Yes, it is [1]. However for this cycle I think it would be nice to add additional groups for ceph (e.g. ceph ansible expects mons, osds, etc) to the existing inventory generation instead of relying on a separate inventory.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ceph-ansible/ceph-base.yaml#L408","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"825b53980afe401ce89d94a887be1cd32eefd1ad","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"},{"line_number":13,"context_line":"    msg: Ceph is in {{ ceph_health.stdout }} state."},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - ceph_health.stdout !\u003d \u0027HEALTH_OK\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_4bd715ef","line":13,"updated":"2019-05-04 23:45:51.000000000","message":"maybe provide a bit more information, as a way to understand the state. IIUC, it\u0027s not fatal? Really never fatal?","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7caddc55d836d275b1c0d2ff2f0eb07d1c069e10","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"},{"line_number":13,"context_line":"    msg: Ceph is in {{ ceph_health.stdout }} state."},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - ceph_health.stdout !\u003d \u0027HEALTH_OK\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_ee1e126f","line":13,"in_reply_to":"dfbec78f_4bd715ef","updated":"2019-05-05 18:11:28.000000000","message":"One thing I don\u0027t understand about validations is what happens with the warnings. Does it print and continue OR does it stop the deployment?","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"0e9d6c6d9ade7c03bc42c91fc5a7571cc76463a0","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"},{"line_number":13,"context_line":"    msg: Ceph is in {{ ceph_health.stdout }} state."},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - ceph_health.stdout !\u003d \u0027HEALTH_OK\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_fab7b1d7","line":13,"in_reply_to":"dfbec78f_4bd715ef","updated":"2019-05-05 13:17:57.000000000","message":"To be more precise on possible issues, we need to trick the command we use in the \u0027Get ceph health\u0027 task above. Otherwise, we won\u0027t have more details than [HEALTH_OK|HEALTH_WARN] as a result.","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7caddc55d836d275b1c0d2ff2f0eb07d1c069e10","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Check ceph health"},{"line_number":12,"context_line":"  warn:"},{"line_number":13,"context_line":"    msg: Ceph is in {{ ceph_health.stdout }} state."},{"line_number":14,"context_line":"  when:"},{"line_number":15,"context_line":"    - ceph_health.stdout !\u003d \u0027HEALTH_OK\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfbec78f_4e24fec6","line":13,"in_reply_to":"dfbec78f_fab7b1d7","updated":"2019-05-05 18:11:28.000000000","message":"I  was thinking we\u0027d get a variable we can do branch logic on instead of multi-line text to give the user information. If Health is OK, then the validation doesn\u0027t need to stop anything. \n\nIf we want to display more info, then after we can add a \u0027ceph -s\u0027 to get the user a nice overview of the ceph cluster. Note that ceph-ansible already does this at the end of it\u0027s run for deployment.","commit_id":"d6ab18b6ed30c55f8113fe20238b764a32a0aa01"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"02d96e8dc2a158291ff06196b16baa37a19fe6e0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - name: Set container_cli fact from the inventory"},{"line_number":11,"context_line":"    set_fact:"},{"line_number":12,"context_line":"      container_cli: \"{{ hostvars[inventory_hostname].container_cli }}\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  - name: Get ceph health"},{"line_number":15,"context_line":"    become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfbec78f_250e608d","line":12,"updated":"2019-05-08 12:08:31.000000000","message":"This line is not working.\n\nhttp://logs.openstack.org/75/657175/2/check/tripleo-ci-centos-7-scenario001-standalone/ccfcd82/logs/undercloud/home/zuul/undercloud-ansible-6x9naj/ansible.log.txt.gz#_2019-05-05_19_40_39_100","commit_id":"a5f581f1fc94cde3bb8067a788620090141ee89e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"f5a4789164b832d79ff92296fe14f57ea768f47c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- block:"},{"line_number":10,"context_line":"  - name: Set container_cli fact from the inventory"},{"line_number":11,"context_line":"    set_fact:"},{"line_number":12,"context_line":"      container_cli: \"{{ hostvars[inventory_hostname].container_cli }}\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  - name: Get ceph health"},{"line_number":15,"context_line":"    become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfb3d3c7_151b6f1b","line":12,"in_reply_to":"dfbec78f_250e608d","updated":"2019-05-20 17:02:22.000000000","message":"I think this change will get it working. Let\u0027s see.\n\nhttps://review.opendev.org/#/c/657175/4/deployment/ceph-ansible/ceph-base.yaml@683","commit_id":"a5f581f1fc94cde3bb8067a788620090141ee89e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"dde039c3c9e5f6fb1f5499e30af4e4bbda829aef","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  - name: Get ceph health"},{"line_number":15,"context_line":"    become: true"},{"line_number":16,"context_line":"    shell: \"{{ container_cli }} exec ceph-mon-{{ ansible_hostname }} ceph health | awk \u0027{print $1}\u0027\""},{"line_number":17,"context_line":"    register: ceph_health"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  - name: Check ceph health"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dfbec78f_d1fe5304","line":16,"updated":"2019-05-05 18:19:43.000000000","message":"quotes\n\nhttp://logs.openstack.org/75/657175/1/check/tripleo-ci-centos-7-scenario001-standalone/8bb9d9f/logs/undercloud/home/zuul/undercloud-ansible-EdgEGC/ansible.log.txt.gz#_2019-05-05_01_03_44_121","commit_id":"a5f581f1fc94cde3bb8067a788620090141ee89e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"7e17f17a2868abe80d483d24445a480deaa50b43","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Set container filter format"},{"line_number":14,"context_line":"  set_fact:"},{"line_number":15,"context_line":"    container_filter_format: !unsafe \"--format \u0027{{ .Names }}\u0027\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Set ceph_mon_container name"},{"line_number":18,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_ac34ab4b","line":15,"range":{"start_line":15,"start_character":48,"end_line":15,"end_character":60},"updated":"2019-06-04 01:45:53.000000000","message":"added this for the tox ansible-linter\n\nroles/ceph/tasks/ceph-health.yaml:15: [E206] Variables should have spaces before and after: {{ var_name }}\n\nEven though it\u0027s not an ansible variable but a podman filter. I\u0027d think !unsafe should cover that.","commit_id":"ce6141673ae3fa743ffd4f4d59dc0603a7597b98"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"01af1bceb53d6f1389a586ed5de1887d95d1299c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  shell: hiera -c /etc/puppet/hiera.yaml enabled_services | egrep -sq ceph_mon"},{"line_number":5,"context_line":"  ignore_errors: true"},{"line_number":6,"context_line":"  register: ceph_mon_enabled"},{"line_number":7,"context_line":"  changed_when: False"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Set container_cli fact from the inventory"},{"line_number":10,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_233c13be","line":7,"updated":"2019-06-06 10:50:45.000000000","message":"If Ceph isn\u0027t deployed, this validation should stop gracefully here by adding:\n\n- name: End play if ceph_mon is not enabled\n  meta: end_play\n  when: ceph_mon_enabled is not succeeded","commit_id":"47bca50da323734cb718bcde7500b8208900afad"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"fc760342b13a3cd86282279ce134c7a453faa4e3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  shell: hiera -c /etc/puppet/hiera.yaml enabled_services | egrep -sq ceph_mon"},{"line_number":5,"context_line":"  ignore_errors: true"},{"line_number":6,"context_line":"  register: ceph_mon_enabled"},{"line_number":7,"context_line":"  changed_when: False"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Set container_cli fact from the inventory"},{"line_number":10,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_23507c32","line":7,"in_reply_to":"9fb8cfa7_233c13be","updated":"2019-06-07 13:12:23.000000000","message":"Done","commit_id":"47bca50da323734cb718bcde7500b8208900afad"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"b8d96f353a41a7dccff65dc2cc28bd033a6fe7dc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  register: ceph_mon_container"},{"line_number":22,"context_line":"  changed_when: False"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- block:"},{"line_number":25,"context_line":"  - name: Get ceph health"},{"line_number":26,"context_line":"    become: true"},{"line_number":27,"context_line":"    shell: \"{{ container_cli }} exec {{ ceph_mon_container.stdout }} ceph health | awk \u0027{print $1}\u0027\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_c391779b","line":24,"updated":"2019-06-06 10:56:19.000000000","message":"Could you please put the condition(s) first before the block for readibility:\n\n- when:\n    - ceph_mon_enabled is succeeded\n    - ceph_mon_container is succeeded\n  block:\n    - name: ..\n      ...","commit_id":"47bca50da323734cb718bcde7500b8208900afad"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"fc760342b13a3cd86282279ce134c7a453faa4e3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  register: ceph_mon_container"},{"line_number":22,"context_line":"  changed_when: False"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- block:"},{"line_number":25,"context_line":"  - name: Get ceph health"},{"line_number":26,"context_line":"    become: true"},{"line_number":27,"context_line":"    shell: \"{{ container_cli }} exec {{ ceph_mon_container.stdout }} ceph health | awk \u0027{print $1}\u0027\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_e349048b","line":24,"in_reply_to":"9fb8cfa7_c391779b","updated":"2019-06-07 13:12:23.000000000","message":"Done","commit_id":"47bca50da323734cb718bcde7500b8208900afad"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"b8d96f353a41a7dccff65dc2cc28bd033a6fe7dc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  - name: Get ceph health"},{"line_number":26,"context_line":"    become: true"},{"line_number":27,"context_line":"    shell: \"{{ container_cli }} exec {{ ceph_mon_container.stdout }} ceph health | awk \u0027{print $1}\u0027\""},{"line_number":28,"context_line":"    register: ceph_health"},{"line_number":29,"context_line":"  - name: Check ceph health"},{"line_number":30,"context_line":"    warn:"},{"line_number":31,"context_line":"      msg: Ceph is in {{ ceph_health.stdout }} state."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_e38cbb80","line":28,"updated":"2019-06-06 10:56:19.000000000","message":"Could you please add one blank line between the tasks?","commit_id":"47bca50da323734cb718bcde7500b8208900afad"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"fc760342b13a3cd86282279ce134c7a453faa4e3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  - name: Get ceph health"},{"line_number":26,"context_line":"    become: true"},{"line_number":27,"context_line":"    shell: \"{{ container_cli }} exec {{ ceph_mon_container.stdout }} ceph health | awk \u0027{print $1}\u0027\""},{"line_number":28,"context_line":"    register: ceph_health"},{"line_number":29,"context_line":"  - name: Check ceph health"},{"line_number":30,"context_line":"    warn:"},{"line_number":31,"context_line":"      msg: Ceph is in {{ ceph_health.stdout }} state."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_83604803","line":28,"in_reply_to":"9fb8cfa7_e38cbb80","updated":"2019-06-07 13:12:23.000000000","message":"Done","commit_id":"47bca50da323734cb718bcde7500b8208900afad"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"b8d96f353a41a7dccff65dc2cc28bd033a6fe7dc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - ceph_mon_enabled is succeeded"},{"line_number":43,"context_line":"    - ceph_mon_container is succeeded"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- block:"},{"line_number":46,"context_line":"  - name: set jq osd percentage filter"},{"line_number":47,"context_line":"    set_fact:"},{"line_number":48,"context_line":"      jq_osd_percentage_filter: \u0027( (.num_in_osds) / (.num_osds) ) * 100\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_83e93f1b","line":45,"updated":"2019-06-06 10:56:19.000000000","message":"Same here.","commit_id":"47bca50da323734cb718bcde7500b8208900afad"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"fc760342b13a3cd86282279ce134c7a453faa4e3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    - ceph_mon_enabled is succeeded"},{"line_number":43,"context_line":"    - ceph_mon_container is succeeded"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- block:"},{"line_number":46,"context_line":"  - name: set jq osd percentage filter"},{"line_number":47,"context_line":"    set_fact:"},{"line_number":48,"context_line":"      jq_osd_percentage_filter: \u0027( (.num_in_osds) / (.num_osds) ) * 100\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_c6096e2c","line":45,"in_reply_to":"9fb8cfa7_83e93f1b","updated":"2019-06-07 13:12:23.000000000","message":"Done","commit_id":"47bca50da323734cb718bcde7500b8208900afad"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"163f9e717b79c0f4d7c387afa7eb14c5be83caa2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    register: ceph_osd_in_percentage"},{"line_number":53,"context_line":"  - name: Fail if there is an unacceptable percentage of in OSDs"},{"line_number":54,"context_line":"    fail:"},{"line_number":55,"context_line":"      msg: \"Only {{ ceph_osd_in_percentage.stdout|float }}% of OSDs are in, but {{ osd_percentage_min|default(0) }}% are required\""},{"line_number":56,"context_line":"    when:"},{"line_number":57,"context_line":"      - ceph_osd_in_percentage.stdout|float \u003c osd_percentage_min|default(0)"},{"line_number":58,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9fb8cfa7_a4dd8015","line":55,"updated":"2019-06-05 14:17:24.000000000","message":"nice","commit_id":"47bca50da323734cb718bcde7500b8208900afad"}]}