)]}'
{"roles/ceph/defaults/main.yml":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"899799f95c5fa405e9f48dbd02d97e7054f8f2db","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fail_without_ceph_ansible: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_e6ce5b82","line":2,"updated":"2019-06-01 12:28:35.000000000","message":"Could you please add this variable to the playbooks as well ?\n`tripleo-validations/playbooks/ceph-ansible-installed.yaml`","commit_id":"4e106c0eb1733dc356825caa322f1eb3040911b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2b9d03581f1886de1505fd892323c4bd74c028a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fail_without_ceph_ansible: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_a288411f","line":2,"in_reply_to":"9fb8cfa7_e6ce5b82","updated":"2019-06-03 14:52:55.000000000","message":"@gchamoul the variable is already here:\n\nhttps://review.opendev.org/#/c/662542/1/roles/ceph/tasks/ceph-ansible-installed.yaml@15\n\nSo I think this is already done unless you mean something else. Is the above not what you were asking about?\n\nThanks,\n  John","commit_id":"4e106c0eb1733dc356825caa322f1eb3040911b5"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"81c189d54255d3d485eabfab4f5e473d88acb1d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fail_without_ceph_ansible: false"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_42daa5e9","line":2,"in_reply_to":"9fb8cfa7_e6ce5b82","updated":"2019-06-03 15:03:01.000000000","message":"done.\n\nhttps://review.opendev.org/#/c/662542/2/playbooks/ceph-ansible-installed.yaml@4","commit_id":"4e106c0eb1733dc356825caa322f1eb3040911b5"}],"roles/ceph/tasks/ceph-ansible-installed.yaml":[{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"2b9d03581f1886de1505fd892323c4bd74c028a3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    msg: If planning to use Ceph, it is necessary to install the ceph-ansible package on the undercloud"},{"line_number":13,"context_line":"  when:"},{"line_number":14,"context_line":"    - ceph_ansible_installed.stdout.find(\u0027is not installed\u0027) !\u003d -1"},{"line_number":15,"context_line":"    - not fail_without_ceph_ansible|default(false)|bool"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Fail if ceph-ansible is missing"},{"line_number":18,"context_line":"  fail:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_4294e544","line":15,"range":{"start_line":15,"start_character":10,"end_line":15,"end_character":35},"updated":"2019-06-03 14:52:55.000000000","message":"@gchamoul the variable is in the playbook.","commit_id":"4e106c0eb1733dc356825caa322f1eb3040911b5"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"5b8eb487999b2a4f04a72fc3242cb154647826f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if ceph-ansible is installed"},{"line_number":3,"context_line":"  shell: rpm -q ceph-ansible || true"},{"line_number":4,"context_line":"  args:"},{"line_number":5,"context_line":"    warn: no"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_b512a257","side":"PARENT","line":2,"updated":"2019-06-04 14:11:09.000000000","message":"q","commit_id":"b8aa827047c186725a045129be27d51c55cc8c96"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"9f7b823c07c71509a26b72d1bb6a6a179f43705b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - ceph_ansible_installed.stdout.find(\u0027is not installed\u0027) !\u003d -1"},{"line_number":15,"context_line":"    - not fail_without_ceph_ansible|default(false)|bool"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Fail if ceph-ansible is missing"},{"line_number":18,"context_line":"  fail:"},{"line_number":19,"context_line":"    msg: If planning to use Ceph, it is necessary to install the ceph-ansible package on the undercloud"},{"line_number":20,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_7898b669","line":17,"updated":"2019-06-03 16:10:15.000000000","message":"wouldn\u0027t this task alone be sufficient given the new parameter?","commit_id":"bf206aa97a5cce5b04de505c294d4d634f05d135"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"bd57bd3820cbbac4d7632394d216f261c5452087","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - ceph_ansible_installed.stdout.find(\u0027is not installed\u0027) !\u003d -1"},{"line_number":15,"context_line":"    - not fail_without_ceph_ansible|default(false)|bool"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Fail if ceph-ansible is missing"},{"line_number":18,"context_line":"  fail:"},{"line_number":19,"context_line":"    msg: If planning to use Ceph, it is necessary to install the ceph-ansible package on the undercloud"},{"line_number":20,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_e7be43fe","line":17,"in_reply_to":"9fb8cfa7_7898b669","updated":"2019-06-03 20:27:00.000000000","message":"Sorry, not sure what you mean. Sufficient for what?\n\nThe warn module prints a warning which a user might not see. The fail module cannot be ignored as it will be the deployment failure message.\n\nThe change which uses this new variable sets this parameter to true since I wanted the deployment to fail with a helpful error when they use Ceph by default in TripleO.","commit_id":"bf206aa97a5cce5b04de505c294d4d634f05d135"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"de41bfe5f2f98363b7e9e6fe8cbfb4f52ad159c8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - ceph_ansible_installed.stdout.find(\u0027is not installed\u0027) !\u003d -1"},{"line_number":15,"context_line":"    - not fail_without_ceph_ansible|default(false)|bool"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Fail if ceph-ansible is missing"},{"line_number":18,"context_line":"  fail:"},{"line_number":19,"context_line":"    msg: If planning to use Ceph, it is necessary to install the ceph-ansible package on the undercloud"},{"line_number":20,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_ef8e102d","line":17,"in_reply_to":"9fb8cfa7_e7be43fe","updated":"2019-06-04 09:00:33.000000000","message":"what I meant is that I can see why we want to explicitly stop the deployment when the bool is true, but then why having also a warning message when the bool is false?","commit_id":"bf206aa97a5cce5b04de505c294d4d634f05d135"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"dfea2f23f3d123a8570a41c356ecfc44056f0454","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    - ceph_ansible_installed.stdout.find(\u0027is not installed\u0027) !\u003d -1"},{"line_number":15,"context_line":"    - not fail_without_ceph_ansible|default(false)|bool"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Fail if ceph-ansible is missing"},{"line_number":18,"context_line":"  fail:"},{"line_number":19,"context_line":"    msg: If planning to use Ceph, it is necessary to install the ceph-ansible package on the undercloud"},{"line_number":20,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_16acd98a","line":17,"in_reply_to":"9fb8cfa7_ef8e102d","updated":"2019-06-04 13:17:57.000000000","message":"I think this role is used in two different contexts:\n\n1. run validations independently of deployment and get all validation results back (so don\u0027t fail, keep getting validation results).\n\n2. run validations during deployment and stop the deployment to save time. \n\nI think this patch and the one which depends on it gives us #2 but I didn\u0027t want to disrupt #1. My experience with #1 is limited to the now deprecated triplo-ui would do. It could warn you things before you deployed and this would be a nice one to know about pre-deploy.\n\n@gchamoul could probably comment further.","commit_id":"bf206aa97a5cce5b04de505c294d4d634f05d135"}]}