)]}'
{"id":"openstack%2Ftripleo-validations~666603","triplet_id":"openstack%2Ftripleo-validations~master~If2c22ad982fafc37ef48b7cd870ea6cf01e7913a","project":"openstack/tripleo-validations","branch":"master","topic":"switch-vlans-python3","hashtags":[],"change_id":"If2c22ad982fafc37ef48b7cd870ea6cf01e7913a","subject":"Use sorted dictionary before iteration","status":"MERGED","created":"2019-06-20 14:58:33.000000000","updated":"2019-06-21 09:39:21.000000000","submitted":"2019-06-21 09:26:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"666603-1561109181886-f9ed76da","meta_rev_id":"094132f8d14f8ce3ae868c8055f102d34a110fa3","_number":666603,"virtual_id_number":666603,"owner":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-21 09:26:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},{"value":0,"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},{"value":0,"date":"2019-06-21 04:29:01.000000000","_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":2,"date":"2019-06-20 21:10:05.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":2,"date":"2019-06-20 23:46:04.000000000","_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},{"value":0,"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},{"value":0,"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":1,"date":"2019-06-20 23:46:04.000000000","_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},{"value":0,"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},{"value":0,"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-20 14:59:24.000000000","updated_by":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"reviewer":{"_account_id":17888,"name":"Florian Fuchs","email":"f@florianfuchs.com","username":"flfuchs"},"state":"REVIEWER"},{"updated":"2019-06-20 15:19:05.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2019-06-20 21:10:05.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2019-06-20 23:46:04.000000000","updated_by":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"reviewer":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"state":"REVIEWER"},{"updated":"2019-06-21 09:26:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7dec51dae79d9dada31d484378690d2467bd041f","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2019-06-20 14:58:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5a740afc4fe40ff3ddd8b08b17fb20195a997101","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2019-06-20 15:19:05.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nordering is always good :)","accounts_in_message":[],"_revision_number":1},{"id":"4bb26ba13d7f5afffef6a05461093906e512f518","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2019-06-20 15:25:17.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"ec0bc53ddba94ea0f543604affc9aea76043b352","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2019-06-20 15:41:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f431f8426f61aae43863827d76de606572bfb789","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 20:52:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-containers-multinode/990a2b2/ : SUCCESS in 2h 13m 19s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-undercloud-containers/8e8bed7/ : SUCCESS in 1h 33m 50s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/b9396e8/ : SUCCESS in 2h 24m 35s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/e935ae7/ : SUCCESS in 2h 25m 37s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-standalone/4e2c493/ : SUCCESS in 2h 09m 36s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/03/666603/3/check/tripleo-ci-fedora-28-standalone/a64916e/ : SUCCESS in 2h 10m 28s\n- tripleo-ci-centos-7-standalone-upgrade http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-standalone-upgrade/3a87531/ : SUCCESS in 2h 14m 36s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade-stein http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-standalone-upgrade-stein/17936ee/ : SUCCESS in 2h 08m 56s\n- openstack-tox-pep8 http://logs.openstack.org/03/666603/3/check/openstack-tox-pep8/bbd6455/ : SUCCESS in 6m 55s\n- openstack-tox-py27 http://logs.openstack.org/03/666603/3/check/openstack-tox-py27/776acbd/ : SUCCESS in 6m 24s\n- openstack-tox-py35 http://logs.openstack.org/03/666603/3/check/openstack-tox-py35/ca75e86/ : SUCCESS in 8m 05s\n- openstack-tox-py36 http://logs.openstack.org/03/666603/3/check/openstack-tox-py36/56f1f69/ : SUCCESS in 6m 31s\n- openstack-tox-docs http://logs.openstack.org/03/666603/3/check/openstack-tox-docs/cfdcd2d/html/ : SUCCESS in 12m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/03/666603/3/check/openstack-tox-lower-constraints/eef64e5/ : SUCCESS in 5m 29s","accounts_in_message":[],"_revision_number":3},{"id":"b6ff403634cb8b20c68c34755272859f6561ae2c","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-06-20 21:10:05.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1260ec88e30ad11c21c3ab4ebc20de60c4dce5df","author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"date":"2019-06-20 23:46:04.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"0112c7f8d43249cf43d78d6d7b5b1155b0921353","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-20 23:46:24.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"2857157367426acfa479899835d42b5d79fecd58","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-21 03:18:39.000000000","message":"Patch Set 3: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/03/666603/3/gate/tripleo-ci-centos-7-containers-multinode/99d4dff/ : SUCCESS in 2h 12m 46s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/03/666603/3/gate/tripleo-ci-centos-7-standalone/e856edd/ : FAILURE in 1h 53m 28s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/03/666603/3/gate/tripleo-ci-fedora-28-standalone/26f2064/ : SUCCESS in 1h 47m 51s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/03/666603/3/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/60a04bb/ : SUCCESS in 2h 03m 49s\n- tripleo-ci-centos-7-standalone-upgrade-stein http://logs.openstack.org/03/666603/3/gate/tripleo-ci-centos-7-standalone-upgrade-stein/ae1f227/ : SUCCESS in 2h 00m 57s\n- openstack-tox-pep8 http://logs.openstack.org/03/666603/3/gate/openstack-tox-pep8/ccdb335/ : SUCCESS in 6m 18s\n- openstack-tox-py27 http://logs.openstack.org/03/666603/3/gate/openstack-tox-py27/94532d1/ : SUCCESS in 5m 10s\n- openstack-tox-py35 http://logs.openstack.org/03/666603/3/gate/openstack-tox-py35/f760a0b/ : SUCCESS in 5m 43s\n- openstack-tox-py36 http://logs.openstack.org/03/666603/3/gate/openstack-tox-py36/e4ad75a/ : SUCCESS in 5m 13s\n- openstack-tox-docs http://logs.openstack.org/03/666603/3/gate/openstack-tox-docs/6e15d83/html/ : SUCCESS in 5m 04s\n- openstack-tox-lower-constraints http://logs.openstack.org/03/666603/3/gate/openstack-tox-lower-constraints/973a518/ : SUCCESS in 5m 45s","accounts_in_message":[],"_revision_number":3},{"id":"8dd977da8fcec28da2d05d4364547db98354414e","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2019-06-21 04:29:01.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"f5e0f9fe4b35baeb0153e6023e5399038e2f78fc","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-21 06:56:22.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-containers-multinode/341beba/ : SUCCESS in 2h 02m 23s\n- tripleo-ci-centos-7-undercloud-containers http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-undercloud-containers/66ed820/ : SUCCESS in 1h 43m 07s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/3041561/ : SUCCESS in 2h 10m 33s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/4577022/ : SUCCESS in 2h 21m 55s (non-voting)\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-standalone/8488903/ : SUCCESS in 1h 58m 57s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/03/666603/3/check/tripleo-ci-fedora-28-standalone/319a74c/ : SUCCESS in 1h 45m 21s\n- tripleo-ci-centos-7-standalone-upgrade http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-standalone-upgrade/155ac4b/ : SUCCESS in 2h 24m 20s (non-voting)\n- tripleo-ci-centos-7-standalone-upgrade-stein http://logs.openstack.org/03/666603/3/check/tripleo-ci-centos-7-standalone-upgrade-stein/2cc41b6/ : SUCCESS in 2h 00m 28s\n- openstack-tox-pep8 http://logs.openstack.org/03/666603/3/check/openstack-tox-pep8/0cc9d85/ : SUCCESS in 6m 25s\n- openstack-tox-py27 http://logs.openstack.org/03/666603/3/check/openstack-tox-py27/f12b3ef/ : SUCCESS in 5m 38s\n- openstack-tox-py35 http://logs.openstack.org/03/666603/3/check/openstack-tox-py35/65ec42c/ : SUCCESS in 7m 47s\n- openstack-tox-py36 http://logs.openstack.org/03/666603/3/check/openstack-tox-py36/cacf4d5/ : SUCCESS in 5m 36s\n- openstack-tox-docs http://logs.openstack.org/03/666603/3/check/openstack-tox-docs/f176e97/html/ : SUCCESS in 6m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/03/666603/3/check/openstack-tox-lower-constraints/73362f5/ : SUCCESS in 5m 55s","accounts_in_message":[],"_revision_number":3},{"id":"f876364aceeff88ad486521ddb2d2619bb013031","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-21 06:56:36.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"10068559c1f3c92cbe84be8e3719abb37b057d06","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-21 09:26:21.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-containers-multinode http://logs.openstack.org/03/666603/3/gate/tripleo-ci-centos-7-containers-multinode/0d4658b/ : SUCCESS in 2h 07m 32s\n- tripleo-ci-centos-7-standalone http://logs.openstack.org/03/666603/3/gate/tripleo-ci-centos-7-standalone/d87674d/ : SUCCESS in 2h 03m 30s\n- tripleo-ci-fedora-28-standalone http://logs.openstack.org/03/666603/3/gate/tripleo-ci-fedora-28-standalone/9723cb9/ : SUCCESS in 1h 47m 25s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates http://logs.openstack.org/03/666603/3/gate/tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates/ef28c26/ : SUCCESS in 2h 09m 14s\n- tripleo-ci-centos-7-standalone-upgrade-stein http://logs.openstack.org/03/666603/3/gate/tripleo-ci-centos-7-standalone-upgrade-stein/5ccbc01/ : SUCCESS in 2h 14m 29s\n- openstack-tox-pep8 http://logs.openstack.org/03/666603/3/gate/openstack-tox-pep8/be0692c/ : SUCCESS in 9m 35s\n- openstack-tox-py27 http://logs.openstack.org/03/666603/3/gate/openstack-tox-py27/ab84ea2/ : SUCCESS in 5m 51s\n- openstack-tox-py35 http://logs.openstack.org/03/666603/3/gate/openstack-tox-py35/eaeb0a2/ : SUCCESS in 5m 52s\n- openstack-tox-py36 http://logs.openstack.org/03/666603/3/gate/openstack-tox-py36/c3d7ef4/ : SUCCESS in 4m 42s\n- openstack-tox-docs http://logs.openstack.org/03/666603/3/gate/openstack-tox-docs/75dd9bc/html/ : SUCCESS in 12m 29s\n- openstack-tox-lower-constraints http://logs.openstack.org/03/666603/3/gate/openstack-tox-lower-constraints/c0f7592/ : SUCCESS in 4m 57s","accounts_in_message":[],"_revision_number":3},{"id":"2313d7be13fc7d632c1d53fed916a3f50e8f5b7b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-21 09:26:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"8b848ff37d6e63ddcc812b7a1a947be38ae99bb6","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2019-06-21 09:39:21.000000000","message":"Patch Set 3: Cherry Picked\n\nThis patchset was cherry picked to branch stable/stein as commit 673148df6fe05f403e79765df0379f4cf4b4ae04","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"90bb5816015f8e4c9d7a44731e2e133429463487","revisions":{"6af34d06e573848ba56ae14bdef05c9ed6a0154a":{"kind":"REWORK","_number":1,"created":"2019-06-20 14:58:33.000000000","uploader":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"ref":"refs/changes/03/666603/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/03/666603/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/1"}}},"commit":{"parents":[{"commit":"8eac2f757cc0d74f0d9f5cdfcae90f1aa6f562ab","subject":"Merge \"Update the Undercloud Services list for the uc-service-status role\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/8eac2f757cc0d74f0d9f5cdfcae90f1aa6f562ab"}]}],"author":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2019-06-20 14:44:43.000000000","tz":120},"committer":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2019-06-20 14:44:43.000000000","tz":120},"subject":"Use sorted dictionary before iteration","message":"Use sorted dictionary before iteration\n\nIn Python 3, dict.values() method returns a view of a the dictionary\u0027s\nvalues but in a different order than Python 2, which returns a\nlist. This patch sorts the data dictionary first to be sure to get the\nsame order whatever the Python version.\n\nThis patch also fixes the warnings and errors lists to get only unique\nmessages.\n\nChange-Id: If2c22ad982fafc37ef48b7cd870ea6cf01e7913a\nSigned-off-by: Gael Chamoulaud \u003cgchamoul@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/6af34d06e573848ba56ae14bdef05c9ed6a0154a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/6af34d06e573848ba56ae14bdef05c9ed6a0154a"}]},"branch":"refs/heads/master"},"3e5dcd6f41b825b6114926f0ca6bf02a14df833e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-06-20 15:25:17.000000000","uploader":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"ref":"refs/changes/03/666603/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/03/666603/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/2"}}},"commit":{"parents":[{"commit":"8eac2f757cc0d74f0d9f5cdfcae90f1aa6f562ab","subject":"Merge \"Update the Undercloud Services list for the uc-service-status role\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/8eac2f757cc0d74f0d9f5cdfcae90f1aa6f562ab"}]}],"author":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2019-06-20 14:44:43.000000000","tz":120},"committer":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2019-06-20 15:24:48.000000000","tz":120},"subject":"Use sorted dictionary before iteration","message":"Use sorted dictionary before iteration\n\nIn Python 3, dict.values() method returns a view of the dictionary\u0027s\nvalues but in a different order than Python 2, which returns a\nlist. This patch sorts the data dictionary first to be sure to get the\nsame order whatever the Python version.\n\nThis patch also fixes the warnings and errors lists to get only unique\nmessages.\n\nChange-Id: If2c22ad982fafc37ef48b7cd870ea6cf01e7913a\nSigned-off-by: Gael Chamoulaud \u003cgchamoul@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/3e5dcd6f41b825b6114926f0ca6bf02a14df833e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/3e5dcd6f41b825b6114926f0ca6bf02a14df833e"}]},"branch":"refs/heads/master"},"90bb5816015f8e4c9d7a44731e2e133429463487":{"kind":"REWORK","_number":3,"created":"2019-06-20 15:41:21.000000000","uploader":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"ref":"refs/changes/03/666603/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/03/666603/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/03/666603/3"}}},"commit":{"parents":[{"commit":"8eac2f757cc0d74f0d9f5cdfcae90f1aa6f562ab","subject":"Merge \"Update the Undercloud Services list for the uc-service-status role\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/8eac2f757cc0d74f0d9f5cdfcae90f1aa6f562ab"}]}],"author":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2019-06-20 14:44:43.000000000","tz":120},"committer":{"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","date":"2019-06-20 15:35:36.000000000","tz":120},"subject":"Use sorted dictionary before iteration","message":"Use sorted dictionary before iteration\n\nIn Python 3, dict.values() method returns a view of the dictionary\u0027s\nvalues but in a different order than Python 2, which returns a\nlist. This patch sorts the data dictionary first to be sure to get the\nsame order whatever the Python version.\n\nIn Python 3.3 \"abstract base classes\" in collections (like Mapping or\nSequence) were moved to second-level module collections.abc. So in\nPython 3.3+ the real type is collections.abc.Mapping and so\non. Documentation states that the old alias\nnames (e.g. collections.Mapping) will be available up to Python\n3.7 (currently the latest version), however in 3.8 these aliases will be\nremoved. This patch prepares the code to the future Python 3.8 version.\n\nThis patch also fixes the warnings and errors lists to get only unique\nmessages.\n\nChange-Id: If2c22ad982fafc37ef48b7cd870ea6cf01e7913a\nSigned-off-by: Gael Chamoulaud \u003cgchamoul@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/90bb5816015f8e4c9d7a44731e2e133429463487"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/90bb5816015f8e4c9d7a44731e2e133429463487"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
