)]}'
{"roles/ceph/tasks/ceph-ansible-installed.yaml":[{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"4637b4e3151b50c8a589fb09638e341fd50e337f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - fail_without_ceph_ansible|default(false)|bool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Get ceph-ansible repository"},{"line_number":25,"context_line":"  shell: \"yum info ceph-ansible | awk \u0027/From repo/ {print $4}\u0027\""},{"line_number":26,"context_line":"  register: repo"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail if ceph-ansible doesn\u0027t belong to the specified repo"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_fef6335e","line":25,"range":{"start_line":25,"start_character":9,"end_line":25,"end_character":63},"updated":"2019-12-09 19:18:49.000000000","message":"Using the yum module I see the \"info\" command is not implemented, so I opted for the \"shell\" module.\nJohn/Giulio, wdyt? Is there a better way to gather the repo info?","commit_id":"cd89690a58f33f59483ad8ade0d503cc4221ad7e"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"8501daed1d87ad11025780640bde070f2ac4d8ce","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - fail_without_ceph_ansible|default(false)|bool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Get ceph-ansible repository"},{"line_number":25,"context_line":"  shell: \"yum info ceph-ansible | awk \u0027/From repo/ {print $4}\u0027\""},{"line_number":26,"context_line":"  register: repo"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail if ceph-ansible doesn\u0027t belong to the specified repo"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_9cc4dd93","line":25,"range":{"start_line":25,"start_character":9,"end_line":25,"end_character":63},"in_reply_to":"3fa7e38b_fef6335e","updated":"2019-12-10 13:13:25.000000000","message":"Perhaps link to the issue with the info command as a comment in the code and then make it two tasks with a when and use yum for cent7 and dnf for cent8.\n\n@Kevin do you have a better idea?","commit_id":"cd89690a58f33f59483ad8ade0d503cc4221ad7e"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"9d5aa5d983f00b47e80b5a4849605fa6efa0a641","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    msg: \"Make sure ceph-ansible package is installed from {{ ceph_ansible_repo }}\""},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - fail_without_ceph_ansible|default(false)|bool"},{"line_number":33,"context_line":"    - repo.stdout | length \u003e 0 or repo.stdout !\u003d \"{{ ceph_ansible_repo }}\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4a221e03","line":33,"range":{"start_line":33,"start_character":6,"end_line":33,"end_character":30},"updated":"2019-12-10 08:09:13.000000000","message":"This form should solve the empty string case (https://github.com/ansible/ansible-lint/issues/457)","commit_id":"c7f78b44a1672ba1a2ed5a3825b0120262c83c92"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"f9d3a7dc26bbe4386ae7be65a1ba1d59ce4572e4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - fail_without_ceph_ansible|default(false)|bool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Get ceph-ansible repository"},{"line_number":25,"context_line":"  shell: \"yum info ceph-ansible | awk \u0027/From repo/ {print $4}\u0027\""},{"line_number":26,"context_line":"  register: repo"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail if ceph-ansible doesn\u0027t belong to the specified repo"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_f7ee3889","line":25,"updated":"2019-12-11 13:33:13.000000000","message":"Needs a \"changed_when: False\" for this task to shut the mouth down of the linter job.\n\"ignore_errors: True\" too, at your convenience.","commit_id":"a031186d12eccf6dd122206f8adcb5a813ed9646"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"d5815a834e08d8a263409a816117f96d07cccdb9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    - fail_without_ceph_ansible|default(false)|bool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Get ceph-ansible repository"},{"line_number":25,"context_line":"  shell: \"yum info ceph-ansible | awk \u0027/From repo/ {print $4}\u0027\""},{"line_number":26,"context_line":"  register: repo"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Fail if ceph-ansible doesn\u0027t belong to the specified repo"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_57fdcc06","line":25,"in_reply_to":"3fa7e38b_f7ee3889","updated":"2019-12-11 13:53:41.000000000","message":"Thanks Gael, I\u0027ll add the changed_when option for sure.\nActually I think we can add \"ignore errors: true\" since stdout will contain an empty string  if \"yum\" results in \"command not found\" or any other issue related to the package manager, but we can add it later (maybe we want to let the execution fail)","commit_id":"a031186d12eccf6dd122206f8adcb5a813ed9646"}]}