)]}'
{"id":"openstack%2Ftripleo-validations~706844","triplet_id":"openstack%2Ftripleo-validations~stable%2Ftrain~Ib758906a08dd611589394c77c627510d667034e9","project":"openstack/tripleo-validations","branch":"stable/train","topic":"stable/train-backports","hashtags":[],"change_id":"Ib758906a08dd611589394c77c627510d667034e9","subject":"Normalize role names when generating roles","status":"MERGED","created":"2020-02-10 14:15:32.000000000","updated":"2020-02-14 18:58:21.000000000","submitted":"2020-02-14 18:58:21.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"706844-1581706701866-86a07e3f","meta_rev_id":"c8fc49f20ade81e8e9cf956a8f062364a1df0f10","_number":706844,"virtual_id_number":706844,"owner":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-14 18:58:21.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-02-12 08:10:59.000000000","_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":1,"date":"2020-02-14 10:30:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},{"value":2,"date":"2020-02-13 17:23:23.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"date":"2020-02-10 14:15:32.000000000","_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"value":0,"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},{"value":1,"date":"2020-02-13 17:23:23.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-10 14:15:32.000000000","updated_by":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"},{"updated":"2020-02-12 08:10:59.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2020-02-13 17:23:23.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2020-02-14 10:30:38.000000000","updated_by":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"reviewer":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"state":"REVIEWER"},{"updated":"2020-02-14 18:58:21.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"775df576d2d597d35a6036613cf5a472720028dc","author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"date":"2020-02-10 14:15:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0ebd024a6a9c6f7144c0425ecd36185e10ba581d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-10 22:32:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/3509cae3a2c94ca3b6a69b26249ec07e : SUCCESS in 2h 45m 14s\n- tripleo-ci-centos-7-undercloud-containers https://zuul.opendev.org/t/openstack/build/7599ca94ad864595aea2093fab9ebd24 : SUCCESS in 2h 01m 52s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/7512fd879a694548a54379d85139204d : SUCCESS in 2h 15m 41s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades https://zuul.opendev.org/t/openstack/build/d3bf286e55704ed79154ea071d4b153a : SUCCESS in 2h 47m 34s (non-voting)\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/fa3d245a36464b4087f4e34a14e30ce5 : SUCCESS in 1h 46m 50s\n- tripleo-ci-centos-7-standalone-upgrade-train https://zuul.opendev.org/t/openstack/build/182b9cee42534dc391660a2f6c3e8c64 : FAILURE in 2h 04m 02s (non-voting)\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/efa614e646eb4684816168ef5b4cb95b : SUCCESS in 7m 53s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e642b4067c624d9aa7167e057e9a0aed : SUCCESS in 8m 24s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/a1e707a608a548de9805a920329669e8 : SUCCESS in 7m 46s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/883cf8e0095349eab1bb92846867fcdf : SUCCESS in 5m 47s","accounts_in_message":[],"_revision_number":1},{"id":"8ecf5c3ce876e89f980f960554221de027dc1936","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2020-02-12 08:10:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9ad91311d50b20843771bc2d16dbe1d2dad600d3","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2020-02-13 17:23:23.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"fcd1b0cb427aace70ff60afc5d24ceddbb1e2248","author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"date":"2020-02-14 10:30:38.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"cd9705db850b1bd3763d16421f796c7c188d2964","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-14 15:02:14.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"eaf441a971d8d6ab6d6e8b1eb6430b65148b5e27","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-14 18:58:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-7-containers-multinode https://zuul.opendev.org/t/openstack/build/ec789830b3014ceab033f6c73d21633a : SUCCESS in 2h 26m 32s\n- tripleo-ci-centos-7-standalone https://zuul.opendev.org/t/openstack/build/26f0d44160b341e791035a371261a146 : SUCCESS in 1h 54m 07s\n- tripleo-ci-centos-7-scenario000-multinode-oooq-container-updates https://zuul.opendev.org/t/openstack/build/4aa4bfa1fef6450c97798cb1e18e222e : SUCCESS in 2h 46m 03s\n- tripleo-ci-centos-7-standalone-upgrade-train https://zuul.opendev.org/t/openstack/build/87d37cd9de56418b94257df10d6d39ee : SUCCESS in 2h 28m 23s (non-voting)\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dace4cf8820644a9aa3ff663f36e1eb5 : SUCCESS in 7m 03s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/be9c7f22e20248d9896e30b9b2ce757c : SUCCESS in 7m 06s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/aad5f46c6bb540b3a0496c6db84bd278 : SUCCESS in 11m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/440f89129d5940b0a3bfc53f0b576ec3 : SUCCESS in 8m 59s","accounts_in_message":[],"_revision_number":1},{"id":"abdab7dc21c31676f7c738bba82fecfa34fc538d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-14 18:58:21.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a4c7660a9bbefb091f4148122869b0bbb1919b88","revisions":{"a4c7660a9bbefb091f4148122869b0bbb1919b88":{"kind":"REWORK","_number":1,"created":"2020-02-10 14:15:32.000000000","uploader":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"ref":"refs/changes/44/706844/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/44/706844/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/44/706844/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/44/706844/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/44/706844/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/44/706844/1"}}},"commit":{"parents":[{"commit":"9a000ab8408e102c5fa77c32784cc563e6ffe433","subject":"molecule-xfs_check_ftypefailure (non-voting), remove from gate","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/9a000ab8408e102c5fa77c32784cc563e6ffe433"}]}],"author":{"name":"Kevin Carter","email":"kecarter@redhat.com","date":"2020-01-20 15:06:38.000000000","tz":-360},"committer":{"name":"Gael Chamoulaud (Strider)","email":"gchamoul@redhat.com","date":"2020-02-10 13:54:53.000000000","tz":60},"subject":"Normalize role names when generating roles","message":"Normalize role names when generating roles\n\nRoles can no longer have a \"-\" in them according to the upstream ansible\ndocumentation[0]. This change ensures that we\u0027re no longer generating roles\nthat have a \"-\" within them. The role-addition.yml playbook will now\nnormalize the name and replace any \"-\" with an \"_\".\n\n[0] https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#roles-directory\n\nChange-Id: Ib758906a08dd611589394c77c627510d667034e9\nSigned-off-by: Kevin Carter \u003ckecarter@redhat.com\u003e\n(cherry picked from commit 3e30472f23efe1bb03c450f9ef78e8e147e65985)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/a4c7660a9bbefb091f4148122869b0bbb1919b88"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/a4c7660a9bbefb091f4148122869b0bbb1919b88"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}