)]}'
{"id":"openstack%2Ftripleo-validations~759558","triplet_id":"openstack%2Ftripleo-validations~stable%2Fussuri~I7a28f6014c55293d018d5fbc3223a26a10550f1c","project":"openstack/tripleo-validations","branch":"stable/ussuri","topic":"bug/1901297","hashtags":[],"change_id":"I7a28f6014c55293d018d5fbc3223a26a10550f1c","subject":"Refactor vif plugging validations","status":"MERGED","created":"2020-10-24 09:50:51.000000000","updated":"2020-10-26 17:50:21.000000000","submitted":"2020-10-26 17:48:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"759558-1603734527537-041edf42","meta_rev_id":"f2a349ec7e376fc92ebef6f339382ba36f550cee","_number":759558,"virtual_id_number":759558,"owner":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-26 17:48:47.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-10-26 09:20:44.000000000","_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-10-26 09:20:44.000000000","_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-24 09:50:51.000000000","updated_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2020-10-24 13:57:05.000000000","updated_by":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"REVIEWER"},{"updated":"2020-10-26 09:20:44.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2020-10-26 17:48:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"843320916fda425d1a2e8242c9d20d4f97021bbc","author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"date":"2020-10-24 09:50:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b187a6d4f3fbe1ddaf984ff695471797922513e7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-24 12:30:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/c2b938e658d449668198d75a52b5b242 : SUCCESS in 2h 38m 03s\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-ussuri https://zuul.opendev.org/t/openstack/build/dda23443027f4b1ea6162c8e94f92a0d : SUCCESS in 1h 56m 59s\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-upgrades-ussuri https://zuul.opendev.org/t/openstack/build/e764a1a9793446188d0cb6dcb4f98535 : SUCCESS in 2h 07m 40s\n- tripleo-ci-centos-8-standalone https://zuul.opendev.org/t/openstack/build/7ea45688e7f24086b7e7e86d76e9618f : SUCCESS in 1h 28m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/542fd4e6828c4a588037c8b9931e419c : SUCCESS in 5m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/057f8a2ed435467db70db804a3d74994 : SUCCESS in 5m 35s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5e46f32f8ecf42a2ad91d77375b2efe2 : SUCCESS in 6m 12s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/f5b99513200a4498ad380f692ad5e6ca : SUCCESS in 7m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b6a7f1188a5f45c2b7ef4ea6d741c679 : SUCCESS in 5m 26s","accounts_in_message":[],"_revision_number":1},{"id":"50b360613ab193e3af68baaee54d799e3d67f61b","author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"date":"2020-10-24 13:57:05.000000000","message":"Patch Set 1: Code-Review-1\n\nThis is a cherry-pick from master, so \"cherry picked from commit\" should be described in the commit message.","accounts_in_message":[],"_revision_number":1},{"id":"a2546d88116dd3eb1a002759dfcbcc086a2c6495","author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"date":"2020-10-24 14:05:13.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"08b368eeb56d74b9c49937f855b740561d7f0e6d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-24 16:35:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/9cd56f0ecd15403daab4cabe92859991 : SUCCESS in 1h 57m 56s\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-ussuri https://zuul.opendev.org/t/openstack/build/b1392c2df1c74507954df0e74d7b1000 : SUCCESS in 1h 46m 58s\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-upgrades-ussuri https://zuul.opendev.org/t/openstack/build/bdbbbea6efb24325845d00ab9206b876 : SUCCESS in 2h 08m 37s\n- tripleo-ci-centos-8-standalone https://zuul.opendev.org/t/openstack/build/7f6c1e1e442e4644bf6864dbeb022d95 : SUCCESS in 1h 50m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6c90f107208b4658933efbafc7867bd9 : SUCCESS in 4m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/94ea7fc207864fb1af47286be7db0a13 : SUCCESS in 4m 58s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a7f459f946814dc28959f3b887f5f057 : SUCCESS in 5m 15s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/1622e017b303415d8a3759e71935f406 : SUCCESS in 9m 39s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bc8e57486ace421fb7bb25c2ad93adbd : SUCCESS in 3m 52s","accounts_in_message":[],"_revision_number":2},{"id":"7adb1c353b3443494d2f64b7f59d0ff6331f17c6","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2020-10-26 09:20:44.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\ncherry-pick - only one reviewer is needed.","accounts_in_message":[],"_revision_number":2},{"id":"70726824e01725a68ec861bcfad7462c9ecab857","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-26 09:20:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"664e44bddf34cd06c2c23e7cdc5f71931d190983","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-26 17:48:47.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tripleo-ci-centos-8-containers-multinode https://zuul.opendev.org/t/openstack/build/2e6583b223a24a5a9a20e26afec059d5 : SUCCESS in 2h 33m 43s\n- tripleo-ci-centos-8-standalone https://zuul.opendev.org/t/openstack/build/f0432464c52b47ad86c75c68fdde63b7 : SUCCESS in 2h 09m 02s\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-ussuri https://zuul.opendev.org/t/openstack/build/02cb33733a70442da5bc8480aafd19b7 : SUCCESS in 2h 30m 05s\n- tripleo-ci-centos-8-scenario000-multinode-oooq-container-upgrades-ussuri https://zuul.opendev.org/t/openstack/build/b22ded11926245899e30fc5adf3cb558 : SUCCESS in 2h 26m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/de8459786156441aa2f132c8668f698e : SUCCESS in 13m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c916bc4b5d8949f69343010a52bd648b : SUCCESS in 12m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3f5b919e5f654034981197118525e721 : SUCCESS in 7m 09s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/0f214320ff43427ea1ff36f47af5ab0e : SUCCESS in 7m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bcc844fb23014af7803ed73033a28239 : SUCCESS in 4m 44s","accounts_in_message":[],"_revision_number":2},{"id":"fb5064ab96ed27601c30e481e20a897bfb25b55d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-26 17:48:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"5a27d5b1999f14a3230eea8deddbc74b72ca0193","author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"date":"2020-10-26 17:50:21.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/train as commit 177a9876a57331b97a0f97a0c60eb5c8d4bae2b9","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bbc99b7aeebed97405dbe68dc04b1ef0b4024fec","revisions":{"601ae85663c3942a9465c32ffa8d26cbd4a910de":{"kind":"REWORK","_number":1,"created":"2020-10-24 09:50:51.000000000","uploader":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"ref":"refs/changes/58/759558/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/58/759558/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/58/759558/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/58/759558/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/58/759558/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/58/759558/1"}}},"commit":{"parents":[{"commit":"766ac4c93d3a03231285e787ebb7084506c93c50","subject":"Merge \"Correct how the image_serve validation works\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/766ac4c93d3a03231285e787ebb7084506c93c50"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-08-21 18:40:00.000000000","tz":-240},"committer":{"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","date":"2020-10-24 09:48:03.000000000","tz":120},"subject":"Refactor vif plugging validations","message":"Refactor vif plugging validations\n\nIt makes no sense to lump vif_plugging_timeout and vif_plugging_fatal\ninto the same tasks. One is a numeric value validated to be larger\nthan a minimum, the other is a boolean value validated to be set to\nTrue. Split them into separate tasks, and clarify the failure error\nmessages.\n\nChange-Id: I7a28f6014c55293d018d5fbc3223a26a10550f1c\nCloses-Bug: #1901297\nRelated: rhbz#1891197\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/601ae85663c3942a9465c32ffa8d26cbd4a910de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/601ae85663c3942a9465c32ffa8d26cbd4a910de"}]},"branch":"refs/heads/stable/ussuri"},"bbc99b7aeebed97405dbe68dc04b1ef0b4024fec":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-10-24 14:05:13.000000000","uploader":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"ref":"refs/changes/58/759558/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/58/759558/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/58/759558/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/58/759558/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/58/759558/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/58/759558/2"}}},"commit":{"parents":[{"commit":"766ac4c93d3a03231285e787ebb7084506c93c50","subject":"Merge \"Correct how the image_serve validation works\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/766ac4c93d3a03231285e787ebb7084506c93c50"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-08-21 18:40:00.000000000","tz":-240},"committer":{"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","date":"2020-10-24 14:04:10.000000000","tz":120},"subject":"Refactor vif plugging validations","message":"Refactor vif plugging validations\n\nIt makes no sense to lump vif_plugging_timeout and vif_plugging_fatal\ninto the same tasks. One is a numeric value validated to be larger\nthan a minimum, the other is a boolean value validated to be set to\nTrue. Split them into separate tasks, and clarify the failure error\nmessages.\n\nCloses-Bug: #1901297\nRelated: rhbz#1891197\n\nChange-Id: I7a28f6014c55293d018d5fbc3223a26a10550f1c\n(cherry picked from commit ee19a57bc58fc8cbfa6ec761fba383a1bfaa48b0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/bbc99b7aeebed97405dbe68dc04b1ef0b4024fec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/bbc99b7aeebed97405dbe68dc04b1ef0b4024fec"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[],"submit_requirements":[]}