)]}'
{"id":"openstack%2Ftripleo-validations~787989","triplet_id":"openstack%2Ftripleo-validations~stable%2Fussuri~If23c41d343678dcbbd0b4aae10ca6281a33e385f","project":"openstack/tripleo-validations","branch":"stable/ussuri","topic":"fqdn-stable/victoria-stable/ussuri","hashtags":[],"change_id":"If23c41d343678dcbbd0b4aae10ca6281a33e385f","subject":"Make tls_everywhere validations compatible with ansible_facts","status":"MERGED","created":"2021-04-26 21:10:34.000000000","updated":"2021-04-27 14:03:28.000000000","submitted":"2021-04-27 13:28:22.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"787989-fqdn-stable/victoria-stable/ussuri","cherry_pick_of_change":787988,"cherry_pick_of_patch_set":1,"meta_rev_id":"891564589460f6a56c32a7084290b69e44eaf745","_number":787989,"virtual_id_number":787989,"owner":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-27 13:28:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-04-27 07:47:14.000000000","_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":1,"date":"2021-04-27 02:33:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-04-27 07:47:14.000000000","_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},{"value":0,"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"}],"reviewers":{"REVIEWER":[{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-26 23:51:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-27 02:33:47.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"state":"REVIEWER"},{"updated":"2021-04-27 07:47:14.000000000","updated_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"reviewer":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"state":"REVIEWER"},{"updated":"2021-04-27 14:03:28.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"state":"REVIEWER"},{"updated":"2021-04-27 14:03:28.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2021-04-27 14:03:28.000000000","updated_by":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"reviewer":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"state":"REVIEWER"}],"messages":[{"id":"cbe9d9f691898fb8bc514548b4e78a49917056dd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"date":"2021-04-26 21:10:34.000000000","message":"Patch Set 1: Cherry Picked from branch stable/victoria.","accounts_in_message":[],"_revision_number":1},{"id":"04fcaf27e24f10c80f4dcf380a9586d8306566ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-26 23:51:59.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0cc16b6b1cec4d6e98e150fd6826aaab : SUCCESS in 7m 02s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0aa66ea9e4d3476eaa019e32ca7d92a0 : SUCCESS in 6m 35s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/bc4aade6fcc94fd586a8b766582345d6 : SUCCESS in 6m 22s\n- tripleo-validations-centos-8-molecule-tls_everywhere https://zuul.opendev.org/t/openstack/build/fdbd4fc59f6a4c5395895a4cbf89b6b9 : SUCCESS in 9m 01s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/7c33d234434349f4b741601f599d0c62 : SUCCESS in 8m 53s\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/52d41a29c2e9437ea20ef889d66c9d0e : SUCCESS in 2h 26m 40s\n- tripleo-ci-centos-8-standalone-tv-validation https://zuul.opendev.org/t/openstack/build/04d2af84a8014ac99c9887202e32aed4 : SUCCESS in 1h 04m 06s","accounts_in_message":[],"_revision_number":1},{"id":"84916e37767891e65595b806941b7d47fcc5a871","author":{"_account_id":7414,"name":"David Wilde","email":"dwilde@redhat.com","username":"d34dh0r53"},"date":"2021-04-27 02:33:47.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"207e2b114662990bfe0421b2711b33777ea6ff13","author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"date":"2021-04-27 07:47:14.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"a7407ee1ee2f9ebe8df32d8fbc30a72e6ebe989b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-27 07:47:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"179a76ccdd1a49c723413abac60a5a9f8c2a4078","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-27 13:28:21.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/67568b89bbf04a4eb861b7415b67dde2 : SUCCESS in 8m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e7e75eda69744f3da639070a3c6f5e43 : SUCCESS in 8m 16s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9307e98b79ad4661b040262244867883 : SUCCESS in 8m 10s\n- tripleo-validations-centos-8-molecule-tls_everywhere https://zuul.opendev.org/t/openstack/build/7f2725a9bc284d1da9dc2c6d34eca356 : SUCCESS in 10m 05s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/97fd20df8989457eac34b99560d9f332 : SUCCESS in 10m 41s\n- tripleo-ci-centos-8-content-provider https://zuul.opendev.org/t/openstack/build/bee97cbe3d8b42f4a4aa6238d8f53718 : SUCCESS in 2h 36m 44s\n- tripleo-ci-centos-8-standalone-tv-validation https://zuul.opendev.org/t/openstack/build/e9514189af554b6eb4562c299314fa4f : SUCCESS in 1h 25m 10s","accounts_in_message":[],"_revision_number":1},{"id":"6e801f0e541d1f580dcd58421e0ceea09d18f3f3","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-27 13:28:22.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"62b33cb30cee932d6a0db90fe0f2adfbc4407499","revisions":{"62b33cb30cee932d6a0db90fe0f2adfbc4407499":{"kind":"REWORK","_number":1,"created":"2021-04-26 21:10:34.000000000","uploader":{"_account_id":20172,"name":"Michele Baldessari","email":"michele@acksyn.org","username":"michele"},"ref":"refs/changes/89/787989/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-validations","ref":"refs/changes/89/787989/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/89/787989/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/89/787989/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-validations refs/changes/89/787989/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-validations refs/changes/89/787989/1"}}},"commit":{"parents":[{"commit":"2577f3dddf79ff660eaf7276901f40e897ae9d35","subject":"Merge \"Use a more targeted job for tripleo-validations\" into stable/ussuri","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/2577f3dddf79ff660eaf7276901f40e897ae9d35"}]}],"author":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2021-04-24 09:12:45.000000000","tz":120},"committer":{"name":"Michele Baldessari","email":"michele@acksyn.org","date":"2021-04-26 21:10:34.000000000","tz":0},"subject":"Make tls_everywhere validations compatible with ansible_facts","message":"Make tls_everywhere validations compatible with ansible_facts\n\nVia [1] we cannot rely on ansible_* vars anymore. So let\u0027s switch to\nansible_facts. This should fix the following error:\n\n  2021-04-22 22:08:36,708 p\u003d36100 u\u003dmistral n\u003dansible | fatal:\n  [undercloud]: FAILED! \u003d\u003e {\"msg\": \"The task includes an option with an\n  undefined variable. The error was: {{ tls_everywhere_undercloud_fqdn |\n  default(ansible_fqdn) }}: \u0027ansible_fqdn\u0027 is undefined\\n\\nThe error\n  appears to be in\n  \u0027/usr/share/ansible/roles/tls_everywhere/tasks/ipa-server-check.yaml\u0027:\n  line 59, column 7, but may\\nbe elsewhere in the file depending on the\n  exact syntax problem.\\n\\nThe offending line appears to be:\\n\\n\\n    -\n  name: kinit as the host entity\\n      ^ here\\n\"}\n\nCloses-Bug: #1925999\n\n[1] https://opendev.org/openstack/tripleo-heat-templates/commit/4e79336d69e6b7fa4b026922bac7953bafeee96d\n\nChange-Id: If23c41d343678dcbbd0b4aae10ca6281a33e385f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/62b33cb30cee932d6a0db90fe0f2adfbc4407499"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-validations/commit/62b33cb30cee932d6a0db90fe0f2adfbc4407499"}]},"branch":"refs/heads/stable/ussuri"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}