)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"09de524e63c20e4e6b7408902b7da0b54178f3d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c7d714ce_d105b8d9","updated":"2021-10-12 12:40:38.000000000","message":"I like the messaging; plus one from me for now, pending passing.","commit_id":"fe00401470b8c356fc1cadd6a1a6afbf158f6e18"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ee364f55497d85a34fa858a7fc0ff277beda4a8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"38a396d2_ec4adca1","updated":"2021-10-13 07:09:56.000000000","message":"Maybe I didn\u0027t understand the consistent working directory feature, but I think we need answers from James about that, wdyt?\n\nMarios or Alex as well maybe?","commit_id":"b2c469f91a2e3f23d5364c2c80a328f991cf50b7"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"1363ae8a3181c0723e36b934ddef59f18d5fda16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6e777188_761081b0","updated":"2022-02-04 15:23:00.000000000","message":"Looks like we dropped the ball on this one and need to reach resolution here - starting 16.2.2 it seems that this is a genuine problem.\n\nDVD is raising a BZ from his reproducer.","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"1995584d9212fd9347ce73cd269ec8f00b212a7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1fd872af_d887ae2c","updated":"2021-10-13 07:37:23.000000000","message":"Thanks Mathieu!","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a98acc863e8c16bb0bb5a9b247901d8276d01fae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e1d1459b_2ec76feb","updated":"2021-10-14 22:21:41.000000000","message":"We could probably land this though if we plan on backporting, it might be beneficial to do the inventory workarounds in this change now rather than a follow up patch","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"ae6117e2e94c20e5a3f59becee9785314ef98cd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"588c9561_e7641209","updated":"2021-10-13 14:13:25.000000000","message":"recheck","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ad91e5ee0ff96c0846e877ffcbb6720b751c428d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e822536d_b3a197db","updated":"2021-10-14 07:33:00.000000000","message":"recheck","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"},{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"4bc3d5bfda220b5adfd5479e9d67b41d302ab06f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"727af849_60d9f74e","updated":"2022-05-26 12:55:34.000000000","message":"recheck","commit_id":"c9b91f4fec1e51370143effa1670da0f0206e8e5"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"3469b047d5bc28c59c7d6817424ad38d63a5a524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"56c0e303_dd29bfa9","updated":"2022-06-01 14:47:09.000000000","message":"recheck","commit_id":"bfc5423659d05985cbc25f8b300a0fc6fb17fedd"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"0de437c6192b390c432b3d5a78f82c0abacfdae6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2b2ab7a7_bac8cfc1","updated":"2022-06-06 14:10:04.000000000","message":"I have been thinking about this. And I think we need to split this patch into deprecation and removal.\nEven if the script doesn\u0027t work right now, going straight to removing it outright feels wrong, and it conflicts with the first line of the commit msg which could lead to some confusion.\n\nFurthermore, removing/deprecating two scripts in one patch is making things too complex.\nI would prefer atomic changes to both. First deprecation, that is warning, note in release notes etc., followed by removal, again with note.\n\nIt should also be tied to wider announcement and check of our customer facing docs to ensure we don\u0027t refer to the scripts in new releases. It may have been done already and I\u0027ve forgotten, for which I apologize. ","commit_id":"f1f0c2047bb8baaa22d0b35ddc1c3ba7425d95e5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"fe0415c4b4ef90c8ea0cee738aa0a8f9edd5dbd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cbd1365f_1ca87d38","updated":"2022-06-15 06:27:32.000000000","message":"recheck","commit_id":"08e2e1a060332bb5dfba4e9b52d526d2272dd343"}],"scripts/tripleo-ansible-inventory":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"ee364f55497d85a34fa858a7fc0ff277beda4a8a","unresolved":true,"context_lines":[{"line_number":24,"context_line":"           \"directory: tripleo-ansible-inventory.yaml. \\n\""},{"line_number":25,"context_line":"           \"To generate an inventory file, use the playbook in \""},{"line_number":26,"context_line":"           \"tripleo-ansible: cli-config-download.yaml\")"},{"line_number":27,"context_line":"    print(msg)"},{"line_number":28,"context_line":"    sys.exit(0)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"65e7f908_77898f54","line":27,"updated":"2021-10-13 07:09:56.000000000","message":"Hmm... To me ~/tripleo-deploy/ is the place where we can find only the generated artifacts for the Undercloud Installation and the inventory located there contains only the Undercloud information and nothing more. \n\nOnce the Overcloud deployed, we can get the full inventory (UC + OC Nodes) from ~/overcloud-deploy/\u003cstack\u003e/tripleo-ansible-inventory.yaml.","commit_id":"b2c469f91a2e3f23d5364c2c80a328f991cf50b7"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"ee27361f52a2ef607460d185e431e7c11065fb50","unresolved":true,"context_lines":[{"line_number":24,"context_line":"           \"directory: tripleo-ansible-inventory.yaml. \\n\""},{"line_number":25,"context_line":"           \"To generate an inventory file, use the playbook in \""},{"line_number":26,"context_line":"           \"tripleo-ansible: cli-config-download.yaml\")"},{"line_number":27,"context_line":"    print(msg)"},{"line_number":28,"context_line":"    sys.exit(0)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"de2d95e3_2d3f3909","line":27,"in_reply_to":"65e7f908_77898f54","updated":"2021-10-13 07:23:38.000000000","message":"tripleo-deploy is for Undercloud, Standalone deployment and overcloud-deploy for Undercloud/Overcloud.\n\nI have just adapted the message, thx.","commit_id":"b2c469f91a2e3f23d5364c2c80a328f991cf50b7"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"1995584d9212fd9347ce73cd269ec8f00b212a7b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"           \"directory: tripleo-ansible-inventory.yaml. \\n\""},{"line_number":25,"context_line":"           \"To generate an inventory file, use the playbook in \""},{"line_number":26,"context_line":"           \"tripleo-ansible: cli-config-download.yaml\")"},{"line_number":27,"context_line":"    print(msg)"},{"line_number":28,"context_line":"    sys.exit(0)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"943d2808_e8673ac9","line":27,"in_reply_to":"de2d95e3_2d3f3909","updated":"2021-10-13 07:37:23.000000000","message":"Done","commit_id":"b2c469f91a2e3f23d5364c2c80a328f991cf50b7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a98acc863e8c16bb0bb5a9b247901d8276d01fae","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                      \u0027inventory data. If a comma delimited list \u0027"},{"line_number":53,"context_line":"                      \u0027of stacks is passed, the inventory will \u0027"},{"line_number":54,"context_line":"                      \u0027contain the union of those stacks.\u0027)),"},{"line_number":55,"context_line":"    cfg.ListOpt(\u0027stack\u0027, default\u003dNone,"},{"line_number":56,"context_line":"                help\u003d(\u0027This arg has the same effect \u0027"},{"line_number":57,"context_line":"                      \u0027as --plan. If both are specified,\u0027"},{"line_number":58,"context_line":"                      \u0027 --stack will take precedence.\u0027)),"},{"line_number":59,"context_line":"    cfg.StrOpt(\u0027ansible_ssh_user\u0027, default\u003dos.environ.get(\u0027ANSIBLE_SSH_USER\u0027,"},{"line_number":60,"context_line":"               \u0027heat-admin\u0027)),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027undercloud-connection\u0027,"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"d5df9bfc_2915a850","side":"PARENT","line":58,"range":{"start_line":55,"start_character":0,"end_line":58,"end_character":57},"updated":"2021-10-14 22:21:41.000000000","message":"I\u0027d just reuse this option and then auto locate ~/{tripleo,overcloud}-deploy/\u003cstack\u003e/\u003cinventory file\u003e and return that","commit_id":"483fbcc8d19fb21b0468d1947e499eedeb8d7061"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"ad91e5ee0ff96c0846e877ffcbb6720b751c428d","unresolved":true,"context_lines":[{"line_number":24,"context_line":"           \"under ~/tripleo-deploy/\u003cstack\u003e for a Standalone/Undercloud \""},{"line_number":25,"context_line":"           \"deployment or overcloud-deploy/\u003cstack\u003e for the Overcloud. \\n\""},{"line_number":26,"context_line":"           \"To generate an inventory file, use the playbook in \""},{"line_number":27,"context_line":"           \"tripleo-ansible: cli-config-download.yaml\")"},{"line_number":28,"context_line":"    print(msg)"},{"line_number":29,"context_line":"    sys.exit(0)"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"a119a816_e92533d7","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":53},"updated":"2021-10-14 07:33:00.000000000","message":"That would download configs along with generating inventory. You would probably need a simple playbook that calls \u0027tripleo_generate_ansible_inventory\u0027 module or a python script that call tripleo_common.inventory.generate_tripleo_ansible_inventory(...)?","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"a8647c21112ebe3da9f7b32f223e4ce0396a812e","unresolved":true,"context_lines":[{"line_number":24,"context_line":"           \"under ~/tripleo-deploy/\u003cstack\u003e for a Standalone/Undercloud \""},{"line_number":25,"context_line":"           \"deployment or overcloud-deploy/\u003cstack\u003e for the Overcloud. \\n\""},{"line_number":26,"context_line":"           \"To generate an inventory file, use the playbook in \""},{"line_number":27,"context_line":"           \"tripleo-ansible: cli-config-download.yaml\")"},{"line_number":28,"context_line":"    print(msg)"},{"line_number":29,"context_line":"    sys.exit(0)"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"e13a8560_274cfc53","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":53},"in_reply_to":"a119a816_e92533d7","updated":"2021-10-14 07:45:17.000000000","message":"Hey Rabi,\n\nThank you for your feedback.\nYes, I was thinking of doing that at 1st, but I didn\u0027t want to duplicate playbook code and avoid double maintenance if something change in the future.\nBut DF feedbacks are more than welcome, so I can do that as well, and yes it will avoid to do the whole config download process.\n\nOn the other hand, I\u0027m not really sure that executing manually the config download playbook will be something that the user will do very often.. I don\u0027t see why the tripleo-deploy and overcloud-deploy inventories will be dropped if the configs are still present.","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a98acc863e8c16bb0bb5a9b247901d8276d01fae","unresolved":true,"context_lines":[{"line_number":24,"context_line":"           \"under ~/tripleo-deploy/\u003cstack\u003e for a Standalone/Undercloud \""},{"line_number":25,"context_line":"           \"deployment or overcloud-deploy/\u003cstack\u003e for the Overcloud. \\n\""},{"line_number":26,"context_line":"           \"To generate an inventory file, use the playbook in \""},{"line_number":27,"context_line":"           \"tripleo-ansible: cli-config-download.yaml\")"},{"line_number":28,"context_line":"    print(msg)"},{"line_number":29,"context_line":"    sys.exit(0)"},{"line_number":30,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"eef08655_b0f0e07a","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":53},"in_reply_to":"e13a8560_274cfc53","updated":"2021-10-14 22:21:41.000000000","message":"Some users do invoke the ansible bits manually though they would usually include the inventory file from the exported directory rather than use tripleo-ansible-inventory","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"}],"tripleo_validations/utils.py":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"1995584d9212fd9347ce73cd269ec8f00b212a7b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    return glance_client.Client(2, session\u003dget_auth_session(auth_variables))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def get_heat_client(auth_variables):"},{"line_number":73,"context_line":"    return heat_client.Client(\u00271\u0027, session\u003dget_auth_session(auth_variables))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"36931894_38bfeb39","line":72,"updated":"2021-10-13 07:37:23.000000000","message":"Thanks for not removing it right now because used by lookup_plugins/stack_resources.py. Even if it doesn\u0027t work anymore.\nWe will fix that once we will have a better status on the legacy validations.","commit_id":"7dea65bd00c034dfc56e2726a484f7b4a2d98dd1"}]}