)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27427,"name":"David Peacock","email":"dpeacock@redhat.com","username":"davidjpeacock"},"change_message_id":"1ac2d1be2566b8450c3761518f440076dc6dbc37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2aa4654_01c249c9","updated":"2022-02-04 15:38:51.000000000","message":"Are there any instances in which localhost will not be the hostname required?","commit_id":"16dfbae6a0b36922497a124426d59a934b9d4256"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"a0105847dcdb8a58674f52fbb87625700b576b1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"525bbf85_a83667b0","in_reply_to":"1b001739_9781ed49","updated":"2022-02-07 07:06:36.000000000","message":"So the registry is usually accessed using something like \"undercloud.ctlplane\" or some other fancy, computer generated FQDN.\nThe \"localhost\" here is to ensure the \"uri\" module is working - but we could inject whatever name we want in the /etc/hosts and use it.\n\nThe replace as proposed should also allow to support any update to the vhost content, especially if we\u0027re going back to an actual hostname. But in such case, we\u0027d need to inject that hostname in the /etc/hosts during the molecule preparation task. Or something like that.","commit_id":"16dfbae6a0b36922497a124426d59a934b9d4256"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"37a8938f022a725f3b6e665f8a6abbcbaf0643e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b001739_9781ed49","in_reply_to":"d2aa4654_01c249c9","updated":"2022-02-04 15:46:54.000000000","message":"Possibly. But only hostnames consisting of exactly one \u0027*\u0027 char will be impacted by this change. The httpd config we are validating is only defining the listening behavior. We can\u0027t really check if the machine listens to any arbitrary address, so we use localhost instead.","commit_id":"16dfbae6a0b36922497a124426d59a934b9d4256"}],"roles/image_serve/tasks/main.yaml":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"099574e6205e0c4aaee284c889b8b96a5b484556","unresolved":true,"context_lines":[{"line_number":17,"context_line":"- name: Ensure port is open"},{"line_number":18,"context_line":"  wait_for:"},{"line_number":19,"context_line":"    port: \"{{ container_registry_port }}\""},{"line_number":20,"context_line":"    host: \"{{ virthost_name.stdout }}\""},{"line_number":21,"context_line":"    timeout: 10"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Ensure registry does answer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d803136d_c0a7ef08","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":4},"updated":"2022-02-04 06:29:27.000000000","message":"fun wait_for isn\u0027t crashing like uri... Should we do the same transformation for the sake of consistency?","commit_id":"0ae2661e0cd88155325d6206ce99f13270df8b68"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"62b4e626326d3af0ba1c571e97e6bae380c91adc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- name: Ensure port is open"},{"line_number":18,"context_line":"  wait_for:"},{"line_number":19,"context_line":"    port: \"{{ container_registry_port }}\""},{"line_number":20,"context_line":"    host: \"{{ virthost_name.stdout }}\""},{"line_number":21,"context_line":"    timeout: 10"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Ensure registry does answer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6ceaebb5_e520b908","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":4},"in_reply_to":"be0ae609_36d85ed7","updated":"2022-02-04 10:40:58.000000000","message":"Done","commit_id":"0ae2661e0cd88155325d6206ce99f13270df8b68"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"6549271fd3ee40a82cd965559f4b7ab8fcbd548a","unresolved":true,"context_lines":[{"line_number":17,"context_line":"- name: Ensure port is open"},{"line_number":18,"context_line":"  wait_for:"},{"line_number":19,"context_line":"    port: \"{{ container_registry_port }}\""},{"line_number":20,"context_line":"    host: \"{{ virthost_name.stdout }}\""},{"line_number":21,"context_line":"    timeout: 10"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Ensure registry does answer"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"be0ae609_36d85ed7","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":4},"in_reply_to":"d803136d_c0a7ef08","updated":"2022-02-04 07:07:14.000000000","message":"It is indeed interesting. socket lib used by wait_for module does perform substitution \u0027\u0027-\u003e\u00270.0.0.0\u0027[0] but I haven\u0027t found any mention of \u0027*\u0027-\u003ex in the docs.\n\nuri module works with subclassed urllib Request[1].\n\nI\u0027ll change the url in the wait_for to use the substitution. It\u0027s better not to leave anything to chance.\n\n[0]https://docs.python.org/3/library/socket.html#socket-families\n[1]https://docs.python.org/3/library/urllib.request.html","commit_id":"0ae2661e0cd88155325d6206ce99f13270df8b68"}]}