)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"898b50ce7238e8b23d498c09da9b622fe39584c4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Added backwards compatibility code until patch"},{"line_number":13,"context_line":"https://review.openstack.org/#/c/100381 merges."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I1057f4a1b6232332ed4b520dbc7b3bbb04145f73"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Co-authored-by: Duk Loi \u003cduk@tesora.com\u003e"},{"line_number":18,"context_line":"Change-Id: I1dffd373da722af55bdea41fead8456bb60c82b2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a930d6b_fa5550fa","line":15,"updated":"2015-01-24 00:21:05.000000000","message":"Can we update this commit message since it looks like this patch no longer depends on the other patch?\n\nThe patch looks ready to merge, but I mistakenly overlooked it since the dependent patch hasn\u0027t merged yet - if someone fixes this, all else looks pretty good.","commit_id":"188475427b916f60aeabf6c8ad6575e75f46a4a7"}],"scripts/files/trove-guest.systemd.conf":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"9e8d087aea55f08e538d0dcb1196902d765518c3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Ensure conf dir exists and is readable"},{"line_number":18,"context_line":"ExecStartPre\u003d/bin/bash \"mkdir -p /etc/trove/conf.d; chmod -R +r /etc/trove\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ExecStart\u003d/home/GUEST_USERNAME/trove/bin/trove-guestagent --config-dir\u003d/etc/trove/conf.d/guest_info --config-dir\u003d/etc/trove/conf.d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Give a reasonable amount of time for the server to start up/shut down"},{"line_number":23,"context_line":"TimeoutSec\u003d300"}],"source_content_type":"text/plain","patch_set":2,"id":"baada198_bd62ae3b","line":20,"updated":"2014-07-14 21:44:40.000000000","message":"--config-dir\u003d/etc/trove/conf.d/guest_info should be removed?","commit_id":"5db118f8fc83b5983634246e4171d89250247432"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ab4e72ab957f1aaa98fdd5ea4afcfeede5182c81","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Ensure conf dir exists and is readable"},{"line_number":18,"context_line":"ExecStartPre\u003d/bin/bash \"mkdir -p /etc/trove/conf.d; chmod -R +r /etc/trove\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ExecStart\u003d/home/GUEST_USERNAME/trove/bin/trove-guestagent --config-dir\u003d/etc/trove/conf.d/guest_info --config-dir\u003d/etc/trove/conf.d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Give a reasonable amount of time for the server to start up/shut down"},{"line_number":23,"context_line":"TimeoutSec\u003d300"}],"source_content_type":"text/plain","patch_set":2,"id":"baada198_f8243461","line":20,"in_reply_to":"baada198_bd62ae3b","updated":"2014-07-14 22:02:21.000000000","message":"even more, guest_info should remain (according to previous comments), but, as Vipul mentioned, guest_info should be loaded with --conf-file shell attribute.","commit_id":"5db118f8fc83b5983634246e4171d89250247432"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"b40d24fe3b3e7c090d430f2edabfe8b60c093285","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Ensure conf dir exists and is readable"},{"line_number":18,"context_line":"ExecStartPre\u003d/bin/bash \"mkdir -p /etc/trove/conf.d; chmod -R +r /etc/trove\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ExecStart\u003d/home/GUEST_USERNAME/trove/bin/trove-guestagent --config-dir\u003d/etc/trove/conf.d/guest_info --config-dir\u003d/etc/trove/conf.d"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Give a reasonable amount of time for the server to start up/shut down"},{"line_number":23,"context_line":"TimeoutSec\u003d300"}],"source_content_type":"text/plain","patch_set":2,"id":"baada198_6c7b07f5","line":20,"in_reply_to":"baada198_f8243461","updated":"2014-07-15 00:04:50.000000000","message":"Actually guest_info does not need to remain. We don\u0027t need kick-start images to work with older versions of trove.\n\nThe backwards-compatibility concern is with juno trove-taskmanager booting a guest image created earlier, that expects /etc/guest_info. I\u0027ll address this in the trove patch set and will only use --conf-dir here.","commit_id":"5db118f8fc83b5983634246e4171d89250247432"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"215df24c294fd242c51b06e9732ee76c5a37dcdd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ExecStartPre\u003d/bin/bash \"test -f /home/GUEST_USERNAME/trove-installed || sudo -u GUEST_USERNAME rsync -e \u0027ssh -o UserKnownHostsFile\u003d/dev/null -o StrictHostKeyChecking\u003dno\u0027 -avz --exclude\u003d\u0027.*\u0027 HOST_SCP_USERNAME@NETWORK_GATEWAY:PATH_TROVE/ /home/GUEST_USERNAME/trove \u0026\u0026 touch /home/GUEST_USERNAME/trove-installed\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Ensure conf dir exists and is readable"},{"line_number":18,"context_line":"ExecStartPre\u003d/bin/bash \"mkdir -p /etc/trove/conf.d; chmod -R +r /etc/trove\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ExecStart\u003d/home/GUEST_USERNAME/trove/bin/trove-guestagent --config-dir\u003d/etc/trove/conf.d"},{"line_number":21,"context_line":""}],"source_content_type":"text/plain","patch_set":5,"id":"da9df570_cbc8a057","line":18,"updated":"2014-09-26 17:04:57.000000000","message":"I am quite puzzled by this +r ...","commit_id":"656eb564b3f5c98e6993271cc9b371f830f3cec8"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"591c518ccabe4a7a3fbc60f6ce9032a458995416","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ExecStartPre\u003d/bin/bash \"test -f /home/GUEST_USERNAME/trove-installed || sudo -u GUEST_USERNAME rsync -e \u0027ssh -o UserKnownHostsFile\u003d/dev/null -o StrictHostKeyChecking\u003dno\u0027 -avz --exclude\u003d\u0027.*\u0027 HOST_SCP_USERNAME@NETWORK_GATEWAY:PATH_TROVE/ /home/GUEST_USERNAME/trove \u0026\u0026 touch /home/GUEST_USERNAME/trove-installed\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Ensure conf dir exists and is readable"},{"line_number":18,"context_line":"ExecStartPre\u003d/bin/bash \"mkdir -p /etc/trove/conf.d; chmod -R +r /etc/trove\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ExecStart\u003d/home/GUEST_USERNAME/trove/bin/trove-guestagent --config-dir\u003d/etc/trove/conf.d"},{"line_number":21,"context_line":""}],"source_content_type":"text/plain","patch_set":5,"id":"1a930d6b_a2acc3a1","line":18,"in_reply_to":"da9df570_4bce702f","updated":"2015-01-22 15:20:21.000000000","message":"yes, I\u0027m curious what umask must\u0027ve been for that to be required.","commit_id":"656eb564b3f5c98e6993271cc9b371f830f3cec8"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"89aa5a3a83de7a9d302b444f2c93a782a99bbc8a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ExecStartPre\u003d/bin/bash \"test -f /home/GUEST_USERNAME/trove-installed || sudo -u GUEST_USERNAME rsync -e \u0027ssh -o UserKnownHostsFile\u003d/dev/null -o StrictHostKeyChecking\u003dno\u0027 -avz --exclude\u003d\u0027.*\u0027 HOST_SCP_USERNAME@NETWORK_GATEWAY:PATH_TROVE/ /home/GUEST_USERNAME/trove \u0026\u0026 touch /home/GUEST_USERNAME/trove-installed\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Ensure conf dir exists and is readable"},{"line_number":18,"context_line":"ExecStartPre\u003d/bin/bash \"mkdir -p /etc/trove/conf.d; chmod -R +r /etc/trove\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ExecStart\u003d/home/GUEST_USERNAME/trove/bin/trove-guestagent --config-dir\u003d/etc/trove/conf.d"},{"line_number":21,"context_line":""}],"source_content_type":"text/plain","patch_set":5,"id":"da9df570_4bce702f","line":18,"in_reply_to":"da9df570_cbc8a057","updated":"2015-01-21 21:48:59.000000000","message":"It\u0027s equivalent to a+r, i.e. change the permissions to make it readable to all.","commit_id":"656eb564b3f5c98e6993271cc9b371f830f3cec8"}],"scripts/files/trove-guest.upstart.conf":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"9e8d087aea55f08e538d0dcb1196902d765518c3","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"end script"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"exec su -c \"/home/GUEST_USERNAME/trove/contrib/trove-guestagent --config-file\u003d/etc/trove/conf.d/guest_info --config-dir\u003d/etc/trove/conf.d\" GUEST_USERNAME"}],"source_content_type":"text/plain","patch_set":2,"id":"baada198_bdf0ee67","line":28,"updated":"2014-07-14 21:44:40.000000000","message":"--config-file\u003d/etc/trove/conf.d/guest_info should be removed, since you\u0027re now supplying the --config-dir argument?  (i am assuming that --config-dir is a catch all for all files in conf.d)","commit_id":"5db118f8fc83b5983634246e4171d89250247432"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"ab4e72ab957f1aaa98fdd5ea4afcfeede5182c81","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"end script"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"exec su -c \"/home/GUEST_USERNAME/trove/contrib/trove-guestagent --config-file\u003d/etc/trove/conf.d/guest_info --config-dir\u003d/etc/trove/conf.d\" GUEST_USERNAME"}],"source_content_type":"text/plain","patch_set":2,"id":"baada198_38978c49","line":28,"in_reply_to":"baada198_bdf0ee67","updated":"2014-07-14 22:02:21.000000000","message":"--config-dir catches files only with *.conf extension(guest_info doesn\u0027t have it)\n\nhere\u0027s a prof. link to oslo.config mechenis that describes all files with *.conf under given directory(from --conf-dir)\n\nhttps://github.com/openstack/oslo.config/blob/master/oslo/config/cfg.py#L509-L544","commit_id":"5db118f8fc83b5983634246e4171d89250247432"}]}