)]}'
{"scripts/redstack":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7cfb3767008a9a915c0bb5d560bf58b5af76e9b2","unresolved":false,"context_lines":[{"line_number":747,"context_line":"function cmd_map_flavors() {"},{"line_number":748,"context_line":"    exclaim \"Mapping default flavors to the default datatstore version\""},{"line_number":749,"context_line":"    DEFAULT_VERSION\u003d`rd_manage get_datastore_version_id`"},{"line_number":750,"context_line":"    DEFAULT_FLAVORS\u003d`nova --os-username\u003dtrove --os-password\u003d$SERVICE_PASSWORD --os-tenant-name\u003d$SERVICE_TENANT --os-auth-url\u003d$TROVE_AUTH_ENDPOINT flavor-list | awk -vORS\u003d, \u0027{ print $2}\u0027|sed \u0027s/,$//\u0027|sed \u0027s/,$//\u0027|cut -d\u0027,\u0027 -f4- -s`"},{"line_number":751,"context_line":"    rd_manage datastore_flavor_add `echo $DEFAULT_VERSION|cut -d\u0027 \u0027 -f3`\\"},{"line_number":752,"context_line":"         `echo $DEFAULT_FLAVORS|cut -d\u0027 \u0027 -f2`"},{"line_number":753,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"baada198_9396b947","line":750,"updated":"2014-07-28 10:40:54.000000000","message":"Instead of passing all attributes required for auth procedure, use next:\n\nsource ~/devstack/openrc; nova flavor-list","commit_id":"48c60bf0e52652cb89d58314a1b0e5346326ef43"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b3596de1fea04fbe88bb6c5ffeafa2e6f2a0624b","unresolved":false,"context_lines":[{"line_number":746,"context_line":""},{"line_number":747,"context_line":"function cmd_map_flavors() {"},{"line_number":748,"context_line":"    exclaim \"Mapping default flavors to the default datatstore version\""},{"line_number":749,"context_line":"    DEFAULT_VERSION\u003d`rd_manage get_datastore_version_id`"},{"line_number":750,"context_line":"    DEFAULT_FLAVORS\u003d`source ~/devstack/openrc; nova flavor-list | awk -vORS\u003d, \u0027{ print $2}\u0027|sed \u0027s/,$//\u0027|sed \u0027s/,$//\u0027|cut -d\u0027,\u0027 -f4- -s`"},{"line_number":751,"context_line":"    rd_manage datastore_flavor_add `echo $DEFAULT_VERSION|cut -d\u0027 \u0027 -f3`\\"},{"line_number":752,"context_line":"         `echo $DEFAULT_FLAVORS|cut -d\u0027 \u0027 -f2`"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_73b02cfd","line":749,"range":{"start_line":749,"start_character":4,"end_line":749,"end_character":56},"updated":"2014-07-28 21:17:44.000000000","message":"another thing, out of this code this method is useless, so, please find another way to get datastore version.\n\nuse Datastore/Versions API to query datastore version.","commit_id":"aa11980d175b892e27f5e4c708759392b58d9865"},{"author":{"_account_id":7796,"name":"Riddhi Shah","email":"ridhi.j.shah@gmail.com","username":"ridhi-j-shah"},"change_message_id":"b32ac8472f8b2e6c4cfe6fe40492196b7b192581","unresolved":false,"context_lines":[{"line_number":746,"context_line":""},{"line_number":747,"context_line":"function cmd_map_flavors() {"},{"line_number":748,"context_line":"    exclaim \"Mapping default flavors to the default datatstore version\""},{"line_number":749,"context_line":"    DEFAULT_VERSION\u003d`rd_manage get_datastore_version_id`"},{"line_number":750,"context_line":"    DEFAULT_FLAVORS\u003d`source ~/devstack/openrc; nova flavor-list | awk -vORS\u003d, \u0027{ print $2}\u0027|sed \u0027s/,$//\u0027|sed \u0027s/,$//\u0027|cut -d\u0027,\u0027 -f4- -s`"},{"line_number":751,"context_line":"    rd_manage datastore_flavor_add `echo $DEFAULT_VERSION|cut -d\u0027 \u0027 -f3`\\"},{"line_number":752,"context_line":"         `echo $DEFAULT_FLAVORS|cut -d\u0027 \u0027 -f2`"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_f4a08344","line":749,"in_reply_to":"baada198_73b02cfd","updated":"2014-07-29 15:38:58.000000000","message":"I agree on the method being of no use out of this code. But, using the Datastore/versions api lists all the available versions for the given datastore and not the default version only. Hence, in my next patch, I query the datastores table to get the default id for the default datastore.","commit_id":"aa11980d175b892e27f5e4c708759392b58d9865"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"1cb4f1de67b1d0e6e252ea3a1173edca778945e1","unresolved":false,"context_lines":[{"line_number":746,"context_line":""},{"line_number":747,"context_line":"function cmd_map_flavors() {"},{"line_number":748,"context_line":"    exclaim \"Mapping default flavors to the default datatstore version\""},{"line_number":749,"context_line":"    DEFAULT_VERSION\u003d$(echo \"use trove;SELECT default_version_id FROM datastores WHERE name LIKE \u0027$DATASTORE_TYPE\u0027\"| mysql -u root -p$MYSQL_PASSWORD|tr \"\\n\" \" \"|cut -d\u0027 \u0027 -f2)"},{"line_number":750,"context_line":"    DEFAULT_FLAVORS\u003d`nova flavor-list | awk -vORS\u003d, \u0027{ print $2}\u0027|sed \u0027s/,$//\u0027|sed \u0027s/,$//\u0027|cut -d\u0027,\u0027 -f4- -s`"},{"line_number":751,"context_line":"    rd_manage datastore_flavor_add `echo $DEFAULT_VERSION|cut -d\u0027 \u0027 -f3`\\"},{"line_number":752,"context_line":"         `echo $DEFAULT_FLAVORS|cut -d\u0027 \u0027 -f2`"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"baada198_47e34334","line":749,"updated":"2014-07-29 15:45:00.000000000","message":"it\u0027s too complicated, you don\u0027t you use what was done in devstack exercises? see https://github.com/openstack-dev/devstack/blob/master/exercises/trove.sh#L39-L43","commit_id":"796bad1b5582ed59faee49b5b01b76570faacb44"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"bfffdd6dffebda612fd221db1cb07922de3e1e7d","unresolved":false,"context_lines":[{"line_number":746,"context_line":""},{"line_number":747,"context_line":"function cmd_map_flavors() {"},{"line_number":748,"context_line":"    exclaim \"Mapping default flavors to the default datatstore version\""},{"line_number":749,"context_line":"    DEFAULT_VERSION\u003d`trove datastore-show $DATASTORE_TYPE | get_field 2 | awk \u0027FNR \u003d\u003d 4\u0027`"},{"line_number":750,"context_line":"    DEFAULT_FLAVORS\u003d`nova flavor-list | awk -vORS\u003d, \u0027{ print $2}\u0027|sed \u0027s/,$//\u0027|sed \u0027s/,$//\u0027|cut -d\u0027,\u0027 -f4- -s`"},{"line_number":751,"context_line":"    rd_manage datastore_flavor_add `echo $DEFAULT_VERSION|cut -d\u0027 \u0027 -f3`\\"},{"line_number":752,"context_line":"         `echo $DEFAULT_FLAVORS|cut -d\u0027 \u0027 -f2`"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"baada198_a3e1539d","line":749,"updated":"2014-07-30 09:02:24.000000000","message":"nice","commit_id":"7b5caa7e8838c45f5d36f46662ba23e0dddc902c"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"f4c5b0149522bae617175975eca4457fe59f6086","unresolved":false,"context_lines":[{"line_number":756,"context_line":"    source $PATH_DEVSTACK_SRC/openrc admin admin"},{"line_number":757,"context_line":"    cmd_test_init"},{"line_number":758,"context_line":"    cmd_build_and_upload_image $1"},{"line_number":759,"context_line":"    cmd_map_flavors"},{"line_number":760,"context_line":"}"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"function cmd_reset_task() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_6694d337","line":759,"updated":"2014-08-18 06:28:21.000000000","message":"Shouldn\u0027t this be part of cmd_set_datastore? It seems to make sense that one would define flavor mappings when one is defining the datastore / datastore version.\n\nIs it now mandatory to set up this mapping before a datastore type is usable?","commit_id":"7b5caa7e8838c45f5d36f46662ba23e0dddc902c"},{"author":{"_account_id":7796,"name":"Riddhi Shah","email":"ridhi.j.shah@gmail.com","username":"ridhi-j-shah"},"change_message_id":"322516eb48c39c8e1dafe79adccc5722e684b878","unresolved":false,"context_lines":[{"line_number":756,"context_line":"    source $PATH_DEVSTACK_SRC/openrc admin admin"},{"line_number":757,"context_line":"    cmd_test_init"},{"line_number":758,"context_line":"    cmd_build_and_upload_image $1"},{"line_number":759,"context_line":"    cmd_map_flavors"},{"line_number":760,"context_line":"}"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"function cmd_reset_task() {"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1abeadc6_23c2a4e9","line":759,"in_reply_to":"1abeadc6_6694d337","updated":"2014-08-18 23:28:56.000000000","message":"It would definitely make more sense for this to be a part of cmd_set_datastore. Will go ahead and change that.\n\nSince I refactored the way we were obtaining the flavor list (as seen in https://review.openstack.org/#/c/109824/7/trove/flavor/models.py), the mapping set up here makes sure that the nova flavors are set and can be retrieved at least for the default datastore version like before. The mgmt api can then be used to add or delete mappings.","commit_id":"7b5caa7e8838c45f5d36f46662ba23e0dddc902c"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"0f8ec217fe42a77af264fc4ccfbf6d48d6520eaf","unresolved":false,"context_lines":[{"line_number":746,"context_line":"}"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"function cmd_map_flavors() {"},{"line_number":749,"context_line":"    exclaim \"Mapping default flavors to the default datatstore version\""},{"line_number":750,"context_line":"    DEFAULT_VERSION\u003d`trove datastore-show $DATASTORE_TYPE | get_field 2 | awk \u0027FNR \u003d\u003d 4\u0027`"},{"line_number":751,"context_line":"    DEFAULT_FLAVORS\u003d`nova flavor-list | awk -vORS\u003d, \u0027{ print $2}\u0027|sed \u0027s/,$//\u0027|sed \u0027s/,$//\u0027|cut -d\u0027,\u0027 -f4- -s`"},{"line_number":752,"context_line":"    rd_manage datastore_flavor_add `echo $DEFAULT_VERSION|cut -d\u0027 \u0027 -f3`\\"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"fa98f980_524702bc","line":749,"updated":"2014-09-04 02:46:15.000000000","message":"typo: datatstore","commit_id":"69cbcbdc4a4d01594623fe3e75af0ebdb5882928"}]}