)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"7fa2bbdba9ddd1cc5a25db1c34923ed0d4eba56e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Carrys the proxy variable while installing trove-integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: BugFix"},{"line_number":10,"context_line":"Closes-Bug: 1322200"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Carrys the proxy variable (http_proxy/https_proxy/no_proxy) to sudo,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_9242a50b","line":9,"updated":"2014-08-07 19:57:24.000000000","message":"please remove this line","commit_id":"ceea648293684c1d12a7098ebc7b71e7674ccf93"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"96abb7630f6e37242dfb64f783d50fac557ea1cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vigneshvar \u003cvigneshvar.a.s@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-21 22:10:18 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Carrys the proxy variable while installing trove-integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1322200"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1abeadc6_12fc70b7","line":7,"updated":"2014-08-22 12:50:40.000000000","message":"Carries, maybe?","commit_id":"8e8f0e92792e09b8716f7410b42b679ec0173582"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b45c084077ec195fdcebd94be7d03161b15d71eb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Closes-Bug: 1322200"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Carrys the proxy variable (http_proxy/https_proxy/no_proxy) to sudo,"},{"line_number":12,"context_line":"while installing trove-integration. Fixing the Bug 1322200"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I23c0b5a5f6ae6cecacf15fc68be8e53effd03532"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1abeadc6_f321da4d","line":12,"updated":"2014-08-21 17:01:56.000000000","message":"Also, you don\u0027t need to mention the bug number twice ;)","commit_id":"8e8f0e92792e09b8716f7410b42b679ec0173582"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"aca3a80de4c9a724055b82aac264458133a4d8a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Carries the proxy variable while installing trove-integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1322200"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Carries the proxy variable (http_proxy/https_proxy/no_proxy) to sudo,"},{"line_number":12,"context_line":"while installing trove-integration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1abeadc6_e174f19d","line":9,"updated":"2014-08-27 08:49:38.000000000","message":"One of the issues mentioned in the bug is that when the proxy is set, it\u0027s being used over eagerly for all calls including calls that connect to the local OpenStack service.\n\nIn order to fix this, you\u0027d have to do something akin to configuring an exception list using the no_proxy env variable that included the local machine, and the fixed and floating ranges set in devstack.\n\nI don\u0027t see that being tackled in this patchset though. Can you please clarify?\n\nThanks!","commit_id":"cdc4b1b78abb969a427c808b1e8ccb952addffb9"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"8a890663ef1a0b52692f9cd2c4b01a70d2e353e6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Carries the proxy variable while installing trove-integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1322200"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Carries the proxy variable (http_proxy/https_proxy/no_proxy) to sudo,"},{"line_number":12,"context_line":"while installing trove-integration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1abeadc6_80932ef9","line":9,"in_reply_to":"1abeadc6_e174f19d","updated":"2014-08-27 13:15:05.000000000","message":"I was assuming, when http_proxy and https_proxy are set, similarly no_proxy should be set by the user. While i was trying to figure out that, i probably got carried over by this issue of proxy variable not set during sudo - install. I think i have misunderstood the bug. Yes its my bad and i probably been too enthusiastic as this is my first bug fix.\n\nCould you help me, should i raise a new bug and patch it with this fix.? I am not really aware what should be done.","commit_id":"cdc4b1b78abb969a427c808b1e8ccb952addffb9"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"68be3855a3ad68c59f67d0b96701d32c4ef5f8db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Carries the proxy variable while installing trove-integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1362797"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Carries the proxy variable (http_proxy/https_proxy/no_proxy) to sudo,"},{"line_number":12,"context_line":"while installing trove-integration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1abeadc6_1edaad77","line":9,"updated":"2014-08-29 17:21:57.000000000","message":"for all reviewers ... please note that the bug number here has changed. In earlier reviews the bug number was 1322200. The bug number now is 1362797.","commit_id":"2d4426aaf86d2fbcaf933ed90480ab17cf287745"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"68be3855a3ad68c59f67d0b96701d32c4ef5f8db","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1362797"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Carries the proxy variable (http_proxy/https_proxy/no_proxy) to sudo,"},{"line_number":12,"context_line":"while installing trove-integration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\"redstack install\" fails to complete behind proxy as few of the installation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1abeadc6_3ee5a937","line":11,"updated":"2014-08-29 17:21:57.000000000","message":"Are you carrying no_proxy? I believe not. You are only carrying ${HTTP_PROXY} which is http_proxy and https_proxy.\n\nRight?","commit_id":"2d4426aaf86d2fbcaf933ed90480ab17cf287745"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"03366631dbf084ba62722d3d3a9fff01014d53d5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Carries the proxy variable while installing trove-integration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1362797"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Carries the proxy variable (http_proxy/https_proxy) to sudo,"},{"line_number":12,"context_line":"while installing trove-integration."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1abeadc6_49fab143","line":10,"updated":"2014-08-30 14:46:39.000000000","message":"For all reviewers, please note that the bug number here has changed.\nIn earlier reviews the bug number was 1322200. The bug number now is 1362797.","commit_id":"7081a61666dabc8ff7b6e7e189c9ce7cb999ff2d"}],"scripts/redstack":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"02f7eacab47fa06807c238f56acf0c0f8062c946","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    pkg_update"},{"line_number":153,"context_line":"    exclaim \u0027Installing dependencies (part 1b)...\u0027"},{"line_number":154,"context_line":"    pkg_install git-core kvm-ipxe python-pip gettext"},{"line_number":155,"context_line":"    sudo $HTTP_PROXY pip install --upgrade pip"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"function install_devstack_code() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_b538d3d5","line":155,"updated":"2014-08-25 07:58:57.000000000","message":"Shouldn\u0027t this be something like http_proxy\u003d$http_proxy for it to work correctly?\n\nThe only reason this is passing tests, I think, is because HTTP_PROXY is unset.","commit_id":"cdc4b1b78abb969a427c808b1e8ccb952addffb9"},{"author":{"_account_id":12487,"name":"vigneshvar","email":"vigneshvar.a.s@gmail.com","username":"vigneshvar"},"change_message_id":"93ad67533e956b9d7f393e4510b2eccdc68e5bc6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    pkg_update"},{"line_number":153,"context_line":"    exclaim \u0027Installing dependencies (part 1b)...\u0027"},{"line_number":154,"context_line":"    pkg_install git-core kvm-ipxe python-pip gettext"},{"line_number":155,"context_line":"    sudo $HTTP_PROXY pip install --upgrade pip"},{"line_number":156,"context_line":"}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"function install_devstack_code() {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1abeadc6_02c3fd8a","line":155,"in_reply_to":"1abeadc6_b538d3d5","updated":"2014-08-25 16:09:05.000000000","message":"There is a function defined already.\nfunction set_http_proxy() {\n    if [ ! \"${http_proxy}\" \u003d \u0027\u0027 ]; then\n        HTTP_PROXY\u003d\"http_proxy\u003d$http_proxy https_proxy\u003d$https_proxy\"\n    fi\n}\n\nYou might need to get the entire script to view it.\nThis variable $HTTP_PROXY is being used already in the existing code (Eg: function  pkg_install ). Kindly Review my patch again.","commit_id":"cdc4b1b78abb969a427c808b1e8ccb952addffb9"}],"scripts/redstack.rc":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"56008896173062349dac56c48c8221487428f898","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Adding alias to sudo, to carry current environmental variables"},{"line_number":2,"context_line":"shopt -s expand_aliases"},{"line_number":3,"context_line":"alias sudo\u003d\"sudo -E\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Paths inside the VM."},{"line_number":6,"context_line":"[ -z $SERVICE_HOST ] \u0026\u0026 SERVICE_HOST\u003d`get_default_host_ip`"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"baada198_589c27bf","line":3,"range":{"start_line":3,"start_character":6,"end_line":3,"end_character":10},"updated":"2014-08-12 14:19:56.000000000","message":"Don\u0027t use aliases in shell scripts.  It will not be clear to future readers that the environment is being passed.  Instead, set \"SUDO\u003dsudo -E\" then use \"$SUDO cmd\" in the shell script.","commit_id":"82bc71d84f5314a3cd4cbca369c4d550b92840de"}]}