)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"546edf1c5116f4fd7e9a3c1b37eb56e0f23eaeef","unresolved":false,"context_lines":[{"line_number":12,"context_line":"upstart/systemd to rsync it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I960c4cf415ca427df07c48865f1ebc9e20a548a9"},{"line_number":15,"context_line":"Implements: blueprint rsync-optional"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a930d6b_dd9c0e12","line":15,"updated":"2015-01-24 02:19:51.000000000","message":"can\u0027t find this BP","commit_id":"7ab4b09eb72c0942f0a218b0dde0fca5fb284f9f"}],"scripts/files/elements/ubuntu-guest/extra-data.d/97-guest-code":[{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"fbb1bd1162bd4de6c338992657fe0a66b80e0f67","unresolved":false,"context_lines":[{"line_number":14,"context_line":"if [ -n \"${GUEST_LOCAL_TROVE_DIR}\" ] \u0026\u0026"},{"line_number":15,"context_line":"   [ -n \"${GUEST_LOCAL_TROVE_CONF}\" ]; then"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    if [ -e ${GUEST_LOCAL_TROVE_DIR} ]; then"},{"line_number":18,"context_line":"        sudo cp -R ${GUEST_LOCAL_TROVE_DIR} ${TMP_HOOKS_PATH}/trove"},{"line_number":19,"context_line":"    else"},{"line_number":20,"context_line":"        die \"GUEST_LOCAL_TROVE_DIR needs to be set to the local directory of the guest agent code\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_4414609f","line":17,"updated":"2014-09-15 19:57:20.000000000","message":"You could use -d here.","commit_id":"5cbc771d93e9a60a1778a27b493bc88a322d4a8b"},{"author":{"_account_id":9683,"name":"Mat Lowery","email":"mlowery@ebaysf.com","username":"mat-lowery"},"change_message_id":"fbb1bd1162bd4de6c338992657fe0a66b80e0f67","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        die \"GUEST_LOCAL_TROVE_DIR needs to be set to the local directory of the guest agent code\""},{"line_number":21,"context_line":"    fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if [ -e ${GUEST_LOCAL_TROVE_CONF} ]; then"},{"line_number":24,"context_line":"        sudo cp ${GUEST_LOCAL_TROVE_CONF} ${TMP_HOOKS_PATH}/trove-guestagent.conf"},{"line_number":25,"context_line":"    else"},{"line_number":26,"context_line":"        die \"GUEST_LOCAL_TROVE_CONF needs to be set to the local path of trove-guestagent.conf\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_84e648ae","line":23,"updated":"2014-09-15 19:57:20.000000000","message":"You could use -f here.","commit_id":"5cbc771d93e9a60a1778a27b493bc88a322d4a8b"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c0c7b2357b8140f4a49eb1d9b801c398894f411d","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"source $_LIB/die"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[ -n \"$TMP_HOOKS_PATH.\" ] || die \"Temp hook path not set\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ -n \"${GUEST_LOCAL_TROVE_DIR}\" ] \u0026\u0026"},{"line_number":15,"context_line":"   [ -n \"${GUEST_LOCAL_TROVE_CONF}\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"3a961159_1f0cd741","line":12,"updated":"2015-01-05 19:18:45.000000000","message":"This shouldn\u0027t have the \u0027.\u0027 after $TMP_HOOKS_PATH - it\u0027ll always evaluate to true","commit_id":"7ab4b09eb72c0942f0a218b0dde0fca5fb284f9f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"50d54d1bd5412c36a105d6d317dd01eb676191ef","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"source $_LIB/die"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[ -n \"$TMP_HOOKS_PATH.\" ] || die \"Temp hook path not set\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ -n \"${GUEST_LOCAL_TROVE_DIR}\" ] \u0026\u0026"},{"line_number":15,"context_line":"   [ -n \"${GUEST_LOCAL_TROVE_CONF}\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a930d6b_5c1df2bc","line":12,"in_reply_to":"3a961159_1f0cd741","updated":"2015-01-21 13:50:15.000000000","message":"Yes, makes sense. But, IMHO, playing around with DIB i haven\u0027t seen that TMP_HOOKS_PATH wasn\u0027t set.","commit_id":"7ab4b09eb72c0942f0a218b0dde0fca5fb284f9f"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"546edf1c5116f4fd7e9a3c1b37eb56e0f23eaeef","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"source $_LIB/die"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[ -n \"$TMP_HOOKS_PATH.\" ] || die \"Temp hook path not set\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"if [ -n \"${GUEST_LOCAL_TROVE_DIR}\" ] \u0026\u0026"},{"line_number":15,"context_line":"   [ -n \"${GUEST_LOCAL_TROVE_CONF}\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a930d6b_fd9d4a0b","line":12,"in_reply_to":"3a961159_1f0cd741","updated":"2015-01-24 02:19:51.000000000","message":"yes, earlier comment I made relates to this line of code.","commit_id":"7ab4b09eb72c0942f0a218b0dde0fca5fb284f9f"}],"scripts/files/elements/ubuntu-guest/install.d/97-guest-code":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"f67cf7d8be49dd86d5a88001920f9cffc6d24e86","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"if [ -e \"${TMP_HOOKS_DIR}/trove-guestagent.conf\" ]; then"},{"line_number":18,"context_line":"    sudo mkdir -p /etc/trove"},{"line_number":19,"context_line":"    sudo cp ${TMP_HOOKS_DIR}/trove-guestagent.conf /etc/trove/trove-guestagent.conf"},{"line_number":20,"context_line":"    sudo chown -R ${GUEST_USERNAME}:${GUEST_USERNAME} /etc/trove"},{"line_number":21,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a890539_7e54d4c5","line":19,"updated":"2014-12-03 13:24:38.000000000","message":"I don\u0027t think that we should do it in this way. We just need to fix https://bugs.launchpad.net/trove/+bug/1265184\nand that\u0027s all.","commit_id":"7ab4b09eb72c0942f0a218b0dde0fca5fb284f9f"}]}
