)]}'
{"scripts/functions_qemu":[{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"2867d728a51e020bf7a16bf45ed8f8f7e46d49d8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        do"},{"line_number":97,"context_line":"            if [ \"${ELEMENT_FILE}\" -nt \"${VM_PATH}\" ]"},{"line_number":98,"context_line":"            then"},{"line_number":99,"context_line":"                IMAGE_OLD\u003d\"true\""},{"line_number":100,"context_line":"                exclaim \"${COLOR_RED}WARNING: Element file \u0027${ELEMENT_FILE}\u0027 is newer than cached image${COLOR_NONE}\""},{"line_number":101,"context_line":"                break"},{"line_number":102,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa81d914_fa155949","line":99,"updated":"2015-01-29 23:33:51.000000000","message":"This is not necessary. Just print the message right in the validation loop before break.","commit_id":"0ca3bb68a3c6e3d9207df9559aac6a1415a68002"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"03d81ef9b00974a9bd3cf63d18d73f3e1282daae","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        touch -c \"${VM_PATH}\""},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        exclaim \"Found image in $VM_PATH - using the qcow2 image found here...\""},{"line_number":92,"context_line":"        ELEMENTS_DIR\u003d\"files/elements/${DISTRO}-${SERVICE_TYPE}\""},{"line_number":93,"context_line":"        # Print out a warning if we think the image is too old"},{"line_number":94,"context_line":"        for ELEMENT_FILE in $(find ${ELEMENTS_DIR});"},{"line_number":95,"context_line":"        do"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa81d914_eec837aa","line":92,"updated":"2015-01-30 01:25:49.000000000","message":"You will need to check ${DISTRO}-guest too.","commit_id":"64e7ae84c9a2e2a4288f810037efc07a9fb23093"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"4693ec0a800903f1be7f3b62a6d40dfe237e7643","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        touch -c \"${VM_PATH}\""},{"line_number":90,"context_line":"    else"},{"line_number":91,"context_line":"        exclaim \"Found image in $VM_PATH - using the qcow2 image found here...\""},{"line_number":92,"context_line":"        ELEMENTS_DIR\u003d\"files/elements/${DISTRO}-${SERVICE_TYPE}\""},{"line_number":93,"context_line":"        # Print out a warning if we think the image is too old"},{"line_number":94,"context_line":"        for ELEMENT_FILE in $(find ${ELEMENTS_DIR});"},{"line_number":95,"context_line":"        do"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa81d914_e96bd1ee","line":92,"in_reply_to":"fa81d914_eec837aa","updated":"2015-01-30 02:48:03.000000000","message":"Done\n\nAlso fixed issue with for loop potentially skipping files with spaces","commit_id":"64e7ae84c9a2e2a4288f810037efc07a9fb23093"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"c40e6f0201b7d86e5c344620875b10eca0f80878","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        exclaim \"Found image in $VM_PATH - using the qcow2 image found here...\""},{"line_number":92,"context_line":"        ELEMENTS_DIR\u003d\"files/elements/${DISTRO}-${SERVICE_TYPE}\""},{"line_number":93,"context_line":"        ELEMENTS_DIR_GUEST\u003d\"files/elements/${DISTRO}-guest\""},{"line_number":94,"context_line":"        # Print out a warning if we think the image is too old"},{"line_number":95,"context_line":"        while IFS\u003d read -r -d \u0027\u0027 ELEMENT_FILE"},{"line_number":96,"context_line":"        do"},{"line_number":97,"context_line":"            if [ \"${ELEMENT_FILE}\" -nt \"${VM_PATH}\" ]"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da86d52c_20ba9c23","line":94,"updated":"2015-02-02 19:48:28.000000000","message":"Better comment would be the criteria of old-ness of image instead of \"we think\"","commit_id":"d719dc8acc223e74ac94c70b29920c1ee703faef"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b9708ffb2108e3581efcb618f4d6b312a0982b0f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        exclaim \"Found image in $VM_PATH - using the qcow2 image found here...\""},{"line_number":92,"context_line":"        ELEMENTS_DIR\u003d\"files/elements/${DISTRO}-${SERVICE_TYPE}\""},{"line_number":93,"context_line":"        ELEMENTS_DIR_GUEST\u003d\"files/elements/${DISTRO}-guest\""},{"line_number":94,"context_line":"        # Print out a warning if we think the image is too old"},{"line_number":95,"context_line":"        while IFS\u003d read -r -d \u0027\u0027 ELEMENT_FILE"},{"line_number":96,"context_line":"        do"},{"line_number":97,"context_line":"            if [ \"${ELEMENT_FILE}\" -nt \"${VM_PATH}\" ]"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da86d52c_e8802bf9","line":94,"in_reply_to":"da86d52c_20ba9c23","updated":"2015-02-04 00:09:13.000000000","message":"will do","commit_id":"d719dc8acc223e74ac94c70b29920c1ee703faef"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"c40e6f0201b7d86e5c344620875b10eca0f80878","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                exclaim \"${COLOR_RED}WARNING: Element file \u0027${ELEMENT_FILE}\u0027 is newer than cached image${COLOR_NONE}\""},{"line_number":100,"context_line":"                exclaim \"${COLOR_RED}Use ${COLOR_NONE}REBUILD_IMAGE\u003dTrue${COLOR_RED} to rebuild image${COLOR_NONE}\""},{"line_number":101,"context_line":"                break"},{"line_number":102,"context_line":"            fi"},{"line_number":103,"context_line":"        done \u003c \u003c(find \"${ELEMENTS_DIR}\" \"${ELEMENTS_DIR_GUEST}\" -print0)"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da86d52c_abe82db5","line":102,"updated":"2015-02-02 19:48:28.000000000","message":"This only lists the elements folder, for eg. if install.d has more than one file, it only gives messages for files/elements/$DISTRO-$SERVICE_TYPE/install.d\nand not the exact file in the install.d","commit_id":"d719dc8acc223e74ac94c70b29920c1ee703faef"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b9708ffb2108e3581efcb618f4d6b312a0982b0f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                exclaim \"${COLOR_RED}WARNING: Element file \u0027${ELEMENT_FILE}\u0027 is newer than cached image${COLOR_NONE}\""},{"line_number":100,"context_line":"                exclaim \"${COLOR_RED}Use ${COLOR_NONE}REBUILD_IMAGE\u003dTrue${COLOR_RED} to rebuild image${COLOR_NONE}\""},{"line_number":101,"context_line":"                break"},{"line_number":102,"context_line":"            fi"},{"line_number":103,"context_line":"        done \u003c \u003c(find \"${ELEMENTS_DIR}\" \"${ELEMENTS_DIR_GUEST}\" -print0)"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da86d52c_a8b8f3c8","line":102,"in_reply_to":"da86d52c_abe82db5","updated":"2015-02-04 00:09:13.000000000","message":"I prints out the first file that it finds that\u0027s newer.  I originally had it print out all of them, but that could generate a lot of messages (each with a double row of \u0027******\u0027) so I opted to just print the first one.","commit_id":"d719dc8acc223e74ac94c70b29920c1ee703faef"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"c40e6f0201b7d86e5c344620875b10eca0f80878","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                break"},{"line_number":102,"context_line":"            fi"},{"line_number":103,"context_line":"        done \u003c \u003c(find \"${ELEMENTS_DIR}\" \"${ELEMENTS_DIR_GUEST}\" -print0)"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"function clean_instances() {"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da86d52c_6b38f5a0","line":104,"updated":"2015-02-02 19:48:28.000000000","message":"even after publishing the warnings in case of REBUILD_IMAGE not equal to True, it goes and uploads the image to glance again, which incidentally is the same old image, it should rather not do this(uploading the same old image again).","commit_id":"d719dc8acc223e74ac94c70b29920c1ee703faef"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b9708ffb2108e3581efcb618f4d6b312a0982b0f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                break"},{"line_number":102,"context_line":"            fi"},{"line_number":103,"context_line":"        done \u003c \u003c(find \"${ELEMENTS_DIR}\" \"${ELEMENTS_DIR_GUEST}\" -print0)"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":"}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"function clean_instances() {"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da86d52c_c80b678c","line":104,"in_reply_to":"da86d52c_6b38f5a0","updated":"2015-02-04 00:09:13.000000000","message":"This is the way it worked before, except it didn\u0027t print out a warning.  I didn\u0027t want to change the default behaviour (and there may be cases where the developer doesn\u0027t care and doesn\u0027t want to wait for a new image to build)","commit_id":"d719dc8acc223e74ac94c70b29920c1ee703faef"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"06004dd7657014f908662d7a40ae737bbf353984","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # If the path does not exist, build it, otherwise just upload it"},{"line_number":79,"context_line":"    # (unless we\u0027re explicitly told to rebuild it)"},{"line_number":80,"context_line":"    REBUILD_IMAGE\u003d$(echo \"${REBUILD_IMAGE}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":81,"context_line":"    if [ ! -d \"${VM_PATH}\" ] || [ \"$(find \"${VM_PATH}\" -maxdepth 1 -type f | wc -l)\" -eq \u00270\u0027 ] || [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":82,"context_line":"    then"},{"line_number":83,"context_line":"        if [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":84,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da86d52c_13034a0e","line":81,"updated":"2015-02-15 03:10:46.000000000","message":"What exactly is the $(find ...) trying to do that a [ ! -f ...] would not do?","commit_id":"401e3f4a59db6c17fa6b0eebfa39a47532618147"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"eae7408e7515ed7114b8fff83038e6489424c8b3","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # If the path does not exist, build it, otherwise just upload it"},{"line_number":79,"context_line":"    # (unless we\u0027re explicitly told to rebuild it)"},{"line_number":80,"context_line":"    REBUILD_IMAGE\u003d$(echo \"${REBUILD_IMAGE}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":81,"context_line":"    if [ ! -d \"${VM_PATH}\" ] || [ \"$(find \"${VM_PATH}\" -maxdepth 1 -type f | wc -l)\" -eq \u00270\u0027 ] || [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":82,"context_line":"    then"},{"line_number":83,"context_line":"        if [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":84,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da86d52c_c7bf28a9","line":81,"in_reply_to":"da86d52c_13034a0e","updated":"2015-02-15 16:13:34.000000000","message":"It\u0027s trying to determine if there are any files in the directory (just a re-write of the original code, since it would pick up an empty directory).  Using [! -f ... ] would require knowing what filename to look for.","commit_id":"401e3f4a59db6c17fa6b0eebfa39a47532618147"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"346ce4910e22026ecf3d28373acdd877282e0d84","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # If the path does not exist, build it, otherwise just upload it"},{"line_number":79,"context_line":"    # (unless we\u0027re explicitly told to rebuild it)"},{"line_number":80,"context_line":"    REBUILD_IMAGE\u003d$(echo \"${REBUILD_IMAGE}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":81,"context_line":"    if [ ! -d \"${VM_PATH}\" ] || [ \"$(find \"${VM_PATH}\" -maxdepth 1 -type f | wc -l)\" -eq \u00270\u0027 ] || [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":82,"context_line":"    then"},{"line_number":83,"context_line":"        if [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":84,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da86d52c_e7934cfe","line":81,"in_reply_to":"da86d52c_c7bf28a9","updated":"2015-02-15 16:24:39.000000000","message":"but you do, it\u0027s called ${VM_PATH_NAME}","commit_id":"401e3f4a59db6c17fa6b0eebfa39a47532618147"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"06004dd7657014f908662d7a40ae737bbf353984","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        exclaim \"Found image in $VM_PATH - using the qcow2 image found here...\""},{"line_number":92,"context_line":"        ELEMENTS_DIR\u003d\"files/elements/${DISTRO}-${SERVICE_TYPE}\""},{"line_number":93,"context_line":"        ELEMENTS_DIR_GUEST\u003d\"files/elements/${DISTRO}-guest\""},{"line_number":94,"context_line":"        # Print out a warning on the first elements file that is newer than the image, if one is found"},{"line_number":95,"context_line":"        while IFS\u003d read -r -d \u0027\u0027 ELEMENT_FILE"},{"line_number":96,"context_line":"        do"},{"line_number":97,"context_line":"            if [ \"${ELEMENT_FILE}\" -nt \"${VM_PATH}\" ]"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da86d52c_53806246","line":94,"updated":"2015-02-15 03:10:46.000000000","message":"why only the first one?","commit_id":"401e3f4a59db6c17fa6b0eebfa39a47532618147"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"eae7408e7515ed7114b8fff83038e6489424c8b3","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        exclaim \"Found image in $VM_PATH - using the qcow2 image found here...\""},{"line_number":92,"context_line":"        ELEMENTS_DIR\u003d\"files/elements/${DISTRO}-${SERVICE_TYPE}\""},{"line_number":93,"context_line":"        ELEMENTS_DIR_GUEST\u003d\"files/elements/${DISTRO}-guest\""},{"line_number":94,"context_line":"        # Print out a warning on the first elements file that is newer than the image, if one is found"},{"line_number":95,"context_line":"        while IFS\u003d read -r -d \u0027\u0027 ELEMENT_FILE"},{"line_number":96,"context_line":"        do"},{"line_number":97,"context_line":"            if [ \"${ELEMENT_FILE}\" -nt \"${VM_PATH}\" ]"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da86d52c_2782c4c8","line":94,"in_reply_to":"da86d52c_53806246","updated":"2015-02-15 16:13:34.000000000","message":"See my response to patchset 4","commit_id":"401e3f4a59db6c17fa6b0eebfa39a47532618147"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"06004dd7657014f908662d7a40ae737bbf353984","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        # Print out a warning on the first elements file that is newer than the image, if one is found"},{"line_number":95,"context_line":"        while IFS\u003d read -r -d \u0027\u0027 ELEMENT_FILE"},{"line_number":96,"context_line":"        do"},{"line_number":97,"context_line":"            if [ \"${ELEMENT_FILE}\" -nt \"${VM_PATH}\" ]"},{"line_number":98,"context_line":"            then"},{"line_number":99,"context_line":"                exclaim \"${COLOR_RED}WARNING: Element file \u0027${ELEMENT_FILE}\u0027 is newer than cached image${COLOR_NONE}\""},{"line_number":100,"context_line":"                exclaim \"${COLOR_RED}Use ${COLOR_NONE}REBUILD_IMAGE\u003dTrue${COLOR_RED} to rebuild image${COLOR_NONE}\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da86d52c_f380764b","line":97,"updated":"2015-02-15 03:10:46.000000000","message":"why not just rebuilt it?","commit_id":"401e3f4a59db6c17fa6b0eebfa39a47532618147"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"eae7408e7515ed7114b8fff83038e6489424c8b3","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        # Print out a warning on the first elements file that is newer than the image, if one is found"},{"line_number":95,"context_line":"        while IFS\u003d read -r -d \u0027\u0027 ELEMENT_FILE"},{"line_number":96,"context_line":"        do"},{"line_number":97,"context_line":"            if [ \"${ELEMENT_FILE}\" -nt \"${VM_PATH}\" ]"},{"line_number":98,"context_line":"            then"},{"line_number":99,"context_line":"                exclaim \"${COLOR_RED}WARNING: Element file \u0027${ELEMENT_FILE}\u0027 is newer than cached image${COLOR_NONE}\""},{"line_number":100,"context_line":"                exclaim \"${COLOR_RED}Use ${COLOR_NONE}REBUILD_IMAGE\u003dTrue${COLOR_RED} to rebuild image${COLOR_NONE}\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da86d52c_e777cc06","line":97,"in_reply_to":"da86d52c_f380764b","updated":"2015-02-15 16:13:34.000000000","message":"ditto","commit_id":"401e3f4a59db6c17fa6b0eebfa39a47532618147"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"355a4ed58fc56a011b169b2c21d7f297a4405960","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # If the path does not exist, build it, otherwise just upload it"},{"line_number":79,"context_line":"    # (unless we\u0027re explicitly told to rebuild it)"},{"line_number":80,"context_line":"    REBUILD_IMAGE\u003d$(echo \"${REBUILD_IMAGE}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":81,"context_line":"    if [ ! -d $VM_PATH ] || [ `ls -1 $VM_PATH | wc -l` -eq \u00270\u0027 ] || [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":82,"context_line":"    then"},{"line_number":83,"context_line":"        if [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":84,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"da86d52c_c2c39655","line":81,"updated":"2015-02-15 18:11:02.000000000","message":"Are you sure this isn\u0027t ${VM_PATH_NAME}\n\namrith@amrith-vm:~/images/ubuntu_cassandra$ pwd\n/home/amrith/images/ubuntu_cassandra\namrith@amrith-vm:~/images/ubuntu_cassandra$ ls -l\ntotal 508120\ndrwxrwxr-x 3 amrith amrith      4096 Jan 30 10:27 ubuntu_cassandra.d\n-rw-r--r-- 1 amrith amrith 521535488 Jan 30 10:30 ubuntu_cassandra.qcow2\namrith@amrith-vm:~/images/ubuntu_cassandra$ \n\nFor REBUILD_IMAGE shouldn\u0027t you be checking that ubuntu_cassandra.qcow2 exists not that /home/amrith/images/ubuntu_cassandra exists?","commit_id":"893244acc0e39ea352cd6710a3ca9c53aa80ed10"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"869f7269c678ec0ee33c0ec5fa8114fb099bc2f9","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # If the path does not exist, build it, otherwise just upload it"},{"line_number":79,"context_line":"    # (unless we\u0027re explicitly told to rebuild it)"},{"line_number":80,"context_line":"    REBUILD_IMAGE\u003d$(echo \"${REBUILD_IMAGE}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":81,"context_line":"    if [ ! -d $VM_PATH ] || [ `ls -1 $VM_PATH | wc -l` -eq \u00270\u0027 ] || [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":82,"context_line":"    then"},{"line_number":83,"context_line":"        if [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":84,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"da86d52c_c85015d7","line":81,"in_reply_to":"da86d52c_423fa6d6","updated":"2015-02-16 00:03:30.000000000","message":"No, I am referring to `ls -1 ${VM_PATH} | wc -l` and the code later that does an\n\nrm -rf ${VM_PATH}\n\nThis causes me problems because of other changes I\u0027ve made to functions_qemu.\n\nI have more files in ${VM_PATH} from time to time, not just the .qcow2 but sometimes also a .tar and a .tar.gz\n\nI see what you are doing, it is a bit of a heavier hammer than I\u0027d have used but it works.","commit_id":"893244acc0e39ea352cd6710a3ca9c53aa80ed10"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"68c8caae14f181bdf0f856637b64ef08f62433e0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # If the path does not exist, build it, otherwise just upload it"},{"line_number":79,"context_line":"    # (unless we\u0027re explicitly told to rebuild it)"},{"line_number":80,"context_line":"    REBUILD_IMAGE\u003d$(echo \"${REBUILD_IMAGE}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":81,"context_line":"    if [ ! -d $VM_PATH ] || [ `ls -1 $VM_PATH | wc -l` -eq \u00270\u0027 ] || [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":82,"context_line":"    then"},{"line_number":83,"context_line":"        if [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":84,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"da86d52c_42488687","line":81,"in_reply_to":"da86d52c_c2c39655","updated":"2015-02-15 19:30:58.000000000","message":"If REBUILD_IMAGE is set to true, I want to rebuild the image *even if* ubuntu_cassandra.qcow2 exists or /home/amrith/images/ubuntu_cassandra exists - in fact that\u0027s the use case.  They both exist, but are stale.","commit_id":"893244acc0e39ea352cd6710a3ca9c53aa80ed10"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8f30f5f163f5228aa180a0c4f1cec3d1cbff944f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    # If the path does not exist, build it, otherwise just upload it"},{"line_number":79,"context_line":"    # (unless we\u0027re explicitly told to rebuild it)"},{"line_number":80,"context_line":"    REBUILD_IMAGE\u003d$(echo \"${REBUILD_IMAGE}\" | tr \u0027[:upper:]\u0027 \u0027[:lower:]\u0027)"},{"line_number":81,"context_line":"    if [ ! -d $VM_PATH ] || [ `ls -1 $VM_PATH | wc -l` -eq \u00270\u0027 ] || [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":82,"context_line":"    then"},{"line_number":83,"context_line":"        if [ \"${REBUILD_IMAGE}\" \u003d \"true\" ]"},{"line_number":84,"context_line":"        then"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"da86d52c_423fa6d6","line":81,"in_reply_to":"da86d52c_c2c39655","updated":"2015-02-15 19:37:09.000000000","message":"If you\u0027re referring to:\n\n  if [ ! -d $VM_PATH ] || [ `ls -1 $VM_PATH | wc -l` -eq \u00270\u0027 ]\n\nthat\u0027s the original code, which I\u0027ve now reverted back to the way it was (since the \u0027better bash\u0027 fixes I made weren\u0027t material to my change).  If you think that code is wrong, then maybe a new bug/commit is in order?","commit_id":"893244acc0e39ea352cd6710a3ca9c53aa80ed10"}]}