)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance \u0027stop\u0027 and \u0027start\u0027 calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run \u0027restack start\u0027 no check is made to see if the processes"},{"line_number":10,"context_line":"are already running.  This can potentially cause multiple sets of"},{"line_number":11,"context_line":"the Trove services to be running at the same time."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_657a2bbf","line":9,"updated":"2015-06-04 18:26:21.000000000","message":"reDstack start","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7375142829fedeb63f9e3ff5266a7b7e27f1e70a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enhance \u0027stop\u0027 and \u0027start\u0027 calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run \u0027restack start\u0027 no check is made to see if the processes"},{"line_number":10,"context_line":"are already running.  This can potentially cause multiple sets of"},{"line_number":11,"context_line":"the Trove services to be running at the same time."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afb71cf_a70b247d","line":9,"in_reply_to":"5afe65bd_657a2bbf","updated":"2015-06-05 14:58:06.000000000","message":"Done","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance \u0027stop\u0027 and \u0027start\u0027 calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run \u0027restack start\u0027 no check is made to see if the processes"},{"line_number":10,"context_line":"are already running.  This can potentially cause multiple sets of"},{"line_number":11,"context_line":"the Trove services to be running at the same time."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"By the same token, calling \u0027stop\u0027 when several sets are running will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5afe65bd_e54cdb9f","line":10,"updated":"2015-06-04 18:26:21.000000000","message":"really? don\u0027t services bind to a well known port which will fail the second time?","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7375142829fedeb63f9e3ff5266a7b7e27f1e70a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enhance \u0027stop\u0027 and \u0027start\u0027 calls"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run \u0027restack start\u0027 no check is made to see if the processes"},{"line_number":10,"context_line":"are already running.  This can potentially cause multiple sets of"},{"line_number":11,"context_line":"the Trove services to be running at the same time."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"By the same token, calling \u0027stop\u0027 when several sets are running will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afb71cf_c71620a7","line":10,"in_reply_to":"5afe65bd_e54cdb9f","updated":"2015-06-05 14:58:06.000000000","message":"Not sure, but it will start up a second screen session for each service","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"}],"scripts/redstack":[{"author":{"_account_id":10440,"name":"Alex Tomic","email":"atomic777@gmail.com","username":"atomic77"},"change_message_id":"5ba24b24c3bede9d90de091b6bcbc94a0f2dcbb8","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        rm -f $DEST/status/stack/tr-*"},{"line_number":655,"context_line":"        USE_SCREEN\u003dTrue"},{"line_number":656,"context_line":"        source /dev/stdin \u003c \u003c(sed -n \u0027/^function stop_trove\\(\\)/,/^}/p\u0027 $PATH_DEVSTACK_SRC/lib/trove)"},{"line_number":657,"context_line":"        MAX_RETRY\u003d5"},{"line_number":658,"context_line":"        COUNT\u003d1"},{"line_number":659,"context_line":"        while true; do"},{"line_number":660,"context_line":"            RUNNING\u003d$(screen -S stack -Q windows)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9aa53dc9_16bad723","line":657,"updated":"2015-04-07 15:16:55.000000000","message":"Any particular reason you chose 5? I\u0027d think if we ever hit that number, the VM is beyond help :)","commit_id":"cc99144814db90b4699309e817f9a53dd58ab166"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"14d38b4a598b732c7d4d986e9375b9725f94077b","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        rm -f $DEST/status/stack/tr-*"},{"line_number":655,"context_line":"        USE_SCREEN\u003dTrue"},{"line_number":656,"context_line":"        source /dev/stdin \u003c \u003c(sed -n \u0027/^function stop_trove\\(\\)/,/^}/p\u0027 $PATH_DEVSTACK_SRC/lib/trove)"},{"line_number":657,"context_line":"        MAX_RETRY\u003d5"},{"line_number":658,"context_line":"        COUNT\u003d1"},{"line_number":659,"context_line":"        while true; do"},{"line_number":660,"context_line":"            RUNNING\u003d$(screen -S stack -Q windows)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3acd31a7_a7cc1b36","line":657,"in_reply_to":"7aaa499b_9202ac3d","updated":"2015-04-30 18:31:24.000000000","message":"maybe it should be a parameter or an environment variable ;)\n\nREDSTACK_STOP_MAX_RETRY_TIMES","commit_id":"cc99144814db90b4699309e817f9a53dd58ab166"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"28f9e7cf9eaf4ef1df903cb0a45f0b9fd296fb87","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        rm -f $DEST/status/stack/tr-*"},{"line_number":655,"context_line":"        USE_SCREEN\u003dTrue"},{"line_number":656,"context_line":"        source /dev/stdin \u003c \u003c(sed -n \u0027/^function stop_trove\\(\\)/,/^}/p\u0027 $PATH_DEVSTACK_SRC/lib/trove)"},{"line_number":657,"context_line":"        MAX_RETRY\u003d5"},{"line_number":658,"context_line":"        COUNT\u003d1"},{"line_number":659,"context_line":"        while true; do"},{"line_number":660,"context_line":"            RUNNING\u003d$(screen -S stack -Q windows)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7aaa499b_9202ac3d","line":657,"in_reply_to":"9aa53dc9_16bad723","updated":"2015-04-10 18:19:04.000000000","message":"No, it was completely arbitrary.  I just didn\u0027t want the script to hang if for some reason the processes didn\u0027t stop.","commit_id":"cc99144814db90b4699309e817f9a53dd58ab166"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"6c8db38c5a6f66b9450589aa88cecd9d26c68325","unresolved":false,"context_lines":[{"line_number":932,"context_line":"        --trove services--"},{"line_number":933,"context_line":"          start           - Start or resume daemons Trove depends on."},{"line_number":934,"context_line":"          stop            - Kill daemons Trove depends on."},{"line_number":935,"context_line":"          restart         - Runs stop then start for Trove services."},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"        --tests--"},{"line_number":938,"context_line":"          unit-tests      - Run the unit tests.dependencies"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"da9b358b_08a06742","line":935,"updated":"2015-03-31 04:49:19.000000000","message":"can we say it Trove daemons as stop and start says.","commit_id":"cc99144814db90b4699309e817f9a53dd58ab166"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"a1911f328092b1d49f69e6da1214c630ca8cd48d","unresolved":false,"context_lines":[{"line_number":932,"context_line":"        --trove services--"},{"line_number":933,"context_line":"          start           - Start or resume daemons Trove depends on."},{"line_number":934,"context_line":"          stop            - Kill daemons Trove depends on."},{"line_number":935,"context_line":"          restart         - Runs stop then start for Trove services."},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"        --tests--"},{"line_number":938,"context_line":"          unit-tests      - Run the unit tests.dependencies"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5ad0253b_6f096d31","line":935,"in_reply_to":"da9b358b_08a06742","updated":"2015-04-28 18:19:05.000000000","message":"I chose \u0027Trove services\u0027 because it\u0027s in the \u0027--trove services--\u0027 section ... (made sense to me ;) )","commit_id":"cc99144814db90b4699309e817f9a53dd58ab166"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        rm -f $DEST/status/stack/tr-*"},{"line_number":822,"context_line":"        USE_SCREEN\u003dTrue"},{"line_number":823,"context_line":"        source /dev/stdin \u003c \u003c(sed -n \u0027/^function stop_trove\\(\\)/,/^}/p\u0027 \"$TROVE_SETUP_CMD_FILE\")"},{"line_number":824,"context_line":"        MAX_RETRY\u003d5"},{"line_number":825,"context_line":"        COUNT\u003d1"},{"line_number":826,"context_line":"        while true; do"},{"line_number":827,"context_line":"            RUNNING\u003d$(screen -S stack -Q windows)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_6528eb9a","line":824,"updated":"2015-06-04 18:26:21.000000000","message":"With the code for start above, why do you need this code? I guess I\u0027m not following how you can have more than one set of trove with this version of redstack unless you launch trove and then update redstack to this new version.","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7375142829fedeb63f9e3ff5266a7b7e27f1e70a","unresolved":false,"context_lines":[{"line_number":821,"context_line":"        rm -f $DEST/status/stack/tr-*"},{"line_number":822,"context_line":"        USE_SCREEN\u003dTrue"},{"line_number":823,"context_line":"        source /dev/stdin \u003c \u003c(sed -n \u0027/^function stop_trove\\(\\)/,/^}/p\u0027 \"$TROVE_SETUP_CMD_FILE\")"},{"line_number":824,"context_line":"        MAX_RETRY\u003d5"},{"line_number":825,"context_line":"        COUNT\u003d1"},{"line_number":826,"context_line":"        while true; do"},{"line_number":827,"context_line":"            RUNNING\u003d$(screen -S stack -Q windows)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3afb71cf_27773404","line":824,"in_reply_to":"5afe65bd_6528eb9a","updated":"2015-06-05 14:58:06.000000000","message":"You\u0027re right, once the start check is in, this shouldn\u0027t be necessary.  But if you do have multiple instances running, then upgrading trove-integration won\u0027t fix your issue without manual steps.  But if the consensus is to remove it, I can pull it out.","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"                            which will be copied into devstack/local.conf on each \u0027install\u0027 run"},{"line_number":1089,"context_line":"                            (defaults to \\$HOME/$USER_LOCAL_CONF_NAME)"},{"line_number":1090,"context_line":"          test-init       - Configure the test configuration files and add keystone test users"},{"line_number":1091,"context_line":"          build-image     - Builds the vm image for the trove guest"},{"line_number":1092,"context_line":"          initialize      - Reinitialize the trove database, users, services, and test config"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        --helper for environment--"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_c0066d1c","line":1091,"updated":"2015-06-04 18:26:21.000000000","message":"Trove","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"                            (defaults to \\$HOME/$USER_LOCAL_CONF_NAME)"},{"line_number":1090,"context_line":"          test-init       - Configure the test configuration files and add keystone test users"},{"line_number":1091,"context_line":"          build-image     - Builds the vm image for the trove guest"},{"line_number":1092,"context_line":"          initialize      - Reinitialize the trove database, users, services, and test config"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        --helper for environment--"},{"line_number":1095,"context_line":"          kick-start      - Kick start the setup of Trove."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_6016994d","line":1092,"updated":"2015-06-04 18:26:21.000000000","message":"Trove","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"          initialize      - Reinitialize the trove database, users, services, and test config"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        --helper for environment--"},{"line_number":1095,"context_line":"          kick-start      - Kick start the setup of Trove."},{"line_number":1096,"context_line":"                            (redstack test-init/build-image in one step)"},{"line_number":1097,"context_line":"                            [mysql no-clean] no clean avoids rebuilding packages from scratch"},{"line_number":1098,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_8515274a","line":1095,"updated":"2015-06-04 18:26:21.000000000","message":"to be pedantic, kick-start is a hyphenated word ;)","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7375142829fedeb63f9e3ff5266a7b7e27f1e70a","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"          initialize      - Reinitialize the trove database, users, services, and test config"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        --helper for environment--"},{"line_number":1095,"context_line":"          kick-start      - Kick start the setup of Trove."},{"line_number":1096,"context_line":"                            (redstack test-init/build-image in one step)"},{"line_number":1097,"context_line":"                            [mysql no-clean] no clean avoids rebuilding packages from scratch"},{"line_number":1098,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3afb71cf_ee231704","line":1095,"in_reply_to":"5afe65bd_8515274a","updated":"2015-06-05 14:58:06.000000000","message":"Done","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"          stop-deps       - Kill daemons Trove depends on."},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"        --trove services--"},{"line_number":1104,"context_line":"          start           - Start or resume daemons Trove depends on."},{"line_number":1105,"context_line":"          stop            - Kill daemons Trove depends on."},{"line_number":1106,"context_line":"          restart         - Runs stop then start for Trove services."},{"line_number":1107,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_450ccf40","line":1104,"updated":"2015-06-04 18:26:21.000000000","message":"daemons\u0027","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"        --trove services--"},{"line_number":1104,"context_line":"          start           - Start or resume daemons Trove depends on."},{"line_number":1105,"context_line":"          stop            - Kill daemons Trove depends on."},{"line_number":1106,"context_line":"          restart         - Runs stop then start for Trove services."},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"        --tests--"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_e0016906","line":1105,"updated":"2015-06-04 18:26:21.000000000","message":"daemons\u0027","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1103,"context_line":"        --trove services--"},{"line_number":1104,"context_line":"          start           - Start or resume daemons Trove depends on."},{"line_number":1105,"context_line":"          stop            - Kill daemons Trove depends on."},{"line_number":1106,"context_line":"          restart         - Runs stop then start for Trove services."},{"line_number":1107,"context_line":""},{"line_number":1108,"context_line":"        --tests--"},{"line_number":1109,"context_line":"          unit-tests      - Run the unit tests.dependencies"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_40415d37","line":1106,"updated":"2015-06-04 18:26:21.000000000","message":"Why not just \"restarts the Trove services\"","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        --tools--"},{"line_number":1115,"context_line":"          debug           - Debug this script (shows all commands)."},{"line_number":1116,"context_line":"          wipe-logs       - Resets all log files."},{"line_number":1117,"context_line":"          rd-sql          - Opens the Trove MySQL database."},{"line_number":1118,"context_line":"          vagrant-ssh     - Runs a command from the host on the server."},{"line_number":1119,"context_line":"          clear           - Destroy instances and rabbit queues."},{"line_number":1120,"context_line":"          run             - Starts RD but not in a screen."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_e04f2969","line":1117,"updated":"2015-06-04 18:26:21.000000000","message":"mumble mumble ... rd-sql?\n\nor would that be a change which would be considered to be breaking the API ;)","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"          wipe-logs       - Resets all log files."},{"line_number":1117,"context_line":"          rd-sql          - Opens the Trove MySQL database."},{"line_number":1118,"context_line":"          vagrant-ssh     - Runs a command from the host on the server."},{"line_number":1119,"context_line":"          clear           - Destroy instances and rabbit queues."},{"line_number":1120,"context_line":"          run             - Starts RD but not in a screen."},{"line_number":1121,"context_line":"          run-fake        - Runs the server in fake mode."},{"line_number":1122,"context_line":"          update-projects - Git pull on all the daemons\u0027 Trove dependencies."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_e0284988","line":1119,"updated":"2015-06-04 18:26:21.000000000","message":"RabbitMQ? That\u0027s what it says later.","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"6806628bcd427671ac9b7babf9c6ffffd8b86769","unresolved":false,"context_lines":[{"line_number":1117,"context_line":"          rd-sql          - Opens the Trove MySQL database."},{"line_number":1118,"context_line":"          vagrant-ssh     - Runs a command from the host on the server."},{"line_number":1119,"context_line":"          clear           - Destroy instances and rabbit queues."},{"line_number":1120,"context_line":"          run             - Starts RD but not in a screen."},{"line_number":1121,"context_line":"          run-fake        - Runs the server in fake mode."},{"line_number":1122,"context_line":"          update-projects - Git pull on all the daemons\u0027 Trove dependencies."},{"line_number":1123,"context_line":"          reset-task      - Sets an instance task to NONE."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5afe65bd_c02d4d96","line":1120,"updated":"2015-06-04 18:26:21.000000000","message":"RD ~ Trove\n\nAlso, screen session?","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7375142829fedeb63f9e3ff5266a7b7e27f1e70a","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"          clear           - Destroy instances and rabbit queues."},{"line_number":1120,"context_line":"          run             - Starts RD but not in a screen."},{"line_number":1121,"context_line":"          run-fake        - Runs the server in fake mode."},{"line_number":1122,"context_line":"          update-projects - Git pull on all the daemons\u0027 Trove dependencies."},{"line_number":1123,"context_line":"          reset-task      - Sets an instance task to NONE."},{"line_number":1124,"context_line":"          wipe-queues     - Resets RabbitMQ queues."},{"line_number":1125,"context_line":"    \""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3afb71cf_ae74fffc","line":1122,"updated":"2015-06-05 14:58:06.000000000","message":"Will remove","commit_id":"113563fe52e0e12952816725b808c799fa13bd94"}]}