)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"c8cfe0403b88059a1a2aa575c4ec47488d26dc3a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sharika \u003csharika.pongubala@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-07 22:45:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changes made to install additional debian packages for vertica management console"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DATASTORE_PKG_LOCATION is now changed to point to a directory that has all debian packages that need to be installed"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aca2d91_65a5b6a0","line":7,"updated":"2015-05-07 23:33:14.000000000","message":"This line needs to be \u003c\u003d 50 characters","commit_id":"f7a5730a2bc8acae64c8dc4f74412c78bfaca41a"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"c8cfe0403b88059a1a2aa575c4ec47488d26dc3a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changes made to install additional debian packages for vertica management console"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DATASTORE_PKG_LOCATION is now changed to point to a directory that has all debian packages that need to be installed"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes Bug : #1452926"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aca2d91_05aa8270","line":9,"updated":"2015-05-07 23:33:14.000000000","message":"This should be wrapped at 79, I believe","commit_id":"f7a5730a2bc8acae64c8dc4f74412c78bfaca41a"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"c8cfe0403b88059a1a2aa575c4ec47488d26dc3a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"DATASTORE_PKG_LOCATION is now changed to point to a directory that has all debian packages that need to be installed"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes Bug : #1452926"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2863a21d186d9c809fa2fdb0050e4728e100b010"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1aca2d91_c5ba4ac0","line":11,"updated":"2015-05-07 23:33:14.000000000","message":"Trove convention is \"Closes-Bug: 1452926\"","commit_id":"f7a5730a2bc8acae64c8dc4f74412c78bfaca41a"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"3e6869d644baf6566c552f6a7c40e62d308de4bd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sharika \u003csharika.pongubala@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-08 00:30:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"To install additional debian packages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vertica Management console requires additional"},{"line_number":10,"context_line":"debian packages to be installed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1aca2d91_53f600d8","line":7,"updated":"2015-05-08 00:45:16.000000000","message":"I should have pointed out that this is supposed to be a short summary - a title line. It should attempt to describe the change at a high level (and in less than 50 chars :) ). Maybe something like this:\n\"Change DATASTORE_PKG_LOCATION to be a directory\"","commit_id":"f884b4541f4aef42e3a98b81a7e59e0c656ffdf5"}],"scripts/files/elements/datastore-package/README.md":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"04bf780d1afa77ad5ae6511527b437c0e5c1bff9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"DIB element to copy datastore packages/installers in the image"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This element reads the environment variable DATASTORE_PKG_LOCATION and"},{"line_number":4,"context_line":"depending on the type of source (file/directory/url) it copies the "},{"line_number":5,"context_line":"packages into the /opt/datastore_package directory"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If the DATASTORE_PKG_LOCATION is a file:"}],"source_content_type":"text/x-gfm","patch_set":17,"id":"1a4dcd0f_a4112454","line":4,"updated":"2015-08-12 06:27:33.000000000","message":"trailing space","commit_id":"7a70a6391c35e4d848e055d528cfe452cd0c24ac"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"afb5e7bb0f1b3f1af8bde1530b6ef80d6aa4b576","unresolved":false,"context_lines":[{"line_number":1,"context_line":"DIB element to copy datastore packages/installers in the image"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This element reads the environment variable DATASTORE_PKG_LOCATION and"},{"line_number":4,"context_line":"depending on the type of source (file/directory/url) it copies the"}],"source_content_type":"text/x-gfm","patch_set":22,"id":"fa1b9901_1899457c","line":1,"updated":"2015-08-20 16:40:53.000000000","message":"I wish other elements would also have a README.md. Thanks for putting this here with a clear description.","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"afb5e7bb0f1b3f1af8bde1530b6ef80d6aa4b576","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"If the DATASTORE_PKG_LOCATION is a URL,"},{"line_number":22,"context_line":"  # first it downloads the package from that URL to"},{"line_number":23,"context_line":"    ${TMP_HOOKS_PATH}/datastore_package directory"},{"line_number":24,"context_line":"  # then once inside the image it copies that download package file to"},{"line_number":25,"context_line":"    /opt/datastore_package directory"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":22,"id":"fa1b9901_58981d6a","line":23,"updated":"2015-08-20 16:40:53.000000000","message":"This may be where the contract gets murky. There\u0027s no guarantee what the file being generated is called. This may be the same thing that peter is talking about.","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"}],"scripts/files/elements/datastore-package/extra-data.d/20-copy-datastore-pkg":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"04bf780d1afa77ad5ae6511527b437c0e5c1bff9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    echo \"Datasore packages location ${DATASTORE_PKG_LOCATION} is a directory\""},{"line_number":19,"context_line":"    pushd \"${DATASTORE_PKG_LOCATION}\""},{"line_number":20,"context_line":"    TMP_DIR\u003d`mktemp -d`"},{"line_number":21,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz *"},{"line_number":22,"context_line":"    popd"},{"line_number":23,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":24,"context_line":"# else, download package from specified URL"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"1a4dcd0f_e46f2cc2","line":21,"updated":"2015-08-12 06:27:33.000000000","message":"would be better to use \u0027.\u0027 instead of \u0027*\u0027 here","commit_id":"7a70a6391c35e4d848e055d528cfe452cd0c24ac"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c94aafc93c5e099bed8506e2d41fded4c7a26c4d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [ -f \"${DATASTORE_PKG_LOCATION}\" ]; then"},{"line_number":13,"context_line":"    echo \"Datasore packages location ${DATASTORE_PKG_LOCATION} is a file\""},{"line_number":14,"context_line":"    PKG_FILE_NAME\u003d`basename ${DATASTORE_PKG_LOCATION}`"},{"line_number":15,"context_line":"    dd if\u003d\"${DATASTORE_PKG_LOCATION}\" of\u003d${TMP_HOOKS_PATH}/datastore_package/${PKG_FILE_NAME}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# else, check if the package is directory"},{"line_number":18,"context_line":"elif [ -d \"${DATASTORE_PKG_LOCATION}\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_c006751b","line":15,"updated":"2015-08-20 15:28:46.000000000","message":"Would it make sense to copy the file to a known filename?  Something generic like \u0027datastore_package.file\u0027?  The elements wouldn\u0027t need to hard-code arbitrary filenames then ... (they could always rename the file to something better if they wanted)","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"b1b3503d61480ec921efa87104db9f8560ed630a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [ -f \"${DATASTORE_PKG_LOCATION}\" ]; then"},{"line_number":13,"context_line":"    echo \"Datasore packages location ${DATASTORE_PKG_LOCATION} is a file\""},{"line_number":14,"context_line":"    PKG_FILE_NAME\u003d`basename ${DATASTORE_PKG_LOCATION}`"},{"line_number":15,"context_line":"    dd if\u003d\"${DATASTORE_PKG_LOCATION}\" of\u003d${TMP_HOOKS_PATH}/datastore_package/${PKG_FILE_NAME}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# else, check if the package is directory"},{"line_number":18,"context_line":"elif [ -d \"${DATASTORE_PKG_LOCATION}\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_6e05fb11","line":15,"in_reply_to":"fa1b9901_c006751b","updated":"2015-08-21 17:21:47.000000000","message":"I would prefer not renaming the file to something like datastore_package.file.  Just between vertica and db2 itself, one needs a .deb and one needs a tar/gz. \n\nHow about we keep copying files with whatever name was there @ source, but change the datastore specific elements to deal with it by doing `ls` on /opt/datastore_package and then look for a specific pattern in the filename (vertica image element already does this today, first it looks  for .deb and then for console and non console packages in the out of of ls on the directory).\n\nSomething like:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nDB2_PACKAGE_PROCESSED\u003dfalse\nfor db2_file in `ls /opt/datastore_package/*`\ndo\n   if [[ $db2_file \u003d~ \u0027.gz\u0027 ]]\n   then\n       tar -xvzf $db2_file\n       DB2_PACKAGE_PROCESSED\u003dtrue\n   fi\ndone\n\nif [ ${DB2_PACKAGE_PROCESSED} \u003d\u003d true ]\nthen\n     echo \"ERROR: DB2 package not available in  /opt/datastore_package/\"\nfi\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nThis way you don\u0027t hardcode the name of the package and then we can process pretty much anything (.deb/.tar/.gz/.rmp etc).\n\nI can change the db2 image element to look for a tar/gz file in output of ls command on /opt/datastore_package directory.","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"afb5e7bb0f1b3f1af8bde1530b6ef80d6aa4b576","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [ -f \"${DATASTORE_PKG_LOCATION}\" ]; then"},{"line_number":13,"context_line":"    echo \"Datasore packages location ${DATASTORE_PKG_LOCATION} is a file\""},{"line_number":14,"context_line":"    PKG_FILE_NAME\u003d`basename ${DATASTORE_PKG_LOCATION}`"},{"line_number":15,"context_line":"    dd if\u003d\"${DATASTORE_PKG_LOCATION}\" of\u003d${TMP_HOOKS_PATH}/datastore_package/${PKG_FILE_NAME}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# else, check if the package is directory"},{"line_number":18,"context_line":"elif [ -d \"${DATASTORE_PKG_LOCATION}\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_3b6c4334","line":15,"in_reply_to":"fa1b9901_c006751b","updated":"2015-08-20 16:40:53.000000000","message":"since you have a message on the wget, why not one here?","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"a6d98bca222a9c152cb8d5ba109f65b47932601a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    TMP_DIR\u003d`mktemp -d`"},{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."},{"line_number":23,"context_line":"    popd"},{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"# else, download package from specified URL"},{"line_number":26,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":27,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_0f1a607d","line":24,"updated":"2015-08-20 15:02:07.000000000","message":"I think we should remove the tar file once it\u0027s been copied over","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"29f9e4659bdd30eb20dbc48ddffc4318b9c07eba","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    TMP_DIR\u003d`mktemp -d`"},{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."},{"line_number":23,"context_line":"    popd"},{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"# else, download package from specified URL"},{"line_number":26,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":27,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"ba8a016a_4041ba0a","line":24,"in_reply_to":"da85f559_0bacda9e","updated":"2015-11-18 16:24:30.000000000","message":"Not sure what you are referring to?\n${TMP_HOOKS_PATH}/datastore_package is used for everything. (file, directory and URL)","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"b1b3503d61480ec921efa87104db9f8560ed630a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    TMP_DIR\u003d`mktemp -d`"},{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."},{"line_number":23,"context_line":"    popd"},{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"# else, download package from specified URL"},{"line_number":26,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":27,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_51953a30","line":24,"in_reply_to":"fa1b9901_0f1a607d","updated":"2015-08-21 17:21:47.000000000","message":"Good point. will do","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"f21a07e139b5ae690b84dc6b8d2c5008c84b53e0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    TMP_DIR\u003d`mktemp -d`"},{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."},{"line_number":23,"context_line":"    popd"},{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"# else, download package from specified URL"},{"line_number":26,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":27,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"da85f559_0bacda9e","line":24,"in_reply_to":"fa1b9901_0f1a607d","updated":"2015-11-10 17:08:12.000000000","message":"You\u0027re hard-coding the directory name here, why not in the single file case as well?","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"c94aafc93c5e099bed8506e2d41fded4c7a26c4d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# else, download package from specified URL"},{"line_number":26,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":27,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"},{"line_number":28,"context_line":"    wget ${DATASTORE_DOWNLOAD_OPTS} \"${DATASTORE_PKG_LOCATION}\""},{"line_number":29,"context_line":"    if [ $? -eq 0];"},{"line_number":30,"context_line":"    then"},{"line_number":31,"context_line":"        echo \"Downloaded datastore package from the ${DATASTORE_PKG_LOCATION}\""}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_60468950","line":28,"updated":"2015-08-20 15:28:46.000000000","message":"ditto - this could be done easily with the -O option - \u0027-O datastore_package.file\u0027","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"afb5e7bb0f1b3f1af8bde1530b6ef80d6aa4b576","unresolved":false,"context_lines":[{"line_number":26,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":27,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"},{"line_number":28,"context_line":"    wget ${DATASTORE_DOWNLOAD_OPTS} \"${DATASTORE_PKG_LOCATION}\""},{"line_number":29,"context_line":"    if [ $? -eq 0];"},{"line_number":30,"context_line":"    then"},{"line_number":31,"context_line":"        echo \"Downloaded datastore package from the ${DATASTORE_PKG_LOCATION}\""},{"line_number":32,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_9b98ef1d","line":29,"updated":"2015-08-20 16:40:53.000000000","message":"since you have the set -e, do you need this check? if the status is non zero, won\u0027t you have an exit?","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"b1b3503d61480ec921efa87104db9f8560ed630a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":27,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"},{"line_number":28,"context_line":"    wget ${DATASTORE_DOWNLOAD_OPTS} \"${DATASTORE_PKG_LOCATION}\""},{"line_number":29,"context_line":"    if [ $? -eq 0];"},{"line_number":30,"context_line":"    then"},{"line_number":31,"context_line":"        echo \"Downloaded datastore package from the ${DATASTORE_PKG_LOCATION}\""},{"line_number":32,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_0e99bb1f","line":29,"in_reply_to":"fa1b9901_9b98ef1d","updated":"2015-08-21 17:21:47.000000000","message":"agree. will change this","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"afb5e7bb0f1b3f1af8bde1530b6ef80d6aa4b576","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    if [ $? -eq 0];"},{"line_number":30,"context_line":"    then"},{"line_number":31,"context_line":"        echo \"Downloaded datastore package from the ${DATASTORE_PKG_LOCATION}\""},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"    popd"},{"line_number":34,"context_line":"else"},{"line_number":35,"context_line":"    echo \"Unable to process datastore package at ${DATASTORE_PKG_LOCATION}\""}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_b837f9fd","line":32,"updated":"2015-08-20 16:40:53.000000000","message":"if not ;)","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3bd98c113b9a90936e68e29fb7dd208ed796e1e7","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# First check if the package is file"},{"line_number":12,"context_line":"if [ -f \"${DATASTORE_PKG_LOCATION}\" ]; then"},{"line_number":13,"context_line":"    echo \"Datasore packages location ${DATASTORE_PKG_LOCATION} is a file\""},{"line_number":14,"context_line":"    PKG_FILE_NAME\u003d`basename ${DATASTORE_PKG_LOCATION}`"},{"line_number":15,"context_line":"    dd if\u003d\"${DATASTORE_PKG_LOCATION}\" of\u003d${TMP_HOOKS_PATH}/datastore_package/${PKG_FILE_NAME}"},{"line_number":16,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"ba8a016a_a553586a","line":13,"updated":"2015-11-18 22:03:35.000000000","message":"1) check spelling - datastore.\n2) I think this debug message can be rephrased a bit. Having a hard time making sense of a package location being a file.","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3bd98c113b9a90936e68e29fb7dd208ed796e1e7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# else, check if the package is directory"},{"line_number":18,"context_line":"elif [ -d \"${DATASTORE_PKG_LOCATION}\" ]; then"},{"line_number":19,"context_line":"    echo \"Datasore packages location ${DATASTORE_PKG_LOCATION} is a directory\""},{"line_number":20,"context_line":"    pushd \"${DATASTORE_PKG_LOCATION}\""},{"line_number":21,"context_line":"    TMP_DIR\u003d`mktemp -d`"},{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"ba8a016a_85609402","line":19,"updated":"2015-11-18 22:03:35.000000000","message":"spelling check - Datastore.\n\nAlso lets say this directory has only one file - for example like in the case of DB2 , v10.5_linuxx64_expc.tar.gz and for DATASTORE_PKG_LOCATION I specify the directory only. This else condition will go and compress this directory again which I dont think is necessary. Wouldnt it be better to compress this folder only if it has more than 1 file in it?","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"0a7f873ff4aff41d2dcb31dbcdfb82989c60cc64","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# else, check if the package is directory"},{"line_number":18,"context_line":"elif [ -d \"${DATASTORE_PKG_LOCATION}\" ]; then"},{"line_number":19,"context_line":"    echo \"Datasore packages location ${DATASTORE_PKG_LOCATION} is a directory\""},{"line_number":20,"context_line":"    pushd \"${DATASTORE_PKG_LOCATION}\""},{"line_number":21,"context_line":"    TMP_DIR\u003d`mktemp -d`"},{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5a5ae5dd_1209d12c","line":19,"in_reply_to":"5a5ae5dd_713f0326","updated":"2016-02-03 15:42:49.000000000","message":"You are right Craig. I think I had that comment against the wrong line. I think I was looking at line 22 were we are compressing the contents of the directory. In the case of DB2, the package that we download is a single compressed file. So assuming we download it to our local directory and specify that directory in DATASTORE_PKG_LOCATION, line 22 will compress an already compressed file. Its not a big deal but just wanted to point that use case.","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"10bcce6a349d82e7c25691a85f725c5524ee3ee9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# else, check if the package is directory"},{"line_number":18,"context_line":"elif [ -d \"${DATASTORE_PKG_LOCATION}\" ]; then"},{"line_number":19,"context_line":"    echo \"Datasore packages location ${DATASTORE_PKG_LOCATION} is a directory\""},{"line_number":20,"context_line":"    pushd \"${DATASTORE_PKG_LOCATION}\""},{"line_number":21,"context_line":"    TMP_DIR\u003d`mktemp -d`"},{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5a5ae5dd_713f0326","line":19,"in_reply_to":"ba8a016a_85609402","updated":"2016-02-03 04:50:01.000000000","message":"@mariam that scenario does not seem intuitive of the actions taken for this element.","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3bd98c113b9a90936e68e29fb7dd208ed796e1e7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."},{"line_number":23,"context_line":"    popd"},{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"    rm ${TMP_DIR}/datastore_package.tgz"},{"line_number":26,"context_line":"# else, download package from specified URL"},{"line_number":27,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":28,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"ba8a016a_0bbcb5da","line":25,"updated":"2015-11-18 22:03:35.000000000","message":"shouldnt we delete the ${TMP_DIR} itself?","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"10bcce6a349d82e7c25691a85f725c5524ee3ee9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    tar -czf ${TMP_DIR}/datastore_package.tgz ."},{"line_number":23,"context_line":"    popd"},{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"    rm ${TMP_DIR}/datastore_package.tgz"},{"line_number":26,"context_line":"# else, download package from specified URL"},{"line_number":27,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":28,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5a5ae5dd_b1afbb7c","line":25,"in_reply_to":"ba8a016a_0bbcb5da","updated":"2016-02-03 04:50:01.000000000","message":"agree","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3bd98c113b9a90936e68e29fb7dd208ed796e1e7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"    rm ${TMP_DIR}/datastore_package.tgz"},{"line_number":26,"context_line":"# else, download package from specified URL"},{"line_number":27,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":28,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"},{"line_number":29,"context_line":"    wget ${DATASTORE_DOWNLOAD_OPTS} \"${DATASTORE_PKG_LOCATION}\""},{"line_number":30,"context_line":"    popd"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"ba8a016a_11d2a25c","line":27,"updated":"2015-11-18 22:03:35.000000000","message":"what if its an ftp url or isnt that a possibility? Also dont see a message here saying that the DATASTORE_PKG_LOCATION is a url similar to the other 2 cases.","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"0a7f873ff4aff41d2dcb31dbcdfb82989c60cc64","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"    rm ${TMP_DIR}/datastore_package.tgz"},{"line_number":26,"context_line":"# else, download package from specified URL"},{"line_number":27,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":28,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"},{"line_number":29,"context_line":"    wget ${DATASTORE_DOWNLOAD_OPTS} \"${DATASTORE_PKG_LOCATION}\""},{"line_number":30,"context_line":"    popd"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5a5ae5dd_d213395b","line":27,"in_reply_to":"5a5ae5dd_11bb2fc6","updated":"2016-02-03 15:42:49.000000000","message":"sounds good.","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"10bcce6a349d82e7c25691a85f725c5524ee3ee9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    dd if\u003d\"${TMP_DIR}/datastore_package.tgz\" of\u003d${TMP_HOOKS_PATH}/datastore_package/datastore_package.tgz"},{"line_number":25,"context_line":"    rm ${TMP_DIR}/datastore_package.tgz"},{"line_number":26,"context_line":"# else, download package from specified URL"},{"line_number":27,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\" ]]; then"},{"line_number":28,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"},{"line_number":29,"context_line":"    wget ${DATASTORE_DOWNLOAD_OPTS} \"${DATASTORE_PKG_LOCATION}\""},{"line_number":30,"context_line":"    popd"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5a5ae5dd_11bb2fc6","line":27,"in_reply_to":"ba8a016a_11d2a25c","updated":"2016-02-03 04:50:01.000000000","message":"it could be a possibility but not something that was needed initially it looks like. So something like this and it can be added to later if needed.\n\n    [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\"|\"ftp\" ]]","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2c2d7e3538f148da5729ca2b1222bf2ddcfaaf5e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# else, download package from specified URL"},{"line_number":27,"context_line":"elif [[ \"${DATASTORE_PKG_LOCATION}\" \u003d~ \"http\"|\"ftp\" ]]; then"},{"line_number":28,"context_line":"    pushd ${TMP_HOOKS_PATH}/datastore_package"},{"line_number":29,"context_line":"    wget ${DATASTORE_DOWNLOAD_OPTS} \"${DATASTORE_PKG_LOCATION}\""},{"line_number":30,"context_line":"    popd"},{"line_number":31,"context_line":"else"},{"line_number":32,"context_line":"    echo \"Unable to process datastore package at ${DATASTORE_PKG_LOCATION}\""}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_b7b1e049","line":29,"updated":"2016-04-19 12:34:54.000000000","message":"All good till here. At this point, I think an error check would be good.","commit_id":"0e65a06166ab0228bb1c5dd2931ccf29a1431f32"}],"scripts/files/elements/datastore-package/install.d/10-copy-datastore-pkg":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"afb5e7bb0f1b3f1af8bde1530b6ef80d6aa4b576","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o xtrace"},{"line_number":5,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"mkdir -p /opt/datastore_package/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# if datastore package location was a directory then lets"},{"line_number":10,"context_line":"# extract the datastore_package.tgz into /opt/datastore_package directory"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_bbc293e7","line":7,"updated":"2015-08-20 16:40:53.000000000","message":"I\u0027m sure /opt exists ;)","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"b1b3503d61480ec921efa87104db9f8560ed630a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o xtrace"},{"line_number":5,"context_line":"export DEBIAN_FRONTEND\u003dnoninteractive"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"mkdir -p /opt/datastore_package/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# if datastore package location was a directory then lets"},{"line_number":10,"context_line":"# extract the datastore_package.tgz into /opt/datastore_package directory"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"fa1b9901_918af262","line":7,"in_reply_to":"fa1b9901_bbc293e7","updated":"2015-08-21 17:21:47.000000000","message":"True, but this doesn\u0027t hurt.","commit_id":"3756fe1710dc2adee2fa04d2a880533608cde676"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"3bd98c113b9a90936e68e29fb7dd208ed796e1e7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    do"},{"line_number":20,"context_line":"        cp /tmp/in_target.d/datastore_package/${package_file} /opt/datastore_package/"},{"line_number":21,"context_line":"    done"},{"line_number":22,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"ba8a016a_b03e3426","line":22,"updated":"2015-11-18 22:03:35.000000000","message":"So according to the definition provided for datastore_package in the previous file, if the variable DATASTORE_PKG_LOCATION is a file, then /tmp/in_target.d/datastore_package directory should contain only 1 file as specified in the DATASTORE_PKG_LOCATION. If thats the case, then why do we need the for loop in the else condition?","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"10bcce6a349d82e7c25691a85f725c5524ee3ee9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    do"},{"line_number":20,"context_line":"        cp /tmp/in_target.d/datastore_package/${package_file} /opt/datastore_package/"},{"line_number":21,"context_line":"    done"},{"line_number":22,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5a5ae5dd_31e50ba8","line":22,"in_reply_to":"ba8a016a_b03e3426","updated":"2016-02-03 04:50:01.000000000","message":"yeah it would seem this isnt needed.","commit_id":"bc13e03c4fc56d93541cfe27d691ce329b48da44"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"15950752c11f3879e716813df66e4c0c071006ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"dae33548_ccdea06c","line":14,"updated":"2016-02-16 21:50:43.000000000","message":"Craig, dont we still need to address the case where the DATASTORE_PKG_LOCATION is a file or url in which case it will be a single package file in the directory? The above case addresses the case where DATASTORE_PKG_LOCATION is a directory which can contain more than one file, which is in turn compressed.","commit_id":"7548ae34a61ca382315209bf1f0b611095f67796"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2c2d7e3538f148da5729ca2b1222bf2ddcfaaf5e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"mkdir -p /opt/datastore_package/"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# if datastore package location was a directory then lets"},{"line_number":10,"context_line":"# extract the datastore_package.tgz into /opt/datastore_package directory"},{"line_number":11,"context_line":"if [ -f  /tmp/in_target.d/datastore_package/datastore_package.tgz ]"},{"line_number":12,"context_line":"then"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_d7f73c57","line":9,"updated":"2016-04-19 12:34:54.000000000","message":"you most certainly have to do something here for the file and the wget case.\n\notherwise, as best as I can tell (without testing this) is that the extra-data.d step would have created something that shows up in /tmp/in_target.d/datastore_package.\n\nFor vertica, a .deb is in there, for the wget case, there\u0027s something in there, no idea what.\n\nBut, this only handles the -f case which was the case where the extra-data.d step dealt with a directory.\n\nTherefore this will leave a file (either the -f or the URL case) in /tmp/in_target.d/...","commit_id":"0e65a06166ab0228bb1c5dd2931ccf29a1431f32"}],"scripts/files/elements/ubuntu-db2/extra-data.d/20-copy-db2-pkgs":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"fb44fe490925b0e9fee4ae9dab6bde1ea3c339a9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# First check if the package is available on the local filesystem."},{"line_number":15,"context_line":"if [ -f \"${DATASTORE_PKG_LOCATION}\" ]; then"},{"line_number":16,"context_line":"    echo \"Found the DB2 Express-C packages in ${DATASTORE_PKG_LOCATION}.\""},{"line_number":17,"context_line":"    cp ${DATASTORE_PKG_LOCATION}/*.tar.gz ${TMP_HOOKS_PATH}/db2.tar.gz"},{"line_number":18,"context_line":"# else, check if the package is available for download in a private repository."},{"line_number":19,"context_line":"elif wget ${DATASTORE_DOWNLOAD_OPTS} \"${DATASTORE_PKG_LOCATION}\" -O ${TMP_HOOKS_PATH}/db2.tar.gz; then"},{"line_number":20,"context_line":"    echo \"Downloaded the DB2 Express-C package from the private repository\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1aca2d91_ba687288","line":17,"updated":"2015-05-08 14:52:19.000000000","message":"sorry, what is ${DATASTORE_PKG_LOCATION}? The file or a directory where there are some files to copy?\n\nI submit to you that it is the former so this change would break the DB2 intended process.","commit_id":"f884b4541f4aef42e3a98b81a7e59e0c656ffdf5"}],"scripts/files/elements/ubuntu-vertica/extra-data.d/93-copy-vertica-deb":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"c8cfe0403b88059a1a2aa575c4ec47488d26dc3a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"source $_LIB/die"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[ -n \"$TMP_HOOKS_PATH\" ] || die \"Temp hook path not set\""},{"line_number":13,"context_line":"[ -d \"$DATASTORE_PKG_LOCATION\" ] || die \"Datastore package installer files not found at the directory:\" $DATASTORE_PKG_LOCATION"},{"line_number":14,"context_line":"#[ -f \"$DATASTORE_CONSOLE_PKG_LOCATION\" ] || die \"Datastore management console package installer file not found at:\" $DATASTORE_CONSOLE_PKG_LOCATION"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#dd if\u003d${DATASTORE_PKG_LOCATION} of\u003d${TMP_HOOKS_PATH}/vertica.deb"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1aca2d91_65e936e6","line":13,"updated":"2015-05-07 23:33:14.000000000","message":"We should ensure that this variable is being used consistently across trove-integration. It looks like DB2 is still using it like a file - maybe file a bug to have that fixed?","commit_id":"f7a5730a2bc8acae64c8dc4f74412c78bfaca41a"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"c8cfe0403b88059a1a2aa575c4ec47488d26dc3a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[ -n \"$TMP_HOOKS_PATH\" ] || die \"Temp hook path not set\""},{"line_number":13,"context_line":"[ -d \"$DATASTORE_PKG_LOCATION\" ] || die \"Datastore package installer files not found at the directory:\" $DATASTORE_PKG_LOCATION"},{"line_number":14,"context_line":"#[ -f \"$DATASTORE_CONSOLE_PKG_LOCATION\" ] || die \"Datastore management console package installer file not found at:\" $DATASTORE_CONSOLE_PKG_LOCATION"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"#dd if\u003d${DATASTORE_PKG_LOCATION} of\u003d${TMP_HOOKS_PATH}/vertica.deb"},{"line_number":17,"context_line":"#dd if\u003d${DATASTORE_CONSOLE_PKG_LOCATION} of\u003d${TMP_HOOKS_PATH}/vertica-console.deb"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1aca2d91_05c5e259","line":14,"updated":"2015-05-07 23:33:14.000000000","message":"Why would we leave new lines in that are commented out?","commit_id":"f7a5730a2bc8acae64c8dc4f74412c78bfaca41a"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"c8cfe0403b88059a1a2aa575c4ec47488d26dc3a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#dd if\u003d${DATASTORE_CONSOLE_PKG_LOCATION} of\u003d${TMP_HOOKS_PATH}/vertica-console.deb"},{"line_number":18,"context_line":"mkdir $TMP_HOOKS_PATH/vertica"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ls -1r $DATASTORE_PKG_LOCATION/"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"for f in `ls -1 $DATASTORE_PKG_LOCATION`"},{"line_number":23,"context_line":"do"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1aca2d91_6597f648","line":20,"updated":"2015-05-07 23:33:14.000000000","message":"I\u0027m not clear why this needs to be done?","commit_id":"f7a5730a2bc8acae64c8dc4f74412c78bfaca41a"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"fb44fe490925b0e9fee4ae9dab6bde1ea3c339a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"source $_LIB/die"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[ -n \"$TMP_HOOKS_PATH\" ] || die \"Temp hook path not set\""},{"line_number":13,"context_line":"[ -d \"$DATASTORE_PKG_LOCATION\" ] || die \"Datastore package installer files not found at the directory:\" $DATASTORE_PKG_LOCATION"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"mkdir $TMP_HOOKS_PATH/vertica"},{"line_number":16,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1aca2d91_1afbe6c2","line":13,"updated":"2015-05-08 14:52:19.000000000","message":"This changes the intent of the DATASTORE_PKG_LOCATION from being a file to being a directory. This could have other implications (such as for other guests).\n\nThis change needs more discussion.","commit_id":"f884b4541f4aef42e3a98b81a7e59e0c656ffdf5"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"0125807771fb9910a8c4ff874f8b74588300ba19","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"mkdir $TMP_HOOKS_PATH/vertica"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# remove the version number form the debian package name before copying"},{"line_number":18,"context_line":"for deb_file in `ls -1 $DATASTORE_PKG_LOCATION/*.deb`"},{"line_number":19,"context_line":"do"},{"line_number":20,"context_line":"    package_name\u003d$(basename \"$deb_file\" \".deb\")"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1aca2d91_37ac87ec","line":17,"updated":"2015-05-08 09:06:09.000000000","message":"s/form/from","commit_id":"f884b4541f4aef42e3a98b81a7e59e0c656ffdf5"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d80a644b56e6c20d1bb50a1b04846f01045401c1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"mkdir $TMP_HOOKS_PATH/vertica"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ls -1r $DATASTORE_PKG_LOCATION/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# remove the version number form the debian package name before copying"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a016987_6323d506","line":17,"updated":"2015-05-14 07:59:48.000000000","message":"Unwanted ls","commit_id":"3f4fe6fdf86f854ff2f7247d234168f8d7f923aa"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"985e99a019d1f21a483009b7906c53aef5f5b3c4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# remove the version number form the debian package name before copying"},{"line_number":21,"context_line":"for deb_file in `ls -1 $DATASTORE_PKG_LOCATION/*.deb`"},{"line_number":22,"context_line":"do"},{"line_number":23,"context_line":"    package_name\u003d$(basename \"$file\" \".deb\")"},{"line_number":24,"context_line":"    deb_file_name\u003d`echo $package_name | cut -d \"_\" -f 1`"},{"line_number":25,"context_line":"    cp $deb_file $TMP_HOOKS_PATH/vertica/$deb_file_name.deb"},{"line_number":26,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a016987_efa0d1a7","line":23,"updated":"2015-05-14 01:21:57.000000000","message":"Shouldn\u0027t this be \"$deb_file\" ?","commit_id":"3f4fe6fdf86f854ff2f7247d234168f8d7f923aa"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d80a644b56e6c20d1bb50a1b04846f01045401c1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# remove the version number form the debian package name before copying"},{"line_number":21,"context_line":"for deb_file in `ls -1 $DATASTORE_PKG_LOCATION/*.deb`"},{"line_number":22,"context_line":"do"},{"line_number":23,"context_line":"    package_name\u003d$(basename \"$file\" \".deb\")"},{"line_number":24,"context_line":"    deb_file_name\u003d`echo $package_name | cut -d \"_\" -f 1`"},{"line_number":25,"context_line":"    cp $deb_file $TMP_HOOKS_PATH/vertica/$deb_file_name.deb"},{"line_number":26,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a016987_e37d85e8","line":23,"in_reply_to":"7a016987_efa0d1a7","updated":"2015-05-14 07:59:48.000000000","message":"+1, this is gonna give error for sure","commit_id":"3f4fe6fdf86f854ff2f7247d234168f8d7f923aa"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"53dcf577f7bd100ca7096a49c27ebdc54bb5f6cd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# remove the version number form the debian package name before copying"},{"line_number":21,"context_line":"for deb_file in `ls -1 $DATASTORE_PKG_LOCATION/*.deb`"},{"line_number":22,"context_line":"do"},{"line_number":23,"context_line":"    package_name\u003d$(basename \"$file\" \".deb\")"},{"line_number":24,"context_line":"    deb_file_name\u003d`echo $package_name | cut -d \"_\" -f 1`"},{"line_number":25,"context_line":"    cp $deb_file $TMP_HOOKS_PATH/vertica/$deb_file_name.deb"},{"line_number":26,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a016987_1a9c8d68","line":23,"in_reply_to":"7a016987_efa0d1a7","updated":"2015-05-14 02:08:31.000000000","message":"most definitely, yes.","commit_id":"3f4fe6fdf86f854ff2f7247d234168f8d7f923aa"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"751d2194de4c69e7b3f48bc504bfe457fdd22fcd","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"mkdir $TMP_HOOKS_PATH/vertica"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# remove the version number form the debian package name before copying"},{"line_number":18,"context_line":"for vertica_file in `ls -1 $DATASTORE_PKG_LOCATION`"},{"line_number":19,"context_line":"do"},{"line_number":20,"context_line":"    if [[ $vertica_file \u003d\u003d *\".deb\" ]]"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"ba3cc151_8ae4e10c","line":17,"updated":"2015-07-09 18:44:05.000000000","message":"s/form/from/ ?","commit_id":"103c78cf0af37ee40ba8a8be6a693ea729698495"}],"scripts/files/elements/ubuntu-vertica/install.d/97-vertica":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"c8cfe0403b88059a1a2aa575c4ec47488d26dc3a","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Backup /etc/hosts"},{"line_number":38,"context_line":"cp -p /etc/hosts /etc/hosts.bkp"},{"line_number":39,"context_line":"~"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1aca2d91_65fa5677","line":39,"updated":"2015-05-07 23:33:14.000000000","message":"What is this for?","commit_id":"f7a5730a2bc8acae64c8dc4f74412c78bfaca41a"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"d80a644b56e6c20d1bb50a1b04846f01045401c1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"apt-get install -qy curl sysstat pstack mcelog"},{"line_number":13,"context_line":"apt-get install -qy python-dev g++ unixODBC unixODBC-dev"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Install Vertica package"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Copy the package file to the image,"},{"line_number":18,"context_line":"#  as it needs to be used later during configuration."}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7a016987_6374f5ce","line":15,"updated":"2015-05-14 07:59:48.000000000","message":"The context of this comment is lost, either it should be removed or \"intall\" word needs to be included in the new comment.","commit_id":"3f4fe6fdf86f854ff2f7247d234168f8d7f923aa"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"07ab7d654968dacc3c8dbf4f6603f10ca6ffc99c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"sudo service vertica-consoled stop"},{"line_number":35,"context_line":"mv /vconsole.tgz /opt"},{"line_number":36,"context_line":"tar -xzf /vconsole.tgz"},{"line_number":37,"context_line":"sudo service vertica-consoled start"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Creating dbadmin user and verticadba group"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"ba3cc151_fc00db02","line":36,"updated":"2015-07-09 17:54:10.000000000","message":"You move the file, then untar it from the old location ...","commit_id":"103c78cf0af37ee40ba8a8be6a693ea729698495"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"912f8e43368f7086283e281cd86d43c6554548f0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"echo \u0027export PATH\u003d$PATH:$JAVA_HOME/bin\u0027 \u003e\u003e  /etc/profile.d/java.sh"},{"line_number":46,"context_line":"chmod 755  /etc/profile.d/java.sh"},{"line_number":47,"context_line":"cd /etc/profile.d"},{"line_number":48,"context_line":"./java.sh"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Creating dbadmin user and verticadba group"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3a50d1a3_f8438aad","line":48,"updated":"2015-07-31 21:05:50.000000000","message":"are you intentionally running java.sh here?","commit_id":"cabb629be842646bb2f316fccbe3e80798e6d4e1"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"2c2d7e3538f148da5729ca2b1222bf2ddcfaaf5e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# .deb package files need to be in the root directory for"},{"line_number":22,"context_line":"# install_vertica script"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"if [ -d /opt/datastore_package ]"},{"line_number":25,"context_line":"then"},{"line_number":26,"context_line":"    # install vertica db package"},{"line_number":27,"context_line":"    for vertica_file in `ls -1r /opt/datastore_package/vertica*.deb`"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1a122d0e_57a20c4c","line":24,"updated":"2016-04-19 12:34:54.000000000","message":"and this likely works for vertica because you\u0027ll use a dir","commit_id":"0e65a06166ab0228bb1c5dd2931ccf29a1431f32"}]}