)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"1b2696c066584857f0481b36be1e31acbedc802d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Van Dijk \u003cmvandijk@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-29 12:06:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"redstack failing if /opt/stack is missing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let redstack proceed if /opt/stack is missing. Change redstack to only"},{"line_number":10,"context_line":"fail if explicitly told to."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_c37897c6","line":7,"updated":"2015-05-30 01:18:16.000000000","message":"By missing, do you mean deleted?  Since it\u0027s typically \u0027missing\u0027 the first time you run \u0027./redstack install\u0027 - I\u0027ll assume that\u0027s the case in my testing ...","commit_id":"acc2b6e9d3fa9cefa8c32de71964f7506545acd1"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"cbf624195f0e376f19a3a73c74a07aafac8357fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Van Dijk \u003cmvandijk@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-05-29 12:06:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"redstack failing if /opt/stack is missing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let redstack proceed if /opt/stack is missing. Change redstack to only"},{"line_number":10,"context_line":"fail if explicitly told to."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a016987_3d108aff","line":7,"in_reply_to":"7a016987_c37897c6","updated":"2015-06-01 14:37:54.000000000","message":"Correct, should be \u0027deleted\u0027.","commit_id":"acc2b6e9d3fa9cefa8c32de71964f7506545acd1"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"6e5eaa2924dddf4b8711bc6b1176e20a4e7dde03","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Van Dijk \u003cmvandijk@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-02 08:26:17 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix redstack failing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let redstack proceed if /opt/stack is missing. Change redstack to only"},{"line_number":10,"context_line":"fail if explicitly told to."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3afb71cf_b61654a5","line":7,"updated":"2015-06-08 15:53:18.000000000","message":"I think commit title could be improved, even the sentence right now does not looks correct to me, it could be better re-written as \n\n\"Fix failing redstack when /opt/stack is missing\"\n\nor \n\n\"Fix failing redstack\"\n\nThough I would prefer first one.","commit_id":"d31e62a3b42bbe1d1fb3ad4d7ab77eb772fc4cc0"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"ad7ed61ab806f6bbdf3987a2e865a65adfe4dcc5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Van Dijk \u003cmvandijk@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-02 08:26:17 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix redstack failing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let redstack proceed if /opt/stack is missing. Change redstack to only"},{"line_number":10,"context_line":"fail if explicitly told to."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3afb71cf_d92c6304","line":7,"in_reply_to":"3afb71cf_3965b7e0","updated":"2015-06-08 16:09:30.000000000","message":"You may update accordingly but current title does not looks more correct.","commit_id":"d31e62a3b42bbe1d1fb3ad4d7ab77eb772fc4cc0"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"3d57fb6e9e4b1800f1721b706820e660e4ceaaa0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Van Dijk \u003cmvandijk@tesora.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-02 08:26:17 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix redstack failing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let redstack proceed if /opt/stack is missing. Change redstack to only"},{"line_number":10,"context_line":"fail if explicitly told to."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3afb71cf_3965b7e0","line":7,"in_reply_to":"3afb71cf_b61654a5","updated":"2015-06-08 16:00:58.000000000","message":"There are 2 issues being fixed though. The /opt/stack missing and the devstack/ existing.","commit_id":"d31e62a3b42bbe1d1fb3ad4d7ab77eb772fc4cc0"}],"scripts/redstack":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"0376e909250137e1bd5a005e619ebfb795b22d30","unresolved":false,"context_lines":[{"line_number":121,"context_line":"# devstack trove plugin, if required.  We\u0027ll use the devstack version if it"},{"line_number":122,"context_line":"# exists, otherwise we assume the plugin method."},{"line_number":123,"context_line":"function set_trove_plugin_vars () {"},{"line_number":124,"context_line":"    FAIL_IF_MISSING\u003d${1:-true}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    TROVE_SETUP_CMD_FILE\u003d\"$PATH_DEVSTACK_SRC/lib/trove\""},{"line_number":127,"context_line":"    if [ -f \"$TROVE_SETUP_CMD_FILE\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5afe65bd_86feb669","line":124,"updated":"2015-06-02 17:30:06.000000000","message":"I understand the notion of adding this new switch but don\u0027t understand why anyone would set it.","commit_id":"9d412996bbda4752470bf561a53485914c263341"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"db06c0d659f8e4ad056c3550a75d69fc3cc00c03","unresolved":false,"context_lines":[{"line_number":121,"context_line":"# devstack trove plugin, if required.  We\u0027ll use the devstack version if it"},{"line_number":122,"context_line":"# exists, otherwise we assume the plugin method."},{"line_number":123,"context_line":"function set_trove_plugin_vars () {"},{"line_number":124,"context_line":"    FAIL_IF_MISSING\u003d${1:-true}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    TROVE_SETUP_CMD_FILE\u003d\"$PATH_DEVSTACK_SRC/lib/trove\""},{"line_number":127,"context_line":"    if [ -f \"$TROVE_SETUP_CMD_FILE\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5afe65bd_a09ab512","line":124,"in_reply_to":"5afe65bd_86feb669","updated":"2015-06-02 18:37:10.000000000","message":"I don\u0027t understand why this is being done.  It\u0027s only called from one place with a hardcoded value.","commit_id":"9d412996bbda4752470bf561a53485914c263341"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"623f7e20bbce0732ae4727477acc450d7f96b56b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"# devstack trove plugin, if required.  We\u0027ll use the devstack version if it"},{"line_number":122,"context_line":"# exists, otherwise we assume the plugin method."},{"line_number":123,"context_line":"function set_trove_plugin_vars () {"},{"line_number":124,"context_line":"    FAIL_IF_MISSING\u003d${1:-true}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    TROVE_SETUP_CMD_FILE\u003d\"$PATH_DEVSTACK_SRC/lib/trove\""},{"line_number":127,"context_line":"    if [ -f \"$TROVE_SETUP_CMD_FILE\" ]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5afe65bd_c50b1f8d","line":124,"in_reply_to":"5afe65bd_a09ab512","updated":"2015-06-04 19:27:18.000000000","message":"This is called several times. One of the calls does not want this to exit if the file is missing (legitimate case). However the rest do. This minimizes the work most callers need to do.","commit_id":"9d412996bbda4752470bf561a53485914c263341"}]}