)]}'
{"scripts/files/elements/ubuntu-db2/install.d/10-db2":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"0ca794333933b100c18cf04d3dee1d66448cbf2e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"then"},{"line_number":20,"context_line":"    tar -xvzf /opt/datastore_package/v10.5_linuxx64_expc.tar.gz"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    echo \"ERROR: DB2 Package (db2.tar.gz or v10.5_linuxx64_expc.tar.gz) not found in /opt/datastore_package/\""},{"line_number":23,"context_line":"    echo \"Please register and download the DB2 Express-C packages to a private repository or local filesystem.\""},{"line_number":24,"context_line":"    exit 1"},{"line_number":25,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa1b9901_25d7434c","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":70},"updated":"2015-08-20 15:29:42.000000000","message":"This seems a little fragile - you specify the package name with DATASTORE_PKG_LOCATION, but it still has to be one of db2.tar.gz or v10.5_linuxx64_expc.tar.gz or the code will break - I\u0027m guessing that people will trip over this pretty soon in the future.  Maybe we should change the datastore_package element to copy the file to a known filename?","commit_id":"6a92cf70f1d81aed38de6b1c70ff5c26dde0fd0d"},{"author":{"_account_id":6160,"name":"Saurabh Surana","email":"saurabh.cloud@gmail.com","username":"saurabh-surana"},"change_message_id":"41b7efe0667948bd6668a54dcca59557016f4b51","unresolved":false,"context_lines":[{"line_number":19,"context_line":"then"},{"line_number":20,"context_line":"    tar -xvzf /opt/datastore_package/v10.5_linuxx64_expc.tar.gz"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    echo \"ERROR: DB2 Package (db2.tar.gz or v10.5_linuxx64_expc.tar.gz) not found in /opt/datastore_package/\""},{"line_number":23,"context_line":"    echo \"Please register and download the DB2 Express-C packages to a private repository or local filesystem.\""},{"line_number":24,"context_line":"    exit 1"},{"line_number":25,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba8a016a_41db8eec","line":22,"in_reply_to":"fa1b9901_25d7434c","updated":"2015-11-18 16:21:55.000000000","message":"Its not fragile, its a check, if the file with that name is not specified then this would fail. \n\nIf we put a fixed file name while coping the file, and if you end up specifying path to a wrong file during image building, then image building will still succeed, and but your instance will never go active, and will require lot of debugging to figure out that you specified wrong file path in your image build command. \n\nInstead if we check for the files name here and fail if we don\u0027t find the file with the correct name then we detect the failure at the correct place and its easy to identify the problem and fix it.\n\nIf you are concerned about the version in the file name then I can adjust the check to ignore the version.","commit_id":"6a92cf70f1d81aed38de6b1c70ff5c26dde0fd0d"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"a5177fc2f80a02eaa79c06fe7f3e492c3be35a60","unresolved":false,"context_lines":[{"line_number":12,"context_line":"mkdir ${DB2_PKG_LOCATION}"},{"line_number":13,"context_line":"cd ${DB2_PKG_LOCATION}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ -f /opt/datastore_package/db2.tar.gz ]"},{"line_number":16,"context_line":"then"},{"line_number":17,"context_line":"    tar -xvzf /opt/datastore_package/db2.tar.gz"},{"line_number":18,"context_line":"elif [ -f /opt/datastore_package/v10.5_linuxx64_expc.tar.gz ]"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba8a016a_11b862c7","line":15,"updated":"2015-11-18 22:10:40.000000000","message":"the db2.tar.gz file is a renamed file(from v10.5_linuxx64_expc.tar.gz ) according to the original changes. This was renamed to avoid the user having to change this file everytime a version or something like that about the name changed. If we are not renaming this file with these new changes (as in the dependent change set), then this check isnt really necessary.","commit_id":"63c1d231f5595afd7ac7770107bebf4023f2f780"}]}