)]}'
{"scripts/redstack":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"11187976ea4627ec76a6b6163bc58e4f849abf00","unresolved":false,"context_lines":[{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"function cmd_dsvm_gate_tests() {"},{"line_number":1085,"context_line":"    DATASTORE_TYPE\u003d${1:-\u0027mysql\u0027}"},{"line_number":1086,"context_line":"    TEST_GROUP\u003d${2:-${DATASTORE_TYPE}}"},{"line_number":1087,"context_line":"    HOST_SCP_USERNAME\u003d${3:-\u0027jenkins\u0027}"},{"line_number":1088,"context_line":"    GUEST_USERNAME\u003d${4:-\u0027ubuntu\u0027}"},{"line_number":1089,"context_line":"    NETWORK_GATEWAY\u003d${5:-\u002710.1.0.1\u0027}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a8ffd7b_6cea76ae","line":1086,"updated":"2015-12-02 00:26:59.000000000","message":"changing the order of these params that are coming into this function seems like a bad idea unless i\u0027m missing something. Because the gate calls this function and might not have a 2nd argument as the TEST_GROUP and this would cause all the later arguments to be off by one.","commit_id":"ab78cca7f72c3b91f91d381b0abdbc013a8d5387"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"2ae93e53e73a65bbad3bfd38a25d6cc1971b3ebf","unresolved":false,"context_lines":[{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"function cmd_dsvm_gate_tests() {"},{"line_number":1085,"context_line":"    DATASTORE_TYPE\u003d${1:-\u0027mysql\u0027}"},{"line_number":1086,"context_line":"    TEST_GROUP\u003d${2:-${DATASTORE_TYPE}}"},{"line_number":1087,"context_line":"    HOST_SCP_USERNAME\u003d${3:-\u0027jenkins\u0027}"},{"line_number":1088,"context_line":"    GUEST_USERNAME\u003d${4:-\u0027ubuntu\u0027}"},{"line_number":1089,"context_line":"    NETWORK_GATEWAY\u003d${5:-\u002710.1.0.1\u0027}"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a8ffd7b_b17aceef","line":1086,"in_reply_to":"9a8ffd7b_6cea76ae","updated":"2015-12-02 15:28:17.000000000","message":"I understand what you\u0027re saying and in general I agree with you.  I did it this way because AFAIK it\u0027s only called from here:\n\n  https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/trove.yaml#L58\n\nand it only passes in one argument.  If I put it at the end, we\u0027d need to have it pass in all 6 arguments to get the scenario tests to work in the gate, instead of just two.\n\ni.e. you\u0027d need to run:\n\n  ./redstack dsvm-gate-tests {datastore} jenkins ubuntu 10.1.0.1 \u0027\\/opt\\/stack\\/new\\/trove\u0027 {datastore}|_supported\n\ninstead of just:\n\n  ./redstack dsvm-gate-tests {datastore} {datastore}_supported\n\nIf you want, I can put it at the end, but I don\u0027t think it\u0027s necessary (unless it\u0027s used differently somewhere else that I don\u0027t know about ;) )","commit_id":"ab78cca7f72c3b91f91d381b0abdbc013a8d5387"}]}