)]}'
{"scripts/redstack":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"06d2d9fdb617ec8823f20468fc83e1c9488f0515","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"function setup_cluster_configs() {"},{"line_number":699,"context_line":"    # Setting cluster_member_count to 2 to decrease cluster spawn time."},{"line_number":700,"context_line":"    iniset $TROVE_CONF $DATASTORE_TYPE cluster_member_count $1"},{"line_number":701,"context_line":"    # Setting cluster configs"},{"line_number":702,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT agent_call_high_timeout 300"},{"line_number":703,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT cluster_usage_timeout 2000"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a68dd71_0a93a950","line":700,"updated":"2016-01-21 16:35:06.000000000","message":"Jonathan, it looks like the name of the config parameter was changes from cluster_member_count to min_cluster_member_count:  https://review.openstack.org/#/c/222468/. Craig has a change out there to fix this: https://review.openstack.org/#/c/267215/. I think it makes sense to change it in here.","commit_id":"23ffc0ae67d879065ef1a18f7aa6f55124ddd1f8"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"84a6301b39f659a2a1a7222b0288d93b00d1cb87","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"function setup_cluster_configs() {"},{"line_number":699,"context_line":"    # Setting cluster_member_count to 2 to decrease cluster spawn time."},{"line_number":700,"context_line":"    iniset $TROVE_CONF $DATASTORE_TYPE cluster_member_count $1"},{"line_number":701,"context_line":"    # Setting cluster configs"},{"line_number":702,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT agent_call_high_timeout 300"},{"line_number":703,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT cluster_usage_timeout 2000"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a5ae5dd_7effb101","line":700,"in_reply_to":"5a5ae5dd_b13a5be6","updated":"2016-02-03 15:30:15.000000000","message":"Sounds good Craig. Thanks for clarifying.","commit_id":"23ffc0ae67d879065ef1a18f7aa6f55124ddd1f8"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"7a1909d01e1fba376b8038b18dbaebe26a2de203","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"function setup_cluster_configs() {"},{"line_number":699,"context_line":"    # Setting cluster_member_count to 2 to decrease cluster spawn time."},{"line_number":700,"context_line":"    iniset $TROVE_CONF $DATASTORE_TYPE cluster_member_count $1"},{"line_number":701,"context_line":"    # Setting cluster configs"},{"line_number":702,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT agent_call_high_timeout 300"},{"line_number":703,"context_line":"    iniset $TROVE_TASKMANAGER_CONF DEFAULT cluster_usage_timeout 2000"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5a5ae5dd_b13a5be6","line":700,"in_reply_to":"9a68dd71_0a93a950","updated":"2016-02-03 05:06:04.000000000","message":"hmm while that was a comment that was requested for pxc its specific to pxc and not vertica in the cfg.py file. Looks like we might need to pass in the parameter name to set as well here until we fix that...\n\nvertica: https://github.com/openstack/trove/blob/00c1e12909940c50aba8181cf7083d19728bcfa3/trove/common/cfg.py#L1112\n\npxc: https://github.com/openstack/trove/blob/00c1e12909940c50aba8181cf7083d19728bcfa3/trove/common/cfg.py#L690\n\n@mariam i\u0027d suggest this change is fine as is but i\u0027ll need to rebase my change and make sure that it works correctly with PXC.\n\ni\u0027ll put a note on my change to make sure to look at this.","commit_id":"23ffc0ae67d879065ef1a18f7aa6f55124ddd1f8"}]}