)]}'
{"scripts/redstack":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d3a5e681ee5454c4493380e613dbb28305e0b83e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    if ! is_fedora; then"},{"line_number":165,"context_line":"        cmd\u003d\"$cmd DEBIAN_FRONTEND\u003dnoninteractive\""},{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":"    cmd\u003d\"$cmd $HTTP_PROXY $PKG_MGR $PKG_GET_ARGS install $@\""},{"line_number":168,"context_line":"    $cmd"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da6ed579_9de653af","line":167,"updated":"2016-01-15 21:18:54.000000000","message":"Since everything else in the command is already a variable, why not just extend that metaphor? I think it would make the code much more readable than this proposed implementation (I think).","commit_id":"b90965946361f5b72718d74fd07b1b8eddfe9d2d"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"c20c181c3284b76e2c7ea6408b93f07a57539df0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    if ! is_fedora; then"},{"line_number":165,"context_line":"        cmd\u003d\"$cmd DEBIAN_FRONTEND\u003dnoninteractive\""},{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":"    cmd\u003d\"$cmd $HTTP_PROXY $PKG_MGR $PKG_GET_ARGS install $@\""},{"line_number":168,"context_line":"    $cmd"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a68dd71_69963c96","line":167,"in_reply_to":"9a68dd71_46b6c73e","updated":"2016-01-20 14:55:49.000000000","message":"You have this wart here with an if ... and you issue a different command depending on whether is_fedora is set.\n\nIn reality, what you are saying is that an argument that must be inserted includes DEBIAN_FRONTEND\u003d... if it is DEBIAN.\n\nYour code is potentially wrong because is_fedora U is_debian is not the complete universe.\n\nFurthermore, why not follow the same mechanism used for other env variables and define it upfront and have a single command here?","commit_id":"b90965946361f5b72718d74fd07b1b8eddfe9d2d"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"25045eca81b2bdbc0a0fbbb8ef9ba484b768d037","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    if ! is_fedora; then"},{"line_number":165,"context_line":"        cmd\u003d\"$cmd DEBIAN_FRONTEND\u003dnoninteractive\""},{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":"    cmd\u003d\"$cmd $HTTP_PROXY $PKG_MGR $PKG_GET_ARGS install $@\""},{"line_number":168,"context_line":"    $cmd"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a68dd71_0831b10b","line":167,"in_reply_to":"9a68dd71_69963c96","updated":"2016-01-20 17:29:32.000000000","message":"Where you define the distro (or other ubuntu specific options), for Ubuntu make PKG_INSTALL_OPTS\u003d\"DEBIAN_FRONTEND\u003dnoninteractive\".\nThis method would then:\ncmd\u003d\"sudo -E $PKG_INSTALL_OPTS $HTTP_PROXY $PKG_MGR...\"","commit_id":"b90965946361f5b72718d74fd07b1b8eddfe9d2d"},{"author":{"_account_id":17456,"name":"Juan Manuel Santos","email":"vicariousdm@gmail.com","username":"godlike"},"change_message_id":"e0d72f7b15b3c1d5f8492ae74e83f7cb35111724","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    if ! is_fedora; then"},{"line_number":165,"context_line":"        cmd\u003d\"$cmd DEBIAN_FRONTEND\u003dnoninteractive\""},{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":"    cmd\u003d\"$cmd $HTTP_PROXY $PKG_MGR $PKG_GET_ARGS install $@\""},{"line_number":168,"context_line":"    $cmd"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a68dd71_46b6c73e","line":167,"in_reply_to":"ba63e191_5099591e","updated":"2016-01-20 14:44:34.000000000","message":"Thanks for your comments. However I think I did not fully understand it. Could you provide a quick example of what you mean?","commit_id":"b90965946361f5b72718d74fd07b1b8eddfe9d2d"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"7f7b3db81e6b2c465a2ba4b5eefbfd80de101c7d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    if ! is_fedora; then"},{"line_number":165,"context_line":"        cmd\u003d\"$cmd DEBIAN_FRONTEND\u003dnoninteractive\""},{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":"    cmd\u003d\"$cmd $HTTP_PROXY $PKG_MGR $PKG_GET_ARGS install $@\""},{"line_number":168,"context_line":"    $cmd"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ba63e191_5099591e","line":167,"in_reply_to":"da6ed579_9de653af","updated":"2016-01-19 19:25:29.000000000","message":"I agree, FWIW","commit_id":"b90965946361f5b72718d74fd07b1b8eddfe9d2d"},{"author":{"_account_id":17456,"name":"Juan Manuel Santos","email":"vicariousdm@gmail.com","username":"godlike"},"change_message_id":"574123d17fcf2d55fd42b6fd764d709e9dab0e0c","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# set up respective package managers"},{"line_number":116,"context_line":"if is_fedora; then"},{"line_number":117,"context_line":"    PKG_INSTALL_OPTS\u003d\"\""},{"line_number":118,"context_line":"    PKG_MGR\u003ddnf"},{"line_number":119,"context_line":"    PKG_GET_ARGS\u003d\"-y\""},{"line_number":120,"context_line":"else"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a68dd71_652ba183","line":117,"updated":"2016-01-21 00:56:23.000000000","message":"Left blank on purpose in case we wish to specify this in the future for dnf","commit_id":"b2fa44aaf20437759891733265b2fd92f78a9189"},{"author":{"_account_id":17456,"name":"Juan Manuel Santos","email":"vicariousdm@gmail.com","username":"godlike"},"change_message_id":"574123d17fcf2d55fd42b6fd764d709e9dab0e0c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    PKG_MGR\u003dapt-get"},{"line_number":123,"context_line":"    PKG_GET_ARGS\u003d\"-y --allow-unauthenticated --force-yes\""},{"line_number":124,"context_line":"fi"},{"line_number":125,"context_line":"PKG_INSTALL_ARG\u003d\"install\""},{"line_number":126,"context_line":"PKG_UPDATE_ARG\u003d\"update\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"###############################################################################"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a68dd71_c53a8dcd","line":125,"updated":"2016-01-21 00:56:23.000000000","message":"These are outside the if because nowadays they are the same. Should this change in the future they can be moved inside the if (or, when supporting more package managers, make this a bit more complex).","commit_id":"b2fa44aaf20437759891733265b2fd92f78a9189"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"66e1d718126aa6928e3bd50e379294ccf10ad2b3","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"function pkg_install () {"},{"line_number":166,"context_line":"    echo Installing $@..."},{"line_number":167,"context_line":"    cmd\u003d\"sudo -E $PKG_INSTALL_OPTS $HTTP_PROXY $PKG_MGR $PKG_GET_ARGS $PKG_INSTALL_ARG $@\""},{"line_number":168,"context_line":"    $cmd"},{"line_number":169,"context_line":"}"},{"line_number":170,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a68dd71_a942b93c","line":167,"updated":"2016-01-21 13:11:44.000000000","message":"Why the two step?\n\nWhy not just\n\nsudo -E ...?","commit_id":"b2fa44aaf20437759891733265b2fd92f78a9189"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"66e1d718126aa6928e3bd50e379294ccf10ad2b3","unresolved":false,"context_lines":[{"line_number":171,"context_line":"function pkg_update () {"},{"line_number":172,"context_line":"    echo Updating $@..."},{"line_number":173,"context_line":"    cmd\u003d\"sudo -E $PKG_INSTALL_OPTS $HTTP_PROXY $PKG_MGR $PKG_GET_ARGS $PKG_UPDATE_ARG $@\""},{"line_number":174,"context_line":"    $cmd"},{"line_number":175,"context_line":"}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"function set_home_dir() {"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a68dd71_694cc170","line":174,"updated":"2016-01-21 13:11:44.000000000","message":"same comment, why the two step?","commit_id":"b2fa44aaf20437759891733265b2fd92f78a9189"}]}