)]}'
{"scripts/files/elements/fedora-guest/extra-data.d/15-reddwarf-dep":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"84a718ab2394f259995dbba89f06262672b9da73","unresolved":false,"context_lines":[{"line_number":11,"context_line":"UC_BRANCH\u003d${BRANCH_OVERRIDE:-master}"},{"line_number":12,"context_line":"BRANCH_OVERRIDE\u003d${BRANCH_OVERRIDE:-default}"},{"line_number":13,"context_line":"ADD_BRANCH\u003d$(basename ${BRANCH_OVERRIDE})"},{"line_number":14,"context_line":"REQUIREMENTS_FILE\u003d${REDSTACK_SCRIPTS}/files/requirements/fedora-requirements-${ADD_BRANCH}.txt"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[ -n \"$TMP_HOOKS_PATH\" ] || die \"Temp hook path not set\""},{"line_number":17,"context_line":"[ -e ${REQUIREMENTS_FILE} ] || die \"Requirements not found\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fad55976_27f52d83","line":14,"updated":"2016-07-15 17:18:46.000000000","message":"You need to fix this as well, sorry ...\n\nthis use of requirements was a hack (I created it, mea culpa). it would be better to refactor these and make them versioned as well; properly versioned that is, not in this crazy way.","commit_id":"e08b37bf98bfa7d6810810d24a293f95e331343a"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"2da04036d815977bde6e3769f114e93087b0502d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"UC_BRANCH\u003d${BRANCH_OVERRIDE:-master}"},{"line_number":12,"context_line":"BRANCH_OVERRIDE\u003d${BRANCH_OVERRIDE:-default}"},{"line_number":13,"context_line":"ADD_BRANCH\u003d$(basename ${BRANCH_OVERRIDE})"},{"line_number":14,"context_line":"REQUIREMENTS_FILE\u003d${REDSTACK_SCRIPTS}/files/requirements/fedora-requirements-${ADD_BRANCH}.txt"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[ -n \"$TMP_HOOKS_PATH\" ] || die \"Temp hook path not set\""},{"line_number":17,"context_line":"[ -e ${REQUIREMENTS_FILE} ] || die \"Requirements not found\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fad55976_67f9e54d","line":14,"in_reply_to":"fad55976_27f52d83","updated":"2016-07-15 17:22:48.000000000","message":"This works, doesn\u0027t it?  I agree that it\u0027s not optimal but since Trove-int isn\u0027t versioned there aren\u0027t too many options ... (I\u0027d like to see a common base file and just differences in the individual files, but that\u0027s definitely out of scope here)","commit_id":"e08b37bf98bfa7d6810810d24a293f95e331343a"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"6b93670fe1df42c21dec807e4e7827bfdc52b16d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"UC_BRANCH\u003d${BRANCH_OVERRIDE:-master}"},{"line_number":12,"context_line":"BRANCH_OVERRIDE\u003d${BRANCH_OVERRIDE:-default}"},{"line_number":13,"context_line":"ADD_BRANCH\u003d$(basename ${BRANCH_OVERRIDE})"},{"line_number":14,"context_line":"REQUIREMENTS_FILE\u003d${REDSTACK_SCRIPTS}/files/requirements/fedora-requirements-${ADD_BRANCH}.txt"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[ -n \"$TMP_HOOKS_PATH\" ] || die \"Temp hook path not set\""},{"line_number":17,"context_line":"[ -e ${REQUIREMENTS_FILE} ] || die \"Requirements not found\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fad55976_403c872f","line":14,"in_reply_to":"fad55976_67f9e54d","updated":"2016-07-15 18:42:49.000000000","message":"I am fine with these changes. Yes I agree that the requirements file needs to be cleaned up but I think relying on the upper-constraints to control the version of a requirement is a good way to go ahead.","commit_id":"e08b37bf98bfa7d6810810d24a293f95e331343a"}]}